Fix the `github-tag-action` workflow (#932)

This has been failing for a while because of some changes in `git`.

(cherry picked from commit 4b14d29c20)

.github/workflows/backport.yml

@@ -0,0 +1,54 @@
+name: Backport to older releases
+on:
+  push:
+    branches:
+    - main
+
+jobs:
+
+  backport:
+    name: Backport change to branch ${{ matrix.branch }}
+    continue-on-error: true
+    strategy:
+      fail-fast: false
+      matrix:
+        branch: [ 'release-0.28', 'release-0.27' ]
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Check out code
+      uses: actions/checkout@v1
+      with:
+        fetch-depth: 0
+    - name: Create a cherry-pick PR
+      run: |
+        if ! git diff --quiet HEAD^ HEAD -- vendor/libgit2; then
+          echo '::warning::Skipping cherry-pick since it is a vendored libgit2 bump'
+          exit 0
+        fi
+
+        BRANCH_NAME="cherry-pick-${{ github.run_id }}-${{ matrix.branch }}"
+
+        # Setup usernames and authentication
+        git config --global user.name "${{ github.actor }}"
+        git config --global user.email "${{ github.actor }}@users.noreply.github.com"
+        cat <<- EOF > $HOME/.netrc
+        machine github.com
+        login ${{ github.actor }}
+        password ${{ secrets.GITHUB_TOKEN }}
+        machine api.github.com
+        login ${{ github.actor }}
+        password ${{ secrets.GITHUB_TOKEN }}
+        EOF
+        chmod 600 $HOME/.netrc
+
+        # Create the cherry-pick commit and create the PR for it.
+        git checkout "${{ matrix.branch }}"
+        git switch -c "${BRANCH_NAME}"
+        git cherry-pick -x "${{ github.sha }}"
+        git push --set-upstream origin "${BRANCH_NAME}"
+        GITHUB_TOKEN="${{ secrets.GITHUB_TOKEN }}" gh pr create \
+          --base "${{ matrix.branch }}" \
+          --title "$(git --no-pager show --format="%s" --no-patch HEAD)" \
+          --body "$(git --no-pager show --format="%b" --no-patch HEAD)"

.github/workflows/ci.yml

@@ -0,0 +1,127 @@
+name: git2go CI
+on:
+  pull_request:
+  push:
+    branches:
+    - main
+    - release-*
+    - v*
+
+jobs:
+
+  build-static:
+    strategy:
+      fail-fast: false
+      matrix:
+        go: [ '1.11', '1.12', '1.13', '1.14', '1.15', '1.16', '1.17' ]
+    name: Go ${{ matrix.go }}
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: ${{ matrix.go }}
+      id: go
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v1
+    - name: Build
+      run: |
+        git submodule update --init
+        sudo apt-get install -y --no-install-recommends libssh2-1-dev
+        make build-libgit2-static
+    - name: Test
+      run:  make TEST_ARGS=-test.v test-static
+
+  build-dynamic:
+    strategy:
+      fail-fast: false
+    name: Go (dynamic)
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.17'
+      id: go
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v1
+    - name: Build
+      run: |
+        git submodule update --init
+        sudo apt-get install -y --no-install-recommends libssh2-1-dev
+        make build-libgit2-dynamic
+    - name: Test
+      run: make TEST_ARGS=-test.v test-dynamic
+
+  build-system-dynamic:
+    strategy:
+      fail-fast: false
+    name: Go (system-wide, dynamic)
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.17'
+      id: go
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v1
+    - name: Build libgit2
+      run: |
+        git submodule update --init
+        sudo apt-get install -y --no-install-recommends libssh2-1-dev
+        sudo ./script/build-libgit2.sh --dynamic --system
+    - name: Test
+      run: make TEST_ARGS=-test.v test
+
+  build-system-static:
+    strategy:
+      fail-fast: false
+    name: Go (system-wide, static)
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.17'
+      id: go
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v1
+    - name: Build libgit2
+      run: |
+        git submodule update --init
+        sudo apt-get install -y --no-install-recommends libssh2-1-dev
+        sudo ./script/build-libgit2.sh --static --system
+    - name: Test
+      run: go test --count=1 --tags "static,system_libgit2" ./...
+
+  check-generate:
+    name: Check generated files were not modified
+    runs-on: ubuntu-20.04
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.17'
+      id: go
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v2
+    - name: Install libgit2 build dependencies
+      run: |
+        git submodule update --init
+        sudo apt-get install -y --no-install-recommends libssh2-1-dev
+        go install golang.org/x/tools/cmd/stringer@latest
+    - name: Generate files
+      run: |
+        export PATH=$(go env GOPATH)/bin:$PATH
+        make generate
+    - name: Check nothing changed
+      run: git diff --quiet --exit-code || (echo "detected changes after generate" ; git status ; exit 1)

.github/workflows/tag.yml

@@ -0,0 +1,28 @@
+name: Tag new releases
+on:
+  push:
+    branches:
+    - main
+    - release-*
+
+jobs:
+
+  tag-release:
+    name: Bump tag in ${{ github.ref }}
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Check out code
+      uses: actions/checkout@v1
+      with:
+        fetch-depth: 0
+    - name: Bump version and push tag
+      id: bump-version
+      uses: anothrNick/github-tag-action@43ed073f5c1445ca8b80d920ce2f8fa550ae4e8d
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        WITH_V: true
+        DEFAULT_BUMP: patch
+        TAG_CONTEXT: branch
+        RELEASE_BRANCHES: .*

.gitignore

@@ -1,4 +1,2 @@
 /static-build/
 /dynamic-build/
-
-go.*

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "vendor/libgit2"]
+	path = vendor/libgit2
+	url = https://github.com/libgit2/libgit2

Build_bundled_static.go

@@ -1,4 +1,3 @@
-//go:build static && !system_libgit2
 // +build static,!system_libgit2
 
 package git
@@ -10,8 +9,8 @@ package git
 #cgo CFLAGS: -DLIBGIT2_STATIC
 #include <git2.h>
 
-#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 5 || LIBGIT2_VER_MINOR > 5
+#if LIBGIT2_VER_MAJOR != 0 || LIBGIT2_VER_MINOR != 27
-# error "Invalid libgit2 version; this libgit2 supports libgit2 between v1.5.0 and v1.5.0"
+# error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
 #endif
 */
 import "C"

Build_system_dynamic.go

@@ -1,14 +1,14 @@
-//go:build !static
 // +build !static
 
 package git
 
 /*
 #cgo pkg-config: libgit2
-#cgo CFLAGS: -DLIBGIT2_DYNAMIC -I/opt/libgit2/include
+#cgo CFLAGS: -DLIBGIT2_DYNAMIC
-#cgo LDFLAGS: -L/opt/libgit2 -lgit2
 #include <git2.h>
 
-
+#if LIBGIT2_VER_MAJOR != 0 || LIBGIT2_VER_MINOR != 27
+# error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
+#endif
 */
 import "C"

Build_system_static.go

@@ -1,4 +1,3 @@
-//go:build static && system_libgit2
 // +build static,system_libgit2
 
 package git
@@ -8,8 +7,8 @@ package git
 #cgo CFLAGS: -DLIBGIT2_STATIC
 #include <git2.h>
 
-#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 5 || LIBGIT2_VER_MINOR > 5
+#if LIBGIT2_VER_MAJOR != 0 || LIBGIT2_VER_MINOR != 27
-# error "Invalid libgit2 version; this libgit2 supports libgit2 between v1.5.0 and v1.5.0"
+# error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
 #endif
 */
 import "C"

LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright (c) 2013 The libgit2 contributors
+Copyright (c) 2013 The git2go contributors
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

Makefile

@@ -1,11 +1,7 @@
 TEST_ARGS ?= --count=1
 
-PKG_CONFIG_PATH=/opt/libgit2/
+default: test
 
-default: goimports test
-
-goimports:
-	goimports -w *.go
 
 generate: static-build/install/lib/libgit2.a
 	go generate --tags "static" ./...
@@ -14,19 +10,12 @@ generate: static-build/install/lib/libgit2.a
 # ==============
 # This uses whatever version of libgit2 can be found in the system.
 test:
-	-go-mod-clean # go install go.wit.com/apps/go-mod-clean@latest
 	go run script/check-MakeGitError-thread-lock.go
-	LD_LIBRARY_PATH=/opt/libgit2 PKG_CONFIG_PATH=/opt/libgit2/ go test -v -x $(TEST_ARGS) ./...
+	go test $(TEST_ARGS) ./...
-
-add-remote:
-	git remote add git2go https://github.com/libgit2/git2go.git
 
 install:
 	go install ./...
 
-clean:
-	rm go.*
-
 # Bundled dynamic library
 # =======================
 # In order to avoid having to manipulate `git_dynamic.go`, which would prevent

README.md

@@ -1,48 +1,86 @@
-GO libgit2
+git2go
 ======
-[![GoDoc](https://godoc.org/go.wit.com/lib/libgit2?status.svg)](http://godoc.org/go.wit.com/lib/libgit2) [![Build Status](https://travis-ci.org/libgit2/libgit2.svg?branch=main)](https://travis-ci.org/libgit2/libgit2)
+[![GoDoc](https://godoc.org/github.com/libgit2/git2go?status.svg)](http://godoc.org/github.com/libgit2/git2go/v27) [![Build Status](https://travis-ci.org/libgit2/git2go.svg?branch=main)](https://travis-ci.org/libgit2/git2go)
 
 Go bindings for [libgit2](http://libgit2.github.com/).
 
-### Updated 2024/12/16
-
 ### Which Go version to use
 
-* This package is updated to work against libgit2 version 1.8 on Debian sid
+Due to the fact that Go 1.11 module versions have semantic meaning and don't necessarily align with libgit2's release schedule, please consult the following table for a mapping between libgit2 and git2go module versions:
-* There is one line commented out which needs to be fixed in remote.go
+
-* some of the tests seem to run
+| libgit2 | git2go        |
+|---------|---------------|
+| main    | (will be v30) |
+| 0.99    | v29           |
+| 0.28    | v28           |
+| 0.27    | v27           |
+
+You can import them in your project with the version's major number as a suffix. For example, if you have libgit2 v0.27 installed, you'd import git2go v27 with
 
 ```sh
-go install go.wit.com/apps/go-clone@latest
+go get github.com/libgit2/git2go/v27
-go install go.wit.com/apps/go-mod-clean@latest
+```
-go-clone --recusive go.wit.com/lib/libgit2
+```go
+import "github.com/libgit2/git2go/v27"
 ```
 
+which will ensure there are no sudden changes to the API.
+
+The `main` branch follows the tip of libgit2 itself (with some lag) and as such has no guarantees on the stability of libgit2's API. Thus this only supports statically linking against libgit2.
 
 ### Which branch to send Pull requests to
 
-TODO: not sure yet
+If there's something version-specific that you'd want to contribute to, you can send them to the `release-${MAJOR}.${MINOR}` branches, which follow libgit2's releases.
 
 Installing
 ----------
 
 This project wraps the functionality provided by libgit2. It thus needs it in order to perform the work.
 
-This project wraps the functionality provided by libgit2. If you're using a versioned branch, install it to your system via your system's package manager and then install libgit2.
+This project wraps the functionality provided by libgit2. If you're using a versioned branch, install it to your system via your system's package manager and then install git2go.
 
 
 ### Versioned branch, dynamic linking
 
-When linking dynamically against a released version of libgit2, install it via your system's package manager. CGo will take care of finding its pkg-config file and set up the linking. Import via Go modules, e.g. to work against libgit2 v1.2
+When linking dynamically against a released version of libgit2, install it via your system's package manager. CGo will take care of finding its pkg-config file and set up the linking. Import via Go modules, e.g. to work against libgit2 v0.27
 
 ```go
-    goimports -w *.go
+import "github.com/libgit2/git2go/v27"
 ```
 
+### Versioned branch, static linking
+
+Follow the instructions for [Versioned branch, dynamic linking](#versioned-branch-dynamic-linking), but pass the `-tags static,system_libgit2` flag to all `go` commands that build any binaries. For instance:
+
+    go build -tags static,system_libgit2 github.com/my/project/...
+    go test -tags static,system_libgit2 github.com/my/project/...
+    go install -tags static,system_libgit2 github.com/my/project/...
+
+### `main` branch, or vendored static linking
+
+If using `main` or building a branch with the vendored libgit2 statically, we need to build libgit2 first. In order to build it, you need `cmake`, `pkg-config` and a C compiler. You will also need the development packages for OpenSSL (outside of Windows or macOS) and LibSSH2 installed if you want libgit2 to support HTTPS and SSH respectively. Note that even if libgit2 is included in the resulting binary, its dependencies will not be.
+
+Run `go get -d github.com/libgit2/git2go` to download the code and go to your `$GOPATH/src/github.com/libgit2/git2go` directory. From there, we need to build the C code and put it into the resulting go binary.
+
+    git submodule update --init # get libgit2
+    make install-static
+
+will compile libgit2, link it into git2go and install it. The `main` branch is set up to follow the specific libgit2 version that is vendored, so trying dynamic linking may or may not work depending on the exact versions involved.
+
+In order to let Go pass the correct flags to `pkg-config`, `-tags static` needs to be passed to all `go` commands that build any binaries. For instance:
+
+    go build -tags static github.com/my/project/...
+    go test -tags static github.com/my/project/...
+    go install -tags static github.com/my/project/...
+
+One thing to take into account is that since Go expects the `pkg-config` file to be within the same directory where `make install-static` was called, so the `go.mod` file may need to have a [`replace` directive](https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive) so that the correct setup is achieved. So if `git2go` is checked out at `$GOPATH/src/github.com/libgit2/git2go` and your project at `$GOPATH/src/github.com/my/project`, the `go.mod` file of `github.com/my/project` might need to have a line like
+
+    replace github.com/libgit2/git2go/v27 => ../../libgit2/git2go
+
 Parallelism and network operations
 ----------------------------------
 
-libgit2 may use OpenSSL and LibSSH2 for performing encrypted network connections. For now, libgit2 asks libgit2 to set locking for OpenSSL. This makes HTTPS connections thread-safe, but it is fragile and will likely stop doing it soon. This may also make SSH connections thread-safe if your copy of libssh2 is linked against OpenSSL. Check libgit2's `THREADSAFE.md` for more information.
+libgit2 may use OpenSSL and LibSSH2 for performing encrypted network connections. For now, git2go asks libgit2 to set locking for OpenSSL. This makes HTTPS connections thread-safe, but it is fragile and will likely stop doing it soon. This may also make SSH connections thread-safe if your copy of libssh2 is linked against OpenSSL. Check libgit2's `THREADSAFE.md` for more information.
 
 Running the tests
 -----------------
@@ -64,6 +102,6 @@ M to the I to the T. See the LICENSE file if you've never seen an MIT license be
 Authors
 -------
 
-- Carlos Martín (github@carlosmn)
+- Carlos Martín (@carlosmn)
-- Vicent Martí (github@vmg)
+- Vicent Martí (@vmg)
 

blame.go

@@ -23,7 +23,7 @@ func DefaultBlameOptions() (BlameOptions, error) {
 	defer runtime.UnlockOSThread()
 
 	opts := C.git_blame_options{}
-	ecode := C.git_blame_options_init(&opts, C.GIT_BLAME_OPTIONS_VERSION)
+	ecode := C.git_blame_init_options(&opts, C.GIT_BLAME_OPTIONS_VERSION)
 	if ecode < 0 {
 		return BlameOptions{}, MakeGitError(ecode)
 	}
@@ -47,8 +47,6 @@ const (
 	BlameTrackCopiesSameCommitCopies BlameOptionsFlag = C.GIT_BLAME_TRACK_COPIES_SAME_COMMIT_COPIES
 	BlameTrackCopiesAnyCommitCopies  BlameOptionsFlag = C.GIT_BLAME_TRACK_COPIES_ANY_COMMIT_COPIES
 	BlameFirstParent                 BlameOptionsFlag = C.GIT_BLAME_FIRST_PARENT
-	BlameUseMailmap                  BlameOptionsFlag = C.GIT_BLAME_USE_MAILMAP
-	BlameIgnoreWhitespace            BlameOptionsFlag = C.GIT_BLAME_IGNORE_WHITESPACE
 )
 
 func (v *Repository) BlameFile(path string, opts *BlameOptions) (*Blame, error) {

blob.go

@@ -68,7 +68,7 @@ func (repo *Repository) CreateBlobFromBuffer(data []byte) (*Oid, error) {
 		size = C.size_t(0)
 	}
 
-	ecode := C.git_blob_create_from_buffer(&id, repo.ptr, unsafe.Pointer(&data[0]), size)
+	ecode := C.git_blob_create_frombuffer(&id, repo.ptr, unsafe.Pointer(&data[0]), size)
 	runtime.KeepAlive(repo)
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)
@@ -88,7 +88,7 @@ func (repo *Repository) CreateFromStream(hintPath string) (*BlobWriteStream, err
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_blob_create_from_stream(&stream, repo.ptr, chintPath)
+	ecode := C.git_blob_create_fromstream(&stream, repo.ptr, chintPath)
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)
 	}
@@ -141,7 +141,7 @@ func (stream *BlobWriteStream) Commit() (*Oid, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_blob_create_from_stream_commit(&oid, stream.ptr)
+	ecode := C.git_blob_create_fromstream_commit(&oid, stream.ptr)
 	runtime.KeepAlive(stream)
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)

branch.go

@@ -210,7 +210,7 @@ func (repo *Repository) RemoteName(canonicalBranchName string) (string, error) {
 	if ret < 0 {
 		return "", MakeGitError(ret)
 	}
-	defer C.git_buf_dispose(&nameBuf)
+	defer C.git_buf_free(&nameBuf)
 
 	return C.GoString(nameBuf.ptr), nil
 }
@@ -258,7 +258,7 @@ func (repo *Repository) UpstreamName(canonicalBranchName string) (string, error)
 	if ret < 0 {
 		return "", MakeGitError(ret)
 	}
-	defer C.git_buf_dispose(&nameBuf)
+	defer C.git_buf_free(&nameBuf)
 
 	return C.GoString(nameBuf.ptr), nil
 }

checkout.go

@@ -7,6 +7,7 @@ extern void _go_git_populate_checkout_callbacks(git_checkout_options *opts);
 */
 import "C"
 import (
+	"errors"
 	"os"
 	"runtime"
 	"unsafe"
@@ -35,6 +36,7 @@ const (
 	CheckoutDontUpdateIndex           CheckoutStrategy = C.GIT_CHECKOUT_DONT_UPDATE_INDEX            // Normally checkout updates index entries as it goes; this stops that
 	CheckoutNoRefresh                 CheckoutStrategy = C.GIT_CHECKOUT_NO_REFRESH                   // Don't refresh index/config/etc before doing checkout
 	CheckoutSkipUnmerged              CheckoutStrategy = C.GIT_CHECKOUT_SKIP_UNMERGED                // Allow checkout to skip unmerged files
+	CheckoutUserOurs                  CheckoutStrategy = C.GIT_CHECKOUT_USE_OURS                     // For unmerged files, checkout stage 2 from index
 	CheckoutUseOurs                   CheckoutStrategy = C.GIT_CHECKOUT_USE_OURS                     // For unmerged files, checkout stage 2 from index
 	CheckoutUseTheirs                 CheckoutStrategy = C.GIT_CHECKOUT_USE_THEIRS                   // For unmerged files, checkout stage 3 from index
 	CheckoutDisablePathspecMatch      CheckoutStrategy = C.GIT_CHECKOUT_DISABLE_PATHSPEC_MATCH       // Treat pathspec as simple list of exact match file paths
@@ -48,8 +50,8 @@ const (
 	CheckoutUpdateSubmodulesIfChanged CheckoutStrategy = C.GIT_CHECKOUT_UPDATE_SUBMODULES_IF_CHANGED // Recursively checkout submodules if HEAD moved in super repo (NOT IMPLEMENTED)
 )
 
-type CheckoutNotifyCallback func(why CheckoutNotifyType, path string, baseline, target, workdir DiffFile) error
+type CheckoutNotifyCallback func(why CheckoutNotifyType, path string, baseline, target, workdir DiffFile) ErrorCode
-type CheckoutProgressCallback func(path string, completed, total uint)
+type CheckoutProgressCallback func(path string, completed, total uint) ErrorCode
 
 type CheckoutOptions struct {
 	Strategy         CheckoutStrategy   // Default will be a dry run
@@ -115,9 +117,9 @@ func checkoutNotifyCallback(
 	if data.options.NotifyCallback == nil {
 		return C.int(ErrorCodeOK)
 	}
-	err := data.options.NotifyCallback(CheckoutNotifyType(why), path, baseline, target, workdir)
+	ret := data.options.NotifyCallback(CheckoutNotifyType(why), path, baseline, target, workdir)
-	if err != nil {
+	if ret < 0 {
-		*data.errorTarget = err
+		*data.errorTarget = errors.New(ErrorCode(ret).String())
 		return C.int(ErrorCodeUser)
 	}
 	return C.int(ErrorCodeOK)
@@ -140,7 +142,7 @@ func checkoutProgressCallback(
 // the provided CheckoutOptions struct.  Returns copts, or nil if opts is nil,
 // in order to help with what to pass.
 func populateCheckoutOptions(copts *C.git_checkout_options, opts *CheckoutOptions, errorTarget *error) *C.git_checkout_options {
-	C.git_checkout_options_init(copts, C.GIT_CHECKOUT_OPTIONS_VERSION)
+	C.git_checkout_init_options(copts, C.GIT_CHECKOUT_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}

cherrypick.go

@@ -9,28 +9,30 @@ import (
 )
 
 type CherrypickOptions struct {
-	Mainline        uint
+	Version      uint
-	MergeOptions    MergeOptions
+	Mainline     uint
-	CheckoutOptions CheckoutOptions
+	MergeOpts    MergeOptions
+	CheckoutOpts CheckoutOptions
 }
 
 func cherrypickOptionsFromC(c *C.git_cherrypick_options) CherrypickOptions {
 	opts := CherrypickOptions{
-		Mainline:        uint(c.mainline),
+		Version:      uint(c.version),
-		MergeOptions:    mergeOptionsFromC(&c.merge_opts),
+		Mainline:     uint(c.mainline),
-		CheckoutOptions: checkoutOptionsFromC(&c.checkout_opts),
+		MergeOpts:    mergeOptionsFromC(&c.merge_opts),
+		CheckoutOpts: checkoutOptionsFromC(&c.checkout_opts),
 	}
 	return opts
 }
 
 func populateCherrypickOptions(copts *C.git_cherrypick_options, opts *CherrypickOptions, errorTarget *error) *C.git_cherrypick_options {
-	C.git_cherrypick_options_init(copts, C.GIT_CHERRYPICK_OPTIONS_VERSION)
+	C.git_cherrypick_init_options(copts, C.GIT_CHERRYPICK_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
 	copts.mainline = C.uint(opts.Mainline)
-	populateMergeOptions(&copts.merge_opts, &opts.MergeOptions)
+	populateMergeOptions(&copts.merge_opts, &opts.MergeOpts)
-	populateCheckoutOptions(&copts.checkout_opts, &opts.CheckoutOptions, errorTarget)
+	populateCheckoutOptions(&copts.checkout_opts, &opts.CheckoutOpts, errorTarget)
 	return copts
 }
 
@@ -48,7 +50,7 @@ func DefaultCherrypickOptions() (CherrypickOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_cherrypick_options_init(&c, C.GIT_CHERRYPICK_OPTIONS_VERSION)
+	ecode := C.git_cherrypick_init_options(&c, C.GIT_CHERRYPICK_OPTIONS_VERSION)
 	if ecode < 0 {
 		return CherrypickOptions{}, MakeGitError(ecode)
 	}
@@ -80,7 +82,7 @@ func (r *Repository) CherrypickCommit(pick, our *Commit, opts CherrypickOptions)
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	cOpts := populateMergeOptions(&C.git_merge_options{}, &opts.MergeOptions)
+	cOpts := populateMergeOptions(&C.git_merge_options{}, &opts.MergeOpts)
 	defer freeMergeOptions(cOpts)
 
 	var ptr *C.git_index

clone.go

@@ -7,15 +7,16 @@ extern void _go_git_populate_clone_callbacks(git_clone_options *opts);
 */
 import "C"
 import (
+	"errors"
 	"runtime"
 	"unsafe"
 )
 
-type RemoteCreateCallback func(repo *Repository, name, url string) (*Remote, error)
+type RemoteCreateCallback func(repo *Repository, name, url string) (*Remote, ErrorCode)
 
 type CloneOptions struct {
-	CheckoutOptions      CheckoutOptions
+	*CheckoutOpts
-	FetchOptions         FetchOptions
+	*FetchOptions
 	Bare                 bool
 	CheckoutBranch       string
 	RemoteCreateCallback RemoteCreateCallback
@@ -70,10 +71,9 @@ func remoteCreateCallback(
 		panic("invalid remote create callback")
 	}
 
-	remote, err := data.options.RemoteCreateCallback(repo, name, url)
+	remote, ret := data.options.RemoteCreateCallback(repo, name, url)
-
+	if ret < 0 {
-	if err != nil {
+		*data.errorTarget = errors.New(ErrorCode(ret).String())
-		*data.errorTarget = err
 		return C.int(ErrorCodeUser)
 	}
 	if remote == nil {
@@ -96,12 +96,12 @@ type cloneCallbackData struct {
 }
 
 func populateCloneOptions(copts *C.git_clone_options, opts *CloneOptions, errorTarget *error) *C.git_clone_options {
-	C.git_clone_options_init(copts, C.GIT_CLONE_OPTIONS_VERSION)
+	C.git_clone_init_options(copts, C.GIT_CLONE_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
-	populateCheckoutOptions(&copts.checkout_opts, &opts.CheckoutOptions, errorTarget)
+	populateCheckoutOptions(&copts.checkout_opts, opts.CheckoutOpts, errorTarget)
-	populateFetchOptions(&copts.fetch_opts, &opts.FetchOptions, errorTarget)
+	populateFetchOptions(&copts.fetch_opts, opts.FetchOptions, errorTarget)
 	copts.bare = cbool(opts.Bare)
 
 	if opts.RemoteCreateCallback != nil {

clone_test.go

@@ -2,7 +2,6 @@ package git
 
 import (
 	"io/ioutil"
-	"os"
 	"testing"
 )
 
@@ -50,9 +49,15 @@ func TestCloneWithCallback(t *testing.T) {
 
 	opts := CloneOptions{
 		Bare: true,
-		RemoteCreateCallback: func(r *Repository, name, url string) (*Remote, error) {
+		RemoteCreateCallback: func(r *Repository, name, url string) (*Remote, ErrorCode) {
 			testPayload += 1
-			return r.Remotes.Create(REMOTENAME, url)
+
+			remote, err := r.Remotes.Create(REMOTENAME, url)
+			if err != nil {
+				return nil, ErrorCodeGeneric
+			}
+
+			return remote, ErrorCodeOK
 		},
 	}
 
@@ -71,17 +76,3 @@ func TestCloneWithCallback(t *testing.T) {
 	}
 	defer remote.Free()
 }
-
-// TestCloneWithExternalHTTPUrl
-func TestCloneWithExternalHTTPUrl(t *testing.T) {
-
-	path, err := ioutil.TempDir("", "git2go")
-	defer os.RemoveAll(path)
-
-	// clone the repo
-	url := "https://github.com/libgit2/TestGitRepository"
-	_, err = Clone(url, path, &CloneOptions{})
-	if err != nil {
-		t.Fatal("cannot clone remote repo via https, error: ", err)
-	}
-}

commit.go

@@ -37,14 +37,10 @@ func (c *Commit) Message() string {
 	return ret
 }
 
-func (c *Commit) MessageEncoding() MessageEncoding {
+func (c *Commit) MessageEncoding() string {
-	ptr := C.git_commit_message_encoding(c.cast_ptr)
+	ret := C.GoString(C.git_commit_message_encoding(c.cast_ptr))
-	if ptr == nil {
-		return MessageEncodingUTF8
-	}
-	ret := C.GoString(ptr)
 	runtime.KeepAlive(c)
-	return MessageEncoding(ret)
+	return ret
 }
 
 func (c *Commit) RawMessage() string {
@@ -68,19 +64,6 @@ func (c *Commit) ContentToSign() string {
 // CommitSigningCallback defines a function type that takes some data to sign and returns (signature, signature_field, error)
 type CommitSigningCallback func(string) (signature, signatureField string, err error)
 
-// CommitCreateCallback defines a function type that is called when another
-// function is going to create commits (for example, Rebase) to allow callers
-// to override the commit creation behavior. For example, users may wish to
-// sign commits by providing this information to Repository.CreateCommitBuffer,
-// signing that buffer, then calling Repository.CreateCommitWithSignature.
-type CommitCreateCallback func(
-	author, committer *Signature,
-	messageEncoding MessageEncoding,
-	message string,
-	tree *Tree,
-	parents ...*Commit,
-) (oid *Oid, err error)
-
 // WithSignatureUsing creates a new signed commit from this one using the given signing callback
 func (c *Commit) WithSignatureUsing(f CommitSigningCallback) (*Oid, error) {
 	signature, signatureField, err := f(c.ContentToSign())
@@ -103,10 +86,10 @@ func (c *Commit) WithSignature(signature string, signatureField string) (*Oid, e
 func (c *Commit) ExtractSignature() (string, string, error) {
 
 	var c_signed C.git_buf
-	defer C.git_buf_dispose(&c_signed)
+	defer C.git_buf_free(&c_signed)
 
 	var c_signature C.git_buf
-	defer C.git_buf_dispose(&c_signature)
+	defer C.git_buf_free(&c_signature)
 
 	oid := c.Id()
 	repo := C.git_commit_owner(c.cast_ptr)

config.go

@@ -135,7 +135,7 @@ func (c *Config) LookupString(name string) (string, error) {
 	if ret < 0 {
 		return "", MakeGitError(ret)
 	}
-	defer C.git_buf_dispose(&valBuf)
+	defer C.git_buf_free(&valBuf)
 
 	return C.GoString(valBuf.ptr), nil
 }
@@ -345,7 +345,7 @@ func (c *Config) OpenLevel(parent *Config, level ConfigLevel) (*Config, error) {
 }
 
 // OpenOndisk creates a new config instance containing a single on-disk file
-func OpenOndisk(path string) (*Config, error) {
+func OpenOndisk(parent *Config, path string) (*Config, error) {
 	cpath := C.CString(path)
 	defer C.free(unsafe.Pointer(cpath))
 
@@ -392,7 +392,7 @@ func (iter *ConfigIterator) Free() {
 
 func ConfigFindGlobal() (string, error) {
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
@@ -407,7 +407,7 @@ func ConfigFindGlobal() (string, error) {
 
 func ConfigFindSystem() (string, error) {
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
@@ -422,7 +422,7 @@ func ConfigFindSystem() (string, error) {
 
 func ConfigFindXDG() (string, error) {
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
@@ -440,7 +440,7 @@ func ConfigFindXDG() (string, error) {
 // Look for the file in %PROGRAMDATA%\Git\config used by portable git.
 func ConfigFindProgramdata() (string, error) {
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()

config_test.go

@@ -13,7 +13,7 @@ func setupConfig() (*Config, error) {
 		err error
 	)
 
-	c, err = OpenOndisk(tempConfig)
+	c, err = OpenOndisk(nil, tempConfig)
 	if err != nil {
 		return nil, err
 	}

credentials.go

@@ -2,114 +2,51 @@ package git
 
 /*
 #include <git2.h>
-#include <git2/credential.h>
-#include <git2/sys/credential.h>
 
-git_credential_t _go_git_credential_credtype(git_credential *cred);
+void _go_git_populate_credential_ssh_custom(git_cred_ssh_custom *cred);
-void _go_git_populate_credential_ssh_custom(git_credential_ssh_custom *cred);
 */
 import "C"
 import (
 	"crypto/rand"
 	"errors"
 	"fmt"
-	"runtime"
-	"strings"
 	"unsafe"
 
 	"golang.org/x/crypto/ssh"
 )
 
-// CredentialType is a bitmask of supported credential types.
+type CredType uint
-//
-// This represents the various types of authentication methods supported by the
-// library.
-type CredentialType uint
 
 const (
-	CredentialTypeUserpassPlaintext CredentialType = C.GIT_CREDENTIAL_USERPASS_PLAINTEXT
+	CredTypeUserpassPlaintext CredType = C.GIT_CREDTYPE_USERPASS_PLAINTEXT
-	CredentialTypeSSHKey            CredentialType = C.GIT_CREDENTIAL_SSH_KEY
+	CredTypeSshKey            CredType = C.GIT_CREDTYPE_SSH_KEY
-	CredentialTypeSSHCustom         CredentialType = C.GIT_CREDENTIAL_SSH_CUSTOM
+	CredTypeSshCustom         CredType = C.GIT_CREDTYPE_SSH_CUSTOM
-	CredentialTypeDefault           CredentialType = C.GIT_CREDENTIAL_DEFAULT
+	CredTypeDefault           CredType = C.GIT_CREDTYPE_DEFAULT
-	CredentialTypeSSHInteractive    CredentialType = C.GIT_CREDENTIAL_SSH_INTERACTIVE
-	CredentialTypeUsername          CredentialType = C.GIT_CREDENTIAL_USERNAME
-	CredentialTypeSSHMemory         CredentialType = C.GIT_CREDENTIAL_SSH_MEMORY
 )
 
-func (t CredentialType) String() string {
+type Cred struct {
-	if t == 0 {
-		return "CredentialType(0)"
-	}
-
-	var parts []string
-
-	if (t & CredentialTypeUserpassPlaintext) != 0 {
-		parts = append(parts, "UserpassPlaintext")
-		t &= ^CredentialTypeUserpassPlaintext
-	}
-	if (t & CredentialTypeSSHKey) != 0 {
-		parts = append(parts, "SSHKey")
-		t &= ^CredentialTypeSSHKey
-	}
-	if (t & CredentialTypeSSHCustom) != 0 {
-		parts = append(parts, "SSHCustom")
-		t &= ^CredentialTypeSSHCustom
-	}
-	if (t & CredentialTypeDefault) != 0 {
-		parts = append(parts, "Default")
-		t &= ^CredentialTypeDefault
-	}
-	if (t & CredentialTypeSSHInteractive) != 0 {
-		parts = append(parts, "SSHInteractive")
-		t &= ^CredentialTypeSSHInteractive
-	}
-	if (t & CredentialTypeUsername) != 0 {
-		parts = append(parts, "Username")
-		t &= ^CredentialTypeUsername
-	}
-	if (t & CredentialTypeSSHMemory) != 0 {
-		parts = append(parts, "SSHMemory")
-		t &= ^CredentialTypeSSHMemory
-	}
-
-	if t != 0 {
-		parts = append(parts, fmt.Sprintf("CredentialType(%#x)", t))
-	}
-
-	return strings.Join(parts, "|")
-}
-
-type Credential struct {
 	doNotCompare
-	ptr *C.git_credential
+	ptr *C.git_cred
 }
 
-func newCredential() *Credential {
+func (o *Cred) HasUsername() bool {
-	cred := &Credential{}
+	if C.git_cred_has_username(o.ptr) == 1 {
-	runtime.SetFinalizer(cred, (*Credential).Free)
-	return cred
-}
-
-func (o *Credential) HasUsername() bool {
-	if C.git_credential_has_username(o.ptr) == 1 {
 		return true
 	}
 	return false
 }
 
-func (o *Credential) Type() CredentialType {
+func (o *Cred) Type() CredType {
-	return (CredentialType)(C._go_git_credential_credtype(o.ptr))
+	return (CredType)(o.ptr.credtype)
 }
 
-func (o *Credential) Free() {
+func credFromC(ptr *C.git_cred) *Cred {
-	C.git_credential_free(o.ptr)
+	return &Cred{ptr: ptr}
-	runtime.SetFinalizer(o, nil)
-	o.ptr = nil
 }
 
 // GetUserpassPlaintext returns the plaintext username/password combination stored in the Cred.
-func (o *Credential) GetUserpassPlaintext() (username, password string, err error) {
+func (o *Cred) GetUserpassPlaintext() (username, password string, err error) {
-	if o.Type() != CredentialTypeUserpassPlaintext {
+	if o.Type() != CredTypeUserpassPlaintext {
 		err = errors.New("credential is not userpass plaintext")
 		return
 	}
@@ -121,8 +58,8 @@ func (o *Credential) GetUserpassPlaintext() (username, password string, err erro
 }
 
 // GetSSHKey returns the SSH-specific key information from the Cred object.
-func (o *Credential) GetSSHKey() (username, publickey, privatekey, passphrase string, err error) {
+func (o *Cred) GetSSHKey() (username, publickey, privatekey, passphrase string, err error) {
-	if o.Type() != CredentialTypeSSHKey && o.Type() != CredentialTypeSSHMemory {
+	if o.Type() != CredTypeSshKey {
 		err = fmt.Errorf("credential is not an SSH key: %v", o.Type())
 		return
 	}
@@ -135,44 +72,27 @@ func (o *Credential) GetSSHKey() (username, publickey, privatekey, passphrase st
 	return
 }
 
-func NewCredentialUsername(username string) (*Credential, error) {
+func NewCredUsername(username string) (int, Cred) {
-	runtime.LockOSThread()
+	cred := Cred{}
-	defer runtime.UnlockOSThread()
-
-	cred := newCredential()
 	cusername := C.CString(username)
-	ret := C.git_credential_username_new(&cred.ptr, cusername)
+	ret := C.git_cred_username_new(&cred.ptr, cusername)
-	if ret != 0 {
+	return int(ret), cred
-		cred.Free()
-		return nil, MakeGitError(ret)
-	}
-	return cred, nil
 }
 
-func NewCredentialUserpassPlaintext(username string, password string) (*Credential, error) {
+func NewCredUserpassPlaintext(username string, password string) (int, Cred) {
-	runtime.LockOSThread()
+	cred := Cred{}
-	defer runtime.UnlockOSThread()
-
-	cred := newCredential()
 	cusername := C.CString(username)
 	defer C.free(unsafe.Pointer(cusername))
 	cpassword := C.CString(password)
 	defer C.free(unsafe.Pointer(cpassword))
-	ret := C.git_credential_userpass_plaintext_new(&cred.ptr, cusername, cpassword)
+	ret := C.git_cred_userpass_plaintext_new(&cred.ptr, cusername, cpassword)
-	if ret != 0 {
+	return int(ret), cred
-		cred.Free()
-		return nil, MakeGitError(ret)
-	}
-	return cred, nil
 }
 
-// NewCredentialSSHKey creates new ssh credentials reading the public and private keys
+// NewCredSshKey creates new ssh credentials reading the public and private keys
 // from the file system.
-func NewCredentialSSHKey(username string, publicKeyPath string, privateKeyPath string, passphrase string) (*Credential, error) {
+func NewCredSshKey(username string, publicKeyPath string, privateKeyPath string, passphrase string) (int, Cred) {
-	runtime.LockOSThread()
+	cred := Cred{}
-	defer runtime.UnlockOSThread()
-
-	cred := newCredential()
 	cusername := C.CString(username)
 	defer C.free(unsafe.Pointer(cusername))
 	cpublickey := C.CString(publicKeyPath)
@@ -181,21 +101,14 @@ func NewCredentialSSHKey(username string, publicKeyPath string, privateKeyPath s
 	defer C.free(unsafe.Pointer(cprivatekey))
 	cpassphrase := C.CString(passphrase)
 	defer C.free(unsafe.Pointer(cpassphrase))
-	ret := C.git_credential_ssh_key_new(&cred.ptr, cusername, cpublickey, cprivatekey, cpassphrase)
+	ret := C.git_cred_ssh_key_new(&cred.ptr, cusername, cpublickey, cprivatekey, cpassphrase)
-	if ret != 0 {
+	return int(ret), cred
-		cred.Free()
-		return nil, MakeGitError(ret)
-	}
-	return cred, nil
 }
 
-// NewCredentialSSHKeyFromMemory creates new ssh credentials using the publicKey and privateKey
+// NewCredSshKeyFromMemory creates new ssh credentials using the publicKey and privateKey
 // arguments as the values for the public and private keys.
-func NewCredentialSSHKeyFromMemory(username string, publicKey string, privateKey string, passphrase string) (*Credential, error) {
+func NewCredSshKeyFromMemory(username string, publicKey string, privateKey string, passphrase string) (int, Cred) {
-	runtime.LockOSThread()
+	cred := Cred{}
-	defer runtime.UnlockOSThread()
-
-	cred := newCredential()
 	cusername := C.CString(username)
 	defer C.free(unsafe.Pointer(cusername))
 	cpublickey := C.CString(publicKey)
@@ -204,27 +117,22 @@ func NewCredentialSSHKeyFromMemory(username string, publicKey string, privateKey
 	defer C.free(unsafe.Pointer(cprivatekey))
 	cpassphrase := C.CString(passphrase)
 	defer C.free(unsafe.Pointer(cpassphrase))
-	ret := C.git_credential_ssh_key_memory_new(&cred.ptr, cusername, cpublickey, cprivatekey, cpassphrase)
+	ret := C.git_cred_ssh_key_memory_new(&cred.ptr, cusername, cpublickey, cprivatekey, cpassphrase)
-	if ret != 0 {
+	return int(ret), cred
-		cred.Free()
-		return nil, MakeGitError(ret)
-	}
-	return cred, nil
 }
 
-func NewCredentialSSHKeyFromAgent(username string) (*Credential, error) {
+func NewCredSshKeyFromAgent(username string) (int, Cred) {
-	runtime.LockOSThread()
+	cred := Cred{}
-	defer runtime.UnlockOSThread()
-
-	cred := newCredential()
 	cusername := C.CString(username)
 	defer C.free(unsafe.Pointer(cusername))
-	ret := C.git_credential_ssh_key_from_agent(&cred.ptr, cusername)
+	ret := C.git_cred_ssh_key_from_agent(&cred.ptr, cusername)
-	if ret != 0 {
+	return int(ret), cred
-		cred.Free()
+}
-		return nil, MakeGitError(ret)
+
-	}
+func NewCredDefault() (int, Cred) {
-	return cred, nil
+	cred := Cred{}
+	ret := C.git_cred_default_new(&cred.ptr)
+	return int(ret), cred
 }
 
 type credentialSSHCustomData struct {
@@ -232,7 +140,7 @@ type credentialSSHCustomData struct {
 }
 
 //export credentialSSHCustomFree
-func credentialSSHCustomFree(cred *C.git_credential_ssh_custom) {
+func credentialSSHCustomFree(cred *C.git_cred_ssh_custom) {
 	if cred == nil {
 		return
 	}
@@ -263,11 +171,11 @@ func credentialSSHSignCallback(
 }
 
 // NewCredentialSSHKeyFromSigner creates new SSH credentials using the provided signer.
-func NewCredentialSSHKeyFromSigner(username string, signer ssh.Signer) (*Credential, error) {
+func NewCredentialSSHKeyFromSigner(username string, signer ssh.Signer) (*Cred, error) {
 	publicKey := signer.PublicKey().Marshal()
 
-	ccred := (*C.git_credential_ssh_custom)(C.calloc(1, C.size_t(unsafe.Sizeof(C.git_credential_ssh_custom{}))))
+	ccred := (*C.git_cred_ssh_custom)(C.calloc(1, C.size_t(unsafe.Sizeof(C.git_cred_ssh_custom{}))))
-	ccred.parent.credtype = C.GIT_CREDENTIAL_SSH_CUSTOM
+	ccred.parent.credtype = C.GIT_CREDTYPE_SSH_CUSTOM
 	ccred.username = C.CString(username)
 	ccred.publickey = (*C.char)(C.CBytes(publicKey))
 	ccred.publickey_len = C.size_t(len(publicKey))
@@ -278,21 +186,9 @@ func NewCredentialSSHKeyFromSigner(username string, signer ssh.Signer) (*Credent
 	}
 	ccred.payload = pointerHandles.Track(&data)
 
-	cred := newCredential()
+	cred := Cred{
-	cred.ptr = &ccred.parent
+		ptr: &ccred.parent,
-
-	return cred, nil
-}
-
-func NewCredentialDefault() (*Credential, error) {
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	cred := newCredential()
-	ret := C.git_credential_default_new(&cred.ptr)
-	if ret != 0 {
-		cred.Free()
-		return nil, MakeGitError(ret)
 	}
-	return cred, nil
+
+	return &cred, nil
 }

deprecated.go

@@ -27,51 +27,6 @@ type BlobCallbackData struct {
 // Deprecated: CheckoutOpts is a deprecated alias of CheckoutOptions.
 type CheckoutOpts = CheckoutOptions
 
-// credentials.go
-
-// Deprecated: CredType is a deprecated alias of CredentialType
-type CredType = CredentialType
-
-const (
-	CredTypeUserpassPlaintext = CredentialTypeUserpassPlaintext
-	CredTypeSshKey            = CredentialTypeSSHKey
-	CredTypeSshCustom         = CredentialTypeSSHCustom
-	CredTypeDefault           = CredentialTypeDefault
-)
-
-// Deprecated: Cred is a deprecated alias of Credential
-type Cred = Credential
-
-// Deprecated: NewCredUsername is a deprecated alias of NewCredentialUsername.
-func NewCredUsername(username string) (*Cred, error) {
-	return NewCredentialUsername(username)
-}
-
-// Deprecated: NewCredUserpassPlaintext is a deprecated alias of NewCredentialUserpassPlaintext.
-func NewCredUserpassPlaintext(username string, password string) (*Cred, error) {
-	return NewCredentialUserpassPlaintext(username, password)
-}
-
-// Deprecated: NewCredSshKey is a deprecated alias of NewCredentialSshKey.
-func NewCredSshKey(username string, publicKeyPath string, privateKeyPath string, passphrase string) (*Cred, error) {
-	return NewCredentialSSHKey(username, publicKeyPath, privateKeyPath, passphrase)
-}
-
-// Deprecated: NewCredSshKeyFromMemory is a deprecated alias of NewCredentialSSHKeyFromMemory.
-func NewCredSshKeyFromMemory(username string, publicKey string, privateKey string, passphrase string) (*Cred, error) {
-	return NewCredentialSSHKeyFromMemory(username, publicKey, privateKey, passphrase)
-}
-
-// Deprecated: NewCredSshKeyFromAgent is a deprecated alias of NewCredentialSSHFromAgent.
-func NewCredSshKeyFromAgent(username string) (*Cred, error) {
-	return NewCredentialSSHKeyFromAgent(username)
-}
-
-// Deprecated: NewCredDefault is a deprecated alias fof NewCredentialDefault.
-func NewCredDefault() (*Cred, error) {
-	return NewCredentialDefault()
-}
-
 // diff.go
 
 const (
@@ -205,8 +160,6 @@ const (
 	ErrPassthrough = ErrorCodePassthrough
 	// Deprecated: ErrIterOver is a deprecated alias of ErrorCodeIterOver.
 	ErrIterOver = ErrorCodeIterOver
-	// Deprecated: ErrApplyFail is a deprecated alias of ErrorCodeApplyFail.
-	ErrApplyFail = ErrorCodeApplyFail
 )
 
 // index.go
@@ -230,27 +183,7 @@ func SubmoduleVisitor(csub unsafe.Pointer, name *C.char, handle unsafe.Pointer)
 	if !ok {
 		panic("invalid submodule visitor callback")
 	}
-	err := callback(sub, C.GoString(name))
+	return (C.int)(callback(sub, C.GoString(name)))
-	if err != nil {
-		return C.int(ErrorCodeUser)
-	}
-	return C.int(ErrorCodeOK)
-}
-
-// reference.go
-
-// Deprecated: ReferenceIsValidName is a deprecated alias of ReferenceNameIsValid.
-func ReferenceIsValidName(name string) bool {
-	valid, _ := ReferenceNameIsValid(name)
-	return valid
-}
-
-// remote.go
-
-// Deprecated: RemoteIsValidName is a deprecated alias of RemoteNameIsValid.
-func RemoteIsValidName(name string) bool {
-	valid, _ := RemoteNameIsValid(name)
-	return valid
 }
 
 // tree.go
@@ -259,13 +192,9 @@ func RemoteIsValidName(name string) bool {
 func CallbackGitTreeWalk(_root *C.char, entry *C.git_tree_entry, ptr unsafe.Pointer) C.int {
 	root := C.GoString(_root)
 
-	callback, ok := pointerHandles.Get(ptr).(TreeWalkCallback)
+	if callback, ok := pointerHandles.Get(ptr).(TreeWalkCallback); ok {
-	if !ok {
+		return C.int(callback(root, newTreeEntry(entry)))
+	} else {
 		panic("invalid treewalk callback")
 	}
-	err := callback(root, newTreeEntry(entry))
-	if err != nil {
-		return C.int(ErrorCodeUser)
-	}
-	return C.int(ErrorCodeOK)
 }

describe.go

@@ -43,7 +43,7 @@ func DefaultDescribeOptions() (DescribeOptions, error) {
 	defer runtime.UnlockOSThread()
 
 	opts := C.git_describe_options{}
-	ecode := C.git_describe_options_init(&opts, C.GIT_DESCRIBE_OPTIONS_VERSION)
+	ecode := C.git_describe_init_options(&opts, C.GIT_DESCRIBE_OPTIONS_VERSION)
 	if ecode < 0 {
 		return DescribeOptions{}, MakeGitError(ecode)
 	}
@@ -77,7 +77,7 @@ func DefaultDescribeFormatOptions() (DescribeFormatOptions, error) {
 	defer runtime.UnlockOSThread()
 
 	opts := C.git_describe_format_options{}
-	ecode := C.git_describe_format_options_init(&opts, C.GIT_DESCRIBE_FORMAT_OPTIONS_VERSION)
+	ecode := C.git_describe_init_format_options(&opts, C.GIT_DESCRIBE_FORMAT_OPTIONS_VERSION)
 	if ecode < 0 {
 		return DescribeFormatOptions{}, MakeGitError(ecode)
 	}
@@ -213,7 +213,7 @@ func (result *DescribeResult) Format(opts *DescribeFormatOptions) (string, error
 	if ecode < 0 {
 		return "", MakeGitError(ecode)
 	}
-	defer C.git_buf_dispose(&resultBuf)
+	defer C.git_buf_free(&resultBuf)
 
 	return C.GoString(resultBuf.ptr), nil
 }

diff.go

@@ -3,7 +3,6 @@ package git
 /*
 #include <git2.h>
 
-extern void _go_git_populate_apply_callbacks(git_apply_options *options);
 extern int _go_git_diff_foreach(git_diff *diff, int eachFile, int eachHunk, int eachLine, void *payload);
 extern void _go_git_setup_diff_notify_callbacks(git_diff_options* opts);
 extern int _go_git_diff_blobs(git_blob *old, const char *old_path, git_blob *new, const char *new_path, git_diff_options *opts, int eachFile, int eachHunk, int eachLine, void *payload);
@@ -265,7 +264,7 @@ const (
 func (stats *DiffStats) String(format DiffStatsFormat,
 	width uint) (string, error) {
 	buf := C.git_buf{}
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
@@ -458,7 +457,7 @@ func (diff *Diff) ToBuf(format DiffFormat) ([]byte, error) {
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)
 	}
-	defer C.git_buf_dispose(&diffBuf)
+	defer C.git_buf_free(&diffBuf)
 
 	return C.GoBytes(unsafe.Pointer(diffBuf.ptr), C.int(diffBuf.size)), nil
 }
@@ -523,7 +522,7 @@ func DefaultDiffOptions() (DiffOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_diff_options_init(&opts, C.GIT_DIFF_OPTIONS_VERSION)
+	ecode := C.git_diff_init_options(&opts, C.GIT_DIFF_OPTIONS_VERSION)
 	if ecode < 0 {
 		return DiffOptions{}, MakeGitError(ecode)
 	}
@@ -562,7 +561,7 @@ const (
 	DiffFindRemoveUnmodified            DiffFindOptionsFlag = C.GIT_DIFF_FIND_REMOVE_UNMODIFIED
 )
 
-// TODO implement git_diff_similarity_metric
+//TODO implement git_diff_similarity_metric
 type DiffFindOptions struct {
 	Flags                      DiffFindOptionsFlag
 	RenameThreshold            uint16
@@ -578,7 +577,7 @@ func DefaultDiffFindOptions() (DiffFindOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_diff_find_options_init(&opts, C.GIT_DIFF_FIND_OPTIONS_VERSION)
+	ecode := C.git_diff_find_init_options(&opts, C.GIT_DIFF_FIND_OPTIONS_VERSION)
 	if ecode < 0 {
 		return DiffFindOptions{}, MakeGitError(ecode)
 	}
@@ -644,7 +643,7 @@ func diffNotifyCallback(_diff_so_far unsafe.Pointer, delta_to_add *C.git_diff_de
 }
 
 func populateDiffOptions(copts *C.git_diff_options, opts *DiffOptions, repo *Repository, errorTarget *error) *C.git_diff_options {
-	C.git_diff_options_init(copts, C.GIT_DIFF_OPTIONS_VERSION)
+	C.git_diff_init_options(copts, C.GIT_DIFF_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
@@ -888,191 +887,6 @@ func DiffBlobs(oldBlob *Blob, oldAsPath string, newBlob *Blob, newAsPath string,
 	return nil
 }
 
-// ApplyHunkCallback is a callback that will be made per delta (file) when applying a patch.
-type ApplyHunkCallback func(*DiffHunk) (apply bool, err error)
-
-// ApplyDeltaCallback is a callback that will be made per hunk when applying a patch.
-type ApplyDeltaCallback func(*DiffDelta) (apply bool, err error)
-
-// ApplyOptions has 2 callbacks that are called for hunks or deltas
-// If these functions return an error, abort the apply process immediately.
-// If the first return value is true, the delta/hunk will be applied. If it is false, the  delta/hunk will not be applied. In either case, the rest of the apply process will continue.
-type ApplyOptions struct {
-	ApplyHunkCallback  ApplyHunkCallback
-	ApplyDeltaCallback ApplyDeltaCallback
-	Flags              uint
-}
-
-type applyCallbackData struct {
-	options     *ApplyOptions
-	errorTarget *error
-}
-
-//export hunkApplyCallback
-func hunkApplyCallback(_hunk *C.git_diff_hunk, _payload unsafe.Pointer) C.int {
-	data, ok := pointerHandles.Get(_payload).(*applyCallbackData)
-	if !ok {
-		panic("invalid apply options payload")
-	}
-
-	if data.options.ApplyHunkCallback == nil {
-		return C.int(ErrorCodeOK)
-	}
-
-	hunk := diffHunkFromC(_hunk)
-
-	apply, err := data.options.ApplyHunkCallback(&hunk)
-	if err != nil {
-		*data.errorTarget = err
-		return C.int(ErrorCodeUser)
-	}
-
-	if !apply {
-		return 1
-	}
-	return C.int(ErrorCodeOK)
-}
-
-//export deltaApplyCallback
-func deltaApplyCallback(_delta *C.git_diff_delta, _payload unsafe.Pointer) C.int {
-	data, ok := pointerHandles.Get(_payload).(*applyCallbackData)
-	if !ok {
-		panic("invalid apply options payload")
-	}
-
-	if data.options.ApplyDeltaCallback == nil {
-		return C.int(ErrorCodeOK)
-	}
-
-	delta := diffDeltaFromC(_delta)
-
-	apply, err := data.options.ApplyDeltaCallback(&delta)
-	if err != nil {
-		*data.errorTarget = err
-		return C.int(ErrorCodeUser)
-	}
-
-	if !apply {
-		return 1
-	}
-	return C.int(ErrorCodeOK)
-}
-
-// DefaultApplyOptions returns default options for applying diffs or patches.
-func DefaultApplyOptions() (*ApplyOptions, error) {
-	opts := C.git_apply_options{}
-
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ecode := C.git_apply_options_init(&opts, C.GIT_APPLY_OPTIONS_VERSION)
-	if int(ecode) != 0 {
-		return nil, MakeGitError(ecode)
-	}
-
-	return applyOptionsFromC(&opts), nil
-}
-
-func populateApplyOptions(copts *C.git_apply_options, opts *ApplyOptions, errorTarget *error) *C.git_apply_options {
-	C.git_apply_options_init(copts, C.GIT_APPLY_OPTIONS_VERSION)
-	if opts == nil {
-		return nil
-	}
-
-	copts.flags = C.uint(opts.Flags)
-
-	if opts.ApplyDeltaCallback != nil || opts.ApplyHunkCallback != nil {
-		data := &applyCallbackData{
-			options:     opts,
-			errorTarget: errorTarget,
-		}
-		C._go_git_populate_apply_callbacks(copts)
-		copts.payload = pointerHandles.Track(data)
-	}
-
-	return copts
-}
-
-func freeApplyOptions(copts *C.git_apply_options) {
-	if copts == nil {
-		return
-	}
-	if copts.payload != nil {
-		pointerHandles.Untrack(copts.payload)
-	}
-}
-
-func applyOptionsFromC(copts *C.git_apply_options) *ApplyOptions {
-	return &ApplyOptions{
-		Flags: uint(copts.flags),
-	}
-}
-
-// ApplyLocation represents the possible application locations for applying
-// diffs.
-type ApplyLocation int
-
-const (
-	// ApplyLocationWorkdir applies the patch to the workdir, leaving the
-	// index untouched. This is the equivalent of `git apply` with no location
-	// argument.
-	ApplyLocationWorkdir ApplyLocation = C.GIT_APPLY_LOCATION_WORKDIR
-	// ApplyLocationIndex applies the patch to the index, leaving the working
-	// directory untouched. This is the equivalent of `git apply --cached`.
-	ApplyLocationIndex ApplyLocation = C.GIT_APPLY_LOCATION_INDEX
-	// ApplyLocationBoth applies the patch to both the working directory and
-	// the index. This is the equivalent of `git apply --index`.
-	ApplyLocationBoth ApplyLocation = C.GIT_APPLY_LOCATION_BOTH
-)
-
-// ApplyDiff appllies a Diff to the given repository, making changes directly
-// in the working directory, the index, or both.
-func (v *Repository) ApplyDiff(diff *Diff, location ApplyLocation, opts *ApplyOptions) error {
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	var err error
-	cOpts := populateApplyOptions(&C.git_apply_options{}, opts, &err)
-	defer freeApplyOptions(cOpts)
-
-	ret := C.git_apply(v.ptr, diff.ptr, C.git_apply_location_t(location), cOpts)
-	runtime.KeepAlive(v)
-	runtime.KeepAlive(diff)
-	runtime.KeepAlive(cOpts)
-	if ret == C.int(ErrorCodeUser) && err != nil {
-		return err
-	}
-	if ret < 0 {
-		return MakeGitError(ret)
-	}
-
-	return nil
-}
-
-// ApplyToTree applies a Diff to a Tree and returns the resulting image as an Index.
-func (v *Repository) ApplyToTree(diff *Diff, tree *Tree, opts *ApplyOptions) (*Index, error) {
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	var err error
-	cOpts := populateApplyOptions(&C.git_apply_options{}, opts, &err)
-	defer freeApplyOptions(cOpts)
-
-	var indexPtr *C.git_index
-	ret := C.git_apply_to_tree(&indexPtr, v.ptr, tree.cast_ptr, diff.ptr, cOpts)
-	runtime.KeepAlive(diff)
-	runtime.KeepAlive(tree)
-	runtime.KeepAlive(cOpts)
-	if ret == C.int(ErrorCodeUser) && err != nil {
-		return nil, err
-	}
-	if ret < 0 {
-		return nil, MakeGitError(ret)
-	}
-
-	return newIndexFromC(indexPtr, v), nil
-}
-
 // DiffFromBuffer reads the contents of a git patch file into a Diff object.
 //
 // The diff object produced is similar to the one that would be produced if you

diff_test.go

@@ -2,10 +2,6 @@ package git
 
 import (
 	"errors"
-	"fmt"
-	"io/ioutil"
-	"path"
-	"reflect"
 	"strings"
 	"testing"
 )
@@ -239,447 +235,3 @@ func TestDiffBlobs(t *testing.T) {
 		t.Fatalf("Bad number of lines iterated")
 	}
 }
-
-func TestApplyDiffAddfile(t *testing.T) {
-	repo := createTestRepo(t)
-	defer cleanupTestRepo(t, repo)
-
-	seedTestRepo(t, repo)
-
-	addFirstFileCommit, addFirstFileTree := addAndGetTree(t, repo, "file1", `hello`)
-	defer addFirstFileCommit.Free()
-	defer addFirstFileTree.Free()
-	addSecondFileCommit, addSecondFileTree := addAndGetTree(t, repo, "file2", `hello2`)
-	defer addSecondFileCommit.Free()
-	defer addSecondFileTree.Free()
-
-	diff, err := repo.DiffTreeToTree(addFirstFileTree, addSecondFileTree, nil)
-	checkFatal(t, err)
-	defer diff.Free()
-
-	t.Run("check does not apply to current tree because file exists", func(t *testing.T) {
-		err = repo.ResetToCommit(addSecondFileCommit, ResetHard, &CheckoutOptions{})
-		checkFatal(t, err)
-
-		err = repo.ApplyDiff(diff, ApplyLocationBoth, nil)
-		if err == nil {
-			t.Error("expecting applying patch to current repo to fail")
-		}
-	})
-
-	t.Run("check apply to correct commit", func(t *testing.T) {
-		err = repo.ResetToCommit(addFirstFileCommit, ResetHard, &CheckoutOptions{})
-		checkFatal(t, err)
-
-		err = repo.ApplyDiff(diff, ApplyLocationBoth, nil)
-		checkFatal(t, err)
-
-		t.Run("Check that diff only changed one file", func(t *testing.T) {
-			checkSecondFileStaged(t, repo)
-
-			index, err := repo.Index()
-			checkFatal(t, err)
-			defer index.Free()
-
-			newTreeOID, err := index.WriteTreeTo(repo)
-			checkFatal(t, err)
-
-			newTree, err := repo.LookupTree(newTreeOID)
-			checkFatal(t, err)
-			defer newTree.Free()
-
-			_, err = repo.CreateCommit("HEAD", signature(), signature(), fmt.Sprintf("patch apply"), newTree, addFirstFileCommit)
-			checkFatal(t, err)
-		})
-
-		t.Run("test applying patch produced the same diff", func(t *testing.T) {
-			head, err := repo.Head()
-			checkFatal(t, err)
-
-			commit, err := repo.LookupCommit(head.Target())
-			checkFatal(t, err)
-			defer commit.Free()
-
-			tree, err := commit.Tree()
-			checkFatal(t, err)
-			defer tree.Free()
-
-			newDiff, err := repo.DiffTreeToTree(addFirstFileTree, tree, nil)
-			checkFatal(t, err)
-			defer newDiff.Free()
-
-			raw1b, err := diff.ToBuf(DiffFormatPatch)
-			checkFatal(t, err)
-			raw2b, err := newDiff.ToBuf(DiffFormatPatch)
-			checkFatal(t, err)
-
-			raw1 := string(raw1b)
-			raw2 := string(raw2b)
-
-			if raw1 != raw2 {
-				t.Error("diffs should be the same")
-			}
-		})
-	})
-
-	t.Run("check convert to raw buffer and apply", func(t *testing.T) {
-		err = repo.ResetToCommit(addFirstFileCommit, ResetHard, &CheckoutOptions{})
-		checkFatal(t, err)
-
-		raw, err := diff.ToBuf(DiffFormatPatch)
-		checkFatal(t, err)
-
-		if len(raw) == 0 {
-			t.Error("empty diff created")
-		}
-
-		diff2, err := DiffFromBuffer(raw, repo)
-		checkFatal(t, err)
-		defer diff2.Free()
-
-		err = repo.ApplyDiff(diff2, ApplyLocationBoth, nil)
-		checkFatal(t, err)
-	})
-
-	t.Run("check apply callbacks work", func(t *testing.T) {
-		// reset the state and get new default options for test
-		resetAndGetOpts := func(t *testing.T) *ApplyOptions {
-			err = repo.ResetToCommit(addFirstFileCommit, ResetHard, &CheckoutOptions{})
-			checkFatal(t, err)
-
-			opts, err := DefaultApplyOptions()
-			checkFatal(t, err)
-
-			return opts
-		}
-
-		t.Run("Check hunk callback working applies patch", func(t *testing.T) {
-			opts := resetAndGetOpts(t)
-
-			called := false
-			opts.ApplyHunkCallback = func(hunk *DiffHunk) (apply bool, err error) {
-				called = true
-				return true, nil
-			}
-
-			err = repo.ApplyDiff(diff, ApplyLocationBoth, opts)
-			checkFatal(t, err)
-
-			if called == false {
-				t.Error("apply hunk callback was not called")
-			}
-
-			checkSecondFileStaged(t, repo)
-		})
-
-		t.Run("Check delta callback working applies patch", func(t *testing.T) {
-			opts := resetAndGetOpts(t)
-
-			called := false
-			opts.ApplyDeltaCallback = func(hunk *DiffDelta) (apply bool, err error) {
-				if hunk.NewFile.Path != "file2" {
-					t.Error("Unexpected delta in diff application")
-				}
-				called = true
-				return true, nil
-			}
-
-			err = repo.ApplyDiff(diff, ApplyLocationBoth, opts)
-			checkFatal(t, err)
-
-			if called == false {
-				t.Error("apply hunk callback was not called")
-			}
-
-			checkSecondFileStaged(t, repo)
-		})
-
-		t.Run("Check delta callback returning false does not apply patch", func(t *testing.T) {
-			opts := resetAndGetOpts(t)
-
-			called := false
-			opts.ApplyDeltaCallback = func(hunk *DiffDelta) (apply bool, err error) {
-				if hunk.NewFile.Path != "file2" {
-					t.Error("Unexpected hunk in diff application")
-				}
-				called = true
-				return false, nil
-			}
-
-			err = repo.ApplyDiff(diff, ApplyLocationBoth, opts)
-			checkFatal(t, err)
-
-			if called == false {
-				t.Error("apply hunk callback was not called")
-			}
-
-			checkNoFilesStaged(t, repo)
-		})
-
-		t.Run("Check hunk callback returning causes application to fail", func(t *testing.T) {
-			opts := resetAndGetOpts(t)
-
-			called := false
-			opts.ApplyHunkCallback = func(hunk *DiffHunk) (apply bool, err error) {
-				called = true
-				return false, errors.New("something happened")
-			}
-
-			err = repo.ApplyDiff(diff, ApplyLocationBoth, opts)
-			if err == nil {
-				t.Error("expected an error after trying to apply")
-			}
-
-			if called == false {
-				t.Error("apply hunk callback was not called")
-			}
-
-			checkNoFilesStaged(t, repo)
-		})
-
-		t.Run("Check delta callback returning causes application to fail", func(t *testing.T) {
-			opts := resetAndGetOpts(t)
-
-			called := false
-			opts.ApplyDeltaCallback = func(hunk *DiffDelta) (apply bool, err error) {
-				if hunk.NewFile.Path != "file2" {
-					t.Error("Unexpected delta in diff application")
-				}
-				called = true
-				return false, errors.New("something happened")
-			}
-
-			err = repo.ApplyDiff(diff, ApplyLocationBoth, opts)
-			if err == nil {
-				t.Error("expected an error after trying to apply")
-			}
-
-			if called == false {
-				t.Error("apply hunk callback was not called")
-			}
-
-			checkNoFilesStaged(t, repo)
-		})
-	})
-}
-
-func TestApplyToTree(t *testing.T) {
-	repo := createTestRepo(t)
-	defer cleanupTestRepo(t, repo)
-
-	seedTestRepo(t, repo)
-
-	commitA, treeA := addAndGetTree(t, repo, "file", "a")
-	defer commitA.Free()
-	defer treeA.Free()
-	commitB, treeB := addAndGetTree(t, repo, "file", "b")
-	defer commitB.Free()
-	defer treeB.Free()
-	commitC, treeC := addAndGetTree(t, repo, "file", "c")
-	defer commitC.Free()
-	defer treeC.Free()
-
-	diffAB, err := repo.DiffTreeToTree(treeA, treeB, nil)
-	checkFatal(t, err)
-
-	diffAC, err := repo.DiffTreeToTree(treeA, treeC, nil)
-	checkFatal(t, err)
-
-	errMessageDropped := errors.New("message dropped")
-
-	for _, tc := range []struct {
-		name               string
-		tree               *Tree
-		diff               *Diff
-		applyHunkCallback  ApplyHunkCallback
-		applyDeltaCallback ApplyDeltaCallback
-		err                error
-		expectedDiff       *Diff
-	}{
-		{
-			name:         "applying patch produces the same diff",
-			tree:         treeA,
-			diff:         diffAB,
-			expectedDiff: diffAB,
-		},
-		{
-			name: "applying a conflicting patch errors",
-			tree: treeB,
-			diff: diffAC,
-			err: &GitError{
-				Message: "hunk at line 1 did not apply",
-				Code:    ErrorCodeApplyFail,
-				Class:   ErrorClassPatch,
-			},
-		},
-		{
-			name:               "callbacks succeeding apply the diff",
-			tree:               treeA,
-			diff:               diffAB,
-			applyHunkCallback:  func(*DiffHunk) (bool, error) { return true, nil },
-			applyDeltaCallback: func(*DiffDelta) (bool, error) { return true, nil },
-			expectedDiff:       diffAB,
-		},
-		{
-			name:              "hunk callback returning false does not apply",
-			tree:              treeA,
-			diff:              diffAB,
-			applyHunkCallback: func(*DiffHunk) (bool, error) { return false, nil },
-		},
-		{
-			name:              "hunk callback erroring fails the call",
-			tree:              treeA,
-			diff:              diffAB,
-			applyHunkCallback: func(*DiffHunk) (bool, error) { return true, errMessageDropped },
-			err:               errMessageDropped,
-		},
-		{
-			name:               "delta callback returning false does not apply",
-			tree:               treeA,
-			diff:               diffAB,
-			applyDeltaCallback: func(*DiffDelta) (bool, error) { return false, nil },
-		},
-		{
-			name:               "delta callback erroring fails the call",
-			tree:               treeA,
-			diff:               diffAB,
-			applyDeltaCallback: func(*DiffDelta) (bool, error) { return true, errMessageDropped },
-			err:                errMessageDropped,
-		},
-	} {
-		t.Run(tc.name, func(t *testing.T) {
-			opts, err := DefaultApplyOptions()
-			checkFatal(t, err)
-
-			opts.ApplyHunkCallback = tc.applyHunkCallback
-			opts.ApplyDeltaCallback = tc.applyDeltaCallback
-
-			index, err := repo.ApplyToTree(tc.diff, tc.tree, opts)
-			if tc.err != nil {
-				if !reflect.DeepEqual(tc.err, err) {
-					t.Fatalf("expected error %q but got %q", tc.err, err)
-				}
-
-				return
-			}
-			checkFatal(t, err)
-
-			patchedTreeOID, err := index.WriteTreeTo(repo)
-			checkFatal(t, err)
-
-			patchedTree, err := repo.LookupTree(patchedTreeOID)
-			checkFatal(t, err)
-
-			patchedDiff, err := repo.DiffTreeToTree(tc.tree, patchedTree, nil)
-			checkFatal(t, err)
-
-			appliedRaw, err := patchedDiff.ToBuf(DiffFormatPatch)
-			checkFatal(t, err)
-
-			if tc.expectedDiff == nil {
-				if len(appliedRaw) > 0 {
-					t.Fatalf("expected no diff but got: %s", appliedRaw)
-				}
-
-				return
-			}
-
-			expectedDiff, err := tc.expectedDiff.ToBuf(DiffFormatPatch)
-			checkFatal(t, err)
-
-			if string(expectedDiff) != string(appliedRaw) {
-				t.Fatalf("diffs do not match:\nexpected: %s\n\nactual: %s", expectedDiff, appliedRaw)
-			}
-		})
-	}
-}
-
-// checkSecondFileStaged checks that there is a single file called "file2" uncommitted in the repo
-func checkSecondFileStaged(t *testing.T, repo *Repository) {
-	opts := StatusOptions{
-		Show:  StatusShowIndexAndWorkdir,
-		Flags: StatusOptIncludeUntracked,
-	}
-
-	statuses, err := repo.StatusList(&opts)
-	checkFatal(t, err)
-
-	count, err := statuses.EntryCount()
-	checkFatal(t, err)
-
-	if count != 1 {
-		t.Error("diff should affect exactly one file")
-	}
-	if count == 0 {
-		t.Fatal("no statuses, cannot continue test")
-	}
-
-	entry, err := statuses.ByIndex(0)
-	checkFatal(t, err)
-
-	if entry.Status != StatusIndexNew {
-		t.Error("status should be 'new' as file has been added between commits")
-	}
-
-	if entry.HeadToIndex.NewFile.Path != "file2" {
-		t.Error("new file should be 'file2")
-	}
-	return
-}
-
-// checkNoFilesStaged checks that there is a single file called "file2" uncommitted in the repo
-func checkNoFilesStaged(t *testing.T, repo *Repository) {
-	opts := StatusOptions{
-		Show:  StatusShowIndexAndWorkdir,
-		Flags: StatusOptIncludeUntracked,
-	}
-
-	statuses, err := repo.StatusList(&opts)
-	checkFatal(t, err)
-
-	count, err := statuses.EntryCount()
-	checkFatal(t, err)
-
-	if count != 0 {
-		t.Error("files changed unexpectedly")
-	}
-}
-
-// addAndGetTree creates a file and commits it, returning the commit and tree
-func addAndGetTree(t *testing.T, repo *Repository, filename string, content string) (*Commit, *Tree) {
-	headCommit, err := headCommit(repo)
-	checkFatal(t, err)
-	defer headCommit.Free()
-
-	p := repo.Path()
-	p = strings.TrimSuffix(p, ".git")
-	p = strings.TrimSuffix(p, ".git/")
-
-	err = ioutil.WriteFile(path.Join(p, filename), []byte((content)), 0777)
-	checkFatal(t, err)
-
-	index, err := repo.Index()
-	checkFatal(t, err)
-	defer index.Free()
-
-	err = index.AddByPath(filename)
-	checkFatal(t, err)
-
-	newTreeOID, err := index.WriteTreeTo(repo)
-	checkFatal(t, err)
-
-	newTree, err := repo.LookupTree(newTreeOID)
-	checkFatal(t, err)
-	defer newTree.Free()
-
-	commitId, err := repo.CreateCommit("HEAD", signature(), signature(), fmt.Sprintf("add %s", filename), newTree, headCommit)
-	checkFatal(t, err)
-
-	commit, err := repo.LookupCommit(commitId)
-	checkFatal(t, err)
-
-	tree, err := commit.Tree()
-	checkFatal(t, err)
-
-	return commit, tree
-}

errorcode_string.go

@@ -36,26 +36,24 @@ func _() {
 	_ = x[ErrorCodeIterOver - -31]
 	_ = x[ErrorCodeRetry - -32]
 	_ = x[ErrorCodeMismatch - -33]
-	_ = x[ErrorCodeIndexDirty - -34]
-	_ = x[ErrorCodeApplyFail - -35]
 }
 
 const (
-	_ErrorCode_name_0 = "ApplyFailIndexDirtyMismatchRetryIterOverPassthrough"
+	_ErrorCode_name_0 = "MismatchRetryIterOverPassthrough"
 	_ErrorCode_name_1 = "MergeConflictDirectoryUncommittedInvalidEOFPeelAppliedCertificateAuthModifiedLockedConflictInvalidSpecNonFastForwardUnmergedUnbornBranchBareRepoUserBuffsAmbiguousExistsNotFound"
 	_ErrorCode_name_2 = "GenericOK"
 )
 
 var (
-	_ErrorCode_index_0 = [...]uint8{0, 9, 19, 27, 32, 40, 51}
+	_ErrorCode_index_0 = [...]uint8{0, 8, 13, 21, 32}
 	_ErrorCode_index_1 = [...]uint8{0, 13, 22, 33, 40, 43, 47, 54, 65, 69, 77, 83, 91, 102, 116, 124, 136, 144, 148, 153, 162, 168, 176}
 	_ErrorCode_index_2 = [...]uint8{0, 7, 9}
 )
 
 func (i ErrorCode) String() string {
 	switch {
-	case -35 <= i && i <= -30:
+	case -33 <= i && i <= -30:
-		i -= -35
+		i -= -33
 		return _ErrorCode_name_0[_ErrorCode_index_0[i]:_ErrorCode_index_0[i+1]]
 	case -24 <= i && i <= -3:
 		i -= -24

git.go

@@ -18,35 +18,35 @@ import (
 type ErrorClass int
 
 const (
-	ErrorClassNone       ErrorClass = C.GIT_ERROR_NONE
+	ErrorClassNone       ErrorClass = C.GITERR_NONE
-	ErrorClassNoMemory   ErrorClass = C.GIT_ERROR_NOMEMORY
+	ErrorClassNoMemory   ErrorClass = C.GITERR_NOMEMORY
-	ErrorClassOS         ErrorClass = C.GIT_ERROR_OS
+	ErrorClassOS         ErrorClass = C.GITERR_OS
-	ErrorClassInvalid    ErrorClass = C.GIT_ERROR_INVALID
+	ErrorClassInvalid    ErrorClass = C.GITERR_INVALID
-	ErrorClassReference  ErrorClass = C.GIT_ERROR_REFERENCE
+	ErrorClassReference  ErrorClass = C.GITERR_REFERENCE
-	ErrorClassZlib       ErrorClass = C.GIT_ERROR_ZLIB
+	ErrorClassZlib       ErrorClass = C.GITERR_ZLIB
-	ErrorClassRepository ErrorClass = C.GIT_ERROR_REPOSITORY
+	ErrorClassRepository ErrorClass = C.GITERR_REPOSITORY
-	ErrorClassConfig     ErrorClass = C.GIT_ERROR_CONFIG
+	ErrorClassConfig     ErrorClass = C.GITERR_CONFIG
-	ErrorClassRegex      ErrorClass = C.GIT_ERROR_REGEX
+	ErrorClassRegex      ErrorClass = C.GITERR_REGEX
-	ErrorClassOdb        ErrorClass = C.GIT_ERROR_ODB
+	ErrorClassOdb        ErrorClass = C.GITERR_ODB
-	ErrorClassIndex      ErrorClass = C.GIT_ERROR_INDEX
+	ErrorClassIndex      ErrorClass = C.GITERR_INDEX
-	ErrorClassObject     ErrorClass = C.GIT_ERROR_OBJECT
+	ErrorClassObject     ErrorClass = C.GITERR_OBJECT
-	ErrorClassNet        ErrorClass = C.GIT_ERROR_NET
+	ErrorClassNet        ErrorClass = C.GITERR_NET
-	ErrorClassTag        ErrorClass = C.GIT_ERROR_TAG
+	ErrorClassTag        ErrorClass = C.GITERR_TAG
-	ErrorClassTree       ErrorClass = C.GIT_ERROR_TREE
+	ErrorClassTree       ErrorClass = C.GITERR_TREE
-	ErrorClassIndexer    ErrorClass = C.GIT_ERROR_INDEXER
+	ErrorClassIndexer    ErrorClass = C.GITERR_INDEXER
-	ErrorClassSSL        ErrorClass = C.GIT_ERROR_SSL
+	ErrorClassSSL        ErrorClass = C.GITERR_SSL
-	ErrorClassSubmodule  ErrorClass = C.GIT_ERROR_SUBMODULE
+	ErrorClassSubmodule  ErrorClass = C.GITERR_SUBMODULE
-	ErrorClassThread     ErrorClass = C.GIT_ERROR_THREAD
+	ErrorClassThread     ErrorClass = C.GITERR_THREAD
-	ErrorClassStash      ErrorClass = C.GIT_ERROR_STASH
+	ErrorClassStash      ErrorClass = C.GITERR_STASH
-	ErrorClassCheckout   ErrorClass = C.GIT_ERROR_CHECKOUT
+	ErrorClassCheckout   ErrorClass = C.GITERR_CHECKOUT
-	ErrorClassFetchHead  ErrorClass = C.GIT_ERROR_FETCHHEAD
+	ErrorClassFetchHead  ErrorClass = C.GITERR_FETCHHEAD
-	ErrorClassMerge      ErrorClass = C.GIT_ERROR_MERGE
+	ErrorClassMerge      ErrorClass = C.GITERR_MERGE
-	ErrorClassSSH        ErrorClass = C.GIT_ERROR_SSH
+	ErrorClassSSH        ErrorClass = C.GITERR_SSH
-	ErrorClassFilter     ErrorClass = C.GIT_ERROR_FILTER
+	ErrorClassFilter     ErrorClass = C.GITERR_FILTER
-	ErrorClassRevert     ErrorClass = C.GIT_ERROR_REVERT
+	ErrorClassRevert     ErrorClass = C.GITERR_REVERT
-	ErrorClassCallback   ErrorClass = C.GIT_ERROR_CALLBACK
+	ErrorClassCallback   ErrorClass = C.GITERR_CALLBACK
-	ErrorClassRebase     ErrorClass = C.GIT_ERROR_REBASE
+	ErrorClassRebase     ErrorClass = C.GITERR_REBASE
-	ErrorClassPatch      ErrorClass = C.GIT_ERROR_PATCH
+	ErrorClassPatch      ErrorClass = C.GITERR_PATCH
 )
 
 //go:generate stringer -type ErrorCode -trimprefix ErrorCode -tags static
@@ -115,10 +115,6 @@ const (
 	ErrorCodeRetry ErrorCode = C.GIT_RETRY
 	// ErrorCodeMismatch represents a hashsum mismatch in object.
 	ErrorCodeMismatch ErrorCode = C.GIT_EMISMATCH
-	// ErrorCodeIndexDirty represents that unsaved changes in the index would be overwritten.
-	ErrorCodeIndexDirty ErrorCode = C.GIT_EINDEXDIRTY
-	// ErrorCodeApplyFail represents that a patch application failed.
-	ErrorCodeApplyFail ErrorCode = C.GIT_EAPPLYFAIL
 )
 
 var (
@@ -171,7 +167,7 @@ func initLibGit2() {
 }
 
 // Shutdown frees all the resources acquired by libgit2. Make sure no
-// references to any libgit2 go objects are live before calling this.
+// references to any git2go objects are live before calling this.
 // After this is called, invoking any function from this library will result in
 // undefined behavior, so make sure this is called carefully.
 func Shutdown() {
@@ -229,7 +225,7 @@ func NewOid(s string) (*Oid, error) {
 	}
 
 	if len(slice) != 20 {
-		return nil, &GitError{"invalid oid", ErrorClassNone, ErrorCodeGeneric}
+		return nil, &GitError{"Invalid Oid", ErrorClassNone, ErrGeneric}
 	}
 
 	copy(o[:], slice[:20])
@@ -321,7 +317,7 @@ func MakeGitError(c C.int) error {
 	var errClass ErrorClass
 	errorCode := ErrorCode(c)
 	if errorCode != ErrorCodeIterOver {
-		err := C.git_error_last()
+		err := C.giterr_last()
 		if err != nil {
 			errMessage = C.GoString(err.message)
 			errClass = ErrorClass(err.klass)
@@ -372,7 +368,7 @@ func Discover(start string, across_fs bool, ceiling_dirs []string) (string, erro
 	defer C.free(unsafe.Pointer(cstart))
 
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()

go.mod

@@ -0,0 +1,9 @@
+module github.com/libgit2/git2go/v27
+
+go 1.13
+
+require (
+	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
+	golang.org/x/crypto v0.0.0-20201203163018-be400aefbc4c
+	golang.org/x/sys v0.0.0-20201204225414-ed752295db88 // indirect
+)

go.sum

@@ -0,0 +1,13 @@
+github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaUGG7oYTSPP8MxqL4YI3kZKwcP4=
+github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
+golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
+golang.org/x/crypto v0.0.0-20201203163018-be400aefbc4c h1:9HhBz5L/UjnK9XLtiZhYAdue5BVKep3PMmS2LuPDt8k=
+golang.org/x/crypto v0.0.0-20201203163018-be400aefbc4c/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I=
+golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
+golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
+golang.org/x/sys v0.0.0-20191026070338-33540a1f6037/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20201204225414-ed752295db88 h1:KmZPnMocC93w341XZp26yTJg8Za7lhb2KhkYmixoeso=
+golang.org/x/sys v0.0.0-20201204225414-ed752295db88/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/term v0.0.0-20201117132131-f5c789dd3221 h1:/ZHdbVpdR/jk3g30/d4yUL0JU9kksj8+F/bnQUVLGDM=
+golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=
+golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

graph.go

@@ -40,30 +40,3 @@ func (repo *Repository) AheadBehind(local, upstream *Oid) (ahead, behind int, er
 
 	return int(aheadT), int(behindT), nil
 }
-
-// ReachableFromAny returns whether a commit is reachable from any of a list of
-// commits by following parent edges.
-func (repo *Repository) ReachableFromAny(commit *Oid, descendants []*Oid) (bool, error) {
-	if len(descendants) == 0 {
-		return false, nil
-	}
-
-	coids := make([]C.git_oid, len(descendants))
-	for i := 0; i < len(descendants); i++ {
-		coids[i] = *descendants[i].toC()
-	}
-
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_graph_reachable_from_any(repo.ptr, commit.toC(), &coids[0], C.size_t(len(descendants)))
-	runtime.KeepAlive(repo)
-	runtime.KeepAlive(commit)
-	runtime.KeepAlive(coids)
-	runtime.KeepAlive(descendants)
-	if ret < 0 {
-		return false, MakeGitError(ret)
-	}
-
-	return (ret > 0), nil
-}

graph_test.go

@@ -1,75 +0,0 @@
-package git
-
-import (
-	"testing"
-)
-
-func TestReachableFromAny(t *testing.T) {
-	repo, err := OpenRepository("testdata/TestGitRepository.git")
-	checkFatal(t, err)
-	defer repo.Free()
-
-	for name, tc := range map[string]struct {
-		reachable   bool
-		commit      string
-		descendants []string
-	}{
-		"empty": {
-			reachable: false,
-			commit:    "49322bb17d3acc9146f98c97d078513228bbf3c0",
-		},
-		"same": {
-			reachable:   true,
-			commit:      "49322bb17d3acc9146f98c97d078513228bbf3c0",
-			descendants: []string{"49322bb17d3acc9146f98c97d078513228bbf3c0"},
-		},
-		"unreachable": {
-			reachable:   false,
-			commit:      "ac7e7e44c1885efb472ad54a78327d66bfc4ecef",
-			descendants: []string{"58be4659bb571194ed4562d04b359d26216f526e"},
-		},
-		"unreachable-reverse": {
-			reachable:   false,
-			commit:      "58be4659bb571194ed4562d04b359d26216f526e",
-			descendants: []string{"ac7e7e44c1885efb472ad54a78327d66bfc4ecef"},
-		},
-		"root": {
-			reachable: false,
-			commit:    "42e4e7c5e507e113ebbb7801b16b52cf867b7ce1",
-			descendants: []string{
-				"ac7e7e44c1885efb472ad54a78327d66bfc4ecef",
-				"d86a2aada2f5e7ccf6f11880bfb9ab404e8a8864",
-				"f73b95671f326616d66b2afb3bdfcdbbce110b44",
-				"d0114ab8ac326bab30e3a657a0397578c5a1af88",
-			},
-		},
-		"head": {
-			reachable: false,
-			commit:    "49322bb17d3acc9146f98c97d078513228bbf3c0",
-			descendants: []string{
-				"ac7e7e44c1885efb472ad54a78327d66bfc4ecef",
-				"d86a2aada2f5e7ccf6f11880bfb9ab404e8a8864",
-				"f73b95671f326616d66b2afb3bdfcdbbce110b44",
-				"d0114ab8ac326bab30e3a657a0397578c5a1af88",
-			},
-		},
-	} {
-		tc := tc
-		t.Run(name, func(t *testing.T) {
-			commit, err := NewOid(tc.commit)
-			checkFatal(t, err)
-
-			descendants := make([]*Oid, len(tc.descendants))
-			for i, o := range tc.descendants {
-				descendants[i], err = NewOid(o)
-				checkFatal(t, err)
-			}
-			reachable, err := repo.ReachableFromAny(commit, descendants)
-			checkFatal(t, err)
-
-			if reachable != tc.reachable {
-				t.Errorf("ReachableFromAny(%s, %v) = %v, wanted %v", tc.commit, tc.descendants, reachable, tc.reachable)
-			}
-		})
-	}
-}

http.go

@@ -38,17 +38,17 @@ func registerManagedHTTP() error {
 
 func httpSmartSubtransportFactory(remote *Remote, transport *Transport) (SmartSubtransport, error) {
 	var proxyFn func(*http.Request) (*url.URL, error)
-	remoteConnectOpts, err := transport.SmartRemoteConnectOptions()
+	proxyOpts, err := transport.SmartProxyOptions()
 	if err != nil {
 		return nil, err
 	}
-	switch remoteConnectOpts.ProxyOptions.Type {
+	switch proxyOpts.Type {
 	case ProxyTypeNone:
 		proxyFn = nil
 	case ProxyTypeAuto:
 		proxyFn = http.ProxyFromEnvironment
 	case ProxyTypeSpecified:
-		parsedUrl, err := url.Parse(remoteConnectOpts.ProxyOptions.Url)
+		parsedUrl, err := url.Parse(proxyOpts.Url)
 		if err != nil {
 			return nil, err
 		}
@@ -103,7 +103,7 @@ func (t *httpSmartSubtransport) Action(url string, action SmartServiceAction) (S
 		return nil, err
 	}
 
-	req.Header.Set("User-Agent", "git/2.0 (libgit2)")
+	req.Header.Set("User-Agent", "git/2.0 (git2go)")
 
 	stream := newManagedHttpStream(t, req)
 	if req.Method == "POST" {
@@ -203,9 +203,7 @@ func (self *httpSmartSubtransportStream) sendRequest() error {
 			req.ContentLength = -1
 		}
 
-		if userName != "" && password != "" {
+		req.SetBasicAuth(userName, password)
-			req.SetBasicAuth(userName, password)
-		}
 		resp, err = http.DefaultClient.Do(req)
 		if err != nil {
 			return err
@@ -218,11 +216,10 @@ func (self *httpSmartSubtransportStream) sendRequest() error {
 		if resp.StatusCode == http.StatusUnauthorized {
 			resp.Body.Close()
 
-			cred, err := self.owner.transport.SmartCredentials("", CredentialTypeUserpassPlaintext)
+			cred, err := self.owner.transport.SmartCredentials("", CredTypeUserpassPlaintext)
 			if err != nil {
 				return err
 			}
-			defer cred.Free()
 
 			userName, password, err = cred.GetUserpassPlaintext()
 			if err != nil {

index.go

@@ -10,12 +10,13 @@ extern int _go_git_index_remove_all(git_index*, const git_strarray*, void*);
 */
 import "C"
 import (
+	"errors"
 	"fmt"
 	"runtime"
 	"unsafe"
 )
 
-type IndexMatchedPathCallback func(string, string) error
+type IndexMatchedPathCallback func(string, string) int
 type indexMatchedPathCallbackData struct {
 	callback    IndexMatchedPathCallback
 	errorTarget *error
@@ -219,7 +220,7 @@ func (v *Index) AddFromBuffer(entry *IndexEntry, buffer []byte) error {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	if err := C.git_index_add_from_buffer(v.ptr, &centry, cbuffer, C.size_t(len(buffer))); err < 0 {
+	if err := C.git_index_add_frombuffer(v.ptr, &centry, cbuffer, C.size_t(len(buffer))); err < 0 {
 		return MakeGitError(err)
 	}
 
@@ -342,9 +343,9 @@ func indexMatchedPathCallback(cPath, cMatchedPathspec *C.char, payload unsafe.Po
 		panic("invalid matched path callback")
 	}
 
-	err := data.callback(C.GoString(cPath), C.GoString(cMatchedPathspec))
+	ret := data.callback(C.GoString(cPath), C.GoString(cMatchedPathspec))
-	if err != nil {
+	if ret < 0 {
-		*data.errorTarget = err
+		*data.errorTarget = errors.New(ErrorCode(ret).String())
 		return C.int(ErrorCodeUser)
 	}
 

index_test.go

@@ -3,7 +3,6 @@ package git
 import (
 	"io/ioutil"
 	"os"
-	"path"
 	"runtime"
 	"testing"
 )
@@ -60,29 +59,14 @@ func TestIndexWriteTreeTo(t *testing.T) {
 	repo := createTestRepo(t)
 	defer cleanupTestRepo(t, repo)
 
-	idx, err := NewIndex()
+	repo2 := createTestRepo(t)
-	checkFatal(t, err)
+	defer cleanupTestRepo(t, repo2)
 
-	odb, err := repo.Odb()
+	idx, err := repo.Index()
 	checkFatal(t, err)
-
+	err = idx.AddByPath("README")
-	content, err := ioutil.ReadFile(path.Join(repo.Workdir(), "README"))
 	checkFatal(t, err)
-
+	treeId, err := idx.WriteTreeTo(repo2)
-	id, err := odb.Write(content, ObjectBlob)
-	checkFatal(t, err)
-
-	err = idx.Add(&IndexEntry{
-		Mode: FilemodeBlob,
-		Uid:  0,
-		Gid:  0,
-		Size: uint32(len(content)),
-		Id:   id,
-		Path: "README",
-	})
-	checkFatal(t, err)
-
-	treeId, err := idx.WriteTreeTo(repo)
 	checkFatal(t, err)
 
 	if treeId.String() != "b7119b11e8ef7a1a5a34d3ac87f5b075228ac81e" {
@@ -223,9 +207,9 @@ func TestIndexAddAllCallback(t *testing.T) {
 	checkFatal(t, err)
 
 	cbPath := ""
-	err = idx.AddAll([]string{}, IndexAddDefault, func(p, mP string) error {
+	err = idx.AddAll([]string{}, IndexAddDefault, func(p, mP string) int {
 		cbPath = p
-		return nil
+		return 0
 	})
 	checkFatal(t, err)
 	if cbPath != "README" {

indexer_test.go

@@ -33,9 +33,9 @@ func TestIndexerOutOfOrder(t *testing.T) {
 	defer os.RemoveAll(tmpPath)
 
 	var finalStats TransferProgress
-	idx, err := NewIndexer(tmpPath, nil, func(stats TransferProgress) error {
+	idx, err := NewIndexer(tmpPath, nil, func(stats TransferProgress) ErrorCode {
 		finalStats = stats
-		return nil
+		return ErrorCodeOK
 	})
 	checkFatal(t, err)
 	defer idx.Free()

mempack.go

@@ -6,7 +6,7 @@ package git
 
 extern int git_mempack_new(git_odb_backend **out);
 extern int git_mempack_dump(git_buf *pack, git_repository *repo, git_odb_backend *backend);
-extern int git_mempack_reset(git_odb_backend *backend);
+extern void git_mempack_reset(git_odb_backend *backend);
 extern void _go_git_odb_backend_free(git_odb_backend *backend);
 */
 import "C"
@@ -71,7 +71,7 @@ func (mempack *Mempack) Dump(repository *Repository) ([]byte, error) {
 	if ret < 0 {
 		return nil, MakeGitError(ret)
 	}
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	return C.GoBytes(unsafe.Pointer(buf.ptr), C.int(buf.size)), nil
 }
@@ -80,13 +80,6 @@ func (mempack *Mempack) Dump(repository *Repository) ([]byte, error) {
 //
 // This assumes that Mempack.Dump has been called before to store all the
 // queued objects into a single packfile.
-func (mempack *Mempack) Reset() error {
+func (mempack *Mempack) Reset() {
-	runtime.LockOSThread()
+	C.git_mempack_reset(mempack.ptr)
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_mempack_reset(mempack.ptr)
-	if ret < 0 {
-		return MakeGitError(ret)
-	}
-	return nil
 }

merge.go

@@ -138,6 +138,7 @@ const (
 )
 
 type MergeOptions struct {
+	Version   uint
 	TreeFlags MergeTreeFlag
 
 	RenameThreshold uint
@@ -150,6 +151,7 @@ type MergeOptions struct {
 
 func mergeOptionsFromC(opts *C.git_merge_options) MergeOptions {
 	return MergeOptions{
+		Version:         uint(opts.version),
 		TreeFlags:       MergeTreeFlag(opts.flags),
 		RenameThreshold: uint(opts.rename_threshold),
 		TargetLimit:     uint(opts.target_limit),
@@ -164,7 +166,7 @@ func DefaultMergeOptions() (MergeOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_merge_options_init(&opts, C.GIT_MERGE_OPTIONS_VERSION)
+	ecode := C.git_merge_init_options(&opts, C.GIT_MERGE_OPTIONS_VERSION)
 	if ecode < 0 {
 		return MergeOptions{}, MakeGitError(ecode)
 	}
@@ -172,11 +174,11 @@ func DefaultMergeOptions() (MergeOptions, error) {
 }
 
 func populateMergeOptions(copts *C.git_merge_options, opts *MergeOptions) *C.git_merge_options {
-	C.git_merge_options_init(copts, C.GIT_MERGE_OPTIONS_VERSION)
+	C.git_merge_init_options(copts, C.GIT_MERGE_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
-	copts.flags = C.uint32_t(opts.TreeFlags)
+	copts.flags = C.git_merge_flag_t(opts.TreeFlags)
 	copts.rename_threshold = C.uint(opts.RenameThreshold)
 	copts.target_limit = C.uint(opts.TargetLimit)
 	copts.recursion_limit = C.uint(opts.RecursionLimit)
@@ -516,7 +518,7 @@ func mergeFileOptionsFromC(c C.git_merge_file_options) MergeFileOptions {
 }
 
 func populateMergeFileOptions(copts *C.git_merge_file_options, opts *MergeFileOptions) *C.git_merge_file_options {
-	C.git_merge_file_options_init(copts, C.GIT_MERGE_FILE_OPTIONS_VERSION)
+	C.git_merge_file_init_options(copts, C.GIT_MERGE_FILE_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
@@ -525,7 +527,7 @@ func populateMergeFileOptions(copts *C.git_merge_file_options, opts *MergeFileOp
 	copts.our_label = C.CString(opts.OurLabel)
 	copts.their_label = C.CString(opts.TheirLabel)
 	copts.favor = C.git_merge_file_favor_t(opts.Favor)
-	copts.flags = C.uint32_t(opts.Flags)
+	copts.flags = C.git_merge_file_flag_t(opts.Flags)
 	copts.marker_size = C.ushort(opts.MarkerSize)
 	return copts
 }
@@ -565,7 +567,7 @@ func MergeFile(ancestor MergeFileInput, ours MergeFileInput, theirs MergeFileInp
 	var copts *C.git_merge_file_options
 	if options != nil {
 		copts = &C.git_merge_file_options{}
-		ecode := C.git_merge_file_options_init(copts, C.GIT_MERGE_FILE_OPTIONS_VERSION)
+		ecode := C.git_merge_file_init_options(copts, C.GIT_MERGE_FILE_OPTIONS_VERSION)
 		if ecode < 0 {
 			return nil, MakeGitError(ecode)
 		}

note.go

@@ -133,7 +133,7 @@ func (c *NoteCollection) DefaultRef() (string, error) {
 	}
 
 	ret := C.GoString(buf.ptr)
-	C.git_buf_dispose(&buf)
+	C.git_buf_free(&buf)
 
 	return ret, nil
 }

object.go

@@ -13,12 +13,12 @@ import (
 type ObjectType int
 
 const (
-	ObjectAny     ObjectType = C.GIT_OBJECT_ANY
+	ObjectAny    ObjectType = C.GIT_OBJ_ANY
-	ObjectInvalid ObjectType = C.GIT_OBJECT_INVALID
+	ObjectBad    ObjectType = C.GIT_OBJ_BAD
-	ObjectCommit  ObjectType = C.GIT_OBJECT_COMMIT
+	ObjectCommit ObjectType = C.GIT_OBJ_COMMIT
-	ObjectTree    ObjectType = C.GIT_OBJECT_TREE
+	ObjectTree   ObjectType = C.GIT_OBJ_TREE
-	ObjectBlob    ObjectType = C.GIT_OBJECT_BLOB
+	ObjectBlob   ObjectType = C.GIT_OBJ_BLOB
-	ObjectTag     ObjectType = C.GIT_OBJECT_TAG
+	ObjectTag    ObjectType = C.GIT_OBJ_TAG
 )
 
 type Object struct {
@@ -36,8 +36,8 @@ func (t ObjectType) String() string {
 	switch t {
 	case ObjectAny:
 		return "Any"
-	case ObjectInvalid:
+	case ObjectBad:
-		return "Invalid"
+		return "Bad"
 	case ObjectCommit:
 		return "Commit"
 	case ObjectTree:
@@ -68,7 +68,7 @@ func (o *Object) ShortId() (string, error) {
 	if ecode < 0 {
 		return "", MakeGitError(ecode)
 	}
-	defer C.git_buf_dispose(&resultBuf)
+	defer C.git_buf_free(&resultBuf)
 	return C.GoString(resultBuf.ptr), nil
 }
 
@@ -218,7 +218,7 @@ func (o *Object) Peel(t ObjectType) (*Object, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	err := C.git_object_peel(&cobj, o.ptr, C.git_object_t(t))
+	err := C.git_object_peel(&cobj, o.ptr, C.git_otype(t))
 	runtime.KeepAlive(o)
 	if err < 0 {
 		return nil, MakeGitError(err)

odb.go

@@ -118,12 +118,12 @@ func (v *Odb) ReadHeader(oid *Oid) (uint64, ObjectType, error) {
 	defer runtime.UnlockOSThread()
 
 	var sz C.size_t
-	var cotype C.git_object_t
+	var cotype C.git_otype
 
 	ret := C.git_odb_read_header(&sz, &cotype, v.ptr, oid.toC())
 	runtime.KeepAlive(v)
 	if ret < 0 {
-		return 0, ObjectInvalid, MakeGitError(ret)
+		return 0, C.GIT_OBJ_BAD, MakeGitError(ret)
 	}
 
 	return uint64(sz), ObjectType(cotype), nil
@@ -150,7 +150,7 @@ func (v *Odb) Write(data []byte, otype ObjectType) (oid *Oid, err error) {
 		size = C.size_t(0)
 	}
 
-	ret := C.git_odb_write(oid.toC(), v.ptr, unsafe.Pointer(&data[0]), size, C.git_object_t(otype))
+	ret := C.git_odb_write(oid.toC(), v.ptr, unsafe.Pointer(&data[0]), size, C.git_otype(otype))
 	runtime.KeepAlive(v)
 	if ret < 0 {
 		return nil, MakeGitError(ret)
@@ -176,32 +176,6 @@ func (v *Odb) Read(oid *Oid) (obj *OdbObject, err error) {
 	return obj, nil
 }
 
-func (odb *Odb) Refresh() error {
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_odb_refresh(odb.ptr)
-	runtime.KeepAlive(odb)
-	if ret < 0 {
-		return MakeGitError(ret)
-	}
-
-	return nil
-}
-
-func (odb *Odb) WriteMultiPackIndex() error {
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_odb_write_multi_pack_index(odb.ptr)
-	runtime.KeepAlive(odb)
-	if ret < 0 {
-		return MakeGitError(ret)
-	}
-
-	return nil
-}
-
 type OdbForEachCallback func(id *Oid) error
 type odbForEachCallbackData struct {
 	callback    OdbForEachCallback
@@ -263,7 +237,7 @@ func (v *Odb) Hash(data []byte, otype ObjectType) (oid *Oid, err error) {
 		size = C.size_t(0)
 	}
 
-	ret := C.git_odb_hash(oid.toC(), unsafe.Pointer(&data[0]), size, C.git_object_t(otype))
+	ret := C.git_odb_hash(oid.toC(), unsafe.Pointer(&data[0]), size, C.git_otype(otype))
 	runtime.KeepAlive(data)
 	if ret < 0 {
 		return nil, MakeGitError(ret)
@@ -275,7 +249,7 @@ func (v *Odb) Hash(data []byte, otype ObjectType) (oid *Oid, err error) {
 // contents of the object.
 func (v *Odb) NewReadStream(id *Oid) (*OdbReadStream, error) {
 	stream := new(OdbReadStream)
-	var ctype C.git_object_t
+	var ctype C.git_otype
 	var csize C.size_t
 
 	runtime.LockOSThread()
@@ -303,7 +277,7 @@ func (v *Odb) NewWriteStream(size int64, otype ObjectType) (*OdbWriteStream, err
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ret := C.git_odb_open_wstream(&stream.ptr, v.ptr, C.git_object_size_t(size), C.git_object_t(otype))
+	ret := C.git_odb_open_wstream(&stream.ptr, v.ptr, C.git_off_t(size), C.git_otype(otype))
 	runtime.KeepAlive(v)
 	if ret < 0 {
 		return nil, MakeGitError(ret)

odb_test.go

@@ -167,9 +167,9 @@ func TestOdbWritepack(t *testing.T) {
 	checkFatal(t, err)
 
 	var finalStats TransferProgress
-	writepack, err := odb.NewWritePack(func(stats TransferProgress) error {
+	writepack, err := odb.NewWritePack(func(stats TransferProgress) ErrorCode {
 		finalStats = stats
-		return nil
+		return ErrorCodeOK
 	})
 	checkFatal(t, err)
 	defer writepack.Free()

patch.go

@@ -52,7 +52,7 @@ func (patch *Patch) String() (string, error) {
 	if ecode < 0 {
 		return "", MakeGitError(ecode)
 	}
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	return C.GoString(buf.ptr), nil
 }

rebase.go

@@ -2,14 +2,11 @@ package git
 
 /*
 #include <git2.h>
-
-extern void _go_git_populate_rebase_callbacks(git_rebase_options *opts);
 */
 import "C"
 import (
 	"errors"
 	"fmt"
-	"reflect"
 	"runtime"
 	"unsafe"
 )
@@ -72,140 +69,18 @@ func newRebaseOperationFromC(c *C.git_rebase_operation) *RebaseOperation {
 	return operation
 }
 
-//export commitCreateCallback
+// RebaseOptions are used to tell the rebase machinery how to operate
-func commitCreateCallback(
-	errorMessage **C.char,
-	_out *C.git_oid,
-	_author, _committer *C.git_signature,
-	_message_encoding, _message *C.char,
-	_tree *C.git_tree,
-	_parent_count C.size_t,
-	_parents **C.git_commit,
-	handle unsafe.Pointer,
-) C.int {
-	data, ok := pointerHandles.Get(handle).(*rebaseOptionsData)
-	if !ok {
-		panic("invalid sign payload")
-	}
-
-	if data.options.CommitCreateCallback == nil && data.options.CommitSigningCallback == nil {
-		return C.int(ErrorCodePassthrough)
-	}
-
-	messageEncoding := MessageEncodingUTF8
-	if _message_encoding != nil {
-		messageEncoding = MessageEncoding(C.GoString(_message_encoding))
-	}
-	tree := &Tree{
-		Object: Object{
-			ptr:  (*C.git_object)(_tree),
-			repo: data.repo,
-		},
-		cast_ptr: _tree,
-	}
-
-	var goParents []*C.git_commit
-	if _parent_count > 0 {
-		hdr := reflect.SliceHeader{
-			Data: uintptr(unsafe.Pointer(_parents)),
-			Len:  int(_parent_count),
-			Cap:  int(_parent_count),
-		}
-		goParents = *(*[]*C.git_commit)(unsafe.Pointer(&hdr))
-	}
-
-	parents := make([]*Commit, int(_parent_count))
-	for i, p := range goParents {
-		parents[i] = &Commit{
-			Object: Object{
-				ptr:  (*C.git_object)(p),
-				repo: data.repo,
-			},
-			cast_ptr: p,
-		}
-	}
-
-	if data.options.CommitCreateCallback != nil {
-		oid, err := data.options.CommitCreateCallback(
-			newSignatureFromC(_author),
-			newSignatureFromC(_committer),
-			messageEncoding,
-			C.GoString(_message),
-			tree,
-			parents...,
-		)
-		if err != nil {
-			if data.errorTarget != nil {
-				*data.errorTarget = err
-			}
-			return setCallbackError(errorMessage, err)
-		}
-		if oid == nil {
-			return C.int(ErrorCodePassthrough)
-		}
-		*_out = *oid.toC()
-	} else if data.options.CommitSigningCallback != nil {
-		commitContent, err := data.repo.CreateCommitBuffer(
-			newSignatureFromC(_author),
-			newSignatureFromC(_committer),
-			messageEncoding,
-			C.GoString(_message),
-			tree,
-			parents...,
-		)
-		if err != nil {
-			if data.errorTarget != nil {
-				*data.errorTarget = err
-			}
-			return setCallbackError(errorMessage, err)
-		}
-
-		signature, signatureField, err := data.options.CommitSigningCallback(string(commitContent))
-		if err != nil {
-			if data.errorTarget != nil {
-				*data.errorTarget = err
-			}
-			return setCallbackError(errorMessage, err)
-		}
-
-		oid, err := data.repo.CreateCommitWithSignature(string(commitContent), signature, signatureField)
-		if err != nil {
-			if data.errorTarget != nil {
-				*data.errorTarget = err
-			}
-			return setCallbackError(errorMessage, err)
-		}
-		*_out = *oid.toC()
-	}
-
-	return C.int(ErrorCodeOK)
-}
-
-// RebaseOptions are used to tell the rebase machinery how to operate.
 type RebaseOptions struct {
+	Version         uint
 	Quiet           int
 	InMemory        int
 	RewriteNotesRef string
 	MergeOptions    MergeOptions
 	CheckoutOptions CheckoutOptions
-	// CommitCreateCallback is an optional callback that allows users to override
-	// commit creation when rebasing. If specified, users can create
-	// their own commit and provide the commit ID, which may be useful for
-	// signing commits or otherwise customizing the commit creation. If this
-	// callback returns a nil Oid, then the rebase will continue to create the
-	// commit.
-	CommitCreateCallback CommitCreateCallback
-	// Deprecated: CommitSigningCallback is an optional callback that will be
-	// called with the commit content, allowing a signature to be added to the
-	// rebase commit. This field is only used when rebasing.  This callback is
-	// not invoked if a CommitCreateCallback is specified.  CommitCreateCallback
-	// should be used instead of this.
-	CommitSigningCallback CommitSigningCallback
 }
 
 type rebaseOptionsData struct {
 	options     *RebaseOptions
-	repo        *Repository
 	errorTarget *error
 }
 
@@ -216,7 +91,7 @@ func DefaultRebaseOptions() (RebaseOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_rebase_options_init(&opts, C.GIT_REBASE_OPTIONS_VERSION)
+	ecode := C.git_rebase_init_options(&opts, C.GIT_REBASE_OPTIONS_VERSION)
 	if ecode < 0 {
 		return RebaseOptions{}, MakeGitError(ecode)
 	}
@@ -225,6 +100,7 @@ func DefaultRebaseOptions() (RebaseOptions, error) {
 
 func rebaseOptionsFromC(opts *C.git_rebase_options) RebaseOptions {
 	return RebaseOptions{
+		Version:         uint(opts.version),
 		Quiet:           int(opts.quiet),
 		InMemory:        int(opts.inmemory),
 		RewriteNotesRef: C.GoString(opts.rewrite_notes_ref),
@@ -233,8 +109,8 @@ func rebaseOptionsFromC(opts *C.git_rebase_options) RebaseOptions {
 	}
 }
 
-func populateRebaseOptions(copts *C.git_rebase_options, opts *RebaseOptions, repo *Repository, errorTarget *error) *C.git_rebase_options {
+func populateRebaseOptions(copts *C.git_rebase_options, opts *RebaseOptions, errorTarget *error) *C.git_rebase_options {
-	C.git_rebase_options_init(copts, C.GIT_REBASE_OPTIONS_VERSION)
+	C.git_rebase_init_options(copts, C.GIT_REBASE_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
@@ -245,16 +121,6 @@ func populateRebaseOptions(copts *C.git_rebase_options, opts *RebaseOptions, rep
 	populateMergeOptions(&copts.merge_options, &opts.MergeOptions)
 	populateCheckoutOptions(&copts.checkout_options, &opts.CheckoutOptions, errorTarget)
 
-	if opts.CommitCreateCallback != nil || opts.CommitSigningCallback != nil {
-		data := &rebaseOptionsData{
-			options:     opts,
-			repo:        repo,
-			errorTarget: errorTarget,
-		}
-		C._go_git_populate_rebase_callbacks(copts)
-		copts.payload = pointerHandles.Track(data)
-	}
-
 	return copts
 }
 
@@ -265,9 +131,6 @@ func freeRebaseOptions(copts *C.git_rebase_options) {
 	C.free(unsafe.Pointer(copts.rewrite_notes_ref))
 	freeMergeOptions(&copts.merge_options)
 	freeCheckoutOptions(&copts.checkout_options)
-	if copts.payload != nil {
-		pointerHandles.Untrack(copts.payload)
-	}
 }
 
 func mapEmptyStringToNull(ref string) *C.char {
@@ -304,7 +167,7 @@ func (r *Repository) InitRebase(branch *AnnotatedCommit, upstream *AnnotatedComm
 
 	var ptr *C.git_rebase
 	var err error
-	cOpts := populateRebaseOptions(&C.git_rebase_options{}, opts, r, &err)
+	cOpts := populateRebaseOptions(&C.git_rebase_options{}, opts, &err)
 	ret := C.git_rebase_init(&ptr, r.ptr, branch.ptr, upstream.ptr, onto.ptr, cOpts)
 	runtime.KeepAlive(branch)
 	runtime.KeepAlive(upstream)
@@ -328,7 +191,7 @@ func (r *Repository) OpenRebase(opts *RebaseOptions) (*Rebase, error) {
 
 	var ptr *C.git_rebase
 	var err error
-	cOpts := populateRebaseOptions(&C.git_rebase_options{}, opts, r, &err)
+	cOpts := populateRebaseOptions(&C.git_rebase_options{}, opts, &err)
 	ret := C.git_rebase_open(&ptr, r.ptr, cOpts)
 	runtime.KeepAlive(r)
 	if ret == C.int(ErrorCodeUser) && err != nil {
@@ -479,7 +342,7 @@ func (r *Rebase) Free() {
 }
 
 func newRebaseFromC(ptr *C.git_rebase, repo *Repository, opts *C.git_rebase_options) *Rebase {
-	rebase := &Rebase{ptr: ptr, r: repo, options: opts}
+    rebase := &Rebase{ptr: ptr, r: repo, options: opts}
 	runtime.SetFinalizer(rebase, (*Rebase).Free)
 	return rebase
 }

rebase_test.go

@@ -1,15 +1,10 @@
 package git
 
 import (
-	"bytes"
 	"errors"
 	"strconv"
-	"strings"
 	"testing"
 	"time"
-
-	"github.com/ProtonMail/go-crypto/openpgp"
-	"github.com/ProtonMail/go-crypto/openpgp/packet"
 )
 
 // Tests
@@ -19,73 +14,73 @@ func TestRebaseInMemoryWithConflict(t *testing.T) {
 	defer cleanupTestRepo(t, repo)
 	seedTestRepo(t, repo)
 
-	// Create two branches with common history, where both modify "common-file"
+    // Create two branches with common history, where both modify "common-file"
-	// in a conflicting way.
+    // in a conflicting way.
-	_, err := commitSomething(repo, "common-file", "a\nb\nc\n", commitOptions{})
+    _, err := commitSomething(repo, "common-file", "a\nb\nc\n", commitOptions{})
-	checkFatal(t, err)
+    checkFatal(t, err)
 	checkFatal(t, createBranch(repo, "branch-a"))
 	checkFatal(t, createBranch(repo, "branch-b"))
 
 	checkFatal(t, repo.SetHead("refs/heads/branch-a"))
-	_, err = commitSomething(repo, "common-file", "1\nb\nc\n", commitOptions{})
+    _, err = commitSomething(repo, "common-file", "1\nb\nc\n", commitOptions{})
-	checkFatal(t, err)
+    checkFatal(t, err)
 
 	checkFatal(t, repo.SetHead("refs/heads/branch-b"))
-	_, err = commitSomething(repo, "common-file", "x\nb\nc\n", commitOptions{})
+    _, err = commitSomething(repo, "common-file", "x\nb\nc\n", commitOptions{})
-	checkFatal(t, err)
+    checkFatal(t, err)
 
 	branchA, err := repo.LookupBranch("branch-a", BranchLocal)
-	checkFatal(t, err)
+    checkFatal(t, err)
 	onto, err := repo.AnnotatedCommitFromRef(branchA.Reference)
+    checkFatal(t, err)
+
+    // We then rebase "branch-b" onto "branch-a" in-memory, which should result
+    // in a conflict.
+    rebase, err := repo.InitRebase(nil, nil, onto, &RebaseOptions{InMemory: 1})
+    checkFatal(t, err)
+
+    _, err = rebase.Next()
 	checkFatal(t, err)
 
-	// We then rebase "branch-b" onto "branch-a" in-memory, which should result
+    index, err := rebase.InmemoryIndex()
-	// in a conflict.
-	rebase, err := repo.InitRebase(nil, nil, onto, &RebaseOptions{InMemory: 1})
 	checkFatal(t, err)
 
-	_, err = rebase.Next()
+    // We simply resolve the conflict and commit the rebase.
-	checkFatal(t, err)
+    if !index.HasConflicts() {
+        t.Fatal("expected index to have conflicts")
+    }
 
-	index, err := rebase.InmemoryIndex()
+    conflict, err := index.Conflict("common-file")
-	checkFatal(t, err)
+    checkFatal(t, err)
 
-	// We simply resolve the conflict and commit the rebase.
+    resolvedBlobID, err := repo.CreateBlobFromBuffer([]byte("resolved contents"))
-	if !index.HasConflicts() {
+    checkFatal(t, err)
-		t.Fatal("expected index to have conflicts")
-	}
 
-	conflict, err := index.Conflict("common-file")
+    resolvedEntry := *conflict.Our
-	checkFatal(t, err)
+    resolvedEntry.Id = resolvedBlobID
+    checkFatal(t, index.Add(&resolvedEntry))
+    checkFatal(t, index.RemoveConflict("common-file"))
 
-	resolvedBlobID, err := repo.CreateBlobFromBuffer([]byte("resolved contents"))
+    var commitID Oid
-	checkFatal(t, err)
+    checkFatal(t, rebase.Commit(&commitID, signature(), signature(), "rebased message"))
+    checkFatal(t, rebase.Finish())
 
-	resolvedEntry := *conflict.Our
+    // And then assert that we can look up the new merge commit, and that the
-	resolvedEntry.Id = resolvedBlobID
+    // "common-file" has the expected contents.
-	checkFatal(t, index.Add(&resolvedEntry))
+    commit, err := repo.LookupCommit(&commitID)
-	checkFatal(t, index.RemoveConflict("common-file"))
+    checkFatal(t, err)
+    if commit.Message() != "rebased message" {
+        t.Fatalf("unexpected commit message %q", commit.Message())
+    }
 
-	var commitID Oid
+    tree, err := commit.Tree()
-	checkFatal(t, rebase.Commit(&commitID, signature(), signature(), "rebased message"))
+    checkFatal(t, err)
-	checkFatal(t, rebase.Finish())
 
-	// And then assert that we can look up the new merge commit, and that the
+    blob, err := repo.LookupBlob(tree.EntryByName("common-file").Id)
-	// "common-file" has the expected contents.
+    checkFatal(t, err)
-	commit, err := repo.LookupCommit(&commitID)
+    if string(blob.Contents()) != "resolved contents" {
-	checkFatal(t, err)
+        t.Fatalf("unexpected resolved blob contents %q", string(blob.Contents()))
-	if commit.Message() != "rebased message" {
+    }
-		t.Fatalf("unexpected commit message %q", commit.Message())
-	}
-
-	tree, err := commit.Tree()
-	checkFatal(t, err)
-
-	blob, err := repo.LookupBlob(tree.EntryByName("common-file").Id)
-	checkFatal(t, err)
-	if string(blob.Contents()) != "resolved contents" {
-		t.Fatalf("unexpected resolved blob contents %q", string(blob.Contents()))
-	}
 }
 
 func TestRebaseAbort(t *testing.T) {
@@ -211,123 +206,6 @@ func TestRebaseNoConflicts(t *testing.T) {
 	assertStringList(t, expectedHistory, actualHistory)
 }
 
-func TestRebaseGpgSigned(t *testing.T) {
-	// TEST DATA
-
-	entity, err := openpgp.NewEntity("Namey mcnameface", "test comment", "test@example.com", nil)
-	checkFatal(t, err)
-
-	rebaseOpts, err := DefaultRebaseOptions()
-	checkFatal(t, err)
-
-	signCommitContent := func(commitContent string) (string, string, error) {
-		cipherText := new(bytes.Buffer)
-		err := openpgp.ArmoredDetachSignText(cipherText, entity, strings.NewReader(commitContent), &packet.Config{})
-		if err != nil {
-			return "", "", errors.New("error signing payload")
-		}
-
-		return cipherText.String(), "", nil
-	}
-	rebaseOpts.CommitSigningCallback = signCommitContent
-
-	commitOpts := commitOptions{
-		CommitSigningCallback: signCommitContent,
-	}
-
-	// Inputs
-	branchName := "emile"
-	masterCommit := "something"
-	emileCommits := []string{
-		"fou",
-		"barre",
-		"ouich",
-	}
-
-	// Outputs
-	expectedHistory := []string{
-		"Test rebase, Baby! " + emileCommits[2],
-		"Test rebase, Baby! " + emileCommits[1],
-		"Test rebase, Baby! " + emileCommits[0],
-		"Test rebase, Baby! " + masterCommit,
-		"This is a commit\n",
-	}
-
-	// TEST
-	repo := createTestRepo(t)
-	defer cleanupTestRepo(t, repo)
-	seedTestRepoOpt(t, repo, commitOpts)
-
-	// Try to open existing rebase
-	_, err = repo.OpenRebase(nil)
-	if err == nil {
-		t.Fatal("Did not expect to find a rebase in progress")
-	}
-
-	// Setup a repo with 2 branches and a different tree
-	err = setupRepoForRebase(repo, masterCommit, branchName, commitOpts)
-	checkFatal(t, err)
-
-	// Create several commits in emile
-	for _, commit := range emileCommits {
-		_, err = commitSomething(repo, commit, commit, commitOpts)
-		checkFatal(t, err)
-	}
-
-	// Rebase onto master
-	rebase, err := performRebaseOnto(repo, "master", &rebaseOpts)
-	checkFatal(t, err)
-	defer rebase.Free()
-
-	// Finish the rebase properly
-	err = rebase.Finish()
-	checkFatal(t, err)
-
-	// Check history is in correct order
-	actualHistory, err := commitMsgsList(repo)
-	checkFatal(t, err)
-	assertStringList(t, expectedHistory, actualHistory)
-
-	checkAllCommitsSigned(t, entity, repo)
-}
-
-func checkAllCommitsSigned(t *testing.T, entity *openpgp.Entity, repo *Repository) {
-	head, err := headCommit(repo)
-	checkFatal(t, err)
-	defer head.Free()
-
-	parent := head
-
-	err = checkCommitSigned(t, entity, parent)
-	checkFatal(t, err)
-
-	for parent.ParentCount() != 0 {
-		parent = parent.Parent(0)
-		defer parent.Free()
-
-		err = checkCommitSigned(t, entity, parent)
-		checkFatal(t, err)
-	}
-}
-
-func checkCommitSigned(t *testing.T, entity *openpgp.Entity, commit *Commit) error {
-	t.Helper()
-
-	signature, signedData, err := commit.ExtractSignature()
-	if err != nil {
-		t.Logf("No signature on commit\n%s", commit.ContentToSign())
-		return err
-	}
-
-	_, err = openpgp.CheckArmoredDetachedSignature(openpgp.EntityList{entity}, strings.NewReader(signedData), bytes.NewBufferString(signature), nil)
-	if err != nil {
-		t.Logf("Commit is not signed correctly\n%s", commit.ContentToSign())
-		return err
-	}
-
-	return nil
-}
-
 // Utils
 func setupRepoForRebase(repo *Repository, masterCommit, branchName string, commitOpts commitOptions) error {
 	// Create a new branch from master

reference.go

@@ -286,7 +286,7 @@ func (v *Reference) Peel(t ObjectType) (*Object, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	err := C.git_reference_peel(&cobj, v.ptr, C.git_object_t(t))
+	err := C.git_reference_peel(&cobj, v.ptr, C.git_otype(t))
 	runtime.KeepAlive(v)
 	if err < 0 {
 		return nil, MakeGitError(err)
@@ -476,7 +476,7 @@ func (v *ReferenceIterator) Free() {
 	C.git_reference_iterator_free(v.ptr)
 }
 
-// ReferenceNameIsValid returns whether the reference name is well-formed.
+// ReferenceIsValidName returns whether the reference name is well-formed.
 //
 // Valid reference names must follow one of two patterns:
 //
@@ -486,19 +486,11 @@ func (v *ReferenceIterator) Free() {
 // 2. Names prefixed with "refs/" can be almost anything. You must avoid
 // the characters '~', '^', ':', ' \ ', '?', '[', and '*', and the sequences
 // ".." and " @ {" which have special meaning to revparse.
-func ReferenceNameIsValid(name string) (bool, error) {
+func ReferenceIsValidName(name string) bool {
 	cname := C.CString(name)
 	defer C.free(unsafe.Pointer(cname))
 
-	runtime.LockOSThread()
+	return C.git_reference_is_valid_name(cname) == 1
-	defer runtime.UnlockOSThread()
-
-	var valid C.int
-	ret := C.git_reference_name_is_valid(&valid, cname)
-	if ret < 0 {
-		return false, MakeGitError(ret)
-	}
-	return valid == 1, nil
 }
 
 const (
@@ -509,10 +501,10 @@ const (
 type ReferenceFormat uint
 
 const (
-	ReferenceFormatNormal           ReferenceFormat = C.GIT_REFERENCE_FORMAT_NORMAL
+	ReferenceFormatNormal           ReferenceFormat = C.GIT_REF_FORMAT_NORMAL
-	ReferenceFormatAllowOnelevel    ReferenceFormat = C.GIT_REFERENCE_FORMAT_ALLOW_ONELEVEL
+	ReferenceFormatAllowOnelevel    ReferenceFormat = C.GIT_REF_FORMAT_ALLOW_ONELEVEL
-	ReferenceFormatRefspecPattern   ReferenceFormat = C.GIT_REFERENCE_FORMAT_REFSPEC_PATTERN
+	ReferenceFormatRefspecPattern   ReferenceFormat = C.GIT_REF_FORMAT_REFSPEC_PATTERN
-	ReferenceFormatRefspecShorthand ReferenceFormat = C.GIT_REFERENCE_FORMAT_REFSPEC_SHORTHAND
+	ReferenceFormatRefspecShorthand ReferenceFormat = C.GIT_REF_FORMAT_REFSPEC_SHORTHAND
 )
 
 // ReferenceNormalizeName normalizes the reference name and checks validity.

reference_test.go

@@ -214,16 +214,12 @@ func TestIsNote(t *testing.T) {
 	}
 }
 
-func TestReferenceNameIsValid(t *testing.T) {
+func TestReferenceIsValidName(t *testing.T) {
 	t.Parallel()
-	valid, err := ReferenceNameIsValid("HEAD")
+	if !ReferenceIsValidName("HEAD") {
-	checkFatal(t, err)
-	if !valid {
 		t.Errorf("HEAD should be a valid reference name")
 	}
-	valid, err = ReferenceNameIsValid("HEAD1")
+	if ReferenceIsValidName("HEAD1") {
-	checkFatal(t, err)
-	if valid {
 		t.Errorf("HEAD1 should not be a valid reference name")
 	}
 }

refspec.go

@@ -1,149 +0,0 @@
-package git
-
-/*
-#include <git2.h>
-*/
-import "C"
-import (
-	"runtime"
-	"unsafe"
-)
-
-type Refspec struct {
-	doNotCompare
-	ptr *C.git_refspec
-}
-
-// ParseRefspec parses a given refspec string
-func ParseRefspec(input string, isFetch bool) (*Refspec, error) {
-	var ptr *C.git_refspec
-
-	cinput := C.CString(input)
-	defer C.free(unsafe.Pointer(cinput))
-
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_refspec_parse(&ptr, cinput, cbool(isFetch))
-	if ret < 0 {
-		return nil, MakeGitError(ret)
-	}
-
-	spec := &Refspec{ptr: ptr}
-	runtime.SetFinalizer(spec, (*Refspec).Free)
-	return spec, nil
-}
-
-// Free releases a refspec object which has been created by ParseRefspec
-func (s *Refspec) Free() {
-	runtime.SetFinalizer(s, nil)
-	C.git_refspec_free(s.ptr)
-}
-
-// Direction returns the refspec's direction
-func (s *Refspec) Direction() ConnectDirection {
-	direction := C.git_refspec_direction(s.ptr)
-	return ConnectDirection(direction)
-}
-
-// Src returns the refspec's source specifier
-func (s *Refspec) Src() string {
-	var ret string
-	cstr := C.git_refspec_src(s.ptr)
-
-	if cstr != nil {
-		ret = C.GoString(cstr)
-	}
-
-	runtime.KeepAlive(s)
-	return ret
-}
-
-// Dst returns the refspec's destination specifier
-func (s *Refspec) Dst() string {
-	var ret string
-	cstr := C.git_refspec_dst(s.ptr)
-
-	if cstr != nil {
-		ret = C.GoString(cstr)
-	}
-
-	runtime.KeepAlive(s)
-	return ret
-}
-
-// Force returns the refspec's force-update setting
-func (s *Refspec) Force() bool {
-	force := C.git_refspec_force(s.ptr)
-	return force != 0
-}
-
-// String returns the refspec's string representation
-func (s *Refspec) String() string {
-	var ret string
-	cstr := C.git_refspec_string(s.ptr)
-
-	if cstr != nil {
-		ret = C.GoString(cstr)
-	}
-
-	runtime.KeepAlive(s)
-	return ret
-}
-
-// SrcMatches checks if a refspec's source descriptor matches a reference
-func (s *Refspec) SrcMatches(refname string) bool {
-	cname := C.CString(refname)
-	defer C.free(unsafe.Pointer(cname))
-
-	matches := C.git_refspec_src_matches(s.ptr, cname)
-	return matches != 0
-}
-
-// SrcMatches checks if a refspec's destination descriptor matches a reference
-func (s *Refspec) DstMatches(refname string) bool {
-	cname := C.CString(refname)
-	defer C.free(unsafe.Pointer(cname))
-
-	matches := C.git_refspec_dst_matches(s.ptr, cname)
-	return matches != 0
-}
-
-// Transform a reference to its target following the refspec's rules
-func (s *Refspec) Transform(refname string) (string, error) {
-	buf := C.git_buf{}
-
-	cname := C.CString(refname)
-	defer C.free(unsafe.Pointer(cname))
-
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_refspec_transform(&buf, s.ptr, cname)
-	if ret < 0 {
-		return "", MakeGitError(ret)
-	}
-	defer C.git_buf_dispose(&buf)
-
-	return C.GoString(buf.ptr), nil
-}
-
-// Rtransform converts a target reference to its source reference following the
-// refspec's rules
-func (s *Refspec) Rtransform(refname string) (string, error) {
-	buf := C.git_buf{}
-
-	cname := C.CString(refname)
-	defer C.free(unsafe.Pointer(cname))
-
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_refspec_rtransform(&buf, s.ptr, cname)
-	if ret < 0 {
-		return "", MakeGitError(ret)
-	}
-	defer C.git_buf_dispose(&buf)
-
-	return C.GoString(buf.ptr), nil
-}

refspec_test.go

@@ -1,75 +0,0 @@
-package git
-
-import (
-	"testing"
-)
-
-func TestRefspec(t *testing.T) {
-	t.Parallel()
-
-	const (
-		input      = "+refs/heads/*:refs/remotes/origin/*"
-		mainLocal  = "refs/heads/main"
-		mainRemote = "refs/remotes/origin/main"
-	)
-
-	refspec, err := ParseRefspec(input, true)
-	checkFatal(t, err)
-
-	// Accessors
-
-	s := refspec.String()
-	if s != input {
-		t.Errorf("expected string %q, got %q", input, s)
-	}
-
-	if d := refspec.Direction(); d != ConnectDirectionFetch {
-		t.Errorf("expected fetch refspec, got direction %v", d)
-	}
-
-	if pat, expected := refspec.Src(), "refs/heads/*"; pat != expected {
-		t.Errorf("expected refspec src %q, got %q", expected, pat)
-	}
-
-	if pat, expected := refspec.Dst(), "refs/remotes/origin/*"; pat != expected {
-		t.Errorf("expected refspec dst %q, got %q", expected, pat)
-	}
-
-	if !refspec.Force() {
-		t.Error("expected refspec force flag")
-	}
-
-	// SrcMatches
-
-	if !refspec.SrcMatches(mainLocal) {
-		t.Errorf("refspec source did not match %q", mainLocal)
-	}
-
-	if refspec.SrcMatches("refs/tags/v1.0") {
-		t.Error("refspec source matched under refs/tags")
-	}
-
-	// DstMatches
-
-	if !refspec.DstMatches(mainRemote) {
-		t.Errorf("refspec destination did not match %q", mainRemote)
-	}
-
-	if refspec.DstMatches("refs/tags/v1.0") {
-		t.Error("refspec destination matched under refs/tags")
-	}
-
-	// Transforms
-
-	fromLocal, err := refspec.Transform(mainLocal)
-	checkFatal(t, err)
-	if fromLocal != mainRemote {
-		t.Errorf("transform by refspec returned %s; expected %s", fromLocal, mainRemote)
-	}
-
-	fromRemote, err := refspec.Rtransform(mainRemote)
-	checkFatal(t, err)
-	if fromRemote != mainLocal {
-		t.Errorf("rtransform by refspec returned %s; expected %s", fromRemote, mainLocal)
-	}
-}

remote.go

@@ -4,7 +4,6 @@ package git
 #include <string.h>
 
 #include <git2.h>
-#include <git2/sys/cred.h>
 
 extern void _go_git_populate_remote_callbacks(git_remote_callbacks *callbacks);
 */
@@ -12,7 +11,6 @@ import "C"
 import (
 	"crypto/x509"
 	"errors"
-	"fmt"
 	"reflect"
 	"runtime"
 	"strings"
@@ -22,23 +20,6 @@ import (
 	"golang.org/x/crypto/ssh"
 )
 
-// RemoteCreateOptionsFlag is Remote creation options flags
-type RemoteCreateOptionsFlag uint
-
-const (
-	// Ignore the repository apply.insteadOf configuration
-	RemoteCreateSkipInsteadof RemoteCreateOptionsFlag = C.GIT_REMOTE_CREATE_SKIP_INSTEADOF
-	// Don't build a fetchspec from the name if none is set
-	RemoteCreateSkipDefaultFetchspec RemoteCreateOptionsFlag = C.GIT_REMOTE_CREATE_SKIP_DEFAULT_FETCHSPEC
-)
-
-// RemoteCreateOptions contains options for creating a remote
-type RemoteCreateOptions struct {
-	Name      string
-	FetchSpec string
-	Flags     RemoteCreateOptionsFlag
-}
-
 type TransferProgress struct {
 	TotalObjects    uint
 	IndexedObjects  uint
@@ -70,15 +51,15 @@ const (
 	ConnectDirectionPush  ConnectDirection = C.GIT_DIRECTION_PUSH
 )
 
-type TransportMessageCallback func(str string) error
+type TransportMessageCallback func(str string) ErrorCode
-type CompletionCallback func(RemoteCompletion) error
+type CompletionCallback func(RemoteCompletion) ErrorCode
-type CredentialsCallback func(url string, username_from_url string, allowed_types CredentialType) (*Credential, error)
+type CredentialsCallback func(url string, username_from_url string, allowed_types CredType) (ErrorCode, *Cred)
-type TransferProgressCallback func(stats TransferProgress) error
+type TransferProgressCallback func(stats TransferProgress) ErrorCode
-type UpdateTipsCallback func(refname string, a *Oid, b *Oid) error
+type UpdateTipsCallback func(refname string, a *Oid, b *Oid) ErrorCode
-type CertificateCheckCallback func(cert *Certificate, valid bool, hostname string) error
+type CertificateCheckCallback func(cert *Certificate, valid bool, hostname string) ErrorCode
-type PackbuilderProgressCallback func(stage int32, current, total uint32) error
+type PackbuilderProgressCallback func(stage int32, current, total uint32) ErrorCode
-type PushTransferProgressCallback func(current, total uint32, bytes uint) error
+type PushTransferProgressCallback func(current, total uint32, bytes uint) ErrorCode
-type PushUpdateReferenceCallback func(refname, status string) error
+type PushUpdateReferenceCallback func(refname, status string) ErrorCode
 
 type RemoteCallbacks struct {
 	SidebandProgressCallback TransportMessageCallback
@@ -147,17 +128,6 @@ type FetchOptions struct {
 	ProxyOptions ProxyOptions
 }
 
-type RemoteConnectOptions struct {
-	// Proxy options to use for this fetch operation
-	ProxyOptions ProxyOptions
-}
-
-func remoteConnectOptionsFromC(copts *C.git_remote_connect_options) *RemoteConnectOptions {
-	return &RemoteConnectOptions{
-		ProxyOptions: proxyOptionsFromC(&copts.proxy_opts),
-	}
-}
-
 type ProxyType uint
 
 const (
@@ -182,8 +152,8 @@ type ProxyOptions struct {
 	Url string
 }
 
-func proxyOptionsFromC(copts *C.git_proxy_options) ProxyOptions {
+func proxyOptionsFromC(copts *C.git_proxy_options) *ProxyOptions {
-	return ProxyOptions{
+	return &ProxyOptions{
 		Type: ProxyType(copts._type),
 		Url:  C.GoString(copts.url),
 	}
@@ -194,9 +164,6 @@ type Remote struct {
 	ptr       *C.git_remote
 	callbacks RemoteCallbacks
 	repo      *Repository
-	// weak indicates that a remote is a weak pointer and should not be
-	// freed.
-	weak bool
 }
 
 type remotePointerList struct {
@@ -267,7 +234,7 @@ const (
 // Certificate represents the two possible certificates which libgit2
 // knows it might find. If Kind is CertficateX509 then the X509 field
 // will be filled. If Kind is CertificateHostkey then the Hostkey
-// field will be filled.
+// field will be fille.d
 type Certificate struct {
 	Kind    CertificateKind
 	X509    *x509.Certificate
@@ -280,8 +247,8 @@ type HostkeyKind uint
 const (
 	HostkeyMD5    HostkeyKind = C.GIT_CERT_SSH_MD5
 	HostkeySHA1   HostkeyKind = C.GIT_CERT_SSH_SHA1
-	HostkeySHA256 HostkeyKind = C.GIT_CERT_SSH_SHA256
+	HostkeySHA256 HostkeyKind = 1 << 2
-	HostkeyRaw    HostkeyKind = C.GIT_CERT_SSH_RAW
+	HostkeyRaw    HostkeyKind = 1 << 3
 )
 
 // Server host key information. A bitmask containing the available fields.
@@ -347,8 +314,10 @@ func sidebandProgressCallback(errorMessage **C.char, _str *C.char, _len C.int, h
 	if data.callbacks.SidebandProgressCallback == nil {
 		return C.int(ErrorCodeOK)
 	}
-	err := data.callbacks.SidebandProgressCallback(C.GoStringN(_str, _len))
+	str := C.GoStringN(_str, _len)
-	if err != nil {
+	ret := data.callbacks.SidebandProgressCallback(str)
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -358,13 +327,14 @@ func sidebandProgressCallback(errorMessage **C.char, _str *C.char, _len C.int, h
 }
 
 //export completionCallback
-func completionCallback(errorMessage **C.char, completionType C.git_remote_completion_type, handle unsafe.Pointer) C.int {
+func completionCallback(errorMessage **C.char, completion_type C.git_remote_completion_type, handle unsafe.Pointer) C.int {
 	data := pointerHandles.Get(handle).(*remoteCallbacksData)
 	if data.callbacks.CompletionCallback == nil {
 		return C.int(ErrorCodeOK)
 	}
-	err := data.callbacks.CompletionCallback(RemoteCompletion(completionType))
+	ret := data.callbacks.CompletionCallback(RemoteCompletion(completion_type))
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -376,7 +346,7 @@ func completionCallback(errorMessage **C.char, completionType C.git_remote_compl
 //export credentialsCallback
 func credentialsCallback(
 	errorMessage **C.char,
-	_cred **C.git_credential,
+	_cred **C.git_cred,
 	_url *C.char,
 	_username_from_url *C.char,
 	allowed_types uint,
@@ -388,8 +358,9 @@ func credentialsCallback(
 	}
 	url := C.GoString(_url)
 	username_from_url := C.GoString(_username_from_url)
-	cred, err := data.callbacks.CredentialsCallback(url, username_from_url, (CredentialType)(allowed_types))
+	ret, cred := data.callbacks.CredentialsCallback(url, username_from_url, (CredType)(allowed_types))
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -411,8 +382,9 @@ func transferProgressCallback(errorMessage **C.char, stats *C.git_transfer_progr
 	if data.callbacks.TransferProgressCallback == nil {
 		return C.int(ErrorCodeOK)
 	}
-	err := data.callbacks.TransferProgressCallback(newTransferProgressFromC(stats))
+	ret := data.callbacks.TransferProgressCallback(newTransferProgressFromC(stats))
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -436,8 +408,9 @@ func updateTipsCallback(
 	refname := C.GoString(_refname)
 	a := newOidFromC(_a)
 	b := newOidFromC(_b)
-	err := data.callbacks.UpdateTipsCallback(refname, a, b)
+	ret := data.callbacks.UpdateTipsCallback(refname, a, b)
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -493,18 +466,6 @@ func certificateCheckCallback(
 		cert.Hostkey.Kind = HostkeyKind(ccert._type)
 		C.memcpy(unsafe.Pointer(&cert.Hostkey.HashMD5[0]), unsafe.Pointer(&ccert.hash_md5[0]), C.size_t(len(cert.Hostkey.HashMD5)))
 		C.memcpy(unsafe.Pointer(&cert.Hostkey.HashSHA1[0]), unsafe.Pointer(&ccert.hash_sha1[0]), C.size_t(len(cert.Hostkey.HashSHA1)))
-		C.memcpy(unsafe.Pointer(&cert.Hostkey.HashSHA256[0]), unsafe.Pointer(&ccert.hash_sha256[0]), C.size_t(len(cert.Hostkey.HashSHA256)))
-		if (cert.Hostkey.Kind & HostkeyRaw) == HostkeyRaw {
-			cert.Hostkey.Hostkey = C.GoBytes(unsafe.Pointer(ccert.hostkey), C.int(ccert.hostkey_len))
-			var err error
-			cert.Hostkey.SSHPublicKey, err = ssh.ParsePublicKey(cert.Hostkey.Hostkey)
-			if err != nil {
-				if data.errorTarget != nil {
-					*data.errorTarget = err
-				}
-				return setCallbackError(errorMessage, err)
-			}
-		}
 	} else {
 		err := errors.New("unsupported certificate type")
 		if data.errorTarget != nil {
@@ -513,8 +474,9 @@ func certificateCheckCallback(
 		return setCallbackError(errorMessage, err)
 	}
 
-	err := data.callbacks.CertificateCheckCallback(&cert, valid, host)
+	ret := data.callbacks.CertificateCheckCallback(&cert, valid, host)
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -530,8 +492,9 @@ func packProgressCallback(errorMessage **C.char, stage C.int, current, total C.u
 		return C.int(ErrorCodeOK)
 	}
 
-	err := data.callbacks.PackProgressCallback(int32(stage), uint32(current), uint32(total))
+	ret := data.callbacks.PackProgressCallback(int32(stage), uint32(current), uint32(total))
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -547,8 +510,9 @@ func pushTransferProgressCallback(errorMessage **C.char, current, total C.uint,
 		return C.int(ErrorCodeOK)
 	}
 
-	err := data.callbacks.PushTransferProgressCallback(uint32(current), uint32(total), uint(bytes))
+	ret := data.callbacks.PushTransferProgressCallback(uint32(current), uint32(total), uint(bytes))
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -564,8 +528,9 @@ func pushUpdateReferenceCallback(errorMessage **C.char, refname, status *C.char,
 		return C.int(ErrorCodeOK)
 	}
 
-	err := data.callbacks.PushUpdateReferenceCallback(C.GoString(refname), C.GoString(status))
+	ret := data.callbacks.PushUpdateReferenceCallback(C.GoString(refname), C.GoString(status))
-	if err != nil {
+	if ret < 0 {
+		err := errors.New(ErrorCode(ret).String())
 		if data.errorTarget != nil {
 			*data.errorTarget = err
 		}
@@ -575,7 +540,7 @@ func pushUpdateReferenceCallback(errorMessage **C.char, refname, status *C.char,
 }
 
 func populateProxyOptions(copts *C.git_proxy_options, opts *ProxyOptions) *C.git_proxy_options {
-	C.git_proxy_options_init(copts, C.GIT_PROXY_OPTIONS_VERSION)
+	C.git_proxy_init_options(copts, C.GIT_PROXY_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
@@ -593,20 +558,12 @@ func freeProxyOptions(copts *C.git_proxy_options) {
 	C.free(unsafe.Pointer(copts.url))
 }
 
-// RemoteNameIsValid returns whether the remote name is well-formed.
+// RemoteIsValidName returns whether the remote name is well-formed.
-func RemoteNameIsValid(name string) (bool, error) {
+func RemoteIsValidName(name string) bool {
 	cname := C.CString(name)
 	defer C.free(unsafe.Pointer(cname))
 
-	runtime.LockOSThread()
+	return C.git_remote_is_valid_name(cname) == 1
-	defer runtime.UnlockOSThread()
-
-	var valid C.int
-	ret := C.git_remote_name_is_valid(&valid, cname)
-	if ret < 0 {
-		return false, MakeGitError(ret)
-	}
-	return valid == 1, nil
 }
 
 // free releases the resources of the Remote.
@@ -620,9 +577,6 @@ func (r *Remote) free() {
 // Free releases the resources of the Remote.
 func (r *Remote) Free() {
 	r.repo.Remotes.untrackRemote(r)
-	if r.weak {
-		return
-	}
 	r.free()
 }
 
@@ -661,7 +615,7 @@ func (c *RemoteCollection) List() ([]string, error) {
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)
 	}
-	defer C.git_strarray_dispose(&r)
+	defer C.git_strarray_free(&r)
 
 	remotes := makeStringsFromCStrings(r.strings, int(r.count))
 	return remotes, nil
@@ -686,28 +640,6 @@ func (c *RemoteCollection) Create(name string, url string) (*Remote, error) {
 	return remote, nil
 }
 
-// CreateWithOptions Creates a repository object with extended options.
-func (c *RemoteCollection) CreateWithOptions(url string, option *RemoteCreateOptions) (*Remote, error) {
-	remote := &Remote{repo: c.repo}
-
-	curl := C.CString(url)
-	defer C.free(unsafe.Pointer(curl))
-
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	copts := populateRemoteCreateOptions(&C.git_remote_create_options{}, option, c.repo)
-	defer freeRemoteCreateOptions(copts)
-
-	ret := C.git_remote_create_with_opts(&remote.ptr, curl, copts)
-	runtime.KeepAlive(c.repo)
-	if ret < 0 {
-		return nil, MakeGitError(ret)
-	}
-	c.trackRemote(remote)
-	return remote, nil
-}
-
 func (c *RemoteCollection) Delete(name string) error {
 	cname := C.CString(name)
 	defer C.free(unsafe.Pointer(cname))
@@ -931,7 +863,7 @@ func (o *Remote) FetchRefspecs() ([]string, error) {
 	if ret < 0 {
 		return nil, MakeGitError(ret)
 	}
-	defer C.git_strarray_dispose(&crefspecs)
+	defer C.git_strarray_free(&crefspecs)
 
 	refspecs := makeStringsFromCStrings(crefspecs.strings, int(crefspecs.count))
 	return refspecs, nil
@@ -964,7 +896,7 @@ func (o *Remote) PushRefspecs() ([]string, error) {
 	if ret < 0 {
 		return nil, MakeGitError(ret)
 	}
-	defer C.git_strarray_dispose(&crefspecs)
+	defer C.git_strarray_free(&crefspecs)
 	runtime.KeepAlive(o)
 
 	refspecs := makeStringsFromCStrings(crefspecs.strings, int(crefspecs.count))
@@ -978,15 +910,13 @@ func (o *Remote) RefspecCount() uint {
 }
 
 func populateFetchOptions(copts *C.git_fetch_options, opts *FetchOptions, errorTarget *error) *C.git_fetch_options {
-	C.git_fetch_options_init(copts, C.GIT_FETCH_OPTIONS_VERSION)
+	C.git_fetch_init_options(copts, C.GIT_FETCH_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
 	populateRemoteCallbacks(&copts.callbacks, &opts.RemoteCallbacks, errorTarget)
 	copts.prune = C.git_fetch_prune_t(opts.Prune)
-	fmt.Println("populateFetchOptions() is broken. fixme!")
+	copts.update_fetchhead = cbool(opts.UpdateFetchhead)
-	// fix this line: ./remote.go:988:27: cannot use cbool(opts.UpdateFetchhead) (value of type _Ctype_int) as _Ctype_uint value in assignment
-	// copts.update_fetchhead = cbool(opts.UpdateFetchhead)
 	copts.download_tags = C.git_remote_autotag_option_t(opts.DownloadTags)
 
 	copts.custom_headers = C.git_strarray{
@@ -1007,7 +937,7 @@ func freeFetchOptions(copts *C.git_fetch_options) {
 }
 
 func populatePushOptions(copts *C.git_push_options, opts *PushOptions, errorTarget *error) *C.git_push_options {
-	C.git_push_options_init(copts, C.GIT_PUSH_OPTIONS_VERSION)
+	C.git_push_init_options(copts, C.GIT_PUSH_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
@@ -1214,54 +1144,3 @@ func (o *Remote) Prune(callbacks *RemoteCallbacks) error {
 	}
 	return nil
 }
-
-// DefaultApplyOptions returns default options for remote create
-func DefaultRemoteCreateOptions() (*RemoteCreateOptions, error) {
-	runtime.LockOSThread()
-	defer runtime.UnlockOSThread()
-
-	opts := C.git_remote_create_options{}
-	ecode := C.git_remote_create_options_init(&opts, C.GIT_REMOTE_CREATE_OPTIONS_VERSION)
-	if ecode < 0 {
-		return nil, MakeGitError(ecode)
-	}
-
-	return &RemoteCreateOptions{
-		Flags: RemoteCreateOptionsFlag(opts.flags),
-	}, nil
-}
-
-func populateRemoteCreateOptions(copts *C.git_remote_create_options, opts *RemoteCreateOptions, repo *Repository) *C.git_remote_create_options {
-	C.git_remote_create_options_init(copts, C.GIT_REMOTE_CREATE_OPTIONS_VERSION)
-	if opts == nil {
-		return nil
-	}
-
-	var cRepository *C.git_repository
-	if repo != nil {
-		cRepository = repo.ptr
-	}
-	copts.repository = cRepository
-	copts.name = C.CString(opts.Name)
-	copts.fetchspec = C.CString(opts.FetchSpec)
-	copts.flags = C.uint(opts.Flags)
-
-	return copts
-}
-
-func freeRemoteCreateOptions(ptr *C.git_remote_create_options) {
-	if ptr == nil {
-		return
-	}
-	C.free(unsafe.Pointer(ptr.name))
-	C.free(unsafe.Pointer(ptr.fetchspec))
-}
-
-// createNewEmptyRemote used to get a new empty object of *Remote
-func createNewEmptyRemote() *Remote {
-	return &Remote{
-		callbacks: RemoteCallbacks{},
-		repo:      nil,
-		weak:      false,
-	}
-}

remote_test.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"crypto/rand"
 	"crypto/rsa"
-	"errors"
 	"fmt"
 	"io"
 	"net"
@@ -38,13 +37,13 @@ func TestListRemotes(t *testing.T) {
 	compareStringList(t, expected, actual)
 }
 
-func assertHostname(cert *Certificate, valid bool, hostname string, t *testing.T) error {
+func assertHostname(cert *Certificate, valid bool, hostname string, t *testing.T) ErrorCode {
 	if hostname != "github.com" {
-		t.Fatal("hostname does not match")
+		t.Fatal("Hostname does not match")
-		return errors.New("hostname does not match")
+		return ErrorCodeUser
 	}
 
-	return nil
+	return ErrorCodeOK
 }
 
 func TestCertificateCheck(t *testing.T) {
@@ -58,7 +57,7 @@ func TestCertificateCheck(t *testing.T) {
 
 	options := FetchOptions{
 		RemoteCallbacks: RemoteCallbacks{
-			CertificateCheckCallback: func(cert *Certificate, valid bool, hostname string) error {
+			CertificateCheckCallback: func(cert *Certificate, valid bool, hostname string) ErrorCode {
 				return assertHostname(cert, valid, hostname, t)
 			},
 		},
@@ -81,29 +80,6 @@ func TestRemoteConnect(t *testing.T) {
 	checkFatal(t, err)
 }
 
-func TestRemoteConnectOption(t *testing.T) {
-	t.Parallel()
-	repo := createTestRepo(t)
-	defer cleanupTestRepo(t, repo)
-
-	config, err := repo.Config()
-	checkFatal(t, err)
-	err = config.SetString("url.git@github.com:.insteadof", "https://github.com/")
-	checkFatal(t, err)
-
-	option, err := DefaultRemoteCreateOptions()
-	checkFatal(t, err)
-	option.Name = "origin"
-	option.Flags = RemoteCreateSkipInsteadof
-
-	remote, err := repo.Remotes.CreateWithOptions("https://github.com/libgit2/TestGitRepository", option)
-	checkFatal(t, err)
-	defer remote.Free()
-
-	err = remote.ConnectFetch(nil, nil, nil)
-	checkFatal(t, err)
-}
-
 func TestRemoteLs(t *testing.T) {
 	t.Parallel()
 	repo := createTestRepo(t)
@@ -243,18 +219,17 @@ func TestRemoteCredentialsCalled(t *testing.T) {
 	checkFatal(t, err)
 	defer remote.Free()
 
-	errNonExistent := errors.New("non-existent repository")
 	fetchOpts := FetchOptions{
 		RemoteCallbacks: RemoteCallbacks{
-			CredentialsCallback: func(url, username string, allowedTypes CredentialType) (*Credential, error) {
+			CredentialsCallback: func(url, username string, allowedTypes CredType) (ErrorCode, *Cred) {
-				return nil, errNonExistent
+				return ErrorCodeUser, nil
 			},
 		},
 	}
 
 	err = remote.Fetch(nil, &fetchOpts, "fetch")
-	if err != errNonExistent {
+	if IsErrorCode(err, ErrorCodeUser) {
-		t.Fatalf("remote.Fetch() = %v, want %v", err, errNonExistent)
+		t.Fatalf("remote.Fetch() = %v, want %v", err, ErrorCodeUser)
 	}
 }
 
@@ -479,29 +454,33 @@ func TestRemoteSSH(t *testing.T) {
 	certificateCheckCallbackCalled := false
 	fetchOpts := FetchOptions{
 		RemoteCallbacks: RemoteCallbacks{
-			CertificateCheckCallback: func(cert *Certificate, valid bool, hostname string) error {
+			CertificateCheckCallback: func(cert *Certificate, valid bool, hostname string) ErrorCode {
 				hostkeyFingerprint := fmt.Sprintf("%x", cert.Hostkey.HashMD5[:])
 				if hostkeyFingerprint != publicKeyFingerprint {
-					return fmt.Errorf("server hostkey %q, want %q", hostkeyFingerprint, publicKeyFingerprint)
+					t.Logf("server hostkey %q, want %q", hostkeyFingerprint, publicKeyFingerprint)
+					return ErrorCodeAuth
 				}
 				certificateCheckCallbackCalled = true
-				return nil
+				return ErrorCodeOK
 			},
-			CredentialsCallback: func(url, username string, allowedTypes CredentialType) (*Credential, error) {
+			CredentialsCallback: func(url, username string, allowedTypes CredType) (ErrorCode, *Cred) {
-				if allowedTypes&(CredentialTypeSSHKey|CredentialTypeSSHCustom|CredentialTypeSSHMemory) != 0 {
+				if allowedTypes&(CredTypeSshKey|CredTypeSshCustom) != 0 {
-					return NewCredentialSSHKeyFromSigner(pubKeyUsername, signer)
+					cred, err := NewCredentialSSHKeyFromSigner(pubKeyUsername, signer)
+					if err != nil {
+						t.Logf("failed to create credentials: %v", err)
+						return ErrorCodeAuth, nil
+					}
+					return ErrorCodeOK, cred
 				}
-				if (allowedTypes & CredentialTypeUsername) != 0 {
+				t.Logf("unknown credential type %+v", allowedTypes)
-					return NewCredentialUsername(pubKeyUsername)
+				return ErrorCodeAuth, nil
-				}
-				return nil, fmt.Errorf("unknown credential type %+v", allowedTypes)
 			},
 		},
 	}
 
 	remote, err := repo.Remotes.Create(
 		"origin",
-		fmt.Sprintf("ssh://%s/TestGitRepository", listener.Addr().String()),
+		fmt.Sprintf("ssh://%s@%s/TestGitRepository", pubKeyUsername, listener.Addr().String()),
 	)
 	checkFatal(t, err)
 	defer remote.Free()

repository.go

@@ -173,15 +173,9 @@ func (v *Repository) Config() (*Config, error) {
 // This configuration file will be used for all configuration queries involving
 // this repository.
 func (v *Repository) SetConfig(c *Config) error {
-	runtime.LockOSThread()
+	C.git_repository_set_config(v.ptr, c.ptr)
-	defer runtime.UnlockOSThread()
-
-	ret := C.git_repository_set_config(v.ptr, c.ptr)
 	runtime.KeepAlive(v)
 	runtime.KeepAlive(c)
-	if ret < 0 {
-		return MakeGitError(ret)
-	}
 	return nil
 }
 
@@ -205,7 +199,7 @@ func (v *Repository) lookupType(id *Oid, t ObjectType) (*Object, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ret := C.git_object_lookup(&ptr, v.ptr, id.toC(), C.git_object_t(t))
+	ret := C.git_object_lookup(&ptr, v.ptr, id.toC(), C.git_otype(t))
 	runtime.KeepAlive(id)
 	if ret < 0 {
 		return nil, MakeGitError(ret)
@@ -220,7 +214,7 @@ func (v *Repository) lookupPrefixType(id *Oid, prefix uint, t ObjectType) (*Obje
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ret := C.git_object_lookup_prefix(&ptr, v.ptr, id.toC(), C.size_t(prefix), C.git_object_t(t))
+	ret := C.git_object_lookup_prefix(&ptr, v.ptr, id.toC(), C.size_t(prefix), C.git_otype(t))
 	runtime.KeepAlive(id)
 	if ret < 0 {
 		return nil, MakeGitError(ret)
@@ -568,7 +562,7 @@ func (v *Repository) CreateCommitBuffer(
 	defer runtime.UnlockOSThread()
 
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 	ret := C.git_commit_create_buffer(
 		&buf, v.ptr,
 		authorSig, committerSig,
@@ -815,7 +809,7 @@ func (r *Repository) ClearGitIgnoreRules() error {
 // the file after you create the commit.
 func (r *Repository) Message() (string, error) {
 	buf := C.git_buf{}
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
@@ -862,7 +856,7 @@ const (
 
 func (r *Repository) ItemPath(item RepositoryItem) (string, error) {
 	var c_buf C.git_buf
-	defer C.git_buf_dispose(&c_buf)
+	defer C.git_buf_free(&c_buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()

revert.go

@@ -10,27 +10,27 @@ import (
 
 // RevertOptions contains options for performing a revert
 type RevertOptions struct {
-	Mainline        uint
+	Mainline     uint
-	MergeOptions    MergeOptions
+	MergeOpts    MergeOptions
-	CheckoutOptions CheckoutOptions
+	CheckoutOpts CheckoutOptions
 }
 
 func populateRevertOptions(copts *C.git_revert_options, opts *RevertOptions, errorTarget *error) *C.git_revert_options {
-	C.git_revert_options_init(copts, C.GIT_REVERT_OPTIONS_VERSION)
+	C.git_revert_init_options(copts, C.GIT_REVERT_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
 	copts.mainline = C.uint(opts.Mainline)
-	populateMergeOptions(&copts.merge_opts, &opts.MergeOptions)
+	populateMergeOptions(&copts.merge_opts, &opts.MergeOpts)
-	populateCheckoutOptions(&copts.checkout_opts, &opts.CheckoutOptions, errorTarget)
+	populateCheckoutOptions(&copts.checkout_opts, &opts.CheckoutOpts, errorTarget)
 	return copts
 }
 
 func revertOptionsFromC(copts *C.git_revert_options) RevertOptions {
 	return RevertOptions{
-		Mainline:        uint(copts.mainline),
+		Mainline:     uint(copts.mainline),
-		MergeOptions:    mergeOptionsFromC(&copts.merge_opts),
+		MergeOpts:    mergeOptionsFromC(&copts.merge_opts),
-		CheckoutOptions: checkoutOptionsFromC(&copts.checkout_opts),
+		CheckoutOpts: checkoutOptionsFromC(&copts.checkout_opts),
 	}
 }
 
@@ -49,7 +49,7 @@ func DefaultRevertOptions() (RevertOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_revert_options_init(&copts, C.GIT_REVERT_OPTIONS_VERSION)
+	ecode := C.git_revert_init_options(&copts, C.GIT_REVERT_OPTIONS_VERSION)
 	if ecode < 0 {
 		return RevertOptions{}, MakeGitError(ecode)
 	}

revert_test.go

@@ -60,11 +60,12 @@ func TestRevertCommit(t *testing.T) {
 	revertOptions, err := DefaultRevertOptions()
 	checkFatal(t, err)
 
-	index, err := repo.RevertCommit(commit, commit, 0, &revertOptions.MergeOptions)
+	index, err := repo.RevertCommit(commit, commit, 0, &revertOptions.MergeOpts)
 	checkFatal(t, err)
 	defer index.Free()
 
-	err = repo.CheckoutIndex(index, &revertOptions.CheckoutOptions)
+	revertOptions.CheckoutOpts.Strategy = CheckoutSafe
+	err = repo.CheckoutIndex(index, &revertOptions.CheckoutOpts)
 	checkFatal(t, err)
 
 	actualReadmeContents := readReadme(t, repo)

script/build-libgit2.sh

@@ -46,40 +46,24 @@ if [ -z "${BUILD_SHARED_LIBS}" ]; then
 	usage
 fi
 
-if [ -n "${BUILD_LIBGIT_REF}" ]; then
-	git -C "${VENDORED_PATH}" checkout "${BUILD_LIBGIT_REF}"
-	trap "git submodule update --init" EXIT
-fi
-
-BUILD_DEPRECATED_HARD="ON"
 if [ "${BUILD_SYSTEM}" = "ON" ]; then
 	BUILD_INSTALL_PREFIX=${SYSTEM_INSTALL_PREFIX-"/usr"}
-	# Most system-wide installations won't intentionally omit deprecated symbols.
-	BUILD_DEPRECATED_HARD="OFF"
 else
 	BUILD_INSTALL_PREFIX="${BUILD_PATH}/install"
 	mkdir -p "${BUILD_PATH}/install/lib"
 fi
 
-USE_BUNDLED_ZLIB="ON"
-if [ "${USE_CHROMIUM_ZLIB}" = "ON" ]; then
-	USE_BUNDLED_ZLIB="Chromium"
-fi
-
 mkdir -p "${BUILD_PATH}/build" &&
 cd "${BUILD_PATH}/build" &&
 cmake -DTHREADSAFE=ON \
       -DBUILD_CLAR=OFF \
       -DBUILD_SHARED_LIBS"=${BUILD_SHARED_LIBS}" \
-      -DREGEX_BACKEND=builtin \
-      -DUSE_BUNDLED_ZLIB="${USE_BUNDLED_ZLIB}" \
       -DUSE_HTTPS=OFF \
       -DUSE_SSH=OFF \
       -DCMAKE_C_FLAGS=-fPIC \
       -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
       -DCMAKE_INSTALL_PREFIX="${BUILD_INSTALL_PREFIX}" \
-      -DCMAKE_INSTALL_LIBDIR="lib" \
+      -DDEPRECATE_HARD=ON \
-      -DDEPRECATE_HARD="${BUILD_DEPRECATE_HARD}" \
       "${VENDORED_PATH}"
 
 if which make nproc >/dev/null && [ -f Makefile ]; then

script/install-libgit2.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
 
 #
-# Install libgit2 to go libgit2 in dynamic mode on Travis
+# Install libgit2 to git2go in dynamic mode on Travis
 #
 
 set -ex

settings.go

@@ -18,7 +18,7 @@ int _go_git_opts_set_size_t(int opt, size_t val)
     return git_libgit2_opts(opt, val);
 }
 
-int _go_git_opts_set_cache_object_limit(git_object_t type, size_t size)
+int _go_git_opts_set_cache_object_limit(git_otype type, size_t size)
 {
     return git_libgit2_opts(GIT_OPT_SET_CACHE_OBJECT_LIMIT, type, size);
 }
@@ -41,7 +41,7 @@ import (
 
 func SearchPath(level ConfigLevel) (string, error) {
 	var buf C.git_buf
-	defer C.git_buf_dispose(&buf)
+	defer C.git_buf_free(&buf)
 
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
@@ -126,7 +126,7 @@ func SetCacheObjectLimit(objectType ObjectType, size int) error {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	err := C._go_git_opts_set_cache_object_limit(C.git_object_t(objectType), C.size_t(size))
+	err := C._go_git_opts_set_cache_object_limit(C.git_otype(objectType), C.size_t(size))
 	if err < 0 {
 		return MakeGitError(err)
 	}

ssh.go

@@ -3,7 +3,7 @@ package git
 /*
 #include <git2.h>
 
-#include <git2/sys/credential.h>
+void _go_git_credential_free(git_cred *cred);
 */
 import "C"
 import (
@@ -106,11 +106,11 @@ func (t *sshSmartSubtransport) Action(urlString string, action SmartServiceActio
 		return nil, fmt.Errorf("unexpected action: %v", action)
 	}
 
-	cred, err := t.transport.SmartCredentials("", CredentialTypeSSHKey|CredentialTypeSSHMemory)
+	cred, err := t.transport.SmartCredentials("", CredTypeSshKey)
 	if err != nil {
 		return nil, err
 	}
-	defer cred.Free()
+	defer C._go_git_credential_free(cred.ptr)
 
 	sshConfig, err := getSSHConfigFromCredential(cred)
 	if err != nil {
@@ -201,10 +201,10 @@ func (stream *sshSmartSubtransportStream) Write(buf []byte) (int, error) {
 func (stream *sshSmartSubtransportStream) Free() {
 }
 
-func getSSHConfigFromCredential(cred *Credential) (*ssh.ClientConfig, error) {
+func getSSHConfigFromCredential(cred *Cred) (*ssh.ClientConfig, error) {
 	switch cred.Type() {
-	case CredentialTypeSSHCustom:
+	case CredTypeSshCustom:
-		credSSHCustom := (*C.git_credential_ssh_custom)(unsafe.Pointer(cred.ptr))
+		credSSHCustom := (*C.git_cred_ssh_custom)(unsafe.Pointer(cred.ptr))
 		data, ok := pointerHandles.Get(credSSHCustom.payload).(*credentialSSHCustomData)
 		if !ok {
 			return nil, errors.New("unsupported custom SSH credentials")
@@ -215,19 +215,14 @@ func getSSHConfigFromCredential(cred *Credential) (*ssh.ClientConfig, error) {
 		}, nil
 	}
 
-	username, _, privatekey, passphrase, err := cred.GetSSHKey()
+	username, _, privatekey, passphrase, ret := cred.GetSSHKey()
-	if err != nil {
+	if ret != nil {
-		return nil, err
+		return nil, ret
 	}
 
-	var pemBytes []byte
+	pemBytes, err := ioutil.ReadFile(privatekey)
-	if cred.Type() == CredentialTypeSSHMemory {
+	if err != nil {
-		pemBytes = []byte(privatekey)
+		return nil, err
-	} else {
-		pemBytes, err = ioutil.ReadFile(privatekey)
-		if err != nil {
-			return nil, err
-		}
 	}
 
 	var key ssh.Signer

stash.go

@@ -152,7 +152,7 @@ func DefaultStashApplyOptions() (StashApplyOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ecode := C.git_stash_apply_options_init(&optsC, C.GIT_STASH_APPLY_OPTIONS_VERSION)
+	ecode := C.git_stash_apply_init_options(&optsC, C.GIT_STASH_APPLY_OPTIONS_VERSION)
 	if ecode < 0 {
 		return StashApplyOptions{}, MakeGitError(ecode)
 	}
@@ -163,11 +163,11 @@ func DefaultStashApplyOptions() (StashApplyOptions, error) {
 }
 
 func populateStashApplyOptions(copts *C.git_stash_apply_options, opts *StashApplyOptions, errorTarget *error) *C.git_stash_apply_options {
-	C.git_stash_apply_options_init(copts, C.GIT_STASH_APPLY_OPTIONS_VERSION)
+	C.git_stash_apply_init_options(copts, C.GIT_STASH_APPLY_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
-	copts.flags = C.uint32_t(opts.Flags)
+	copts.flags = C.git_stash_apply_flags(opts.Flags)
 	populateCheckoutOptions(&copts.checkout_options, &opts.CheckoutOptions, errorTarget)
 	if opts.ProgressCallback != nil {
 		progressData := &stashApplyProgressCallbackData{

status.go

@@ -160,7 +160,7 @@ func (v *Repository) StatusList(opts *StatusOptions) (*StatusList, error) {
 		}
 	} else {
 		copts = &C.git_status_options{}
-		ret := C.git_status_options_init(copts, C.GIT_STATUS_OPTIONS_VERSION)
+		ret := C.git_status_init_options(copts, C.GIT_STATUS_OPTIONS_VERSION)
 		if ret < 0 {
 			return nil, MakeGitError(ret)
 		}

submodule.go

@@ -8,14 +8,15 @@ extern int _go_git_visit_submodule(git_repository *repo, void *fct);
 import "C"
 
 import (
+	"errors"
 	"runtime"
 	"unsafe"
 )
 
 // SubmoduleUpdateOptions
 type SubmoduleUpdateOptions struct {
-	CheckoutOptions CheckoutOptions
+	*CheckoutOpts
-	FetchOptions    FetchOptions
+	*FetchOptions
 }
 
 // Submodule
@@ -110,7 +111,7 @@ func (c *SubmoduleCollection) Lookup(name string) (*Submodule, error) {
 }
 
 // SubmoduleCallback is a function that is called for every submodule found in SubmoduleCollection.Foreach.
-type SubmoduleCallback func(sub *Submodule, name string) error
+type SubmoduleCallback func(sub *Submodule, name string) int
 type submoduleCallbackData struct {
 	callback    SubmoduleCallback
 	errorTarget *error
@@ -125,9 +126,9 @@ func submoduleCallback(csub unsafe.Pointer, name *C.char, handle unsafe.Pointer)
 		panic("invalid submodule visitor callback")
 	}
 
-	err := data.callback(sub, C.GoString(name))
+	ret := data.callback(sub, C.GoString(name))
-	if err != nil {
+	if ret < 0 {
-		*data.errorTarget = err
+		*data.errorTarget = errors.New(ErrorCode(ret).String())
 		return C.int(ErrorCodeUser)
 	}
 
@@ -385,13 +386,13 @@ func (sub *Submodule) Update(init bool, opts *SubmoduleUpdateOptions) error {
 }
 
 func populateSubmoduleUpdateOptions(copts *C.git_submodule_update_options, opts *SubmoduleUpdateOptions, errorTarget *error) *C.git_submodule_update_options {
-	C.git_submodule_update_options_init(copts, C.GIT_SUBMODULE_UPDATE_OPTIONS_VERSION)
+	C.git_submodule_update_init_options(copts, C.GIT_SUBMODULE_UPDATE_OPTIONS_VERSION)
 	if opts == nil {
 		return nil
 	}
 
-	populateCheckoutOptions(&copts.checkout_opts, &opts.CheckoutOptions, errorTarget)
+	populateCheckoutOptions(&copts.checkout_opts, opts.CheckoutOpts, errorTarget)
-	populateFetchOptions(&copts.fetch_opts, &opts.FetchOptions, errorTarget)
+	populateFetchOptions(&copts.fetch_opts, opts.FetchOptions, errorTarget)
 
 	return copts
 }

submodule_test.go

@@ -15,9 +15,9 @@ func TestSubmoduleForeach(t *testing.T) {
 	checkFatal(t, err)
 
 	i := 0
-	err = repo.Submodules.Foreach(func(sub *Submodule, name string) error {
+	err = repo.Submodules.Foreach(func(sub *Submodule, name string) int {
 		i++
-		return nil
+		return 0
 	})
 	checkFatal(t, err)
 

tag.go

@@ -161,7 +161,7 @@ func (c *TagsCollection) List() ([]string, error) {
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)
 	}
-	defer C.git_strarray_dispose(&strC)
+	defer C.git_strarray_free(&strC)
 
 	tags := makeStringsFromCStrings(strC.strings, int(strC.count))
 	return tags, nil
@@ -185,7 +185,7 @@ func (c *TagsCollection) ListWithMatch(pattern string) ([]string, error) {
 	if ecode < 0 {
 		return nil, MakeGitError(ecode)
 	}
-	defer C.git_strarray_dispose(&strC)
+	defer C.git_strarray_free(&strC)
 
 	tags := makeStringsFromCStrings(strC.strings, int(strC.count))
 	return tags, nil

transport.go

@@ -22,6 +22,7 @@ void _go_git_setup_smart_subtransport_stream(_go_managed_smart_subtransport_stre
 */
 import "C"
 import (
+	"errors"
 	"fmt"
 	"io"
 	"reflect"
@@ -31,7 +32,7 @@ import (
 )
 
 var (
-	// globalRegisteredSmartTransports is a mapping of global, libgit2 go-managed
+	// globalRegisteredSmartTransports is a mapping of global, git2go-managed
 	// transports.
 	globalRegisteredSmartTransports = struct {
 		sync.Mutex
@@ -41,7 +42,7 @@ var (
 	}
 )
 
-// unregisterManagedTransports unregisters all libgit2 go-managed transports.
+// unregisterManagedTransports unregisters all git2go-managed transports.
 func unregisterManagedTransports() error {
 	globalRegisteredSmartTransports.Lock()
 	originalTransports := globalRegisteredSmartTransports.transports
@@ -84,22 +85,22 @@ type Transport struct {
 	ptr *C.git_transport
 }
 
-// SmartRemoteConnectOptions gets a copy of the proxy options for this transport.
+// SmartProxyOptions gets a copy of the proxy options for this transport.
-func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) {
+func (t *Transport) SmartProxyOptions() (*ProxyOptions, error) {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	var copts C.git_remote_connect_options
+	var cpopts C.git_proxy_options
-	if ret := C.git_transport_remote_connect_options(&copts, t.ptr); ret < 0 {
+	if ret := C.git_transport_smart_proxy_options(&cpopts, t.ptr); ret < 0 {
 		return nil, MakeGitError(ret)
 	}
 
-	return remoteConnectOptionsFromC(&copts), nil
+	return proxyOptionsFromC(&cpopts), nil
 }
 
 // SmartCredentials calls the credentials callback for this transport.
-func (t *Transport) SmartCredentials(user string, methods CredentialType) (*Credential, error) {
+func (t *Transport) SmartCredentials(user string, methods CredType) (*Cred, error) {
-	cred := newCredential()
+	cred := &Cred{}
 	var cstr *C.char
 
 	runtime.LockOSThread()
@@ -111,7 +112,6 @@ func (t *Transport) SmartCredentials(user string, methods CredentialType) (*Cred
 	}
 	ret := C.git_transport_smart_credentials(&cred.ptr, t.ptr, cstr, C.int(methods))
 	if ret != 0 {
-		cred.Free()
 		return nil, MakeGitError(ret)
 	}
 
@@ -127,21 +127,10 @@ func (t *Transport) SmartCertificateCheck(cert *Certificate, valid bool, hostnam
 			parent: C.git_cert{
 				cert_type: C.GIT_CERT_HOSTKEY_LIBSSH2,
 			},
-			_type:       C.git_cert_ssh_t(cert.Kind),
+			_type: C.git_cert_ssh_t(cert.Kind),
-			hostkey:     (*C.char)(C.CBytes(cert.Hostkey.Hostkey)),
-			hostkey_len: C.size_t(len(cert.Hostkey.Hostkey)),
 		}
-		defer C.free(unsafe.Pointer(chostkeyCert.hostkey))
 		C.memcpy(unsafe.Pointer(&chostkeyCert.hash_md5[0]), unsafe.Pointer(&cert.Hostkey.HashMD5[0]), C.size_t(len(cert.Hostkey.HashMD5)))
 		C.memcpy(unsafe.Pointer(&chostkeyCert.hash_sha1[0]), unsafe.Pointer(&cert.Hostkey.HashSHA1[0]), C.size_t(len(cert.Hostkey.HashSHA1)))
-		C.memcpy(unsafe.Pointer(&chostkeyCert.hash_sha256[0]), unsafe.Pointer(&cert.Hostkey.HashSHA256[0]), C.size_t(len(cert.Hostkey.HashSHA256)))
-		if cert.Hostkey.SSHPublicKey.Type() == "ssh-rsa" {
-			chostkeyCert.raw_type = C.GIT_CERT_SSH_RAW_TYPE_RSA
-		} else if cert.Hostkey.SSHPublicKey.Type() == "ssh-dss" {
-			chostkeyCert.raw_type = C.GIT_CERT_SSH_RAW_TYPE_DSS
-		} else {
-			chostkeyCert.raw_type = C.GIT_CERT_SSH_RAW_TYPE_UNKNOWN
-		}
 		ccert = (*C.git_cert)(unsafe.Pointer(&chostkeyCert))
 
 	case CertificateX509:
@@ -305,10 +294,8 @@ func smartTransportCallback(
 	registeredSmartTransport := pointerHandles.Get(handle).(*RegisteredSmartTransport)
 	remote, ok := remotePointers.get(owner)
 	if !ok {
-		// create a new empty remote and set it
+		err := errors.New("remote pointer not found")
-		// as a weak pointer, so that control stays in golang
+		return setCallbackError(errorMessage, err)
-		remote = createNewEmptyRemote()
-		remote.weak = true
 	}
 
 	managed := &managedSmartSubtransport{

tree.go

@@ -121,7 +121,7 @@ func (t *Tree) EntryCount() uint64 {
 	return uint64(num)
 }
 
-type TreeWalkCallback func(string, *TreeEntry) error
+type TreeWalkCallback func(string, *TreeEntry) int
 type treeWalkCallbackData struct {
 	callback    TreeWalkCallback
 	errorTarget *error
@@ -134,30 +134,15 @@ func treeWalkCallback(_root *C.char, entry *C.git_tree_entry, ptr unsafe.Pointer
 		panic("invalid treewalk callback")
 	}
 
-	err := data.callback(C.GoString(_root), newTreeEntry(entry))
+	ret := data.callback(C.GoString(_root), newTreeEntry(entry))
-	if err == TreeWalkSkip {
+	if ret < 0 {
-		return C.int(1)
+		*data.errorTarget = errors.New(ErrorCode(ret).String())
-	} else if err != nil {
-		*data.errorTarget = err
 		return C.int(ErrorCodeUser)
 	}
 
 	return C.int(ErrorCodeOK)
 }
 
-// TreeWalkSkip is an error that can be returned form TreeWalkCallback to skip
-// a subtree from being expanded.
-var TreeWalkSkip = errors.New("skip")
-
-// Walk traverses the entries in a tree and its subtrees in pre order.
-//
-// The entries will be traversed in the pre order, children subtrees will be
-// automatically loaded as required, and the callback will be called once per
-// entry with the current (relative) root for the entry and the entry data
-// itself.
-//
-// If the callback returns TreeWalkSkip, the passed entry will be skipped on
-// the traversal. Any other non-nil error stops the walk.
 func (t *Tree) Walk(callback TreeWalkCallback) error {
 	var err error
 	data := treeWalkCallbackData{

tree_test.go

@@ -1,9 +1,6 @@
 package git
 
-import (
+import "testing"
-	"errors"
-	"testing"
-)
 
 func TestTreeEntryById(t *testing.T) {
 	t.Parallel()
@@ -66,72 +63,3 @@ func TestTreeBuilderInsert(t *testing.T) {
 		t.Fatalf("got oid %v, want %v", entry.Id, blobId)
 	}
 }
-
-func TestTreeWalk(t *testing.T) {
-	t.Parallel()
-	repo, err := OpenRepository("testdata/TestGitRepository.git")
-	checkFatal(t, err)
-	treeID, err := NewOid("6020a3b8d5d636e549ccbd0c53e2764684bb3125")
-	checkFatal(t, err)
-
-	tree, err := repo.LookupTree(treeID)
-	checkFatal(t, err)
-
-	var callCount int
-	err = tree.Walk(func(name string, entry *TreeEntry) error {
-		callCount++
-
-		return nil
-	})
-	checkFatal(t, err)
-	if callCount != 11 {
-		t.Fatalf("got called %v times, want %v", callCount, 11)
-	}
-}
-
-func TestTreeWalkSkip(t *testing.T) {
-	t.Parallel()
-	repo, err := OpenRepository("testdata/TestGitRepository.git")
-	checkFatal(t, err)
-	treeID, err := NewOid("6020a3b8d5d636e549ccbd0c53e2764684bb3125")
-	checkFatal(t, err)
-
-	tree, err := repo.LookupTree(treeID)
-	checkFatal(t, err)
-
-	var callCount int
-	err = tree.Walk(func(name string, entry *TreeEntry) error {
-		callCount++
-
-		return TreeWalkSkip
-	})
-	checkFatal(t, err)
-	if callCount != 4 {
-		t.Fatalf("got called %v times, want %v", callCount, 4)
-	}
-}
-
-func TestTreeWalkStop(t *testing.T) {
-	t.Parallel()
-	repo, err := OpenRepository("testdata/TestGitRepository.git")
-	checkFatal(t, err)
-	treeID, err := NewOid("6020a3b8d5d636e549ccbd0c53e2764684bb3125")
-	checkFatal(t, err)
-
-	tree, err := repo.LookupTree(treeID)
-	checkFatal(t, err)
-
-	var callCount int
-	stopError := errors.New("stop")
-	err = tree.Walk(func(name string, entry *TreeEntry) error {
-		callCount++
-
-		return stopError
-	})
-	if err != stopError {
-		t.Fatalf("got error %v, want %v", err, stopError)
-	}
-	if callCount != 1 {
-		t.Fatalf("got called %v times, want %v", callCount, 1)
-	}
-}

vendor/libgit2

@@ -0,0 +1 @@
+Subproject commit 45c6187cbfdcfee2bcf59a1ed3a853065142f203

wrapper.c

@@ -3,7 +3,6 @@
 #include <git2.h>
 #include <git2/sys/odb_backend.h>
 #include <git2/sys/refdb_backend.h>
-#include <git2/sys/cred.h>
 
 // There are two ways in which to declare a callback:
 //
@@ -104,50 +103,12 @@ static int set_callback_error(char *error_message, int ret)
 {
 	if (error_message != NULL) {
 		if (ret < 0)
-			giterr_set_str(GIT_ERROR_CALLBACK, error_message);
+			giterr_set_str(GITERR_CALLBACK, error_message);
 		free(error_message);
 	}
 	return ret;
 }
 
-void _go_git_populate_apply_callbacks(git_apply_options *options)
-{
-	options->delta_cb = (git_apply_delta_cb)&deltaApplyCallback;
-	options->hunk_cb = (git_apply_hunk_cb)&hunkApplyCallback;
-}
-
-static int commit_create_callback(
-		git_oid *out,
-		const git_signature *author,
-		const git_signature *committer,
-		const char *message_encoding,
-		const char *message,
-		const git_tree *tree,
-		size_t parent_count,
-		const git_commit *parents[],
-		void *payload)
-{
-	char *error_message = NULL;
-	const int ret = commitCreateCallback(
-			&error_message,
-			out,
-			(git_signature *)author,
-			(git_signature *)committer,
-			(char *)message_encoding,
-			(char *)message,
-			(git_tree *)tree,
-			parent_count,
-			(git_commit **)parents,
-			payload
-	);
-	return set_callback_error(error_message, ret);
-}
-
-void _go_git_populate_rebase_callbacks(git_rebase_options *opts)
-{
-	opts->commit_create_cb = commit_create_callback;
-}
-
 void _go_git_populate_clone_callbacks(git_clone_options *opts)
 {
 	opts->remote_cb = (git_remote_create_cb)&remoteCreateCallback;
@@ -254,7 +215,7 @@ static int completion_callback(git_remote_completion_type completion_type, void
 }
 
 static int credentials_callback(
-		git_credential **cred,
+		git_cred **cred,
 		const char *url,
 		const char *username_from_url,
 		unsigned int allowed_types,
@@ -450,11 +411,6 @@ void _go_git_writestream_free(git_writestream *stream)
 	stream->free(stream);
 }
 
-git_credential_t _go_git_credential_credtype(git_credential *cred)
-{
-	return cred->credtype;
-}
-
 static int credential_ssh_sign_callback(
 		LIBSSH2_SESSION *session,
 		unsigned char **sig, size_t *sig_len,
@@ -472,12 +428,17 @@ static int credential_ssh_sign_callback(
 	return set_callback_error(error_message, ret);
 }
 
-void _go_git_populate_credential_ssh_custom(git_credential_ssh_custom *cred)
+void _go_git_populate_credential_ssh_custom(git_cred_ssh_custom *cred)
 {
-	cred->parent.free = (void (*)(git_credential *))credentialSSHCustomFree;
+	cred->parent.free = (void (*)(git_cred *))credentialSSHCustomFree;
 	cred->sign_callback = credential_ssh_sign_callback;
 }
 
+void _go_git_credential_free(git_cred *cred)
+{
+	cred->free(cred);
+}
+
 int _go_git_odb_write_pack(git_odb_writepack **out, git_odb *db, void *progress_payload)
 {
 	return git_odb_write_pack(out, db, transfer_progress_callback, progress_payload);
@@ -509,10 +470,7 @@ int _go_git_indexer_new(
 		git_odb *odb,
 		void *progress_cb_payload)
 {
-	git_indexer_options indexer_options = GIT_INDEXER_OPTIONS_INIT;
+	return git_indexer_new(out, path, mode, odb, transfer_progress_callback, progress_cb_payload);
-	indexer_options.progress_cb = transfer_progress_callback;
-	indexer_options.progress_cb_payload = progress_cb_payload;
-	return git_indexer_new(out, path, mode, odb, &indexer_options);
 }
 
 static int smart_transport_callback(