Implement git_repository_set_config #735

2021-02-01T07:18:43-06:00

bc-lee commented

2021-02-01 07:18:43 -06:00

(Migrated from github.com)

Closes #732

lhchavez (Migrated from github.com) reviewed 2021-02-02 08:31:00 -06:00

repository.go

													
				@ -168,0 +169,4 @@

				//

				// This configuration file will be used for all configuration queries involving

				// this repository.

				func (v *Repository) SetConfig(c *Config) error {

lhchavez (Migrated from github.com) commented

2021-02-02 08:30:08 -06:00

// SetConfig sets the configuration file for this repository.
//
// This configuration file will be used for all configuration queries involving
// this repository.
func (v *Repository) SetConfig(c *Config) error {

```suggestion // SetConfig sets the configuration file for this repository. // // This configuration file will be used for all configuration queries involving // this repository. func (v *Repository) SetConfig(c *Config) error { ```

repository.go

													
				@ -168,0 +174,4 @@

					defer runtime.UnlockOSThread()

					ret := C.git_repository_set_config(v.ptr, c.ptr)

					runtime.KeepAlive(v)

lhchavez (Migrated from github.com) commented

2021-02-02 08:30:56 -06:00

	runtime.KeepAlive(v)
	runtime.KeepAlive(c)

otherwise if c is not used by the caller later, the Go runtime is free to remove it in the middle of the CGO call.

```suggestion runtime.KeepAlive(v) runtime.KeepAlive(c) ``` otherwise if `c` is not used by the caller later, the Go runtime is free to remove it in the middle of the CGO call.