Enable set the VENDORED_PATH for libgit2 #650

2020-09-30T13:19:06-05:00

suhaibmujahid commented

2020-09-30 13:19:06 -05:00

(Migrated from github.com)

What this change is doing?

This change aims to enable us to set the VENDORED_PATH as an environment variable and failback to the default value if the environment variable is not set. Thus, this change should not break current behavior.

Why we need this?

This will enable using the script to build libgit2 form source code downloaded manually.

Example:

LIBGIT2_VER="1.0.1"
DOWNLOAD_URL="https://codeload.github.com/libgit2/libgit2/tar.gz/v${LIBGIT2_VER}""
LIBGIT2_PATH="${HOME}/libgit2-${LIBGIT2_VER}"
wget -O "${LIBGIT2_PATH}.tar.gz" "$DOWNLOAD_URL"
tar -xzvf "${LIBGIT2_PATH}.tar.gz"


VENDORED_PATH=$LIBGIT2_PATH sh ./script/build-libgit2.sh --static

### What this change is doing? This change aims to enable us to set the `VENDORED_PATH` as an environment variable and failback to the default value if the environment variable is not set. Thus, this change should not break current behavior. ### Why we need this? This will enable using the script to build libgit2 form source code downloaded manually. Example: ```sh LIBGIT2_VER="1.0.1" DOWNLOAD_URL="https://codeload.github.com/libgit2/libgit2/tar.gz/v${LIBGIT2_VER}"" LIBGIT2_PATH="${HOME}/libgit2-${LIBGIT2_VER}" wget -O "${LIBGIT2_PATH}.tar.gz" "$DOWNLOAD_URL" tar -xzvf "${LIBGIT2_PATH}.tar.gz" VENDORED_PATH=$LIBGIT2_PATH sh ./script/build-libgit2.sh --static ```

lhchavez (Migrated from github.com) approved these changes 2020-09-30 18:57:27 -05:00

lhchavez (Migrated from github.com) left a comment

sounds reasonable. thanks!

Sign in to join this conversation.

No reviewers

lhchavez