jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Add support for git_blob_is_binary #625

Merged
vvatanabe merged 2 commits from blob-git_blob_is_binary into master 2020-07-30 07:07:06 -05:00
Conversation 1 Commits 2 Files Changed 2 +25 -1
vvatanabe commented 2020-07-29 15:42:45 -05:00 (Migrated from github.com)
Copy Link

This adds IsBinary() func to Blob struct, which simply returns the result of git_blob_is_binary function.
Refs: https://libgit2.org/libgit2/#HEAD/group/blob/git_blob_is_binary
Issue: Add support for git_blob_is_binary #426

Fixes: #426

This adds IsBinary() func to Blob struct, which simply returns the result of git_blob_is_binary function. Refs: https://libgit2.org/libgit2/#HEAD/group/blob/git_blob_is_binary Issue: Add support for git_blob_is_binary #426 Fixes: #426
lhchavez (Migrated from github.com) reviewed 2020-07-29 18:34:32 -05:00
lhchavez (Migrated from github.com) left a comment
Copy Link

Can this be called from git2go/blob_test.go? looks good otherwise

Can this be called from git2go/blob_test.go? looks good otherwise
vvatanabe commented 2020-07-29 23:22:33 -05:00 (Migrated from github.com)
Copy Link

I have extended a test in blob_test.go. It works.

I have extended a test in blob_test.go. It works.
lhchavez (Migrated from github.com) approved these changes 2020-07-30 07:06:12 -05:00
lhchavez (Migrated from github.com) left a comment
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
lhchavez
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#625
No description provided.
Delete Branch "blob-git_blob_is_binary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?