Add DiffIgnoreWitespaceEol and deprecate DiffIgnoreWitespaceEol #774

2021-08-24T04:48:14-05:00

zegl commented

2021-08-24 04:48:14 -05:00

(Migrated from github.com)

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart.

Fixes #773

DiffIgnoreWitespaceEol contains a typo and does not have the same name as it's libgit2 counterpart. Fixes #773

suhaibmujahid (Migrated from github.com) reviewed 2021-08-24 10:50:06 -05:00

suhaibmujahid (Migrated from github.com) left a comment

Thank you @zegl, good catch.

diff.go

suhaibmujahid (Migrated from github.com) commented

2021-08-24 10:47:56 -05:00

I feel that the following looks more explicit that there is no difference between the two of them. What do you think?

	DiffIgnoreWitespaceEol = DiffIgnoreWhitespaceEol

I feel that the following looks more explicit that there is no difference between the two of them. What do you think? ```suggestion DiffIgnoreWitespaceEol = DiffIgnoreWhitespaceEol ```

zegl (Migrated from github.com) reviewed 2021-08-25 05:03:46 -05:00

diff.go

zegl (Migrated from github.com) commented

2021-08-25 05:03:46 -05:00

Agreed, I've updated the patch. :)

suhaibmujahid (Migrated from github.com) approved these changes 2021-08-25 08:53:04 -05:00

suhaibmujahid (Migrated from github.com) reviewed 2021-08-25 08:54:13 -05:00

diff.go

suhaibmujahid (Migrated from github.com) commented

2021-08-25 08:54:12 -05:00

Thank you.

lhchavez (Migrated from github.com) reviewed 2021-08-31 07:55:38 -05:00

diff.go

lhchavez (Migrated from github.com) commented

2021-08-31 07:55:32 -05:00

	DiffIgnoreWitespaceEOL = DiffIgnoreWhitespaceEol

per https://github.com/golang/go/wiki/CodeReviewComments#initialisms, the convention in Go is to use uppercase for initialisms.

```suggestion DiffIgnoreWitespaceEOL = DiffIgnoreWhitespaceEol ``` per https://github.com/golang/go/wiki/CodeReviewComments#initialisms, the convention in Go is to use uppercase for initialisms.

lhchavez (Migrated from github.com) reviewed 2021-08-31 07:56:58 -05:00

diff.go

lhchavez (Migrated from github.com) commented

2021-08-31 07:56:57 -05:00

	DiffIgnoreWhitespaceEOL    DiffOptionsFlag = C.GIT_DIFF_IGNORE_WHITESPACE_EOL
	// Deprecated: use DiffIgnoreWhitespaceEol instead
	DiffIgnoreWitespaceEol = DiffIgnoreWhitespaceEOL

```suggestion DiffIgnoreWhitespaceEOL DiffOptionsFlag = C.GIT_DIFF_IGNORE_WHITESPACE_EOL // Deprecated: use DiffIgnoreWhitespaceEol instead DiffIgnoreWitespaceEol = DiffIgnoreWhitespaceEOL ```

lhchavez (Migrated from github.com) reviewed 2021-08-31 07:57:46 -05:00

diff.go

lhchavez (Migrated from github.com) commented

2021-08-31 07:57:46 -05:00

	// Deprecated: use DiffIgnoreWhitespaceEOL instead

```suggestion // Deprecated: use DiffIgnoreWhitespaceEOL instead ```

lhchavez (Migrated from github.com) reviewed 2021-08-31 08:13:05 -05:00

lhchavez (Migrated from github.com) left a comment

I'll take a look at the CI failures :/

diff.go

lhchavez (Migrated from github.com) commented

2021-08-31 08:12:57 -05:00

Can this be moved to deprecated.go? that way everything that's deprecated is in the same file.

Can this be moved to `deprecated.go`? that way everything that's deprecated is in the same file.

lhchavez commented

2021-09-03 08:28:19 -05:00

(Migrated from github.com)

CI should be fixed by https://github.com/libgit2/git2go/pull/776 !

Sign in to join this conversation.

No reviewers

suhaibmujahid

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#774