merge: add two missing AnnotatedCommit methods #423

2018-01-25T18:02:26-06:00

josharian commented

2018-01-25 18:02:26 -06:00

(Migrated from github.com)

These should be reviewed somewhat skeptically; the implementation was pulled in monkey-see-monkey-do from similar calls.

carlosmn (Migrated from github.com) reviewed 2018-03-11 14:23:18 -05:00

merge.go

carlosmn (Migrated from github.com) commented

2018-03-11 14:23:18 -05:00

The runtime.KeepAlive() call needs to come after our last reference to what we need to keep alive. The annotated commit goes into newAnnotatedCommitFromC and we need to make sure r stays alive until we return from this function.

The `runtime.KeepAlive()` call needs to come after our last reference to what we need to keep alive. The annotated commit goes into `newAnnotatedCommitFromC` and we need to make sure `r` stays alive until we return from this function.