Add binding for git_index_add_frombuffer #400

2017-07-17T05:17:49-05:00

ramanenka commented

2017-07-17 05:17:49 -05:00

(Migrated from github.com)

It would be nice to have this binding.

carlosmn commented

2017-09-03 13:19:11 -05:00

(Migrated from github.com)

The blob's id and size are updated in the entry you pass into the C function, but this is thrown away in this implementation.

lhchavez commented

2020-02-23 08:36:41 -06:00

(Migrated from github.com)

The blob's id and size are updated in the entry you pass into the C function, but this is thrown away in this implementation.

tried to add a test to ensure that the updated info gets propagated to the entry, but it turns out that this was never the case! the source_entry is never touched, and the id and size are only updated in the entry which is local to that function. So I sent out https://github.com/libgit2/libgit2/pull/5419 to fix the docs.

> The blob's id and size are updated in the entry you pass into the C function, but this is thrown away in this implementation. tried to add a test to ensure that the updated info gets propagated to the `entry`, but it turns out that this was never the case! the `source_entry` is never touched, and the `id` and `size` are only updated in the `entry` which is local to that function. So I sent out https://github.com/libgit2/libgit2/pull/5419 to fix the docs.

lhchavez (Migrated from github.com) approved these changes 2020-02-23 08:39:26 -06:00

Sign in to join this conversation.

No reviewers

lhchavez