Rename methods with Get prefix #582

2020-05-09T18:58:28-05:00

suhaibmujahid commented

2020-05-09 18:58:28 -05:00

(Migrated from github.com)

It is not Go idiomatic to put Get into the getter's name (see here).

Based on the discussion with @lhchavez on Slack. He suggested the renaming and adding backward compatibility.

It is not Go idiomatic to put Get into the getter's name ([see here](https://golang.org/doc/effective_go.html#Getters)). Based on the discussion with @lhchavez on Slack. He suggested the renaming and adding backward compatibility.

lhchavez (Migrated from github.com) reviewed 2020-05-09 21:54:20 -05:00

lhchavez (Migrated from github.com) left a comment

Thanks for doing this!

diff.go

lhchavez (Migrated from github.com) commented

2020-05-09 21:53:49 -05:00

// deprecated: You should use `Diff.Delta()` instead.

```suggestion // deprecated: You should use `Diff.Delta()` instead. ```

index.go

lhchavez (Migrated from github.com) commented

2020-05-09 21:53:59 -05:00

// deprecated: You should use `Index.Conflict()` instead.

```suggestion // deprecated: You should use `Index.Conflict()` instead. ```

suhaibmujahid commented

2020-05-09 21:59:50 -05:00

(Migrated from github.com)

Thank you for the corrections 👍

lhchavez (Migrated from github.com) reviewed 2020-05-09 22:15:12 -05:00

lhchavez (Migrated from github.com) left a comment

since I can't squash this commit, do you mind doing that? otherwise looks good!

suhaibmujahid commented

2020-05-09 22:33:36 -05:00

(Migrated from github.com)

Done!

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#582