823daa8002
Add Korean translation
2019-01-16 10:43:49 +01:00
ef64917a90
Only disable scrollbars on Android and iOS
...
Previously scrollbars were disabled on all touch devices. This meant
that they were disabled on Windows when touch was detected. Windows does
in fact have useful scrollbars even in touch mode. Fixes Issue #1172
2019-01-09 14:59:22 +01:00
47b3eac82b
Move UI.isSafari into core/util/browser.js
...
This is where the rest of these kinds of functions are.
2019-01-09 14:58:03 +01:00
3e835a5d37
Add Windows Key Feature
2019-01-08 06:57:12 -08:00
cffb42ee8f
Dont reset touch mouse button state for view-only
...
Fixes bug introduced in 61f93180c8
2018-11-01 11:22:19 +01:00
7449170cc8
Fix chinese translation of "Connect"
...
Thanks to Lyon Hu (@chnhyg) for finding the issue.
2018-11-01 11:07:58 +01:00
56c82ecd35
Czech translation
2018-10-19 13:01:39 +02:00
84586c0f17
Change copyright header ( #1138 )
...
* Change copyright header
This updates the copyright header to say "The noVNC Authors". People
who previously had copyright listings are now under the AUTHORS file.
2018-10-09 12:15:35 +02:00
9881899e7b
Merge branch 'style' of https://github.com/CendioOssman/noVNC
2018-09-17 13:54:04 +02:00
4c38179d15
Show dot when there is no visible cursor
...
Disabled by default.
2018-09-14 20:31:59 +05:00
2c5491e131
Enforce space after function name
2018-09-06 17:34:15 +02:00
426a8c927b
Enforce curly braces for control statements
2018-09-06 17:22:40 +02:00
4a16dc51a8
Enforce no trailing whitespace
2018-09-06 17:12:45 +02:00
35068204f4
Enforce keyword spacing
2018-09-06 17:08:19 +02:00
942a312779
Enforce object key spacing
2018-09-06 17:07:11 +02:00
e777765320
Enforce function names
2018-09-06 16:53:40 +02:00
6786fd8719
Enforce comma spacing
2018-09-06 16:43:31 +02:00
7b536961b2
Enforce indentation
2018-09-06 16:37:38 +02:00
a98881151f
Enforce brace style
2018-09-06 15:39:26 +02:00
e0d4e5a1c0
Move css rules for vnc_lite to the html
...
Easier to get an overview if it's all in one file.
2018-08-21 11:34:28 +02:00
c995c0863e
Revert "Handle if desktopName isn't set.."
...
This reverts commit 22000b93d5
2018-08-16 15:52:21 +02:00
22000b93d5
Handle if desktopName isn't set when connected
...
We can't guarantee that the desktopName event has been fired before the
connect event.
2018-08-16 13:33:35 +02:00
a793df3d6d
Merge pull request #1118 from novnc/disabledragwhilescale
...
Turn off view drag when scaling
2018-08-16 10:31:09 +02:00
4ddcc7537f
Merge enableDisableViewClip and updateViewClip
...
Makes the code easier to follow and makes sure that viewDrag is
properly disabled when scaling. Fixes #1110 .
2018-08-16 10:29:01 +02:00
3b7c47417e
Move dragThreshold definition to util/
...
In order to avoid multiple declarations that has to be updated in the
case of future updates.
2018-08-10 11:24:09 +02:00
2bbd15ccaf
Remove setViewDrag function
...
Unnecessary function only used in the toggle function above.
2018-07-30 10:46:41 +02:00
0b903af296
Remove unnecessary code
...
The enableDisableViewClip call in the fullscreen code didn't have any
effect and should have been removed when the special case for clipping
in IE and Safari fullscreen was removed in b18ef81
2018-07-30 10:29:35 +02:00
651c23ece3
Use fat arrow functions `const foo = () => { ... };` for callbacks
...
and any other function that is passed around and it's not a top level function
2018-07-12 19:06:57 +02:00
0e4808bf6f
Use ES6 classes
...
Always use the shorthand notation if the function is a method of an object or class `{ foo() { ... } }` or `class bar { foo() { ... } }`
unless it's a callback in which case you a fat arrow function should be used `{ cb: () => { ... } }`
2018-07-12 19:06:57 +02:00
11715f2092
Properly force clipping on touch
...
It shouldn't depend on what's saved in webstorage nor save the forced
value to webstorage.
Includes a revert of 0342e4f489
2018-06-07 15:58:31 +02:00
0342e4f489
Clipping should be enabled on touch
...
This was always the intention and the main use case of 'clipping'. It
seems like it got lost somewhere along the way.
2018-06-04 21:41:45 +02:00
2b5f94fa6a
Prefer const/let over var
2018-05-24 00:27:09 +03:00
8727f598c2
Add eslint and fix reported issues
2018-05-24 00:25:44 +03:00
024aca48e5
Update the noVNC translation part
...
fix the specification in zh_CN.po
2018-04-24 02:29:51 +08:00
dcee7c5e91
Add translation in zh_CN
...
Signed-off-by: CUI Wei <ghostplant@qq.com>
2018-04-07 06:16:00 -04:00
3328675b44
Clarify which Chinese translation we have
...
Chinese has several writing systems so we need to be clear which one
our translation covers. The one we currently have is for Traditional
Chinese so make sure it uses the matching language tag.
2018-04-03 14:51:12 +02:00
7d60e97cc9
Only show error stack if it is not empty
...
Parsing errors will not have a stack, and we don't want an empty
box in those cases.
2018-03-21 15:33:14 +01:00
06309160ee
Only disable animation when element is displayed
...
The transitionend event will not fire when display=none. This can
prevent the initial animation for hiding the controlbar in some cases.
2018-03-08 16:52:53 +01:00
8ad8f15cf6
Move writeSetting from updateSetting to initSetting
...
initSetting was the only place that supplied a 'value' to
updateSetting. So move it to clean up updateSetting.
2018-02-13 10:22:36 -05:00
e0750f9b2c
Use localstorage only to initialize settings map
...
This only reads from localstorage in order to initialize the settings
map. After initializaton, reads will return the value from the map.
When writing a value, the settings map and the local storage
are updated, unless the setting is a default value or derived from
the query string.
This has a few advantages:
1. Saved settings will not be overridden by settings specified in
the query string. This means a setting could be temporarily changed
using the query string, but once removed from the query string, the
setting would return back to what the user selected.
2. Default values will not be saved. If a user has always used
the default value for a setting, then they can move to a new version
with different defaults without clearing localstorage.
3. Changes made to localstorage in a session running in a different
window will not affect the settings in the current window (until
the page is refreshed).
Regarding eraseSetting:
It is possible that another tab could change the value, leading
to an unexpected value change in the tab that deletes. However,
this function is currently unused, so this will be evaluted if
and when it used.
2018-02-13 10:22:21 -05:00
37b4d13db8
Add Spanish and Turkish JSON files
2018-02-07 09:33:13 +01:00
7c332ad930
Don't crash on translation errors
...
A non-translated interface is better than no interface at all.
2018-02-07 09:23:45 +01:00
a4d51bd220
Merge pull request #1009 from juanjoDiaz/move_browser_checks
...
Move browser checks to browser.js
2018-02-01 10:33:28 -05:00
690d07baba
Add Turkish translation
2018-02-01 16:28:39 +01:00
096fcc4fa3
Merge pull request #1007 from juanjoDiaz/remove_jshints_comments
...
Remove jshint comments
2018-01-31 10:58:20 -05:00
9e1bd410aa
Remove jshint comments
2018-01-31 07:38:29 -08:00
7b73dbd4dd
Add Spanish translation
2018-01-30 19:17:55 -08:00
a003535941
Remove console statements
2018-01-30 08:53:38 -08:00
59ef29163e
Move browser checks to browser.js
2018-01-30 08:35:47 -08:00
d1aeb43551
Drop UI.rfb reference on all disconnects
...
We can be disconnected because of server reasons, not just because
someone clicked the disconnect button. Make sure we clean up the
reference and get a proper state in those cases as well.
2018-01-25 15:32:22 +01:00
86b9c473d1
Apply translations on input type submit
...
Commit 3729976Fixes #997
2018-01-24 13:00:48 +01:00
61f93180c8
Show/hide mouse button selector in updateViewOnly
...
Before this commit, the mouse button selector was hidden when the user
clicked it in view only..
2018-01-12 01:45:26 +01:00
f3763a010c
Update interface on view only toggle
...
Instead of waiting for updateVisualState() to be called in order for the
interface to update, we can call it directly in updateViewOnly(). This
is a better placement logically as well. Another upside of this is that
we can call updateVisualState() earlier on connect, that allows for the
"connecting"-throbber to be shown quicker.
2018-01-12 01:45:15 +01:00
03d829f170
Add Chinese (Traditional) translation
2018-01-10 00:59:27 +08:00
37c609359a
Fix view_only setting with autoconnect ( #985 )
...
updateVisualState() and updateViewOnly() requires an initiated UI.rfb reference, the calls in connect() was made too early.
2018-01-05 12:05:17 +01:00
a4822c3a86
Only connect if we don't have an rfb object
...
Each connection creates a new RFB object. Fixes #978 .
2017-12-14 12:16:45 +01:00
75e1161434
Throw away the reference to RFB on disconnect
2017-12-14 12:15:56 +01:00
7f1049c0ee
Make error more specific at connection failure
...
The UI does after all have enough information to determine if the
disconnection event was received before or after we were connected. If
we were never connected at all, we should adapt the error message to
reflect this.
2017-12-12 16:14:43 +01:00
4f4f62261a
Merge branch 'resize' of https://github.com/CendioOssman/noVNC
2017-12-11 16:48:54 +01:00
9b84f51685
Move resize handling in to RFB object
...
Makes the API simpler and makes it easier for other frontends to
get this functionality.
2017-12-06 11:29:57 +01:00
110a52c57d
update german translations
...
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-11-24 08:26:37 +01:00
2efa8a5a7c
Merge branch 'master' of https://github.com/mariuszjamro/noVNC
2017-11-23 15:22:50 +01:00
ceea51fa16
Update polish translations to match recent code changes
2017-11-21 19:56:43 +01:00
44db9c92e8
Greek translations revised
2017-11-17 21:51:41 +02:00
db46e36eb9
Merge pull request #950 from samhed/disconnectapi
...
Abstract information from RFB to the UI
2017-11-17 11:01:11 +01:00
7279364c9a
Move localization.js to app
...
Since it is no longer used in core. Also splits localization tests into
a separate file.
2017-11-14 15:36:12 +01:00
689580381c
Move UI.cancelReconnect() to related functions
2017-11-14 15:36:12 +01:00
d623a029d6
Dont overwrite more severe visible statuses
...
And only show the first error. This means that if UI.showStatus() is
called for a new error while one error is already showing, the new
error will not be shown. However, if a warning was showing and a new
error comes up, the warning will be overwritten.
2017-11-14 15:36:12 +01:00
d472f3f19e
Abstract RFB errors to avoid sending strings
...
The API allowed strings to be passed from the RFB module to the
application using the disconnect reason. This caused problems since
the application didn't have control over translations for these
strings.
Most of the information being passed using this string was very
technical and not helpful to the end user. One exception to this was
the security result information regarding for example authentication
failures. The protocol allows the VNC server to pass a string
directly to the user in the security result.
So the disconnect reason is replaced by a boolean saying if the
disconnection was clean or not. And for the security result information
from the server, a new event has been added.
2017-11-14 15:36:12 +01:00
ee5cae9fee
Replace updatestate event with connect
...
Instead of exposing all the internal connection states, the RFB module
will now only send events on connect and on disconnect. This makes it
simpler for the application and gets rid of the double events that were
being sent on disconnect (previously updatestate and disconnect).
2017-11-14 14:10:36 +01:00
b8dfb983df
Fix old focus on click references
...
The property was renamed when mergin the public API changes, but
a few references were overlooked.
2017-11-11 16:44:53 +01:00
8317524cda
Don't translate log messages
2017-11-11 02:12:45 +01:00
2592c24388
Translate user visible text
...
And make the log message a bit more detailed
2017-11-11 02:12:39 +01:00
5b20d338ce
Remove RFB.notification()
...
This interface was a band aid for poor design. The two cases where it
was used was replaced by logging.
2017-11-11 02:10:12 +01:00
a201bfc5eb
Merge branch 'api' of https://github.com/CendioOssman/noVNC
2017-11-10 14:19:05 +01:00
a80b5fdaaf
Prevent password form submission early
...
Otherwise it might reload the page if we run in to some kind of
error.
2017-11-09 13:14:16 +01:00
e89eef94aa
Use standard EventTarget interface for events
2017-11-09 13:14:16 +01:00
65fdfeae13
Remove unused options argument in onnotification event handler
2017-11-09 13:13:41 +01:00
2f4516f293
Integrate connect() in to constructor
...
An RFB object represents a single connection so it doesn't make
sense to have one without it trying to connect right away. Matches
the behaviour of other APIs, e.g. WebSocket.
2017-11-09 13:13:41 +01:00
002907d2ce
Remove "downscale only" mode
...
The normal scaling mode should be sufficient for most use cases, so
let's keep the interface simple.
2017-11-09 13:13:41 +01:00
8d1f0a3de8
Remove local cursor setting
...
We have no reason to disable this except for touch devices, which
we can handle without having a setting for it.
2017-11-09 13:13:41 +01:00
0460e5fdbe
Improve naming for viewport properties
2017-11-09 13:13:41 +01:00
a80aa41628
Change clippingDisplay() to a property
...
It fits much better as a property given that it only tells what the
current state of things are.
2017-11-09 13:13:41 +01:00
747b462337
Use standard JavaScript properties
...
Use normal properties with JavaScript setters and getters instead of
our homegrown stuff.
This also changes the properties to follow normal naming conventions.
2017-11-09 13:03:32 +01:00
3d7bb02036
Change some attributes to arguments
...
Some attributes are better suited as arguments, primarily because they
are associated with a specific method and cannot be changed later.
2017-11-09 12:52:05 +01:00
5b4e5d016e
Switch to URL for connect()
...
This is more in line with how other JavaScript APIs work.
2017-11-09 12:52:05 +01:00
832be2625b
Add resize as a capability
...
Makes the API more transparent than piggybacking on completion
of the first framebuffer update.
2017-11-09 12:51:15 +01:00
cd523e8f28
Make power API generic
...
Decouple it from XVP and make it a generic API.
2017-11-09 12:47:21 +01:00
430f00d6fe
Allow other credentials than just password
...
Makes the XVP authentication mechanism more general.
2017-11-09 12:45:05 +01:00
a1d547657f
Merge pull request #947 from samhed/lite_center
...
Properly center things in vnc_lite.html
2017-11-04 11:50:50 +01:00
1d6ff4a3e9
Improved focus handling on touch input field
...
The previous method of retaining focus didn't work reliably when
the RFB object tried to move the focus to the canvas. Add a setting
to control "focus on click" behaviour instead of letting them try
to fight it out.
2017-11-02 15:30:36 +01:00
ba9e1ecc94
Center canvas vertically as well in vnc_lite
...
Fixes issue #881 .
2017-11-01 09:23:46 +01:00
3c07dc51af
Add small padding to buttons in vnc_lite
2017-11-01 09:23:46 +01:00
4023a6e1c7
Properly center status message in vnc_lite
...
This gets rid of the table and uses a flexbox instead.
2017-11-01 09:23:46 +01:00
dc905e859f
Move styling from vnc_lite.html to css
...
This clears up some conflicting style attributes as well. HTML
inline-styling is prioritized above css styling.
2017-10-31 18:58:14 +01:00
8167e459bc
Remove unnecessary css rules for lite
2017-10-31 18:57:14 +01:00
178bf8ec97
Get rid of unnecessary noVNC_container in lite
...
If we want to keep vnc_lite simple, we shouldn't have unnecessary
elements. All aspects of the container could be moved up a step in the
hierarchy.
2017-10-31 16:06:57 +01:00
082bc6b478
Use more subtle colors for warn and error in lite
...
The clear red and yellow colors used before does not match well with the
rest of noVNC's color scheme.
2017-10-30 15:31:56 +01:00
0bc4e4eb8a
Remove prefixed versions of linear-gradient
...
Other parts of noVNC have significantly higher requirements than this.
All supported browsers will be able to handle the real linear-gradient.
2017-10-30 15:29:19 +01:00
f976b5500e
Hide mouse object from RFB callers
2017-10-27 13:58:12 +02:00
b9854a5ca5
Hide display object from RFB callers
2017-10-27 13:58:11 +02:00
4c11755ce7
Merge branch 'focus' of https://github.com/CendioOssman/noVNC
2017-10-18 15:12:46 +02:00
867daa98af
Restore handling of key events for virtual keyboard
...
We broke handling of keydown/keyup when we moved the focus to the
canvas, as events from our input element would then no longer be
caught when they bubbled up to the document object (where we
previously caught events).
Restore the previous behaviour in a cleaner manner by creating a
second Keyboard object to handle this extra input variant.
2017-10-18 15:08:33 +02:00
06fe4a3e1b
Make sure control bar stays visible on Tab
...
Avoid the deprecated keypress event in favour of the keydown event.
It has the benefit of triggering for all keys, not just those that
produce symbols.
2017-10-18 15:08:33 +02:00
2545a6c12e
Stop giving host field default focus
...
It's a field that isn't shown by default and rarely changed.
2017-10-18 15:08:33 +02:00
e36f95868a
Add focus state for control bar buttons
...
The focus can now move to the canvas so it is no longer a source of
confusion. It is also important to indicate that they have focus now
that we actually respect it.
2017-10-18 15:08:29 +02:00
2afda54456
Only grab key events on canvas
...
Give the canvas proper focus handling. This avoids messy logic that
needs to disable and enable event handling when we want to interact
with other UI elements.
It also makes sure we can properly inhibit the browser from triggering
local actions on key presses.
2017-10-18 15:07:17 +02:00
a342ed703f
Check if <audio>.play() returns a promise
...
It doesn't always. IE and Edge crashed when trying to play the bell due
to this. Fixes #929 .
2017-10-17 12:16:38 +02:00
2e735160bf
Save pw for reconnections when using query params
2017-10-16 11:06:40 +02:00
93358b2eed
Remove 'fuzzy' marks that were mistakenly left
...
During the last round of translations a few fuzzy markings was not
removed even though the string was updated. This can happen when the
translators edit the .po-file manually. Fuzzy markings result in that
the strings do not get included into the generated .json files.
2017-10-11 16:20:25 +02:00
061488f8f1
Fix Dutch translation for "Reconnecting..."
2017-10-11 16:19:22 +02:00
76fa34a635
Update .json for Dutch and Swedish translations
2017-10-11 10:52:48 +02:00
61c37685f6
Merge pull request #920 from flumm/german
...
updated german translations
2017-10-11 10:01:34 +02:00
b420b966a3
updated german translations
...
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-11 07:09:50 +00:00
e4791eac9d
Merge pull request #922 from kosmasgiannis/greek
...
Update Greek translation
2017-10-11 09:04:13 +02:00
4e2de902e7
Update Greek translation
2017-10-11 09:52:26 +03:00
a0513c87c7
Add polish translation
2017-10-10 15:37:31 +02:00
9e314b44e2
Merge pull request #913 from kosmasgiannis/missing_quote
...
Add missing quotes
2017-10-06 23:03:55 +02:00
067accb8d9
autoconnect variable was used before it was defined.
2017-10-06 22:53:52 +03:00
eb533b2b00
Add missing quotes
2017-10-06 14:15:22 +03:00
d593483ecc
Make port optional in ui.js as well
...
It is optional in the RFB object since 1a50f68
2017-10-06 10:07:47 +02:00
a49ade5fa0
Rename setting_clip to setting_view_clip
...
Clarifies the purpose of the setting in order to avoid mix ups with
clipboard related things.
2017-09-07 09:01:52 +02:00
409b7fb97e
Remove unused variable
...
The use of this variable was removed in b18ef8162e
2017-09-07 09:00:15 +02:00
d1a1e0e529
Adjust scaling when session size changes
...
Session size changes can be initiated from the server, and not just
from the client. Make sure we update the scaling when this happens.
2017-08-16 11:00:04 +02:00
74a29f3ff5
Make sure the control bar hint is centered
...
Fixed positioned flex boxes are not positioned correctly in Safari. Add
the normal top 50% translate -50% method.
Fixes issue #848 .
2017-07-26 17:06:27 +02:00
637a282be5
Scroll error stack trace
...
Make sure we get the stack trace without distortions by wrapping, or
cropping because it flows out of the screen.
2017-06-15 13:49:27 +02:00
858ea4a774
Avoid use of 'let' and 'const'
...
They are not supported on older browsers, e.g. iOS 9.
2017-06-02 15:41:37 +02:00
bbc1648c7a
Add hint that the control bar can be moved
...
The control bar can be dragged to the other side, this isn't obvious
however. This adds a hint on the opposite side in the form of a subtle
glowing half-ellipse.
2017-05-29 15:57:13 +02:00
c23665dd82
Clear the password input field
...
If a user disconnects but leaves the browser tab open, the password
input field would still contain the password for future connections.
We now clear the input field after reading the password into memory.
2017-05-20 19:05:46 +02:00
b0061a3c49
Revert "Remove shadow from logo"
...
This reverts commit 7c44f86dcd
2017-05-15 14:57:33 +02:00
55988e7aec
Fix bootstart of input field
...
It wasn't working properly anymore because it expected to be triggered
by the "load". But we now register that event listener long after the
"load" event has already fired.
2017-05-15 14:42:28 +02:00
c464f47e96
Remove trailing whitespace
2017-05-13 01:56:24 +02:00
7c44f86dcd
Remove shadow from logo
2017-05-13 01:43:02 +02:00
d4fc89d8b9
Catch errors for when we can't play bell
...
Many browsers, for example Chrome on Android will not allow audio to
play unless it's initiated from a user action. It is not reasonable to
display an error for this. Fixes issue #821 .
2017-05-12 12:52:05 +02:00
83391ffc38
Rename vnc_auto to vnc_lite
2017-05-12 08:57:23 +02:00
7ca650b73d
Add missing semi colon
2017-05-12 08:48:41 +02:00
333ad45c70
Don't capture touch events
...
They are implicitly captured anyway, and we get problems if we try
to explicitly capture them.
2017-05-11 13:34:43 +02:00
8a0cbd742b
Update German translation
...
From Pull Request #771 .
2017-05-09 11:49:57 +02:00
26586b9ddf
Remove colour map support
...
It was broken and unused. Remove it so we can simplify the code.
2017-05-04 15:13:33 +02:00
545442afc3
Merge branch 'keyboard' of https://github.com/CendioOssman/noVNC
2017-05-04 12:18:55 +02:00
5a3e9d3da8
Error.error can be null in some cases
2017-05-04 12:13:48 +02:00
94f5cf05f3
Send keyboard events from single place
...
This makes it easier to handle any needed variations, like different
types of messages.
2017-05-04 12:13:47 +02:00
41c958d450
Properly restore the default style
...
Setting a style to null does restore it in FF, Chrome, Safari and Edge.
But it does not work in Internet Explorer. The proper way to restore to
default values is to set it to the empty string. This works in all
browsers. Fixes issue #808 .
2017-04-11 10:57:21 +02:00
732233eda0
Handle partial error location information
...
We might not get line or column number, but the file is still
useful information.
2017-03-27 16:29:38 +02:00
5da03103a3
ErrorEvent.error isn't always set
...
It's not just a matter of the browser lacking support.
2017-03-27 16:29:38 +02:00
13c558e3a0
Limit fallback error width to window width
...
Change the layout a bit to make sure the entire message can be read.
2017-03-27 16:29:38 +02:00
c361080be8
Use monospace font for unhandled errors
...
The browsers uses crude layout formatting that expects this.
2017-03-27 16:29:38 +02:00
524d67f283
Remove keysym names from keysymdef.js
...
They were incomplete and turned off in most cases so they served
little use besides adding complexity.
2017-03-24 11:16:53 +01:00
7e19216368
Define an initial shadow for spinner
...
IE and Edge refuse to animate attributes that weren't present in
the static definition.
2017-03-23 17:53:09 +01:00
adfc9d3f54
Move error handler into separate file
...
This commit moves the global error handler into a separate file,
so that it can catch module loading errors.
This also adds support for properly displaying error messages with
newlines in them (since the module loader may throw those)
2017-03-21 17:39:07 -04:00
e6a8eb15ca
Only apply settings with an RFB object
...
We should only apply settings if we have an RFB object available.
Some of the settings handlers didn't respect this, but do now.
2017-03-21 17:39:07 -04:00
e25f9c4010
Use transition animation while loading
...
This shows the transition animation while loading, so users can see
something is going on.
2017-03-21 17:39:07 -04:00
6d6f0db0da
Refactor ES6 module structure/split up Util
...
This commit restructures many of the ES6 modules, splitting them
up to actual export multiple functions instead of a single object.
It also splits up Util into multiple sub-modules, to make it easier
to maintain.
Finally, localisation is renamed to localization.
2017-03-21 17:39:05 -04:00
6e744119f8
Remove WebUtil.load_scripts
...
The only remaining user of WebUtil.load_scripts was for loading
localisation. Instead, we now load the localization information
over XHR as a JSON blob.
2017-03-07 11:11:29 -05:00
2a7c6d20ab
Load translations over XHR
...
This commit causes translations to be loaded over XHR instead of
the import system.
2017-03-07 11:11:29 -05:00
bc35b1d27e
Remove WebUtil.dirObj
...
`WebUtil.dirObj` wasn't being used anywhere, so this removes it.
2017-03-07 11:11:29 -05:00
3ae0bb0968
Uncomment ES6 module syntax
...
This removes the special comment part of the ES6 module syntax,
opting to enable ES6 module syntax by default.
It also appends `.js` to all import paths to better support in-browser
loading.
2017-02-26 16:30:37 -05:00
d55e454582
Fix typos in imports and i18n
...
`app/ui.js` had an incorrect import path which caused issues
when using the ES6 and/or CommonJS builds of noVNC.
`core/util.js` had a non-strict-compatible declaration of a variable
without a `let` or `var` (it now uses `let`).
This fixes both issues.
2017-02-26 16:30:37 -05:00
b56d975248
Merge branch 'settingswhileconnected' of https://github.com/samhed/noVNC
...
Closes pull request #778
2017-02-24 15:42:27 +01:00
7a005a1b18
Merge branch 'disableLabels' of https://github.com/samhed/noVNC
...
Closes pull request #776
2017-02-24 15:13:09 +01:00
6e8a8c8df1
Remove 512x512 icon
...
It is not a launcher icon, but rather used for display on Google
Play. As such it is not needed and removing it mitigates the issue
of some buggy browsers downloading each and every listed icon.
2017-02-23 16:29:16 +01:00
24584cca89
Disable labels for settings as well
...
Makes the settings UI easier to read.
2017-02-21 11:58:03 +01:00
6c857dc50c
Set input type number for port & reconnect_delay
2017-02-21 11:57:24 +01:00
fb49f91b00
Allow local cursor to be changed while connected
2017-02-19 01:53:41 +01:00
3a535adab0
Allow auto reconnect to be changed while connected
2017-02-19 01:53:41 +01:00
ef1e8bab22
Allow view_only to be changed while connected
2017-02-19 01:53:41 +01:00
0298305e80
Allow clipping to be changed while connected
2017-02-18 16:30:35 +01:00
e677b66cc7
Proper workaround for Chrome's scrollbar bug
...
Avoid applying this workaround more than necessary. Also comment a
bit more why this hack is needed.
2017-02-16 16:28:55 +01:00
b56772ec43
Update drag button at right time
...
It needs to update whenever the viewport or clipping changes, so
let's make sure that actually happens and not trigger on mildly
related events.
2017-02-16 16:07:55 +01:00
6bfd9dc96f
Update clipping before changing scaling
...
The scaling is relative the current viewport, so we need to make
sure it is correct before changing the scale setting.
2017-02-16 16:07:55 +01:00
5f38376adb
Don't change stored setting when "forcing"
...
Don't overwrite the user's configured choice. Instead ignore
settings when they cannot be respected.
2017-02-16 16:07:55 +01:00
631428d966
Fix status class for IE
...
IE apparently doesn't support removing several class specifiers at
once, so switch to several calls.
2017-02-16 16:07:55 +01:00
b18ef8162e
Allow scroll bars on Safari and IE
...
The previous problems were because we were scrolling the wrong element,
so we can enable this feature now.
2017-02-16 16:07:40 +01:00
f3b7727535
Fix canvas size on IE
2017-02-16 14:48:34 +01:00
280676c7e9
Properly encapsulate the scale in Display
...
Other parts of the code shouldn't have to care about this. Let Display
convert between canvas coordinates and framebuffer coordinates.
2017-02-16 14:00:39 +01:00
bd7d89e7cc
Fix resize on Chrome
...
Chrome sucks at calculating the size and gets confused due to the
scrollbars. Hide the scroll bars while resizing.
2017-02-10 16:39:18 +01:00
86d15a4929
Use setCapture() polyfill everywhere
...
This makes sure we get consistent behaviour across all browsers.
2017-02-09 15:51:22 +01:00
b345859ed6
More aggressive retaining of focus
...
Try to keep the virtual keyboard up even more. Only release focus
when it is absolutely necessary.
2017-02-09 14:20:37 +01:00
3f48c7017d
Tweak spinner appearence
...
Change the look of the "busy" spinner a bit. It's mostly used for
connection stuff, so give it a more data flow feel. Also bling it
up a bit with some fading. Perty sells. :)
2017-02-07 16:09:10 +01:00
84b05d24b0
Allow submitting the password from the input field
2017-02-03 13:19:15 +01:00
648c83984c
Scroll correct element
...
The element we want scrolling around is noVNC_screen, not the entire
window. This also allows us to compute the screen size without
fiddling the scrollbars on and off.
2017-02-03 13:17:43 +01:00
f6299e0aed
Move keyboard style in CSS
...
Put it so it matches where it is in the HTML.
2017-02-03 11:44:24 +01:00
9865432a02
Center canvas (again)
...
The previous attempt could leave parts of the canvas outside the
document, making it impossible to reach. Use a safer method as
recommended by Mozilla.
2017-02-03 11:43:17 +01:00
623b1b7d96
Allow resize setting to be changed while connected
...
There is no reason to why this shouldn't be possible.
2017-01-27 16:22:15 +01:00
59387b34ea
Separate init functions from event handling setup
...
Adds a new section for all functions that add event handlers.
2017-01-27 16:20:53 +01:00
3fdc69ceda
Rename function for adding resize handlers
...
Moves the one handler for the status out of the function as well. It
didn't fit in with the function's old name either.
2017-01-27 16:20:53 +01:00
b3d91b78e1
Rename and move init function for fullscreen
2017-01-27 16:20:53 +01:00
dceda58642
Save settings immediately
...
Retire the old settingsApply. This also allows UI logic to check the
state of things using the settings instead of having to look at the
values of HTML elements (we couldn't be sure if the changes were
applied yet or not).
2017-01-27 16:20:33 +01:00
0b09e9cb6f
Remove unused toggleConnectPanel function
2017-01-24 14:37:14 +01:00
aa90547519
Add UI wrapper for Webutil.init_logging
2017-01-24 14:36:19 +01:00
394ad22be9
Merge branch 'add-reconnect' of https://github.com/fd0/noVNC
2017-01-23 13:47:57 +01:00
044d54ed62
Add reconnect option
...
Add an option to automatically reconnect after a delay when the
connection is closed.
Closes #746
2017-01-23 11:42:41 +01:00
a7619faf18
Set pointer cursor for status bar
...
It can be dismissed by clicking on it, so hint this by setting the
pointer cursor type.
2017-01-20 10:11:16 +01:00
413ea87741
Fix global error handler
...
It stopped working when we switched to textContent as it relies
on being able to add new HTML elements. Do things properly by
adding new elements via createElement().
2017-01-18 15:59:31 +01:00
6048299a13
Use textContent instead of innerHTML
...
Previously, setting `innerHTML` was used to display the statuses. These
could include content communicated from the remote VNC server, allowing
the remove VNC server to inject HTML into the noVNC page.
This commit switches all uses of `innerHTML` to use `textContent`, which
is not vulnerable to the HTML injection.
2017-01-12 14:47:36 -05:00
813458923e
Avoid wrapping labels
2017-01-04 15:05:59 +01:00
cac935ffc2
Clean up z index ordering
...
We have enough layers now that we need to have some system for this.
E.g. make sure that dialogs during connect show up in front of the
blocking transition layer.
2017-01-04 15:05:59 +01:00
b3c932c386
Make connect button more prominent
...
It's generally the only thing the user needs to click on, so make
sure it clearly stands out.
2017-01-04 15:05:58 +01:00
512d3605ad
Remove connect dialog
...
It only contained a password field, which might not be needed, and
is handled by a separate dialog if it is.
2017-01-04 15:05:01 +01:00
ef3e12b595
Remove vendor prefix from border-radius
...
It's been standardised for quite some time, so remove the extra
noise in the CSS.
2017-01-04 15:05:01 +01:00
575f69832d
Group WebSocket settings together
...
It was easy to confuse them as being VNC settings, so keep them all
under one group.
2017-01-04 15:05:01 +01:00
340d9d66cc
Remove alternative style sheets
...
Anyone with basic knowledge of CSS will easily figure out how to
customise the appearance of the UI, so remove the burden of having
to maintain these extra style sheets.
2017-01-04 15:05:01 +01:00
58fc267b2b
Remove unused token setting
2017-01-04 15:05:01 +01:00
47fbdced45
Center canvas vertically as well
2017-01-04 15:05:01 +01:00
8f2ca5feaa
Black out background when connected
2017-01-04 15:04:51 +01:00
c01b2f0259
Merge pull request #699 from CendioOssman/double
...
Display double buffering
2016-12-13 12:42:22 +01:00
adf345fdc4
Clean up viewport handling
...
Make sure the viewport is properly updated when necessary, on respects
given restrictions.
2016-12-09 09:20:50 +01:00
3f781f2aa3
Remove max dimension handling
...
The viewport handling is now a lot clearer, so simply limit the size
of the viewport in the caller rather than having this extra layer
of checks.
2016-12-09 09:20:50 +01:00
18d21e3621
Update all state on session size change
2016-12-09 09:20:50 +01:00
a8cc32d8b9
Merge pull request #725 from CendioOssman/rightbar
...
Allow control bar to be moved to the right side
2016-11-29 13:23:02 +01:00
d062074b5a
Clear UI.connected state variable right away
...
Keeping it set for the disconnecting state was causing an issue where
the controlbar could be hidden without any way to open it, when a
session disconnects too quickly.
2016-11-28 12:36:29 +01:00
d8ff7c9ed6
Further fixes for fallback error handler
...
Layout improvements as well as an check for ErrorEvent.error as it is
not standardized.
2016-11-28 12:33:42 +01:00
38d8cfdf83
Fix fallback error handling
...
Start using the correct API for window.addEventListener('error',..).
Unlike when using onerror, the handler function gets an event.
2016-11-28 10:02:13 +01:00
cf348b7892
Remember control bar position
2016-11-26 15:26:28 +01:00
8ee432f1db
Allow control bar to be moved to the right side
2016-11-26 15:13:33 +01:00
de315d6216
Touching the handle should keep the control bar visible
...
Calling stopPropagation() was causing the normal event listeners
to never get the proper events.
2016-11-24 17:03:47 +01:00
dd085b40a9
Update Greek translation
2016-11-24 12:18:59 +02:00
f5bf2d84ef
Merge pull request #718 from ossman/po
...
Use gettext .po files, and translate everything
2016-11-22 21:02:13 +01:00
1983baf5bf
Fix link tagname
2016-11-21 13:43:02 +01:00
79b05f9f19
Update Swedish translation
2016-11-19 13:23:00 +01:00
edffd9e2f8
Also translate HTML elements
2016-11-19 13:23:00 +01:00
3cdc603aa4
Use gettext .po files for translations
...
This allows the same workflow as most other projects for translations.
2016-11-17 20:42:08 +01:00
45729def6d
Restore translations for some strings
...
We lost the translation calls for a couple of strings in one of
the clenaups.
2016-11-17 19:58:10 +01:00
f28e248d3f
Use _() as shorthand for translations
...
Used commonly when gettext is used for translations. Avoids cluttering
the code.
2016-11-17 19:58:10 +01:00
d24de750b1
Add fallback handling for uncought errors
2016-11-10 14:33:23 +01:00
b85a13de69
Merge pull request #689 from ossman/keysym
...
Don't send Unicode as keysym
2016-11-10 09:36:43 +01:00
f3d25df048
Merge pull request #711 from CendioOssman/spinners
...
Blocking transition screen when connecting/disconnecting
2016-11-10 08:47:23 +01:00
8d710e8b18
Blocking transition screen when connecting/disconnecting
2016-11-08 14:54:48 +01:00
37ebc5c14e
Merge pull request #697 from CendioOssman/keyboard
...
Better method to keep focus on virtual keyboard
2016-11-08 12:28:23 +01:00
b98b2f813d
Added Greek translation
2016-10-28 21:22:25 +03:00
a4fc1fa586
Add Swedish translation
2016-10-28 15:41:08 +02:00
fdb02f8570
Always translate literals instead of variables
...
Makes it much easier to find what needs to be translated.
2016-10-28 15:41:08 +02:00
91e41150f0
Don't translate unexpected errors
2016-10-28 15:41:00 +02:00
e848790194
Replace tab with spaces
2016-10-28 15:23:51 +02:00
f55e041908
Add newlines at the end of the translation files
2016-10-28 14:37:40 +02:00
a93cda3a36
Move app-specific location of language files
...
The core directory should only contain core API code that isn't
specific to an application.
2016-10-28 14:30:14 +02:00
5af39a878a
Added localization to statusbar
2016-10-28 12:40:28 +02:00
b1358a1f2e
Always disable forced touch gestures
...
Don't only disable these for the canvas, disable for the entire page.
There were issues where the control bar handle couldn't be moved on
IE and Edge on Microsoft Surface devices due to these "touch-actions".
2016-10-26 15:43:43 +02:00
2e5cae1b23
Update comment for screenSize()
...
The explanation was outdated.
2016-10-24 14:26:53 +02:00
1a15f22905
Remove unnecessary anonymous function
...
addEventListener can handle multiple assigned events, no need for a
wrapping function.
2016-10-24 14:08:53 +02:00
4770b0c311
Typo fix for last commit
...
Commit 7d20158b4b
2016-10-24 13:59:35 +02:00
7d20158b4b
Add missing log output for UI-specific errors
...
Some UI errors and one warning didn't write to the log. We want all
errors to be logged.
2016-10-24 13:36:05 +02:00
daca5b1727
Reformat lines to avoid line-breaks
2016-10-24 13:35:06 +02:00
9b3d363d07
Merge pull request #686 from CendioOssman/favicon
...
Clean up page icons ("favicon")
2016-10-24 12:09:58 +02:00
ffcadf9507
Better method to keep focus on virtual keyboard
...
This prevents the focus being lost rather than trying to restore it
at various places.
2016-10-21 16:27:43 +02:00
ac33960368
Merge pull request #649 from kanaka/dontgrabinviewonly
...
Fix view only
2016-10-20 01:04:14 +02:00
b0f7466ad4
Merge pull request #687 from CendioOssman/info
...
Improve info and error icons
2016-10-20 01:02:55 +02:00
5826ab6f6a
Merge pull request #650 from kanaka/touchdetect
...
New way of detecting touch
2016-10-20 00:18:32 +02:00
d6cb04aa6b
Disable forced touch gestures on IE and Edge
...
Fixes issue discussed in #613
2016-10-20 00:13:29 +02:00
8473635a09
Fix typo that caused clipping by default on IE
...
Typo from commit a6357e8276
2016-10-19 15:33:06 +02:00
Baw_Appie
Samuel Mannehed
Sebastian Safari
Petr
Solly Ross
Pierre Ossman
Alexander E. Patrakov
Juanjo Diaz
Zhou Chaolin
CUI Wei
Andrew Webster
Ömer ÇAKMAK
Juanjo Diaz
Peter Dave Hello
Deni42
Dominik Csapak
Mariusz Jamro
Giannis Kosmas
David Gnedt
Solly Ross
Alexander Neumann
Pierre Ossman
Loek Janssen