Set BasicAuth in http.go only if username and password are not empty (#914) #921

Open

github-actions[bot] wants to merge 1 commits from cherry-pick-2663196279-release-1.0 into release-1.0

Author SHA1 Message Date

Author	SHA1	Message	Date
Calin	ea645bc456	Set BasicAuth in http.go only if username and password are not empty (#914 ) This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe. (cherry picked from commit `9db5de109c`)	2022-07-13 11:50:49 +00:00

Calin

ea645bc456

Set BasicAuth in http.go only if username and password are not empty (#914 )

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt
is unsuccessful, any subsequent requests after calling the `CredentialsCallback`
will attempt to read/write on a closed pipe.

(cherry picked from commit 9db5de109c)

2022-07-13 11:50:49 +00:00

Set BasicAuth in http.go only if username and password are not empty (#914) #921

1 Commits