Set BasicAuth in http.go only if username and password are not empty (#914) #921

2022-07-13T06:50:51-05:00

github-actions[bot] commented

2022-07-13 06:50:51 -05:00

(Migrated from github.com)

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt
is unsuccessful, any subsequent requests after calling the CredentialsCallback
will attempt to read/write on a closed pipe.

(cherry picked from commit 9db5de109c)

This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe. (cherry picked from commit 9db5de109c166aa802b85cfae2dced3c4728a00d)

This pull request can be merged automatically.

You are not authorized to merge this pull request.

You can also view command line instructions.