Set BasicAuth in http.go only if username and password are not empty #914

2022-04-20T22:44:48-05:00

clns commented

2022-04-20 22:44:48 -05:00

(Migrated from github.com)

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt
is unsuccessful, any subsequent requests after calling the CredentialsCallback
will attempt to read/write on a closed pipe.

This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe.

lhchavez (Migrated from github.com) approved these changes 2022-07-13 06:50:26 -05:00

Sign in to join this conversation.

No reviewers

lhchavez