c01eb5e74d
Drop support for Internet Explorer
2020-10-15 18:53:51 +02:00
c1281b136d
Add workaround for Firefox PNG rounding bug
2020-09-28 12:24:56 +02:00
b91b1e8edc
Handle empty rects in RAW decoder as well
...
It was overlooked in the previous commit because we couldn't feed
empty data messages through the test framework.
2020-09-07 12:58:52 +02:00
3037eb16f7
Ignore recording variables in our linter
2020-09-05 11:08:16 +02:00
3762300399
Approximate comparison of JPEG result
...
The browsers have various rounding errors so we need to compare the
output data only approximately and not exactly.
2020-09-04 16:48:44 +02:00
113fa27ebc
Handle empty rects from the server
...
These are very pointless for the server to send, but not a violation of
the protocol so we need to be able to handle them. We've seen this
happen in real world scenarios a few times.
2020-09-04 16:16:44 +02:00
0630352e19
Merge branch 'rgbx' of https://github.com/CendioOssman/noVNC
2020-09-04 13:40:23 +02:00
7ce1b071ec
Fix call to _recvMessage()
...
Missed to rename this one in commit ea858bfa27
2020-09-04 10:40:42 +02:00
ecdd075672
Fix names of recording variables
...
The name of these variables must match how they were set when the
recording was created.
Reverts part of 95632e413d
2020-09-04 10:40:37 +02:00
794b06b2bd
Don't detach handler if it doesn't exist
...
If the beforeEach() step has been skipped then there won't be anything
here to detach.
2020-06-25 14:45:58 +02:00
50cde2faab
Move mouse event handling to RFB class
...
Move the last remaining bits to the RFB class to keep things simple, as
the Mouse class no longer provides any real value.
2020-06-12 14:36:10 +02:00
88589a44f7
Increase wheel step threshold
...
The previous value made the detection too sensitive and it was very
difficult to scroll precisely. A value of 50 pixels should give similar
behaviour to systems that don't do fine grained scrolling.
2020-06-12 09:18:46 +02:00
f84bc57bda
Move wheel event handling to RFB class
...
The Mouse class does very little now so it mostly just obfuscate things.
Move everything directly in to the RFB class instead.
2020-06-12 09:18:46 +02:00
4a87038080
Remove very legacy mouse event handling
...
This is only needed on such ancient versions of Internet Explorer that
it wouldn't satisfy our other requirements anyway.
2020-06-12 09:18:46 +02:00
77c32d164d
Remove delayed wheel timer
...
This isn't really expected behaviour from a user, i.e. that an extremely
small wheel movement still gives a large scroll event in the remote application.
2020-06-12 09:18:46 +02:00
8be924c9d9
Add touch gestures for mouse emulation
...
Add several single and multitouch gestures to simulate various mouse
actions that would otherwise be impossible to perform.
This replaces the old system where you could select which mouse button
a single touch would generate.
2020-06-12 09:18:46 +02:00
440ec8a0b6
Start fake test clock at real clock time
...
Some code relies on the clock having a somewhat sane value, so let's not
start at 0.
2020-06-11 16:50:08 +02:00
0a6aec3578
Avoid printing the Websock buffer in tests
...
It takes forever and just messes up the output.
2020-06-11 16:50:08 +02:00
6a19390baa
Switch to RGBx pixel format
...
This is what the browser wants so it avoids having to spend time
converting everything. Unfortunately it usually means the server instead
needs to convert it for us, but we assume it has more power than we do.
2020-06-08 07:57:17 +02:00
f5b5767c98
Standardise on a single blit function
...
Keep everything simpler by always blitting in the same pixel format.
It's up to the decoders to convert if they need to.
2020-06-08 07:53:41 +02:00
18a68dfac1
Test correct handling of alpha
...
The forth byte of a pixel is undefined in most encodings, so make sure
the decoders don't leak that through as an alpha channel.
2020-06-08 07:53:16 +02:00
15cfa13563
Add tests for the Tight decoders
2020-06-08 07:48:20 +02:00
111225fa41
Split decoder tests to separate files
2020-06-08 07:46:42 +02:00
224f95f997
Move tile handling to Hextile decoder
...
It is only used there so no need for it to be in the general
Display class.
2020-06-06 13:23:05 +02:00
f694c32fd5
Merge branch 'camelcase' of https://github.com/samhed/noVNC
2020-06-05 09:41:25 +02:00
cfb824ed03
Add camelCase rule to eslint
2020-05-31 23:37:29 +02:00
a7fe079f81
Standardize on camelCase in Logging
2020-05-31 23:37:29 +02:00
ea858bfa27
Standardize on camelCase in Websock
2020-05-31 23:21:35 +02:00
5d570207f7
Standardize on camelCase in Display
2020-05-31 23:21:35 +02:00
95632e413d
Standardize on camelCase in tests
2020-05-31 23:21:35 +02:00
80187d158c
Standardize on camelCase in RFB
2020-05-31 23:21:35 +02:00
dff4fefa3c
Remove unused properties and variables
...
The code that used these were removed in the following commits:
* 9ff86fb718bb6965f2e6490d471c53
2020-05-31 22:49:41 +02:00
150596be83
Properly limit mouse moves to once every 17 ms
...
Previous attempt in c958269#1402
2020-05-31 00:53:15 +02:00
11a22dbf0c
Stop send mouse clicks while dragging in view only
2020-05-31 00:53:15 +02:00
006743857b
Standardize on camelCase for functions in RFB
2020-05-31 00:53:15 +02:00
e7dec5270e
Standardize on camelCase for variables in RFB
2020-05-31 00:53:15 +02:00
479d8cefd1
Add ability to set compression level
...
Fixes github issue #1382 .
2020-05-01 20:47:36 +02:00
a672168d4d
Add unit tests for mouse move limit
2020-05-01 20:37:48 +02:00
efd1f8a4f2
adds qualityLevel property to RFB class for updating JPEG quality level encoding on the fly
2020-02-28 13:14:19 +01:00
ceb8ef4ec1
Fix crash with too large clipboard data
...
If too much text is copied in the session, String.fromCharCode.apply()
would crash in Safari on macOS and Chrome on Linux. This commit fixes
this issue by avoiding apply() altogether. Also added test to cover this
issue.
2020-02-21 09:39:31 +01:00
384232fb56
Merge branch 'clipboard_unicode' of https://github.com/CendioNiko/noVNC
2020-02-18 09:46:10 +01:00
f73fdc3ed3
Add extended clipboard Pseudo-Encoding
...
Add extended clipboard pseudo-encoding to allow the use of unicode
characters in the clipboard.
2020-02-18 09:32:36 +01:00
9575ded8da
Add util for unsigned and signed int. conversion
...
Will be used in later commit in extended clipboard handling.
2020-02-17 11:29:40 +01:00
f52e979082
Add deflator helper class for deflating data
...
Wraps pako's deflate for easier usage.
2020-02-17 11:29:29 +01:00
3b562e8a0f
Make clipBoardPasteFrom() test more specific
...
Don't rely on clientCutText() to test clipboardPasteFrom().
2020-02-17 09:34:44 +01:00
71bb3fdfa5
Fix color channels for VMware alpha cursors
...
The red and blue channels were incorrectly swapped.
2020-01-30 11:48:17 +01:00
eb05b45b70
Make afterEach() hooks work when skipping tests
...
Mocha will now run afterEach() hooks when tests are skipped, so we need
to make them more robust against things being partially set up.
2020-01-23 14:27:37 +01:00
64fdd336a0
Simplify encodeUTF8/decodeUTF8 unittests
2020-01-03 10:41:34 +01:00
80c72e92d2
Add unit tests for encodeUTF8 and decodeUTF8
2020-01-02 17:29:41 +01:00
c4eb4ddcfe
Handle slow loading of images
...
Internet Explorer seems to flag images as loaded prematurely, which
can result in rendering bugs. We can detect this by looking at the
dimensions though.
2019-12-23 15:52:54 +01:00
a6304f91d0
Fix missing caps lock events on iOS
...
Caps Lock on iOS only trigged key release or key press events.
When it's clicked it would only send keydown, and next time
it would only send keyup and so on. It should send both a key press
and a key release.
Also added the unit tests for macOS since those were missing.
Co-Authored-By: Alex Tanskanen <aleta@cendio.se>
2019-11-07 16:44:26 +01:00
ccb511a527
Handle missing Shift events on Windows
...
This is a bug in the OS that leaks through to the browsers. We need
to fake a Shift release here to avoid Shift getting stuck in the remote
session.
2019-11-04 10:17:45 +01:00
3388c92c7f
Send NumLock on macOS, even though the key is Clear
...
There is no obvious choice what works best here, but this is what
TigerVNC has been doing for years without complaints. Let's follow
them until we get reports that this doesn't work well.
2019-11-01 13:13:35 +01:00
5736ea0bd5
Fix AltGr for a few more keys in IE and Edge
...
Some keys apparently send 'Unidentified' rather than an unshifted value.
Make sure those are also handled. Examples are \ and | on a Swedish
keyboard.
2019-11-01 09:59:02 +01:00
8c51e9a8a2
Revert iOS keyup workaround
...
It seems Apple has fixed their buggy keyup events, so remove the
workaround and allow keys to be kept pressed again.
This is a revert of 9e99ce126c
2019-10-31 15:36:40 +01:00
9d956e9198
Handle broken numpad delete key in Chrome
2019-10-31 14:51:36 +01:00
758399050d
Try to handle Meta key properly
...
The standards have unfortunatly caused some confusion between the Windows
key and the original Meta key. Try to handle the common case sanely at least.
2019-10-31 14:12:58 +01:00
3055307d3d
Merge pull request #1299 from CendioNiko/vmwarecursor
...
Add support for VMware cursor encoding
2019-09-25 14:45:29 +02:00
8dc47f3c06
Merge pull request #1289 from CendioNiko/master
...
Desktop name improvements
2019-09-25 14:43:55 +02:00
c51a77c2eb
Merge pull request #1281 from jalfd/optimize-receive-buffer
...
Optimize receive buffer
2019-09-25 13:26:02 +02:00
296ba51f49
Add support for VMware cursor encoding
...
Supports both classic cursor type and alpha cursor type. In classic
mode the server can send 'inverted' pixels for the cursor, our code
does not support this but handles these pixels as opaque black.
Co-authored-by: Samuel Mannehed <samuel@cendio.se>
2019-09-24 10:26:30 +02:00
8d6f686b59
Test unicode desktop names
2019-09-04 14:47:40 +02:00
ce66b46986
Add support for DesktopName extension
...
This extension allows session name to be changed during runtime.
2019-09-04 14:23:37 +02:00
9886d5951d
Set viewport size for autoscale tests
...
We were incorrectly relying on the viewport being indirectly set
for us. Make sure we are explicit in what we want for these tests.
2019-08-23 15:48:30 +02:00
30ff15a35a
Merge branch 'upgrade' of https://github.com/CendioOssman/noVNC
2019-08-23 15:08:56 +02:00
e5255fc246
Remove pointless Display.clear()
...
It served no meaningful purpose and it had bugs. So let's remove it
rather than try to fix it.
2019-08-23 15:05:58 +02:00
3855a7bee4
Remove unused Display.logo attribute
2019-08-23 15:04:23 +02:00
7d755d10dc
Don't compact the receive buffer unless we've actually run out of space
...
Previously, we would compact the buffer (moving unread data to the
start of the buffer) as follows:
- after processing a message, if there are zero unread bytes, just reset
the indices for first and last unread byte to zero
- else, if at least 1/8th of the buffer is used, copy remaining data to the beginning of the buffer
The second option is never actually necessary, as before inserting new data
into the array, we already check if there's enough free space, and
compact the buffer first if necessary. So we've been doing a lot of
copies that weren't actually needed. Let's not do that any more.
2019-08-16 19:34:09 +02:00
c9765e5066
Upgrade to latest sinon and chai
2019-08-15 15:58:09 +02:00
b875486db8
Avoid deprecated called.once from sinon-chai
...
It's been removed in newer versions and will break eventually.
2019-08-15 15:58:09 +02:00
dcc41bde61
Fix up errors and warnings in vnc_playback.html
...
Remove the styling, as it isn't really needed, and fix some minor
things that the w3c validator complains about.
2019-03-26 15:21:31 +01:00
1c9b904d1a
Remove callbacks from UI in favour of promises
2019-02-27 10:18:59 +02:00
70e6795829
Send data one byte at a time in tests
...
This makes sure we don't have code assuming that everything is
neatly packaged in a single WebSocket message.
2019-02-15 10:26:27 +01:00
7a1f2e4cf5
Merge branch 'user_getters_and_setters_in_websock' of https://github.com/juanjoDiaz/noVNC
2019-01-08 12:26:17 +01:00
e35570227c
Use CustomEvent for playback events
...
Stop abusing Event as that doesn't work everwhere.
2019-01-08 12:25:42 +01:00
568f6567e1
Avoid using String.prototype.startsWith()
...
IE doesn't support it.
2019-01-08 12:25:01 +01:00
527a1fd0ae
Pre-convert recordings for playback
...
Convert the recordings ahead of time instead of during the playback.
That way we aren't messing up the profiling with time spent converting
data, rather than processing it.
2019-01-08 12:24:39 +01:00
8a189a6291
Add getters/setter to websock
2018-12-08 17:31:20 +02:00
84586c0f17
Change copyright header ( #1138 )
...
* Change copyright header
This updates the copyright header to say "The noVNC Authors". People
who previously had copyright listings are now under the AUTHORS file.
2018-10-09 12:15:35 +02:00
d105040581
Add tests for Cursor encoding
2018-09-18 11:36:32 +02:00
2c5491e131
Enforce space after function name
2018-09-06 17:34:15 +02:00
3f1cda2e37
Enforce space before code block
2018-09-06 17:29:26 +02:00
0ae5c54ab3
Enforce explicit semi-colons
2018-09-06 17:25:02 +02:00
426a8c927b
Enforce curly braces for control statements
2018-09-06 17:22:40 +02:00
e777765320
Enforce function names
2018-09-06 16:53:40 +02:00
d80d9d3731
Enforce function call spacing
2018-09-06 16:46:38 +02:00
6786fd8719
Enforce comma spacing
2018-09-06 16:43:31 +02:00
7b536961b2
Enforce indentation
2018-09-06 16:37:38 +02:00
ce6287574f
Merge branch 'hidpi_scale' of https://github.com/CendioOssman/noVNC
2018-08-16 17:50:09 +02:00
7407c1f4e2
Replace bad sinon stub in mouse tests
...
It screwed up important calls inside the code being tested. Avoid
the stub by creating a temporary element with the desired properties.
2018-08-16 17:36:54 +02:00
2c0b146630
Merge pull request #1117 from novnc/bug/fix-test-playback
...
Fix test playback
2018-08-16 15:38:43 +02:00
16f0861501
Support password auth recordings for playback
...
When password auth is enabled on the server, the RFB object sends a
'credentialsrequired' event to the UI. This commit adds support for
this event to our recoding playback.
2018-08-16 15:36:43 +02:00
b3ac94a978
Remove firebug comments
...
Firebug is discontinued and it's features are included in browser
development tools now a days.
2018-08-08 14:05:06 +02:00
ee3493c060
Add a record flag to launch.sh
...
Add the `--record` flag to launch.js, for easy recording when testing.
2018-07-30 11:07:33 -04:00
cccf3b008a
Fix perf/playback tool
...
Somewhere along the way, the refactors broke playback.js. This fixes
the actual functionality, and makes its JS loading match that in
vnc.html.
2018-07-29 19:14:56 -04:00
7bcdbbc65b
Stop transpiling karma tests
...
This runs our code in the same manner as it would be used if loaded
directly in the browser. Includes the same kind of fallback for older
browsers.
2018-07-16 13:32:35 +02:00
9eaea86234
Don't stub out ES module imports
...
It is not allowed and only happens to work because babel doesn't
strictly follow the specification. It doesn't seem necessary for the
tests to run, so just remove it.
2018-07-13 15:57:24 +02:00
ae2e1ff7bd
Move sinon to karma framework
...
This frees us from manual imports, and makes things less magical
as those aren't ES modules even if the code suggest that the are.
2018-07-13 15:57:24 +02:00
885363a373
Use the classic `function foo() { ... }` for top level functions or functions that depend on the scope
2018-07-12 19:06:57 +02:00
651c23ece3
Use fat arrow functions `const foo = () => { ... };` for callbacks
...
and any other function that is passed around and it's not a top level function
2018-07-12 19:06:57 +02:00
Pierre Ossman
Samuel Mannehed
Andrey Trebler
Alex Tanskanen
Niko Lehto
Alex Tanskanen
Jesper Alf Dam
Juanjo Diaz
Solly Ross
Solly Ross