jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove very legacy mouse event handling 

This is only needed on such ancient versions of Internet Explorer that
it wouldn't satisfy our other requirements anyway.
This commit is contained in:
Pierre Ossman 2020-06-10 12:56:50 +02:00 committed by Samuel Mannehed
parent 77c32d164d
commit 4a87038080
2 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/input/mouse.js
View File

@ -42,16 +42,7 @@ export default class Mouse {
this._updateMousePosition(e);
let pos = this._pos;
let bmask;
if (e.which) {
/* everything except IE */
bmask = 1 << e.button;
} else {
/* IE including 9 */
bmask = (e.button & 0x1) + // Left
(e.button & 0x2) * 2 + // Right
(e.button & 0x4) / 2; // Middle
}
let bmask = 1 << e.button;
Log.Debug("onmousebutton " + (down ? "down" : "up") +
", x: " + pos.x + ", y: " + pos.y + ", bmask: " + bmask);

6
tests/test.mouse.js
View File

@ -43,7 +43,7 @@ describe('Mouse Event Handling', function () {
expect(down).to.be.equal(1);
done();
};
mouse._handleMouseDown(mouseevent('mousedown', { button: '0x01' }));
mouse._handleMouseDown(mouseevent('mousedown', { button: 0 }));
});
it('should decode mouseup events', function (done) {
let calls = 0;
@ -55,8 +55,8 @@ describe('Mouse Event Handling', function () {
done();
}
};
mouse._handleMouseDown(mouseevent('mousedown', { button: '0x01' }));
mouse._handleMouseUp(mouseevent('mouseup', { button: '0x01' }));
mouse._handleMouseDown(mouseevent('mousedown', { button: 0 }));
mouse._handleMouseUp(mouseevent('mouseup', { button: 0 }));
});
it('should decode mousemove events', function (done) {
const mouse = new Mouse(target);