7dd8754575
Factoring of jtag_examine_chain for maintainability:
...
- Improve variable type: change device_count to unsigned.
- Improves jtag_tap_count_enabled() API too (now returns unsigned).
git-svn-id: svn://svn.berlios.de/openocd/trunk@2091 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:24:27 +00:00
b550f70100
Factoring of jtag_examine_chain for maintainability:
...
- Limit scope: move tap and bit_count variables to point of first use.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2090 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:24:20 +00:00
63c4848d11
Factoring of jtag_examine_chain for maintainability:
...
- Factor TAP ID matching into new helper function.
- Simplifies the main jtag_examine_chain loop logic considerably.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2089 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:24:12 +00:00
f106382055
Factoring of jtag_examine_chain for maintainability:
...
- Minor whitespace and style cleanups in body of jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2088 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:24:03 +00:00
9eefd4d7e5
Factoring of jtag_examine_chain for maintainability:
...
- Add helper to check for the terminating ID during jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2087 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:23:50 +00:00
d8421f2766
Factoring of jtag_examine_chain for maintainability:
...
- Factor end-of-chain verfication into new helper routine.
- Change 'unexpected' local variable name to 'triggered' and type to bool.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2086 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:23:40 +00:00
feb865f9ee
Factoring of jtag_examine_chain for maintainability:
...
- Factor output of accepted/incorrect/expected TAP IDs into static helper.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2085 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:23:30 +00:00
c318068839
Factoring of jtag_examine_chain for maintainability:
...
- Factor initial chain examination check into new static helper.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2084 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:23:13 +00:00
90dbfcea7d
Factoring of jtag_examine_chain for maintainability:
...
- Factor JTAG chain examination into static helper function.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2083 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:23:03 +00:00
861f52ff16
Factoring of jtag_examine_chain for maintainability:
...
- Reduce indent: invert logical test of expected_id count.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2082 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:22:53 +00:00
15ae1ac678
Factoring of jtag_examine_chain for maintainability:
...
- Reduce indent: invert logic test for unexpected TAP (no IDs).
git-svn-id: svn://svn.berlios.de/openocd/trunk@2081 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:22:42 +00:00
32350a5006
Factoring of jtag_examine_chain for maintainability:
...
- Reduce indent: invert logic test for tap in jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2080 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:22:34 +00:00
401d6472cc
Factoring of jtag_examine_chain for maintainability:
...
- Move definition of maximum JTAG chain size closer to its only uses.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2079 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:22:25 +00:00
0b08845e3f
Factoring of jtag_examine_chain for maintainability:
...
- Move JTAG EXTRACT macros out from the middle of jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2078 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 05:22:09 +00:00
43e1ed244f
Clean up handle_endstate_command():
...
- Merge declaration of state with first use.
- Unindent and remove unnecessary 'else' block.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2077 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-07 03:48:21 +00:00
f92b104d8d
David Brownell <david-b@pacbell.net> target/at91rm9200.cfg cleanup
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2075 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 08:35:24 +00:00
aee65603ee
remove hacks no longer required to build OpenOCD w/eCos
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2074 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 06:43:09 +00:00
af838b03a0
remove unused include file: strings.h
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2073 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 06:42:20 +00:00
3b3a5b642c
remove unused include file: inttypes.h
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2072 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 06:41:54 +00:00
a49faa206d
remove unused include file: inttypes.h
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2071 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 06:37:21 +00:00
0eb5c7509d
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_NextEnabledTap' as 'jtag_tap_next_enabled.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2069 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:43:43 +00:00
0d39db1109
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_NumEnabledTaps' as 'jtag_tap_count_enabled.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2068 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:43:32 +00:00
92cf94295e
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_NumTotalTaps' as 'jtag_tap_count.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2067 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:43:23 +00:00
7db5839608
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByJimObj' as 'jtag_tap_by_jim_obj.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2066 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:43:12 +00:00
689e9664b0
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByString' as 'jtag_tap_by_string.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2065 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:42:52 +00:00
473dc89c24
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByAbsPosition' as 'jtag_tap_by_abs_position.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2064 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:42:39 +00:00
05eb8d8c13
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByPosition' as 'jtag_tap_by_position.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2063 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:42:32 +00:00
dd89964ae0
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_AllTaps' as 'jtag_all_taps.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2062 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:42:25 +00:00
eaf37cf9e8
Eliminate MixedCaps symbol from public JTAG TAP API:
...
- Purely mechanical transformations to the source files.
- Rename 'jtag_all_taps' as '__jtag_all_taps.'
- Frees original symbol name to rename the accessor function.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2061 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:42:17 +00:00
499f30f693
Add accessors for jtag_verify; use them in jim command handler.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2060 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:06:34 +00:00
99fd479503
Add accessors for reset delays; use them in jim command handlers.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2059 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:04:12 +00:00
d530313866
Add accessors for speed_khz; use them in jim command handler.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2058 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-05 00:02:00 +00:00
8580c70172
Add jtag_get_flush_queue_count accessor to help future factoring.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2057 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 23:52:58 +00:00
a847326216
Clean up the JTAG TAP creation handler:
...
- Factor jtag_tap_init() helper out of the end of jim_newtap_cmd.
- Factor jtag_tap_free() helper out of the error case in jim_newtap_cmd.
- Invert test to improve indentation at the end of jim_newtap_cmd.
- Improve whitespace in the newly factored functions.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2056 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 23:49:52 +00:00
d3d02f4789
Clean up the core JTAG TAP APIs:
...
- Move jtag_tap_name to same location as other TAP functions; export it.
- Factor new jtag_tap_add() from jim_newtap_cmd(); appends TAP to global list.
- Move static chain position counter to global; use in jtag_NumTotalTaps().
- Use jtag_AllTaps for reading tap list, instead of accessing global directly.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2055 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 23:26:58 +00:00
82a5f6ff3e
Change hasKHz to use bool type.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2054 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 22:43:34 +00:00
c0f9fbcca5
Add missing static keywords in JTAG source file.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2053 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 22:41:21 +00:00
01801e3f45
unbreak arm11. TAP_INVALID is used to communicate inband that a special state should be used to lower level fn's in ARM11 code.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2052 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 20:05:32 +00:00
f7d3fdb195
- add support for different TAR autotincrement sizes as per ARM ADI spec.
...
- set TAR size to 12 bits for Cortex-M3.
- Original patch submitted by Magnus Lundin [lundin@mlu.mine.nu ].
git-svn-id: svn://svn.berlios.de/openocd/trunk@2051 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 13:45:50 +00:00
d861002612
Rename jtag_add_end_state to jtag_set_end_state since "add" implies that
...
this fn has something to do with the queue, which it does not as such.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2050 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 13:18:07 +00:00
f133158175
Introduce jtag_get_end_state() fn to clarify code a bit.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2049 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 13:14:07 +00:00
310a9eabff
tiny bit of encapsulation of global end state. No longer expose it as a global variable.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2048 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 13:05:57 +00:00
9e8dce64fc
do not modify global end state from jtag_add_xxx()
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2047 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 12:52:54 +00:00
89e9d86a56
remove unused code.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2046 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 12:42:21 +00:00
040e6cef41
no longer use jtag_add_xxx() to set end state to TAP_DRPAUSE
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2045 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 12:12:38 +00:00
f499341558
no longer use jtag_add_xxx() to set end state to TAP_IDLE. Same must be done for TAP_DRPAUSE
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2044 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 12:06:31 +00:00
f86f2ab3f8
use assert() to catch TAP_INVALID passed to jtag_add_xxx() fn's.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2043 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 11:42:34 +00:00
6468859389
remove TAP_INVALID as argument to jtag_add_xxx() fn's
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2042 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 11:33:36 +00:00
bb1a1ddb54
jtag_add_end_state() now returns the value of the global variable and does not modify the global variable if passed TAP_INVALID. This patch has no effect on the current code and is just to prepare upcoming patches.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2041 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 07:05:22 +00:00
9ab49135c6
JTAG_TRST_ASSERTED event cleanup. More clear where and when it is invoked and some duplicate(harmless) invocations avoided.
...
git-svn-id: svn://svn.berlios.de/openocd/trunk@2040 b42882b7-edfa-0310-969c-e2dbd0fdcd60
2009-06-04 06:56:22 +00:00
zwelch
oharboe
ntfreak