interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

arm breakpoints: amended fix comment 

the handling of caches, should be moved into the breakpoint
specific callbacks rather than being plonked into generic
memory write fn's.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe 2010-03-21 19:20:26 +01:00
parent 5dcad2d34f
commit b7811b7679
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/target/arm920t.c
View File

@ -567,7 +567,11 @@ int arm920t_write_memory(struct target *target, uint32_t address,
/* FIX!!!! this should be cleaned up and made much more general. The /* FIX!!!! this should be cleaned up and made much more general. The
* plan is to write up and test on arm920t specifically and * plan is to write up and test on arm920t specifically and
* then generalize and clean up afterwards. */ * then generalize and clean up afterwards.
*
* Also it should be moved to the callbacks that handle breakpoints
* specifically and not the generic memory write fn's. See XScale code.
*/
if (arm920t->armv4_5_mmu.mmu_enabled && (count == 1) && if (arm920t->armv4_5_mmu.mmu_enabled && (count == 1) &&
((size==2) || (size==4))) ((size==2) || (size==4)))
{ {

7
src/target/arm926ejs.c
View File

@ -579,7 +579,12 @@ int arm926ejs_write_memory(struct target *target, uint32_t address,
/* FIX!!!! this should be cleaned up and made much more general. The /* FIX!!!! this should be cleaned up and made much more general. The
* plan is to write up and test on arm926ejs specifically and * plan is to write up and test on arm926ejs specifically and
* then generalize and clean up afterwards. */ * then generalize and clean up afterwards.
*
*
* Also it should be moved to the callbacks that handle breakpoints
* specifically and not the generic memory write fn's. See XScale code.
**/
if (arm926ejs->armv4_5_mmu.mmu_enabled && (count == 1) && ((size==2) || (size==4))) if (arm926ejs->armv4_5_mmu.mmu_enabled && (count == 1) && ((size==2) || (size==4)))
{ {
/* special case the handling of single word writes to bypass MMU /* special case the handling of single word writes to bypass MMU