From b7811b76795aaeacfea0473bdca2c44826f20501 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Harboe?= Date: Sun, 21 Mar 2010 19:20:26 +0100 Subject: [PATCH] arm breakpoints: amended fix comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit the handling of caches, should be moved into the breakpoint specific callbacks rather than being plonked into generic memory write fn's. Signed-off-by: Øyvind Harboe --- src/target/arm920t.c | 6 +++++- src/target/arm926ejs.c | 7 ++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/target/arm920t.c b/src/target/arm920t.c index 4916de1da..99f7dca94 100644 --- a/src/target/arm920t.c +++ b/src/target/arm920t.c @@ -567,7 +567,11 @@ int arm920t_write_memory(struct target *target, uint32_t address, /* FIX!!!! this should be cleaned up and made much more general. The * plan is to write up and test on arm920t specifically and - * then generalize and clean up afterwards. */ + * then generalize and clean up afterwards. + * + * Also it should be moved to the callbacks that handle breakpoints + * specifically and not the generic memory write fn's. See XScale code. + */ if (arm920t->armv4_5_mmu.mmu_enabled && (count == 1) && ((size==2) || (size==4))) { diff --git a/src/target/arm926ejs.c b/src/target/arm926ejs.c index ff18bae82..1f753a6e3 100644 --- a/src/target/arm926ejs.c +++ b/src/target/arm926ejs.c @@ -579,7 +579,12 @@ int arm926ejs_write_memory(struct target *target, uint32_t address, /* FIX!!!! this should be cleaned up and made much more general. The * plan is to write up and test on arm926ejs specifically and - * then generalize and clean up afterwards. */ + * then generalize and clean up afterwards. + * + * + * Also it should be moved to the callbacks that handle breakpoints + * specifically and not the generic memory write fn's. See XScale code. + **/ if (arm926ejs->armv4_5_mmu.mmu_enabled && (count == 1) && ((size==2) || (size==4))) { /* special case the handling of single word writes to bypass MMU