772bfad79f
Remove early abort for NULL values in uiprivTableModelSetCellValue.
...
We are changing the value, update the row!
There are several uses for setting NULL values, IMO all abusing the
API for different causes. Fix those API abuses instead:
- This will cause one unneeded redraw when clicking on table column
buttons as they signal a click through setting NULL. Possibly use
a dedicated callback handler for that instead?
- This will fix resetting colors to default, as this is signaled
through a NULL value.
2020-08-27 14:02:56 -05:00
b504629cc0
Fix table editing redraw code on all platforms.
...
This fixes bugs on all platforms not calling uiTableModelRowChanged()
when setting a new value in edit mode. This is now automatically
done in uiprivTableModelSetValue() so that ALL uiTable views are
informed about the update.
Darwin and windows did some custom redrawing which hid this bug.
Unix does frequent unrelated redraw which hide the bug. It can often
be experienced when double clicking a checkbox.
2020-08-25 13:32:29 -05:00
f6ef61cdee
And settled common/CMakeLists.txt (it also had nothing that needed to be moved).
2019-03-27 01:05:57 -04:00
1b9250e41e
Removed include_directories hackery, as suggested by various people in freenode #mesonbuild.
2019-03-25 20:07:22 -04:00
1deacb55aa
And massaged things into a buildable state. Woo. NOW things are starting to get annoying, but at least it's not so much *voodoo* anymore?
2019-03-23 16:18:13 -04:00
253ce9a3cc
Decided to just use add_project_(link_)arguments() for now, and set up the macOS build for testing.
2019-03-23 15:42:42 -04:00
419c584523
Merge pull request #379 from mischnic/attrstr-delete
...
Fix uiAttributedStringDelete
2018-08-09 05:16:52 -04:00
f3882d6124
Cleaned up color access across platforms.
2018-06-24 14:22:05 -04:00
acb40964f3
Deduplicated editable logic across platforms.
2018-06-24 11:41:19 -04:00
4dbf1994a6
Deduplicated the default text column parameters across platforms.
2018-06-24 00:45:54 -04:00
74ec21f4c7
Turned the direct method calls on uiTableModel into functions to make the call sites look a bit cleaner. More stuff will go into common/tablemodel.c...
2018-06-23 23:35:42 -04:00
9a79eed2ac
Final cleanup, first part: renamed uiTableData to uiTableValue.
2018-06-23 20:19:30 -04:00
2b428d50f6
And fixed build errors. Now I just need to rewrite the tester and try this out...
2018-06-03 23:06:44 -04:00
54ca41afb6
Moved common/table.c out of the way for now; it's not relevant with the proposed colum changes and definite data changes.
2018-06-03 17:57:17 -04:00
43b1a46669
Wrote the common table data functions.
2018-06-03 17:28:54 -04:00
773856fa90
Fix uiAttributedStringDelete
2018-05-31 17:49:44 +02:00
7b570a4026
Merge branch 'master' into table
2018-05-05 09:15:08 -04:00
55f2eba45b
Add wchar_t overloads to utf.h for C++ on Windows with non-MSVC compilers; I did not realize that was also a thing I needed to worry about!
...
Update #287
2018-04-30 07:46:38 -04:00
ae2eea7975
Merge branch 'master' into table
...
Long-overdue sync.
2018-04-18 10:00:13 -04:00
52dc39a553
Decided to keep attrstr.h for now; removed extern "C" hack from attrstr.hpp on Windows and moved it into attrstr.h. Let's merge back.
2018-04-18 00:54:24 -04:00
4df47a6ee8
Decided what to do about uipriv.h including ui.h (uipriv_OS.h* wrecks that plan, so make a note of us not doing it). Now to just decide what to do about attrstr.h and then we can merge back.
2018-04-17 21:04:04 -04:00
750f4214b7
Cleaned up private symbols (and in one case, explicit initialization) of symbols in all *.c files in common/. Now to decide what to do about whether uipriv.h should include ui.h and if attrstr.h should even stay, and then I can merge this back.
2018-04-16 02:31:24 -04:00
b3df05eb8e
More TODOs. (This was originally added in a prior commit but I forgot to mention it; I wanted it to be LONGTERM but forgot about that the first time.)
2018-04-15 23:16:04 -04:00
c3992cc647
uipriv-ized utf.c.
2018-04-15 23:08:57 -04:00
8e2004cf67
struct graphemes -> uiprivGraphemes. Also deleted OLD_uipriv.h now that that one is settled.
2018-04-15 22:43:14 -04:00
01d6422664
Added uipriv prefixes to the matrix functions.
2018-04-15 22:39:34 -04:00
24a4b0997c
fromScancode() -> uiprivFromScancode().
2018-04-15 22:31:17 -04:00
0dddf4a490
clickCounter -> uiprivClickCounter.
2018-04-15 22:26:51 -04:00
f5be05f143
shouldQuit() -> uiprivShouldQuit().
2018-04-15 21:54:46 -04:00
59835a9bae
Removed the declaration of newControl(): it was completely unused, as it was superceded by uiAllocControl() long ago.
2018-04-15 21:49:58 -04:00
f93973d3cb
Migrated implbug() and userbug() to uipriv forms.
2018-04-15 21:46:08 -04:00
72e8b9a198
Started FINALLY renaming uiAlloc(), uiNew(), uiRealloc(), and uiFree() into uipriv* forms. This handles the common folder.
2018-04-15 15:53:27 -04:00
4a57b15d09
Renamed the common options variable to uiprivOptions.
2018-04-15 15:49:45 -04:00
e0f800d5eb
Started cleaning up the common/ folder. Backed up the current uipriv.h.
2018-04-15 15:39:28 -04:00
93f0eea140
Likewise codified uiprivStricmp(). Honestly this will probably do for the Windows code for now...
2018-03-17 23:22:17 -04:00
d358e87583
Moved the old metrics attrstr code out of the way.
2018-03-17 21:00:11 -04:00
a5bbc83359
Fixed build errors. Now to test.
2018-03-17 15:49:00 -04:00
6ba2d3606d
Removed uiprivStrdup() (we'll just uiprivAlloc()+strcpy() instead) and fleshed out the drawtext example's text a bit more.
2018-03-10 22:51:39 -05:00
4bb6a56c99
More warning fixes. Made private uiAttributeString functions const-correct to expose more potential issues later. Const-correctness and uiAttributeRetain() are going to be an issue...
2018-03-10 19:21:39 -05:00
115a60c950
uiAttribute copies family names, so its internal copy doesn't need to be const. Fix this.
2018-03-10 19:13:20 -05:00
9194ba29fe
And fixed build errors. Now I'm sure there are warnings that are real bugs, so let's handle those next.
2018-03-10 19:02:10 -05:00
82d3de7c31
More compiler error fixes. Oops, I forgot to finish attrstr.m!
2018-03-08 23:27:04 -05:00
e9a62461c2
Started fixing compile errors. I forgot I renamed uiDrawFontDescriptor to uiFontDescriptor!
2018-03-08 23:04:45 -05:00
9661d14262
And fixed up loose ends preventing a build. Let's build!
2018-03-08 22:44:35 -05:00
9c8f6849c3
Synced const-correctness in ui_attrstr.h to attrstr.c, propagated that to the necessary private functions, and added some references to testing.h.
2018-03-04 11:15:18 -05:00
77c07075e3
Updated grapheme function names in attrsr.h and updated allocator function names in attrstr.c.
2018-03-04 10:46:00 -05:00
f025783632
Migrated attrstr.c back like we just did to attrlist.c. RIP "graphemes()"
2018-03-03 22:02:18 -05:00
766f3a0cb2
Moved the unit tests out of the way for now. We'll fill them in later.
2018-03-03 21:35:29 -05:00
3337f06e2e
Oops.
2018-03-03 21:32:18 -05:00
dcf6726239
More TODOs.
2018-03-03 21:29:45 -05:00
Angelo Haller
Pietro Gagliardi
Pietro Gagliardi
Niklas Mischkulnig