Commit Graph

1438 Commits

Author SHA1 Message Date
Pietro Gagliardi 753f4316e2 Removed the GTK+ indefinite progressbar TODO; the choppiness is correct for GTK+ <= 3.10: http://blogs.gnome.org/mclasen/2013/11/10/smooth-progress/ - mclasen and Company suggest timing with the frame, but this blog post says this will be automatic in 3.12+, so we're good. 2014-06-05 17:47:20 -04:00
Pietro Gagliardi ae0246d6a7 Removed TODO on gdk_device_ungrab() errors: this is a bug in oxygen-gtk and GTK+ relating to a feature of GtkComboBoxes and not some issue with our code. Thanks to garnacho_ in irc.gimp.net/#gtk+ for figuring this out; this issue will not be followed here from this point on. 2014-06-05 14:54:23 -04:00
Pietro Gagliardi 00ec1215bb Removed some leftover debugging code from the previous few commits. 2014-06-05 13:43:31 -04:00
Pietro Gagliardi 5a9bd4b4b5 Fixed the GTK+ Combobox sizing issues for real this time. 2014-06-05 13:40:47 -04:00
Pietro Gagliardi 86cf1fbcba Fixed resizing of editable comboboxes in the GTK+ backend. Uneditable comboboxes are still an issue, and there's experimental code to try to fix them, but it doesn't work... 2014-06-05 13:04:34 -04:00
Pietro Gagliardi e1c4e7d655 Decided not to change the default window title of a MsgBox() on Windows for now. If I change my mind, it's a documentaiton change =P 2014-06-05 11:03:18 -04:00
Pietro Gagliardi 125cc7d477 Figured out what happens if a message box is created for an invisible window, documented it was undefined (Windows and GTK+ behave reasonably but at least Windows is not documented here; Mac OS X shows a sheet attached to invisible where the titlebar should be and then considers the window closed), and added the panic() checks for uncreated Windows. 2014-06-05 03:09:02 -04:00
Pietro Gagliardi 60f3c1b24f Verified resize differences on MsgBox() with a parent. 2014-06-05 01:03:37 -04:00
Pietro Gagliardi 89ab55cfbd More TODOs. 2014-06-05 00:55:31 -04:00
Pietro Gagliardi 60de6d05c5 Implemented message box transience on Mac OS X. 2014-06-05 00:53:26 -04:00
Pietro Gagliardi 8e0a38dc47 Implemented the new MsgBox() transience behavior on GTK+. 2014-06-05 00:24:05 -04:00
Pietro Gagliardi 7acc70c39e Implemented the new MsgBox() transience on Windows. 2014-06-04 23:28:43 -04:00
Pietro Gagliardi 4e6f6cd147 More TODOs. 2014-06-04 23:16:27 -04:00
Pietro Gagliardi 7ee05f8263 Added the concept of transience to MsgBox() and MsgBoxError(). Individual implementations will come next. 2014-06-04 23:12:56 -04:00
Pietro Gagliardi c3a87ab713 Resolved the ACTCTX_FLAG_SET_PROCESS_DEFAULT TODO by deciding to enable this flag for maximum safety. Also added more future plans. 2014-06-04 19:30:19 -04:00
Pietro Gagliardi fb7e638d69 Resolved TODO about indeterminate ProgressBar repetition by deciding to leave it to the implementation. 2014-06-04 19:09:26 -04:00
Pietro Gagliardi bd08967a5a Removed TODOs about sign extension on Windows; situation resolved. 2014-06-04 19:06:16 -04:00
Pietro Gagliardi ec5c4594b2 Added a link to the older Layout page on MSDN to prefsize_windows.go. 2014-06-04 12:29:07 -04:00
Pietro Gagliardi 5027a50845 Resolved a TODO in stdwndclass_windows.go about deferring WM_NCCREATE to DefWindowProc(). 2014-06-04 01:17:59 -04:00
Pietro Gagliardi bc34836227 Marked the README as needing updates and added API change warnings. 2014-06-03 23:14:12 -04:00
Pietro Gagliardi 427a0f3a74 Big change to Window: split Open()'s functionality into Create() and Open(); they no longer return errors. 2014-06-03 23:08:51 -04:00
Pietro Gagliardi 59870e80f0 Quick changes: turned "Window has been opened" to "Window has been created" since I'm going to separate creating and opening (Open() will call Create()). 2014-06-03 22:54:28 -04:00
Pietro Gagliardi d69c90401f Decided to panic in the hwnd sanity check in sysdata_windows.go; the situation /is/ exceptional, after all (and we need to just get rid of all errors sometime). 2014-06-03 22:47:49 -04:00
Pietro Gagliardi d7c37671f3 Removed the TODO on memstride: we were already using it?????? It is working correctly... No idea why that TODO was there; I know I added it when I was too tired to think though. 2014-06-03 22:32:24 -04:00
Pietro Gagliardi 3af926cf3b Added the previous commit to the future plans instead. 2014-06-03 22:27:27 -04:00
Pietro Gagliardi bf6c29b39c Made multiple modifier keys undefined; removed the TODO there. If I need to change the behavior I can do it later. 2014-06-03 22:26:25 -04:00
Pietro Gagliardi 3745acf57b Decided not to rename MouseEvent.Pos. 2014-06-03 22:23:48 -04:00
Pietro Gagliardi 1451273dad And removed that TODO from the previous commit after verifying that such a proposal is too risky. 2014-06-03 18:40:47 -04:00
Pietro Gagliardi d7a73bec2d Rewrote a TODO on build tags for the Unix build. 2014-06-03 18:37:24 -04:00
Pietro Gagliardi 74a8a6f9da Removed TODO about application-modal dialog boxes in GTK+; they were already application modal! The real issue is window transience... and that's where platforms differ greatly. 2014-06-03 18:32:58 -04:00
Pietro Gagliardi 9a86659c37 Removed TODOs about device coordinates in the GTK+ backend; that has been resolved. 2014-06-03 12:54:13 -04:00
Pietro Gagliardi ad4ea927b8 Now that the Windows string handling has been properly fixed, removed the TODO about the 32-bit build being unstable. 2014-06-03 11:17:16 -04:00
Pietro Gagliardi 33d4178865 Migrated area_windows.go to the new string handling. I think that's it for converting existing code... Now to test on real Windows. 2014-06-03 11:04:31 -04:00
Pietro Gagliardi ea95d5559d Migrated dialog_windows.go to the new string handling. 2014-06-03 11:00:29 -04:00
Pietro Gagliardi a46668ca22 Migrated stdwndclass_windows.go to the new string handling. 2014-06-03 10:52:53 -04:00
Pietro Gagliardi 05828236ec Migrated uitask_windows.go to the new string handling. 2014-06-03 10:48:21 -04:00
Pietro Gagliardi c5df1b1afc Removed a stray function from common_windows.go that both was not used and went against what we're trying to do with strings in Windows. 2014-06-03 10:42:26 -04:00
Pietro Gagliardi 25d8aeb993 Converted comctl_windows.go to use the new string wrapper functions. 2014-06-03 03:37:48 -04:00
Pietro Gagliardi 3058927f2e More TODOs. 2014-06-03 03:22:02 -04:00
Pietro Gagliardi 38800f027f Converted sysdata_windows.go to use the new string conversion setup from the previous commit. This has to be first, otherwise a few other things will fail to compile... 2014-06-03 03:20:04 -04:00
Pietro Gagliardi d8ee23ff74 Added convenience functions to the Windows backend for UTF-16 string handling. I'll convert the existing code to use it shortly. 2014-06-03 02:06:11 -04:00
Pietro Gagliardi fb8e64cb5a Removed a TODO from area_windows.go after verifying that what it flagged (GetKeyState() vs. GetAsyncKeyState()) is indeed what we want to do (the former). 2014-06-03 00:53:24 -04:00
Pietro Gagliardi 4ede7d497d Removed a policy TODO in area_windows.go; decided to keep the redundant entries in the Modifiers table table just to be safe. 2014-06-03 00:48:11 -04:00
Pietro Gagliardi b62fd3279f Removed a leftover TODO note in area_unix.go. 2014-06-02 22:10:23 -04:00
Pietro Gagliardi 99059483a7 Resolved TODOs in callbacks_unix.go. (For the returning FALSE TODO, I decided it would be safest to let event handlers propagate, as I did with Areas earlier.) 2014-06-02 22:07:50 -04:00
Pietro Gagliardi f170780324 Resolved command-line handling in the GTK+ backend by not doing it and documenting that we don't do it. 2014-06-02 21:25:28 -04:00
Pietro Gagliardi 74c851754c Gave message boxes on Windows the MB_TASKMODAL style, which does event modality to the other windows in the program. Does not affect resizes. 2014-06-02 17:12:10 -04:00
Pietro Gagliardi a1150fb9ea Added a test of MsgBox() event modality to the standard Area test. 2014-06-02 17:04:39 -04:00
Pietro Gagliardi 15c10b63de Removed leftover TODO about left-justifying labels in GTK+. 2014-06-02 15:24:01 -04:00
Pietro Gagliardi 9903fd624c Properly left-aligned Labels in GTK+. Also added a note to decide on/document/verify vertical alignment of Labels. 2014-06-02 15:22:31 -04:00