Commit Graph

158 Commits

Author SHA1 Message Date
Pietro Gagliardi e713b59bec Removed TODO about Windows -1 conversions, as the Go spec specifically says that signed values are sign-extended to the full size of the type to convert to (and even shows an example of this), so the code we have was correct, not just working out of luck. 2014-04-10 20:52:12 -04:00
Pietro Gagliardi d6abf79932 Added bounds checking to NewArea() and Area.SetSize() such that an Area must have a valid size. 2014-04-10 20:42:01 -04:00
Pietro Gagliardi 1c11ef2d9c More TODOs. 2014-04-10 19:38:48 -04:00
Pietro Gagliardi a01ffafba0 Fixed Area mouse events being sent when something happens outside the Area itself. 2014-04-10 18:52:43 -04:00
Pietro Gagliardi 1516c0d938 Decided not to make Labels selectable; nothing does it and it's a platform detail. 2014-04-10 16:23:51 -04:00
Pietro Gagliardi 09e92b0eb3 Documented scrollbars on Listbox and Area to the best of my ability, shuffling the appropriate TODOs around. 2014-04-10 16:18:53 -04:00
Pietro Gagliardi 7b8580b12d More TODOs. 2014-04-10 13:35:27 -04:00
Pietro Gagliardi 865a0ec662 "Fixed" the zero-size Combobox drop-down on Windows by having Windows fix it for us (and since we did everything we need to do to get it to fix it for us, it was already fixed!). 2014-04-10 12:53:23 -04:00
Pietro Gagliardi 013e8707da Removed unnecessary space if the secondaryText argument to MsgBox***() is an empty string. This doesn't change much on Mac OS X; it always shows the informational text field, showing an empty string by default. On GTK+ it seems to get rid of the bold over the primary text; I'm going to assume this is intentional (it looks that way on GTK+ 2; the HIG docs have outdated screenshots...). 2014-04-10 12:35:37 -04:00
Pietro Gagliardi 9e185d815e Documented that event channels can be assigned to each other to collapse events. 2014-04-10 11:59:40 -04:00
Pietro Gagliardi 0a54daa7b1 More TODOs and future plans. 2014-04-09 22:37:36 -04:00
Pietro Gagliardi 8259e6d1f8 Added a test for the extremities of the Area's actual drawing area to make sure all pixels are shown on all platforms. That seems to be the case right now... Also more TODOs. 2014-04-09 20:44:07 -04:00
Pietro Gagliardi 78bb4cdace Fixed Area drawing assuming the first pixel of the *image.NRGBA is at i.Pix[0]. 2014-04-09 18:26:20 -04:00
Pietro Gagliardi bfb259da27 Tried to resolve the use a single window class for each type of custom window TODO; found it was nothing but problems, so moved to future plans. 2014-04-09 13:22:16 -04:00
Pietro Gagliardi e395adb214 Fixed GTK+ windows having the wrong background. 2014-04-09 12:04:04 -04:00
Pietro Gagliardi 69b63dbbb8 Slowed GTK+ indeterminate Progressbars down. 2014-04-08 00:21:12 -04:00
Pietro Gagliardi 14bb9e3621 Removed the TODOs about AppQuit: fixed on OS X, never a problem on Windows, unfixable elsewhere (these are window manager window-local(? apparently...) events so they never hit us; thanks to some people in irc.gimp.net/#gtk+). Also added some notes to the future plans document (related to all that). 2014-04-07 12:49:23 -04:00
Pietro Gagliardi af770340c9 Added details of application termination handling. 2014-04-06 19:14:28 -04:00
Pietro Gagliardi 0524a17920 Added borders to GTK+ Listboxes (thanks to jlindgren in irc.gimp.net/#gtk+); ends that TODO. 2014-04-06 13:25:23 -04:00
Pietro Gagliardi a65012f476 More TODOs. 2014-04-05 23:14:25 -04:00
Pietro Gagliardi 7d02af4e81 Removed the bit about selectable messagebox text from the TODO file: that's a platform-specific thing. 2014-04-05 23:10:07 -04:00
Pietro Gagliardi 30c3ee1b98 Gave Listboxes a border on Mac OS X. That just leaves GTK+: oyxgen-gtk always gives GtkScrollingWindows a border, which misled me earlier... other themes don't. 2014-04-05 22:51:01 -04:00
Pietro Gagliardi 3d04200e8d Split the todo.md file into one for immediate TODOs and one for future work; merged the latter with controlcandidates.md to form a single future stuff list. Also cleaned up all those lists. 2014-04-05 19:38:35 -04:00
Pietro Gagliardi 1449409f61 More TODOs. 2014-04-05 13:32:40 -04:00
Pietro Gagliardi bf1e7aae42 More TODOs. 2014-04-04 18:39:06 -04:00
Pietro Gagliardi be668a965a Fixed Mac OS X Button appearance; turns out it was using the wrong font. Also updated the TODO file to mark this fix and remove other stale/already fixed details. 2014-04-04 14:52:38 -04:00
Pietro Gagliardi 2e617611c5 Adjusted Button and Combobox sizes on Windows to be better... 2014-04-03 21:00:38 -04:00
Pietro Gagliardi 2e72ab689a Updated TODO on dragging in an Area (decided to go with what GTK+ and Windows currently do; dragging was working on Windows all along; now dragging is weird on Mac). 2014-04-03 18:33:57 -04:00
Pietro Gagliardi 773668c35b Fixed the major scrolling corruption on Windows: had to commit the scroll changes before we can get to them in our painting routine =P This doesn't fix ALL the issues; check the (now-updated) TODO. 2014-04-02 23:40:38 -04:00
Pietro Gagliardi a325e9e404 More TODOs. 2014-04-02 21:56:45 -04:00
Pietro Gagliardi 07c8aab1e6 More TODOs. 2014-04-02 19:59:39 -04:00
Pietro Gagliardi 4ac5290771 Fixed Listbox and LineEdit borders on Windows. Also more TODOs. 2014-04-02 19:57:49 -04:00
Pietro Gagliardi 77b5afe824 More TODOs. 2014-04-02 13:48:49 -04:00
Pietro Gagliardi d1c0b9b29d Not using PostThreadMessage() (a few commits back) seems to fix the weird Invalid thread ID. error that happens when running package ui-based programs in wine for the first time (I assume that issue is related to the one that led to the PostThreadMessage() fix). 2014-04-02 10:17:24 -04:00
Pietro Gagliardi 973853c835 Fixed odd Listbox sizing on Windows. (Windows by default sizes List Box controls so that partial items are not visible.) 2014-04-02 10:15:04 -04:00
Pietro Gagliardi cbf439223b Changed the font loading on Windows to always load the control font unless a flag to not load any font is set; when menus and statusbars are added, they need special casing. This also means the preferred size calculations reads controlFont directly (it will need the same change). 2014-04-01 21:24:20 -04:00
Pietro Gagliardi 8cb3991ef9 Fixed Windows control sizing: turns out simply calling GetTextMetrics() was not enough, as the GetDC() functions don't load the control font into the DC; we have to do it ourselves with SelectObject() (according to GetTextMetrics()'s docs on MSDN). Upon re-evaluation, the only things that need custom fonts are menus and statusbars; I don't know if menus can be done with the standard contorls and statusbars change the font of all controls inside... so how fonts are handled in classData needs to change now. 2014-04-01 21:17:27 -04:00
Pietro Gagliardi af95232589 More TODOs. 2014-04-01 20:01:38 -04:00
Pietro Gagliardi 76de7db2c0 Remove TODO about GTK+ and Cocoa errors since we're just assuming errors are mistakes I made in the implementation because at this point that's really what we're left with since on Cocoa doing manual exception handling is discouraged... or something like that. 2014-04-01 19:27:45 -04:00
Pietro Gagliardi df087d0ea5 Fixed the Windows stalling when scrolling an Area problem: messages were getting lost because (I assume) scrolling is done in a modal event loop. Alas, we have to change to using a dummy window to handle events. Also altered the respective TODO to document bugs now exposed by this fix. 2014-04-01 19:10:30 -04:00
Pietro Gagliardi 2efda7bc39 Separated initial text from sysData.make() on the Mac OS X backend, completing that set of commits. 2014-04-01 17:05:16 -04:00
Pietro Gagliardi 854ec2d17c More TODOs. 2014-04-01 15:54:55 -04:00
Pietro Gagliardi b2f0fe1956 Reordered each part of the Windows uitask so that it does things in the same order and with the same goroutine setup as the other platforms; this gets rid of a few channels. Also panics on more errors (gets rid of a few more channels) and removed some stray TODOs. 2014-04-01 15:14:57 -04:00
Pietro Gagliardi 6a7cb73dda Added key events to Mac OS X Areas. Now Area is feature-complete (but buggy) on all platforms :D Also more TODOs. 2014-03-30 19:53:44 -04:00
Pietro Gagliardi 41a7e3dab8 Implemented Area mouse events on Mac OS X. Also fixed a few other things left behind in the previous commits. Also more TODOs. 2014-03-30 17:52:27 -04:00
Pietro Gagliardi b94bd1cc60 More TODOs. 2014-03-29 19:40:45 -04:00
Pietro Gagliardi bafb13dd2f Added Alt+[key] and F10 handling to Windows Area key events. Also more TODOs. 2014-03-29 19:30:08 -04:00
Pietro Gagliardi efdd60375a Documented that the clip area in AreaHandler.Paint() more properly and indicate that it is cleared on each AreaHandler.Paint() call; (try to) implement that on Windows (GTK+ does it for us; noted that as well). 2014-03-29 19:02:09 -04:00
Pietro Gagliardi 652797bd3e More TODOs. 2014-03-29 18:55:50 -04:00
Pietro Gagliardi 85182aec67 More TODOs. 2014-03-29 13:11:19 -04:00