Merge pull request #501 from lnis-uofu/time_stamp

Patch the errors in basic regression tests due to ``--no_time_stamp`` support

libopenfpga/libfpgabitstream/src/report_arch_bitstream_distribution.cpp

@@ -33,11 +33,12 @@ void report_architecture_bitstream_distribution_xml_file_head(std::fstream& fp,
  
   fp << "<!-- " << std::endl;
   fp << "\t- Report Architecture Bitstream Distribution" << std::endl;
-  fp << "\t- Version: " << openfpga::VERSION << std::endl;
 
   if (include_time_stamp) {
     auto end = std::chrono::system_clock::now(); 
     std::time_t end_time = std::chrono::system_clock::to_time_t(end);
+    /* Note that version is also a type of time stamp */
+    fp << "\t- Version: " << openfpga::VERSION << std::endl;
     fp << "\t- Date: " << std::ctime(&end_time) ;
   }
 

openfpga/src/fpga_bitstream/write_text_fabric_bitstream.cpp

@@ -35,11 +35,12 @@ void write_fabric_bitstream_text_file_head(std::fstream& fp,
   valid_file_stream(fp);
  
   fp << "// Fabric bitstream" << std::endl;
-  fp << "// Version: " << openfpga::VERSION << std::endl;
 
   if (include_time_stamp) {
     auto end = std::chrono::system_clock::now(); 
     std::time_t end_time = std::chrono::system_clock::to_time_t(end);
+    /* Note that version is also a type of time stamp */
+    fp << "// Version: " << openfpga::VERSION << std::endl;
     fp << "// Date: " << std::ctime(&end_time);
   }
 }

openfpga/src/fpga_bitstream/write_xml_io_mapping.cpp

@@ -35,11 +35,12 @@ void write_io_mapping_xml_file_head(std::fstream& fp,
  
   fp << "<!--" << std::endl;
   fp << "\t- I/O mapping" << std::endl;
-  fp << "\t- Version: " << openfpga::VERSION << std::endl;
 
   if (include_time_stamp) {
     auto end = std::chrono::system_clock::now(); 
     std::time_t end_time = std::chrono::system_clock::to_time_t(end);
+    /* Note that version is also a type of time stamp */
+    fp << "\t- Version: " << openfpga::VERSION << std::endl;
     fp << "\t- Date: " << std::ctime(&end_time) ;
   }
 

openfpga_flow/regression_test_scripts/basic_reg_test.sh

@@ -148,7 +148,7 @@ run-task basic_tests/explicit_multi_verilog_files --debug --show_thread_logs
 echo -e "Testing output files without time stamp";
 run-task basic_tests/no_time_stamp --debug --show_thread_logs
 # Run git-diff to ensure no changes on the golden netlists
-if git diff origin/main HEAD --name-status -- ':openfpga_flow/tasks/basic_tests/no_time_stamp/golden_output_no_time_stamp/**'; then
+if git diff --name-status -- ':openfpga_flow/tasks/basic_tests/no_time_stamp/golden_outputs_no_time_stamp/**'; then
   echo -e "Golden netlist remain unchanged"
 else
   echo -e "Detect changes in golden scripts"; exit 1;

openfpga_flow/tasks/basic_tests/no_time_stamp/golden_outputs_no_time_stamp/bitstream_distribution.xml

@@ -1,6 +1,5 @@
 <!-- 
 	- Report Architecture Bitstream Distribution
-	- Version: 1.0.3764-dev+dd400579-dirty
 --> 
 
 <block name="fpga_top" number_of_bits="527">

openfpga_flow/tasks/basic_tests/no_time_stamp/golden_outputs_no_time_stamp/fabric_bitstream.bit

@@ -1,5 +1,4 @@
 // Fabric bitstream
-// Version: 1.0.3764-dev+dd400579-dirty
 // Bitstream length: 527
 // Bitstream width (LSB -> MSB): 1
 1

openfpga_flow/tasks/basic_tests/no_time_stamp/golden_outputs_no_time_stamp/pin_mapping.xml

@@ -1,6 +1,5 @@
 <!--
 	- I/O mapping
-	- Version: 1.0.3764-dev+dd400579-dirty
 -->
 
 <io_mapping>