280676c7e9
Properly encapsulate the scale in Display
...
Other parts of the code shouldn't have to care about this. Let Display
convert between canvas coordinates and framebuffer coordinates.
2017-02-16 14:00:39 +01:00
8cbf1dd9d2
Set correct cursor style for setCapture()
2017-02-16 14:00:36 +01:00
10d1ecc118
Remove return value from event handlers
...
It's not used in modern event handlers.
2017-02-16 13:59:34 +01:00
a0e3ec0ae6
Stop using window.event
...
It's an old propriatary IE thing that isn't necessary.
2017-02-16 13:59:34 +01:00
af1b2ae1e5
Remove Util.getEventPosition()
...
It mostly dealt with scrolling which we don't use. It also made mistakes
in some cases. Remove it and compute the coordinates directly in the
calling code.
2017-02-16 13:59:34 +01:00
b69dda9b19
Clean up some mouse workarounds
...
Adds comments that clarifies why they are needed. Also narrows the
handler for contextmenu a bit.
2017-02-16 13:59:34 +01:00
1658466579
Improve setCapture polyfill
...
Fix some corner cases.
Fixes issue #773
2017-02-16 13:59:22 +01:00
0ee5ca6ebe
Fix tests after changing auth negotiation
...
PhantomJS has a very basic implementation of Uint8Array, so we
need to help it out a bit.
2017-02-13 15:00:32 +01:00
95533c579e
Better selection of auth type
...
If no authentication is required then we should pick the None
option to avoid bothering the user.
2017-02-13 13:58:10 +01:00
6ffdfd3aa7
Improve check for when to ignore mouse events
...
The browser tells us which element was under the cursor, so we don't
have to calculate it ourselves.
2017-02-09 16:02:58 +01:00
86d15a4929
Use setCapture() polyfill everywhere
...
This makes sure we get consistent behaviour across all browsers.
2017-02-09 15:51:22 +01:00
d314d2c226
Merge branch 'util-console' of https://github.com/tghw/noVNC
2017-02-07 16:37:58 +01:00
d2467189f5
Don't delay WebSocket flushing
...
The native WebSocket is in a much better position to do queue
management than us. We also failed to check the return value and
set up a timer, causing stalls.
This gets us in sync with websockify as of 40238b00.
2017-02-03 17:12:41 +01:00
2e6a58fb15
Avoid changing scale unless necessary
...
It causes the browser to redo the layout needlessly otherwise,
having annoying effects like moving the scroll position.
2017-02-03 12:00:13 +01:00
a6e52f9a73
Merge display scale changes
2017-02-03 11:56:02 +01:00
3e08594c89
Fix rfb._cleanup() ( #743 )
...
We don't have to check for _display or context here since this is a
private function which is never called under such circumstances. This
solves problems caused by display.get_context() which was previously
removed in e549ae074f
2017-01-09 12:49:10 +01:00
558544364c
Fix no auth "this._updateState" bug
...
Fixes #735
2016-12-20 08:37:31 +01:00
c01b2f0259
Merge pull request #699 from CendioOssman/double
...
Display double buffering
2016-12-13 12:42:22 +01:00
adf345fdc4
Clean up viewport handling
...
Make sure the viewport is properly updated when necessary, on respects
given restrictions.
2016-12-09 09:20:50 +01:00
3f781f2aa3
Remove max dimension handling
...
The viewport handling is now a lot clearer, so simply limit the size
of the viewport in the caller rather than having this extra layer
of checks.
2016-12-09 09:20:50 +01:00
e549ae074f
Prevent access to sensitive display variables
...
These should not be directly accessed. Instead use drawing operation
and Display.resize().
2016-12-09 09:20:50 +01:00
84cd0e719e
Double buffering damage tracking
...
Optimise the copy from the hidden canvas to the visible one a bit
by only copying the modified area.
2016-12-09 09:20:50 +01:00
2ba767a7fe
Use double buffering for the display
...
Do all rendering to a hidden canvas and then copy over the finished
frame to the visible canvas once everything is done. This simplifies
things and solves some bugs as we can retain a copy of the entire
frame buffer.
2016-12-09 09:20:50 +01:00
74e390512d
Remove blitStringImage() in favour of imageRect()
...
The latter is more generic and can easily be modified for other
mechanisms in the future.
2016-12-09 09:20:50 +01:00
f5bf2d84ef
Merge pull request #718 from ossman/po
...
Use gettext .po files, and translate everything
2016-11-22 21:02:13 +01:00
edffd9e2f8
Also translate HTML elements
2016-11-19 13:23:00 +01:00
9964ab0e8e
Add a space in logging of RFB._fail()
2016-11-18 10:30:40 +01:00
3cdc603aa4
Use gettext .po files for translations
...
This allows the same workflow as most other projects for translations.
2016-11-17 20:42:08 +01:00
45729def6d
Restore translations for some strings
...
We lost the translation calls for a couple of strings in one of
the clenaups.
2016-11-17 19:58:10 +01:00
f28e248d3f
Use _() as shorthand for translations
...
Used commonly when gettext is used for translations. Avoids cluttering
the code.
2016-11-17 19:58:10 +01:00
67cd2072ab
Allow specifying details when calling RFB._fail()
...
RFB's _fail function logs the error, disconnects the session and sets
disconnect_reason. The disconnect_reason is upon disconnection sent to
the user interface. It is thus not suitable for including error details
that aren't user friendly. The idea is that you will look in the
browser console for a full log with details of the error.
2016-11-10 15:17:37 +01:00
9f909d9b46
Don't wait for websocket closes on failure
...
RFB._fail() can be called at any time in any state, it is not certain
that we will get a close event on the socket since the socket might not
be open. This caused us to hit the disconnect timeout in such cases.
Fixes issue #678
2016-11-10 15:17:37 +01:00
b2e961d48d
Ensure proper connection state transitions
...
Makes the state machine more rubust and clear.
2016-11-10 15:17:31 +01:00
b45905ab86
Handle server-side disconnections
...
Don't handle socket-close events when connected as errors. You could
for example, in the VNC session run 'vncconfig -disconnect'.
2016-11-10 14:33:29 +01:00
e48d1b254e
Separate state actions from connection actions
2016-11-10 14:33:29 +01:00
c4b274ebb8
Move disconnect actions to a separate funciton
...
Done in order to be consistent with connect() and to separate state
actions from connection actions.
2016-11-10 14:33:29 +01:00
376864d6d1
Handle errors while opening a Websocket
...
For example, previously if the user typed in illegal characters in the
port field, no error would be displayed in the interface and the page
would stop at "connecting".
2016-11-10 14:33:29 +01:00
b2cf3b68b3
requestDesktopSize() should always return a value
2016-11-10 14:33:23 +01:00
b85a13de69
Merge pull request #689 from ossman/keysym
...
Don't send Unicode as keysym
2016-11-10 09:36:43 +01:00
b98b2f813d
Added Greek translation
2016-10-28 21:22:25 +03:00
9e26112d1a
Ensure translations variable is set before use
2016-10-28 18:40:56 +02:00
a4fc1fa586
Add Swedish translation
2016-10-28 15:41:08 +02:00
fdb02f8570
Always translate literals instead of variables
...
Makes it much easier to find what needs to be translated.
2016-10-28 15:41:08 +02:00
da88c28714
Remove unnecessary whitespace
2016-10-28 15:41:08 +02:00
a93cda3a36
Move app-specific location of language files
...
The core directory should only contain core API code that isn't
specific to an application.
2016-10-28 14:30:14 +02:00
5af39a878a
Added localization to statusbar
2016-10-28 12:40:28 +02:00
d9ca5e5b6b
Don't allow more than one pending update
2016-10-24 14:42:45 +02:00
bb6965f2e6
Wait for proper image load event
...
There is a specific event for when an image has finished loading,
so trigger on that rather than polling. The polling interval of
requestAnimationFrame() can also be very large.
2016-10-24 14:42:13 +02:00
1578fa68ac
Hide image handling in display object
...
The callers don't need to concern themselves with how images are
rendered, so hide the details behind the API. This also avoids
exposing the render queue.
2016-10-24 14:42:13 +02:00
9535539bb2
Process entire WebSocket message at once
...
setTimeout() causes too much delay to be useful. Also, we
already handle all rects in a message at once, so this shouldn't
be too much of a change.
2016-10-24 14:42:08 +02:00
Samuel Mannehed
Pierre Ossman
Lee-Feng
Pierre Ossman
Giannis Kosmas
Loek Janssen