jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove internal monitoring from Plain tests 

Tests should avoid poking in to the internals and should only look at
external behaviour.
This commit is contained in:
Pierre Ossman 2023-05-23 07:22:10 +02:00
parent 0c80c68e92
commit 336ec86997
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/test.rfb.js
View File

@ -2138,10 +2138,6 @@ describe('Remote Frame Buffer Protocol Client', function () {
pushString(expectedResponse, 'username'); pushString(expectedResponse, 'username');
pushString(expectedResponse, 'password'); pushString(expectedResponse, 'password');
expect(client._sock).to.have.sent(new Uint8Array(expectedResponse)); expect(client._sock).to.have.sent(new Uint8Array(expectedResponse));
sinon.spy(client, "_initMsg");
client._sock._websocket._receiveData(new Uint8Array([0, 0, 0, 0]));
expect(client._initMsg).to.have.been.called;
}); });
it('should support Plain authentication with an empty password', function () { it('should support Plain authentication with an empty password', function () {
@ -2159,10 +2155,6 @@ describe('Remote Frame Buffer Protocol Client', function () {
pushString(expectedResponse, 'username'); pushString(expectedResponse, 'username');
pushString(expectedResponse, ''); pushString(expectedResponse, '');
expect(client._sock).to.have.sent(new Uint8Array(expectedResponse)); expect(client._sock).to.have.sent(new Uint8Array(expectedResponse));
sinon.spy(client, "_initMsg");
client._sock._websocket._receiveData(new Uint8Array([0, 0, 0, 0]));
expect(client._initMsg).to.have.been.called;
}); });
it('should support Plain authentication with a very long username and password', function () { it('should support Plain authentication with a very long username and password', function () {
@ -2180,10 +2172,6 @@ describe('Remote Frame Buffer Protocol Client', function () {
pushString(expectedResponse, 'a'.repeat(300)); pushString(expectedResponse, 'a'.repeat(300));
pushString(expectedResponse, 'b'.repeat(300)); pushString(expectedResponse, 'b'.repeat(300));
expect(client._sock).to.have.sent(new Uint8Array(expectedResponse)); expect(client._sock).to.have.sent(new Uint8Array(expectedResponse));
sinon.spy(client, "_initMsg");
client._sock._websocket._receiveData(new Uint8Array([0, 0, 0, 0]));
expect(client._initMsg).to.have.been.called;
}); });
}); });
}); });