From 336ec86997bdf639d5799c40a262a979019c9471 Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Tue, 23 May 2023 07:22:10 +0200 Subject: [PATCH] Remove internal monitoring from Plain tests Tests should avoid poking in to the internals and should only look at external behaviour. --- tests/test.rfb.js | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tests/test.rfb.js b/tests/test.rfb.js index 9936716e..5422b995 100644 --- a/tests/test.rfb.js +++ b/tests/test.rfb.js @@ -2138,10 +2138,6 @@ describe('Remote Frame Buffer Protocol Client', function () { pushString(expectedResponse, 'username'); pushString(expectedResponse, 'password'); expect(client._sock).to.have.sent(new Uint8Array(expectedResponse)); - - sinon.spy(client, "_initMsg"); - client._sock._websocket._receiveData(new Uint8Array([0, 0, 0, 0])); - expect(client._initMsg).to.have.been.called; }); it('should support Plain authentication with an empty password', function () { @@ -2159,10 +2155,6 @@ describe('Remote Frame Buffer Protocol Client', function () { pushString(expectedResponse, 'username'); pushString(expectedResponse, ''); expect(client._sock).to.have.sent(new Uint8Array(expectedResponse)); - - sinon.spy(client, "_initMsg"); - client._sock._websocket._receiveData(new Uint8Array([0, 0, 0, 0])); - expect(client._initMsg).to.have.been.called; }); it('should support Plain authentication with a very long username and password', function () { @@ -2180,10 +2172,6 @@ describe('Remote Frame Buffer Protocol Client', function () { pushString(expectedResponse, 'a'.repeat(300)); pushString(expectedResponse, 'b'.repeat(300)); expect(client._sock).to.have.sent(new Uint8Array(expectedResponse)); - - sinon.spy(client, "_initMsg"); - client._sock._websocket._receiveData(new Uint8Array([0, 0, 0, 0])); - expect(client._initMsg).to.have.been.called; }); }); });