Support printing and overriding notification ID, so that it's possible
to replace a notification that is currently showing with an updated
content.
Based on patch as provided by Paul Collins in the following bug
report:
https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/257135/comments/8
Co-authored-by: Marco Trevisan (Treviño) <mail@3v1n0.net>
Fixes#19
Snaps use desktop IDs based on the snap name and the application name
inside the snap, so if we're in a such container, we need to compute the
desktop-entry using those values. We can figure them out from the snap
cgroup they're in.
In such case, don't even try to use the GApplication ID as that is
likely wrong in a snapped environment.
We may need to use them in various places, so there's no point to repeat
the same in multiple places, this way we can also use some shortcuts for
non-snap setups.
We used to just add it again, to eventually figure out that the file
did not exists, but may not work properly in some scenarios.
Also always fill the path_filename when using a file-name only, as that
may be refer to something under the SNAP path, and in such case we want
to try check if that exists before giving up.
Do not cut off an icon filename (passed to -i) at the first comma
character. The original motivation probably was to support a list of
icon names in -i separated by comma. However, this has never been
implemented and the help text for -i also only mentions "an icon".
Hence, no functionality is lost by this change. In contrast, -i now
supports commas in icon filepaths.
https://gitlab.gnome.org/GNOME/libnotify/-/issues/16
when pushing a new commit, I noticed the CI build gets stuck on:
Configuring tzdata
------------------
Please select the geographic area in which you live. Subsequent configuration
questions will narrow this down by presenting a list of cities, representing
the time zones in which they are located.
1. Africa 3. Antarctica 5. Arctic 7. Atlantic 9. Indian 11. US
2. America 4. Australia 6. Asia 8. Europe 10. Pacific 12. Etc
Geographic area:
When a non-relocatable application is packaged as a snap, its resources
will be visible under `${SNAP}`. We can discover these resources by
probing paths that are given to us and trying the same path under
`${SNAP}` if the probe fails.
Snap packages have desktop files namespaced by the snap name. This name
is available inside the snap environment as `${SNAP_NAME}`. Also probe
desktop files and try this form of mangled name if the referenced
desktop file is not found.
While some hints like image-path or sound-file supports parameters using the
file:// protocol, it's impossible to pass such hints to notify-send, because
it splits the passed argument so that it can have an unlimited number of colons,
while only 3 should be there (as per TYPE:NAME:VALUE format).
So, make `g_strsplit` to accept only 3 tokens as maximum, while pass the
remaining parameters all-together.
So now it's possible to do
notify-send -h string:image-path:file:///usr/share/icons/foo.png
The generated notify-features.h header lives in builddir, which means it
does not exist in srcdir, where glib-mkenums will look. It also contains
pre-processor symbols only, so it's not really useful.
As we removed it from the list of headers to be scanned by the
introspection parser, we also need to update the files rules for that.
Paul Collins
Marco Trevisan (Treviño)
Corentin Noël
David King
Logan Rathbone
Maximiliano Sandoval R
Ray Strode
Alberts Muktupāvels
Thorsten Wißmann
Matthias Sweertvaegher
Boris Shtrasman
Jan Tojnar
Iain Lane
Florian Müllner
Iain Lane
Abderrahim Kitouni
Emmanuele Bassi
Ting-Wei Lan
Cosimo Cecchi
Quentin Glidic