Commit Graph

461 Commits

Author SHA1 Message Date
Marco Trevisan (Treviño) 4e40a460ce notification: Fix documentation and transfer info for NotifyActionCallback 2022-06-07 03:18:38 +02:00
Logan Rathbone 8162b1d397 Bump version to 0.7.12
Update NEWS.
2022-05-05 12:03:27 -04:00
Logan Rathbone 4d68baf5ef Merge branch 'fix-electron-crash' into 'master'
Closes #25

See merge request GNOME/libnotify!26
2022-05-05 02:10:25 +00:00
Logan Rathbone 596d09a78f notification: Bookend calling NotifyActionCallback with temporary ref
Starting with d0778595, we access the Notification object after the
NotifyActionCallback; some clients (eg, Electron) have historically
unref'd the object at the end of the NotifyActionCallback. They probably
should not have been doing so, but this hotfix adds an additional ref
before and after the callback so that we don't break existing code.

Fixes #25
2022-05-04 21:04:25 -04:00
Logan Rathbone f5b9619b2f doap: Add self as co-maintainer; remove chammond and mccann
Per:
- Discussions on #release-team
- No response to email to mccann in over 10 days
- Email response from chammond confirming he should no longer be listed
  as maintainer

See also: afef1e98
Closes: #14
2022-05-04 11:36:37 -04:00
Marco Trevisan (Treviño) afef1e98b3 Adding myself as maintainer
As discussed on #release-team:

  21:12:18 <ebassi> Trevinho: You could already add yourself to the DOAP file
2022-05-04 16:22:23 +02:00
Marco Trevisan (Treviño) ecb1d4ec08 libnotify.doap: Add missing description field 2022-05-04 16:22:23 +02:00
Patrick Griffis 6d8e38bc69 Merge branch 'pgriffis/delete-unused-file' into 'master'
Delete unused notifynotification.xml

See merge request GNOME/libnotify!25
2022-05-03 20:37:41 +00:00
Patrick Griffis 6e6d52340b Delete unused notifynotification.xml 2022-05-03 20:35:50 +00:00
Marco Trevisan (Treviño) 1fba04bc03 notification: Include sender-pid hint by default if not provided
It's used by various daemons including GNOME Shell to figure out the
parent application.
2022-04-28 01:06:58 +02:00
Marco Trevisan (Treviño) a674e610ee notify-send: Add debug message about server not supporting persistence
In case a transient notification is requested but persistence is not
supported, it's not an error but it is useful to show a debug message
to clarify that.
2022-04-27 21:32:56 +02:00
Marco Trevisan (Treviño) c99aacdb91 notify-send: Move server capabilities check to a separate function 2022-04-27 21:32:30 +02:00
Marco Trevisan (Treviño) 997115b459 docs/notify-send: Add --transient option to manpage 2022-04-27 21:25:10 +02:00
Marco Trevisan (Treviño) e8a57f7245
Bump version to 0.7.11
Update NEWS.
2022-04-27 21:05:49 +02:00
Marco Trevisan (Treviño) ed43da3479 notify-send: Add explicit option to create transient notifications 2022-04-27 20:52:48 +02:00
Marco Trevisan (Treviño) 02f2f91c3d notify-send: Support passing any hint value, by parsing variant strings 2022-04-27 20:45:06 +02:00
Marco Trevisan (Treviño) d6f4734adf notify-send: Add support for boolean hints
Boolean hints are used for some common parameters such as "transient".

Original bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636343
2022-04-27 20:33:40 +02:00
Marco Trevisan (Treviño) 6e871a4047 cleanup: Do not use GLIB_CHECK_VERSION
It's not supported by GLib 2.26.0, the minimum version we required
2022-04-27 20:18:48 +02:00
Marco Trevisan (Treviño) 59553a5af2 NEWS: Add --wait feature to last release 2022-04-27 20:16:49 +02:00
Marco Trevisan (Treviño) 2674c76f53
Bump version to 0.7.10
Update NEWS.
2022-04-27 19:00:44 +02:00
Marco Trevisan (Treviño) d138596c78 CI: Also install the built files and expose docs and logs 2022-04-27 18:29:47 +02:00
Marco Trevisan (Treviño) d07785959c notification: Add support for getting actions activation token
Notification actions can now be activated with an activation token
containing platform data. So update the notification-spec to include
latest version of the specification, and expose the activation token
during an action activation.

Not to change the API, by modifying the type of NotifyActionCallback
it's just better to provide a function to fetch the activation token
during activation only, so that this can be retro-compatible.

Reference: https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a4700
2022-04-27 18:02:20 +02:00
Marco Trevisan (Treviño) 47400a2ff7 notify-send: Clear errors that could be re-used
We're using error variable multiple times, and this may lead to problems
when trying to set it again. So let's just clear once it's used.
2022-04-25 22:23:40 +02:00
Marco Trevisan (Treviño) 1da6996491 notify: Use the application ID if available to set the fallback app name 2022-04-25 22:23:40 +02:00
Ben Blain e05030875e docs/notify-send: Add missing --app-name description to manual 2022-04-25 22:23:40 +02:00
Ben Blain 12d4b90623 notify-send: Check for notification server actions capability support 2022-04-25 22:23:40 +02:00
Ben Blain 6c707d2dfd notify-send: Add support for notification actions and responses
The activated action name is written to stdout and the notification is closed
when a valid action has been selected.
2022-04-25 22:23:37 +02:00
Ben Blain a396dd9af9 notify-send: Add option to wait until notification has been closed
If an expiration timeout is set, the notification is not waited longer
than such time.
2022-04-25 22:15:50 +02:00
Matthias Sweertvaegher 00a7e74774 docs/notify-send: Add print/replace-id arguments to man page 2022-04-25 19:43:12 +02:00
Paul Collins 652b4d6911 notify-send: Support for replacing an existing notification
Support printing and overriding notification ID, so that it's possible
to replace a notification that is currently showing with an updated
content.

Based on patch as provided by Paul Collins in the following bug
report:
  https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/257135/comments/8

Co-authored-by: Marco Trevisan (Treviño) <mail@3v1n0.net>

Fixes #19
2022-04-25 19:42:13 +02:00
Marco Trevisan (Treviño) f9c1cf1b71 notification: Keep converted URIs as such when we prepend a path 2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) 997e2e374a notification: Do not duplicate calls on parse functions 2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) 0d86d8c8d5 notification: Improve debug logs when rewriting paths 2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) b2d6712b15 notification: Avoid creating a new hint variant when nothing has changed 2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) 961f45f44c notification: Use snap name and app name as fallback desktop-entry
Snaps use desktop IDs based on the snap name and the application name
inside the snap, so if we're in a such container, we need to compute the
desktop-entry using those values. We can figure them out from the snap
cgroup they're in.

In such case, don't even try to use the GApplication ID as that is
likely wrong in a snapped environment.
2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) e72396e8ca notification: Preserve snap details into the private struct
We may need to use them in various places, so there's no point to repeat
the same in multiple places, this way we can also use some shortcuts for
non-snap setups.
2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) d21b8140a8 notification: Do not try to append snap name to desktop when it's a path 2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) c4d5ea8baf notification: Do not prepend SNAP prefix when is already present
We used to just add it again, to eventually figure out that the file
did not exists, but may not work properly in some scenarios.

Also always fill the path_filename when using a file-name only, as that
may be refer to something under the SNAP path, and in such case we want
to try check if that exists before giving up.
2022-04-25 19:13:22 +02:00
Marco Trevisan (Treviño) d348a36a05 build: Do not require g-ir-scanner on introspection=auto 2022-04-21 23:53:44 +02:00
Marco Trevisan (Treviño) d5a888fa31 notification: Use g_memdup2 when available
It's not really an issue here, as we use a properly typed len, but
better not to use a deprecated and potentially dangerous API.
2022-04-21 23:53:44 +02:00
Marco Trevisan (Treviño) 736fcea1d0 build: Avoid warnings or mis-behavior in recent meson versions
In future meson will check the run_command result by default, while it's
fine for us, it would cause our nicer error message not to work.
2022-04-21 23:53:44 +02:00
Marco Trevisan (Treviño) 2accd4ceab Revert "Revert "Merge branch 'readme' into 'master'""
This reverts commit 1ad4630107.

As per: https://gitlab.gnome.org/GNOME/libnotify/-/commit/1ad46301#note_1434358
2022-04-21 18:51:13 +02:00
Corentin Noël 333f7c5d32 Send the application ID when possible 2022-04-21 16:35:38 +02:00
David King 7f31e29e62 docs: Use consistent IDs in spec build
This avoids differences between IDs for separate builds of the
specification.
2022-04-21 14:37:58 +02:00
Logan Rathbone 1ad4630107 Revert "Merge branch 'readme' into 'master'"
This reverts merge request !21
2022-03-21 22:19:32 +00:00
Logan Rathbone e35921f10f Merge branch 'readme' into 'master'
Add README clarifying status of libnotify

See merge request GNOME/libnotify!21
2022-03-21 22:15:16 +00:00
Maximiliano Sandoval R edb1dc8394
Add README clarifying status of libnotify
See discussions at https://gitlab.gnome.org/GNOME/libnotify/-/issues/20.

Based off https://gitlab.gnome.org/GNOME/libnotify/-/merge_requests/19
2022-03-14 17:50:55 +01:00
Ray Strode a228f1e84d notify-send: Give failing exit code if showing notification fails
Right now notify-send will quietly return a successful exit status
even if showing the notification fails.

This commit changes the behavior to instead fail on failure.

https://gitlab.gnome.org/GNOME/libnotify/-/merge_requests/13
2021-05-14 13:55:53 -04:00
Marco Trevisan 05112e2a5b Merge branch 'update_documenation' into 'master'
Update documenation (generated man file) to express that plasma notification...

See merge request GNOME/libnotify!14
2021-04-06 11:59:19 +00:00
Alberts Muktupāvels 39575f7c6f Merge branch 'master' into 'master'
notify-send: Support commas in icon filenames

See merge request GNOME/libnotify!15
2021-03-26 15:57:33 +00:00