jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Fix smart HTTP transport protocol handling #952

Open
alixinne wants to merge 1 commits from alixinne/patch-1 into main
pull from: alixinne/patch-1
merge into: jcarr:main
Conversation 0 Commits 1 Files Changed 1 +1 -1
alixinne commented 2023-04-05 16:11:17 -05:00 (Migrated from github.com)
Copy Link

This fixes the smart HTTP transport implementation receive pack service to send requests to /git-receive-pack instead of /info/Refs?service=git-upload-pack.

This issue seems to stem from a bad copy-paste, because this was the only difference when comparing the traces of a git push done with git2go with the regular git client.

In case of a HTTPS push, it would before result in a HTTP 405 Method Not Allowed (at least on the Gitea instance I was testing it on), and it now works.

This fixes the smart HTTP transport implementation receive pack service to send requests to `/git-receive-pack` instead of `/info/Refs?service=git-upload-pack`. This issue seems to stem from a bad copy-paste, because this was the only difference when comparing the traces of a git push done with `git2go` with the regular `git` client. In case of a HTTPS push, it would before result in a `HTTP 405 Method Not Allowed` (at least on the Gitea instance I was testing it on), and it now works.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b alixinne/patch-1 main
git pull origin alixinne/patch-1

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff alixinne/patch-1
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#952
No description provided.
Delete Branch "alixinne/patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?