apply: Add bindings for git_apply_to_tree #657

2020-10-20T13:30:38-05:00

SamiHiltunen commented

2020-10-20 13:30:38 -05:00

(Migrated from github.com)

Adds bindings to the git_apply_to_tree function that allows applying
a diff directly to a tree.

Should this get merged, when do you anticipate a new release that includes these changes?

Adds bindings to the git_apply_to_tree function that allows applying a diff directly to a tree. Should this get merged, when do you anticipate a new release that includes these changes?

suhaibmujahid (Migrated from github.com) reviewed 2020-10-20 14:28:28 -05:00

diff.go

suhaibmujahid (Migrated from github.com) commented

2020-10-20 14:28:27 -05:00

I do not think this is needed since you are using the variable at line 1010.

I do not think this is needed since you are using the variable at line `1010`.

SamiHiltunen (Migrated from github.com) reviewed 2020-10-21 02:58:44 -05:00

diff.go

SamiHiltunen (Migrated from github.com) commented

2020-10-21 02:58:44 -05:00

Good eye, removed. Thanks! 👍

lhchavez (Migrated from github.com) reviewed 2020-10-22 07:35:30 -05:00

lhchavez (Migrated from github.com) left a comment

Should this get merged, when do you anticipate a new release that includes these changes?

immediately! we have automation in place to cut a new patch release the moment a new change gets merged.

> Should this get merged, when do you anticipate a new release that includes these changes? immediately! we have automation in place to cut a new patch release the moment a new change gets merged.

diff_test.go

lhchavez (Migrated from github.com) commented

2020-10-22 07:34:25 -05:00

just a small request, can the commits and trees returned by this function be defer ...Free()d? I know that TestApplyDiffAddFile() doesn't do that either, but we should probably fix that later.

just a small request, can the commits and trees returned by this function be `defer ...Free()`d? I know that `TestApplyDiffAddFile()` doesn't do that either, but we should probably fix that later.