jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Provide missing merge flags #615

Merged
takuji merged 2 commits from add-merge-options into master 2020-06-04 22:34:37 -05:00
Conversation 0 Commits 2 Files Changed 1 +8
takuji commented 2020-06-04 05:37:08 -05:00 (Migrated from github.com)
Copy Link

This change adds two missing merge flags MergeTreeSkipREUC and MergeTreeNoRecursive.
Thanks.

This change adds two missing merge flags MergeTreeSkipREUC and MergeTreeNoRecursive. Thanks.
lhchavez (Migrated from github.com) reviewed 2020-06-04 07:35:29 -05:00
lhchavez (Migrated from github.com) left a comment
Copy Link

nice! just one tiny request

nice! just one tiny request
merge.go
lhchavez (Migrated from github.com) commented 2020-06-04 07:34:41 -05:00
Copy Link

i'll fix the other docstrings on another change, but would it be possible for the added docstrings to follow Go's convention of starting with the name they are describing?

// MergeTreeSkipREUC does not write ...
i'll fix the other docstrings on another change, but would it be possible for the added docstrings to follow Go's convention of starting with the name they are describing? ```go // MergeTreeSkipREUC does not write ... ```
lhchavez (Migrated from github.com) approved these changes 2020-06-04 22:34:22 -05:00
lhchavez (Migrated from github.com) left a comment
Copy Link

Thank you :D

Thank you :D
Sign in to join this conversation.
Reviewers
No reviewers
lhchavez
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#615
No description provided.
Delete Branch "add-merge-options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?