Add branch functions #58

2014-02-22T00:42:10-06:00

jezell commented

2014-02-22 00:42:10 -06:00

(Migrated from github.com)

Clean up consts in #45 and make it build against head

jezell commented

2014-02-24 12:08:03 -06:00

(Migrated from github.com)

Rewrite commits on top of latest head (c6d1bde37c)

Rewrite commits on top of latest head (c6d1bde37cc7f3bd213fc182fd9f60a7cd685419)

carlosmn commented

2014-02-26 03:42:52 -06:00

(Migrated from github.com)

It'd be great if this did build up on top of #45 instead of slurping it all up into a single-commit, leaving the original author without recognition.

jezell commented

2014-02-26 09:36:44 -06:00

(Migrated from github.com)

Fixed

carlosmn commented

2014-02-26 10:33:35 -06:00

(Migrated from github.com)

I merged in an older PR which adds details to error message, any time you used to call

LastError()

you should now call

MakeGitError(ret)

where ret is the return code from libgit2.

I merged in an older PR which adds details to error message, any time you used to call ``` LastError() ``` you should now call ``` MakeGitError(ret) ``` where ret is the return code from libgit2.

carlosmn commented

2014-02-26 10:35:20 -06:00

(Migrated from github.com)

Also, any time we want to be able to get an error from libgit2, we need to lock the OS thread, or we might lose it. Most of these functions need a

runtime.LockOSThread()
defer runtime.UnlockOSThread()

before calling the libgit2 functions.

Also, any time we want to be able to get an error from libgit2, we need to lock the OS thread, or we might lose it. Most of these functions need a ``` go runtime.LockOSThread() defer runtime.UnlockOSThread() ``` before calling the libgit2 functions.

jezell commented

2014-02-26 10:40:39 -06:00

(Migrated from github.com)

Sure. I'll clean it up.

Sign in to join this conversation.

No reviewers