jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

make Delta and DiffLineType stringers #523

Merged
josharian merged 1 commits from diff-stringers into master 2020-02-12 19:03:52 -06:00
Conversation 2 Commits 1 Files Changed 3 +93
josharian commented 2019-08-27 12:02:52 -05:00 (Migrated from github.com)
Copy Link
No description provided.
lhchavez (Migrated from github.com) approved these changes 2020-02-09 09:45:06 -06:00
lhchavez (Migrated from github.com) left a comment
Copy Link

TIL about this command!

TIL about this command!
josharian commented 2020-02-11 23:01:49 -06:00 (Migrated from github.com)
Copy Link

Thanks for the review.

I'd given up on upstreaming my changes, because the repo seemed unmaintained. Glad to see you do a pass through. (Want to hit the merge button on all the approved changes?) Do you anticipate doing more reviewing? That is, should I take the time to put together a bunch of PRs? It's ok if the answer is no--I'm doing just fine all by myself off in my fork.

Thanks for the review. I'd given up on upstreaming my changes, because the repo seemed unmaintained. Glad to see you do a pass through. (Want to hit the merge button on all the approved changes?) Do you anticipate doing more reviewing? That is, should I take the time to put together a bunch of PRs? It's ok if the answer is no--I'm doing just fine all by myself off in my fork.
lhchavez commented 2020-02-12 19:03:38 -06:00 (Migrated from github.com)
Copy Link

I'd given up on upstreaming my changes, because the repo seemed unmaintained. Glad to see you do a pass through. (Want to hit the merge button on all the approved changes?) Do you anticipate doing more reviewing? That is, should I take the time to put together a bunch of PRs? It's ok if the answer is no--I'm doing just fine all by myself off in my fork.

I will do more reviewing :D and I'll try to reply within a reasonable timeframe (hopefully ~48h).

> I'd given up on upstreaming my changes, because the repo seemed unmaintained. Glad to see you do a pass through. (Want to hit the merge button on all the approved changes?) Do you anticipate doing more reviewing? That is, should I take the time to put together a bunch of PRs? It's ok if the answer is no--I'm doing just fine all by myself off in my fork. I will do more reviewing :D and I'll try to reply within a reasonable timeframe (hopefully ~48h).
Sign in to join this conversation.
Reviewers
No reviewers
lhchavez
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#523
No description provided.
Delete Branch "diff-stringers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?