Fix the Cred interface #478

2019-01-15T19:04:06-06:00

lhchavez commented

2019-01-15 19:04:06 -06:00

(Migrated from github.com)

This change adds Cred.Free() and finalizers to prevent memory leaks. It
also makes the interface for Cred more idiomatic and return actual
errors intead of ints.

This change adds Cred.Free() and finalizers to prevent memory leaks. It also makes the interface for Cred more idiomatic and return actual errors intead of ints.

carlosmn (Migrated from github.com) reviewed 2019-02-05 07:34:42 -06:00

credentials.go

carlosmn (Migrated from github.com) commented

2019-02-05 07:23:57 -06:00

There's no need to lock the thread here.

carlosmn (Migrated from github.com) commented

2019-02-05 07:26:59 -06:00

There's no need to check for nil here.

There's no need to check for `nil` here.

carlosmn commented

2019-02-05 07:36:11 -06:00

(Migrated from github.com)

These types tie into the CredentialsCallback type. Unless credentialsCallback learns how to deal with this, code is going to break.

These types tie into the `CredentialsCallback` type. Unless `credentialsCallback` learns how to deal with this, code is going to break.

lhchavez commented

2019-02-10 21:47:23 -06:00

(Migrated from github.com)

These types tie into the CredentialsCallback type. Unless credentialsCallback learns how to deal with this, code is going to break.

Done. We might need to update all the other callbacks, then.

> These types tie into the `CredentialsCallback` type. Unless `credentialsCallback` learns how to deal with this, code is going to break. Done. We might need to update all the other callbacks, then.

Sign in to join this conversation.

No reviewers