[WIP] Use Go's TLS stream instead of whatever the library ships with #372

2017-04-14T06:28:09-05:00

carlosmn commented

2017-04-14 06:28:09 -05:00

(Migrated from github.com)

This lets us have a more consistent set of features across platforms and avoids having to worry about OpenSSL's locking support as much (since crypto itself doesn't seem to need it).

There is no support for proxies in this state. libgit2 itself only supports proxies either on Windows (at a HTTP level which wouldn't use this code anyway) and by piggy-backing off of curl, which this doesn't do either.

I'm not familiar with what proxy support exists in the Go ecosystem, but I assume there must be something that'll let us do HTTP tunneling.

This lets us have a more consistent set of features across platforms and avoids having to worry about OpenSSL's locking support as much (since _crypto_ itself doesn't seem to need it). There is no support for proxies in this state. libgit2 itself only supports proxies either on Windows (at a HTTP level which wouldn't use this code anyway) and by piggy-backing off of curl, which this doesn't do either. I'm not familiar with what proxy support exists in the Go ecosystem, but I assume there must be something that'll let us do HTTP tunneling.

lhchavez commented

2021-09-05 20:30:49 -05:00

(Migrated from github.com)

I just landed https://github.com/libgit2/git2go/pull/810, which was heavily based upon this change, with proxy support!