handles, merge, odb: changes for Go 1.6 pointer passing rules #282

2016-01-07T20:40:34-06:00

ianlancetaylor commented

2016-01-07 20:40:34 -06:00

(Migrated from github.com)

See http://tip.golang.org/cmd/cgo/#hdr-Passing_pointers .

carlosmn commented

2016-02-15 08:50:47 -06:00

(Migrated from github.com)

There's a bunch of unrelated whitespace change that makes this harder to read, could you drop that?

ianlancetaylor commented

2016-02-16 23:41:28 -06:00

(Migrated from github.com)

Pull request updated.

I dropped the whitespace changes, but they were entirely from gofmt. I would suggest running gofmt on the Go files.

Pull request updated. I dropped the whitespace changes, but they were entirely from gofmt. I would suggest running gofmt on the Go files.

carlosmn commented

2016-02-18 06:10:06 -06:00

(Migrated from github.com)

The next branch did get a go fmt treatment, but I've kept master as-is to reduce the amount of in-flight work that would conflict due to whitespace change.

Thanks!

The `next` branch did get a `go fmt` treatment, but I've kept `master` as-is to reduce the amount of in-flight work that would conflict due to whitespace change. Thanks!

Sign in to join this conversation.

No reviewers