jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Switch over the version constraints to v0.28 #531

Merged
suhaibmujahid merged 1 commits from patch-1 into v28 2020-02-16 08:44:16 -06:00
Conversation 6 Commits 1 Files Changed 1 +2 -2
suhaibmujahid commented 2020-01-17 21:09:50 -06:00 (Migrated from github.com)
Copy Link
No description provided.
carlosmn (Migrated from github.com) reviewed 2020-01-17 21:09:50 -06:00
ethomson (Migrated from github.com) reviewed 2020-01-17 21:09:50 -06:00
pks-t (Migrated from github.com) reviewed 2020-01-17 21:09:50 -06:00
vmg (Migrated from github.com) reviewed 2020-01-17 21:09:50 -06:00
mechanicker commented 2020-01-21 10:44:18 -06:00 (Migrated from github.com)
Copy Link

Request merging this change, it is blocking me from upgrading to libgit2 0.28 across Python and Go

For description: https://github.com/libgit2/git2go/pull/532

Request merging this change, it is blocking me from upgrading to libgit2 0.28 across Python and Go For description: https://github.com/libgit2/git2go/pull/532
lhchavez commented 2020-02-12 18:56:56 -06:00 (Migrated from github.com)
Copy Link

Thanks for the patch!

an identical PR was merged earlier today (#515), so closing this one since it would conflict with HEAD

Thanks for the patch! an identical PR was merged earlier today (#515), so closing this one since it would conflict with HEAD
suhaibmujahid commented 2020-02-15 23:52:16 -06:00 (Migrated from github.com)
Copy Link

@lhchavez thank you for looking into this pull request.

I want to let you know that this fix still not merged to the v28 branch. Yes ((#515) have the same fix, but it was merged to the master.

@lhchavez thank you for looking into this pull request. I want to let you know that this fix still not merged to the `v28` branch. Yes ((#515) have the same fix, but it was merged to the `master`.
lhchavez (Migrated from github.com) approved these changes 2020-02-16 08:40:09 -06:00
lhchavez commented 2020-02-16 08:40:39 -06:00 (Migrated from github.com)
Copy Link

@lhchavez thank you for looking into this pull request.

I want to let you know that this fix still not merged to the v28 branch. Yes ((#515) have the same fix, but it was merged to the master.

branches are hard -_-. approved, will merge as soon as Travis says we are good to go.

> @lhchavez thank you for looking into this pull request. > > I want to let you know that this fix still not merged to the `v28` branch. Yes ((#515) have the same fix, but it was merged to the `master`. branches are hard -_-. approved, will merge as soon as Travis says we are good to go.
QuLogic commented 2020-02-18 01:49:12 -06:00 (Migrated from github.com)
Copy Link

There really should be a new tag with this fix, since the last one cannot build as is.

There really should be a new tag with this fix, since the last one cannot build as is.
lhchavez commented 2020-02-18 08:13:59 -06:00 (Migrated from github.com)
Copy Link

There really should be a new tag with this fix, since the last one cannot build as is.

v0.28.4.1 is now live!

> There really should be a new tag with this fix, since the last one cannot build as is. [v0.28.4.1](https://github.com/libgit2/git2go/releases/tag/v0.28.4.1) is now live!
🎉 2
Sign in to join this conversation.
Reviewers
No reviewers
carlosmn
ethomson
pks-t
vmg
lhchavez
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#531
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?