fix invalid guard forcing v27 instead of v28 #515

2019-06-19T12:49:49-05:00

Nivl commented

2019-06-19 12:49:49 -05:00

(Migrated from github.com)

A few months ago a PR has been made to support v28, but the guard around the dynamic lib hasn't been updated. This PR fixes that.

A few months ago a PR has been made to [support v28](https://github.com/libgit2/git2go/commit/5fda6dd90191b1c51a1785ad7cabd2fd5b05e802), but the guard around the dynamic lib hasn't been updated. This PR fixes that.

👍 6

carlosmn (Migrated from github.com) reviewed 2019-06-19 12:49:49 -05:00

jmkim (Migrated from github.com) approved these changes 2019-08-17 02:43:39 -05:00

rssathe commented

2019-08-19 17:33:29 -05:00

(Migrated from github.com)

@Nivl can we get this merged?

Nivl commented

2019-08-19 17:36:18 -05:00

(Migrated from github.com)

@rssathe Unfortunately that's not my call. Ping @carlosmn

👍 3

cmbernard333 commented

2019-09-09 11:03:11 -05:00

(Migrated from github.com)

Bumping this. Definitely want support for latest libgit2 with this library.

rssathe commented

2019-09-12 12:40:38 -05:00

(Migrated from github.com)

@carlosmn any chance we can get this in? There are a few security updates in 0.28 that are important.

segevfiner commented

2019-12-29 05:18:29 -06:00

(Migrated from github.com)

There is a v28 branch building with 0.28 statically but the guard there forces v27 which probably doesn't build.

I think even the tag of v0.28.4 is broken in this way.

There is a v28 branch building with 0.28 statically but the guard there forces v27 which probably doesn't build. I think even the tag of v0.28.4 is broken in this way.

lhchavez (Migrated from github.com) approved these changes 2020-02-09 09:42:44 -06:00

lhchavez (Migrated from github.com) left a comment

oops, sorry about that ><

Sign in to join this conversation.

No reviewers

carlosmn

jmkim

lhchavez