Remove unused parameter in OpenOndisk #256 #469

2018-12-24T21:09:07-06:00

praveentiru commented

2018-12-24 21:09:07 -06:00

(Migrated from github.com)

This is to fix issue #256. Removing parent from OpenOndisk from method signature which is not used.

Risk: Change in method signature will impact dependent programs so, there is need to plan how to incorporate this change.

This is to fix issue #256. Removing parent from OpenOndisk from method signature which is not used. **Risk:** Change in method signature will impact dependent programs so, there is need to plan how to incorporate this change.

carlosmn commented

2019-01-02 15:33:05 -06:00

(Migrated from github.com)

Thanks, I think originally this was supposed to go the other way around and use the passed in configuration instead of the one we instantiate but it's been long enough like this that it's probably not happening (and that probably would be better as a method).

Sign in to join this conversation.

No reviewers