Unused parameter in OpenOndisk(parent *Config, path string) #256

New Issue

2015-09-20T22:14:10-05:00

TheDahv commented

2015-09-20 22:14:10 -05:00

(Migrated from github.com)

This is very minor and low priority, but something I noticed as I was working on a personal project.

It seems as though parent has no bearing on the result of the function. Am I misinterpreting its intent or usage, or is this just fodder for code cleanup?

https://github.com/libgit2/git2go/blob/master/config.go#L329

This is _very_ minor and low priority, but something I noticed as I was working on a personal project. It seems as though `parent` has no bearing on the result of the function. Am I misinterpreting its intent or usage, or is this just fodder for code cleanup? https://github.com/libgit2/git2go/blob/master/config.go#L329

carlosmn commented

2016-02-15 08:07:54 -06:00

(Migrated from github.com)

It's quite possible this was a copy-paste error from OpenLevel() or a similar function. There is no parent here, since it's creating a new configuration object.

It's quite possible this was a copy-paste error from `OpenLevel()` or a similar function. There is no parent here, since it's creating a new configuration object.

praveentiru commented

2018-12-24 19:33:08 -06:00

(Migrated from github.com)

I would like to work on this. But, I am bit confused.
The issue refers OpenOndisk which now at https://github.com/libgit2/git2go/blob/master/config.go#L346 rather than https://github.com/libgit2/git2go/blob/master/config.go#L329 where we have OpenLevel.

I will submit appropriate patch assuming that we want to clean-up OpenOndisk.

I would like to work on this. But, I am bit confused. The issue refers OpenOndisk which now at https://github.com/libgit2/git2go/blob/master/config.go#L346 rather than https://github.com/libgit2/git2go/blob/master/config.go#L329 where we have OpenLevel. I will submit appropriate patch assuming that we want to clean-up OpenOndisk.

carlosmn commented

2019-01-02 15:33:54 -06:00

(Migrated from github.com)

Fixed via #469

Sign in to join this conversation.