jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Fix review comment

This commit is contained in:
Segev Finer 2020-11-13 17:46:43 +02:00
parent af9ac641c1
commit 201889963f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
reference.go
View File

@ -491,7 +491,7 @@ func ReferenceIsValidName(name string) bool {
const ( const (
// This should match GIT_REFNAME_MAX in src/refs.h // This should match GIT_REFNAME_MAX in src/refs.h
refnameMaxLength = 1024 _refnameMaxLength = C.size_t(1024)
) )
type ReferenceFormat uint type ReferenceFormat uint
@ -514,14 +514,13 @@ func ReferenceNormalizeName(name string, flags ReferenceFormat) (string, error)
cname := C.CString(name) cname := C.CString(name)
defer C.free(unsafe.Pointer(cname)) defer C.free(unsafe.Pointer(cname))
bufSize := C.size_t(refnameMaxLength) buf := (*C.char)(C.malloc(_refnameMaxLength))
buf := (*C.char)(C.malloc(bufSize))
defer C.free(unsafe.Pointer(buf)) defer C.free(unsafe.Pointer(buf))
runtime.LockOSThread() runtime.LockOSThread()
defer runtime.UnlockOSThread() defer runtime.UnlockOSThread()
ecode := C.git_reference_normalize_name(buf, bufSize, cname, C.uint(flags)) ecode := C.git_reference_normalize_name(buf, _refnameMaxLength, cname, C.uint(flags))
if ecode < 0 { if ecode < 0 {
return "", MakeGitError(ecode) return "", MakeGitError(ecode)
} }