From 201889963f179e84890d6e2bebd5103e478b7e57 Mon Sep 17 00:00:00 2001 From: Segev Finer Date: Fri, 13 Nov 2020 17:46:43 +0200 Subject: [PATCH] Fix review comment --- reference.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/reference.go b/reference.go index c86f97e..7b5e3c2 100644 --- a/reference.go +++ b/reference.go @@ -491,7 +491,7 @@ func ReferenceIsValidName(name string) bool { const ( // This should match GIT_REFNAME_MAX in src/refs.h - refnameMaxLength = 1024 + _refnameMaxLength = C.size_t(1024) ) type ReferenceFormat uint @@ -514,14 +514,13 @@ func ReferenceNormalizeName(name string, flags ReferenceFormat) (string, error) cname := C.CString(name) defer C.free(unsafe.Pointer(cname)) - bufSize := C.size_t(refnameMaxLength) - buf := (*C.char)(C.malloc(bufSize)) + buf := (*C.char)(C.malloc(_refnameMaxLength)) defer C.free(unsafe.Pointer(buf)) runtime.LockOSThread() defer runtime.UnlockOSThread() - ecode := C.git_reference_normalize_name(buf, bufSize, cname, C.uint(flags)) + ecode := C.git_reference_normalize_name(buf, _refnameMaxLength, cname, C.uint(flags)) if ecode < 0 { return "", MakeGitError(ecode) }