dfecfd5fd4
image_t -> struct image
...
Remove misleading typedef and redundant suffix from struct image.
Also removes the typedef from enum image_type, as it is used in
image.h only.
2009-11-13 11:58:13 -08:00
af949b2531
armv4_5_common_t -> struct arm
...
Remove misleading typedef and just use struct arm.
2009-11-13 11:58:13 -08:00
46fc1d57ac
working_area_t -> struct working_area
...
Remove misleading typedef and redundant suffix from struct working_area.
2009-11-13 11:58:12 -08:00
a8141cafde
mips_ejtag_t -> struct mips_ejtag
...
Remove misleading typedef and redundant suffix from struct mips_ejtag.
2009-11-13 11:58:11 -08:00
3b7aee21b5
mips32_common_t -> struct mips32_common
...
Remove misleading typedef and redundant suffix from struct mips32_common.
2009-11-13 11:58:11 -08:00
e7f65c5a11
avr_common_t -> struct avr_common
...
Remove misleading typedef and redundant suffix from struct avr_common.
2009-11-13 11:58:10 -08:00
5e43565ab5
armv7m_algorithm_t -> struct armv7m_algorithm
...
Remove misleading typedef and redundant suffix from struct armv7m_algorithm.
2009-11-13 11:58:10 -08:00
15e8e45308
armv4_5_algorithm_t -> struct armv4_5_algorithm
...
Remove misleading typedef and redundant suffix from struct armv4_5_algorithm.
2009-11-13 11:58:10 -08:00
056fcdb540
arm_jtag_t -> struct arm_jtag
...
Remove misleading typedef and redundant suffix from struct arm_jtag.
2009-11-13 11:58:10 -08:00
8012b3963f
arm7_9_common_t -> struct arm7_9_common
...
Remove misleading typedef and redundant suffix from struct arm7_9_common.
2009-11-13 11:58:09 -08:00
b1de5eb9a0
reg_param_t -> struct reg_param
...
Remove misleading typedef and redundant suffix from struct reg_param.
2009-11-13 11:58:09 -08:00
6c965a3da9
mem_param_t -> struct mem_param
...
Remove misleading typedef and redundant suffix from struct mem_param.
2009-11-13 11:58:09 -08:00
43483e5054
remove unused aduc702x structure.
...
The ADUC702x_FLASH_MMIO structure was completely used, so it must die.
2009-11-13 11:58:08 -08:00
a03c9a8dce
aduc702x_flash_bank_t -> struct aduc702x_flash_bank
...
Remove misleading typedef and redundant suffix from struct
aduc702x_flash_bank.
2009-11-13 11:58:08 -08:00
6a374afe71
tms470_flash_bank_t -> struct tms470_flash_bank
...
Remove misleading typedef and redundant suffix from struct tms470_flash_bank.
2009-11-13 11:58:08 -08:00
3c9afaa645
pic32mx_mem_layout_t -> struct pic32mx_mem_layout
...
Remove misleading typedef and redundant suffix from struct pic32mx_mem_layout.
2009-11-13 11:58:08 -08:00
54be77bc79
non_cfi_t -> struct non_cfi
...
Remove misleading typedef and redundant suffix from struct non_cfi.
2009-11-13 11:58:08 -08:00
d0dfec33b6
nand_block_t -> struct nand_block
...
Remove misleading typedef and redundant suffix from struct nand_block.
2009-11-13 11:58:07 -08:00
92fc7a6fde
str9xpec_flash_controller_t -> struct str9xpec_flash_controller
...
Remove misleading typedef and redundant suffix from struct str9xpec_flash_controller.
2009-11-13 11:58:07 -08:00
6aa82891b6
str9x_flash_bank_t -> struct str9x_flash_bank
...
Remove misleading typedef and redundant suffix from struct str9x_flash_bank.
2009-11-13 11:58:07 -08:00
774d71f2cf
str7x_mem_layout_t -> struct str7x_mem_layout
...
Remove misleading typedef and redundant suffix from struct str7x_mem_layout.
2009-11-13 11:58:07 -08:00
3b09560ae8
str7x_flash_bank_t -> struct str7x_flash_bank
...
Remove misleading typedef and redundant suffix from struct str7x_flash_bank.
2009-11-13 11:58:07 -08:00
01b10d65bf
stm32x_mem_layout_t -> struct stm32x_mem_layout
...
Remove misleading typedef and redundant suffix from struct stm32x_mem_layout.
2009-11-13 11:58:07 -08:00
c7b2cad52d
stm32x_flash_bank_t -> struct stm32x_flash_bank
...
Remove misleading typedef and redundant suffix from struct stm32x_flash_bank.
2009-11-13 11:58:07 -08:00
40273967bf
stm32x_options_t -> struct stm32x_options
...
Remove misleading typedef and redundant suffix from struct stm32x_options.
2009-11-13 11:58:07 -08:00
9059f9f28e
stellaris_flash_bank_t -> struct stellaris_flash_bank
...
Remove misleading typedef and redundant suffix from struct stellaris_flash_bank.
2009-11-13 11:58:07 -08:00
ed9c4ef3c4
s3c24xx_nand_controller_t -> struct s3c24xx_nand_controller
...
Remove misleading typedef and redundant suffix from struct s3c24xx_nand_controller.
2009-11-13 11:58:07 -08:00
eba5608b52
pic32mx_flash_bank_t -> struct pic32mx_flash_bank
...
Remove misleading typedef and redundant suffix from struct pic32mx_flash_bank.
2009-11-13 11:58:07 -08:00
5948e66ee8
orion_nand_controller_t -> struct orion_nand_controller
...
Remove misleading typedef and redundant suffix from struct orion_nand_controller.
2009-11-13 11:58:07 -08:00
c7b96a4dc1
ocl_priv_t -> struct ocl_priv
...
Remove misleading typedef and redundant suffix from struct ocl_priv.
2009-11-13 11:58:07 -08:00
958ff04b08
nand_info_t -> struct nand_info
...
Remove misleading typedef and redundant suffix from struct nand_info.
2009-11-13 11:58:07 -08:00
f7ca047213
nand_manufacturer_t -> struct nand_manufacturer
...
Remove misleading typedef and redundant suffix from struct nand_manufacturer.
2009-11-13 11:58:07 -08:00
8f4860d13f
nand_ecclayout_t -> struct nand_ecclayout
...
Remove misleading typedef and redundant suffix from struct nand_ecclayout.
2009-11-13 11:58:07 -08:00
8605352387
nand_flash_controller_t -> struct nand_flash_controller
...
Remove misleading typedef and redundant suffix from struct nand_flash_controller.
2009-11-13 11:58:07 -08:00
4bc46d61ca
mx3_nf_controller_t -> struct mx3_nf_controller
...
Remove misleading typedef and redundant suffix from struct mx3_nf_controller.
2009-11-13 11:58:07 -08:00
79338ec6c2
mflash_bank_t -> struct mflash_bank
...
Remove misleading typedef and redundant suffix from struct mflash_bank.
2009-11-13 11:58:07 -08:00
bb6b9988cb
mg_drv_info_t -> struct mg_drv_info
...
Remove misleading typedef and redundant suffix from struct mg_drv_info.
2009-11-13 11:58:07 -08:00
fc01dd6a13
mflash_gpio_drv_t -> struct mflash_gpio_drv
...
Remove misleading typedef and redundant suffix from struct mflash_gpio_drv.
2009-11-13 11:58:06 -08:00
a043632a52
mflash_gpio_num_t -> struct mflash_gpio_num
...
Remove misleading typedef and redundant suffix from struct mflash_gpio_num.
2009-11-13 11:58:06 -08:00
ed1aed8dd9
lpc3180_nand_controller_t -> struct lpc3180_nand_controller
...
Remove misleading typedef and redundant suffix from struct lpc3180_nand_controller.
2009-11-13 11:58:06 -08:00
b712a4e8b8
lpc2900_flash_bank_t -> struct lpc2900_flash_bank
...
Remove misleading typedef and redundant suffix from struct lpc2900_flash_bank.
2009-11-13 11:58:06 -08:00
12f83f0429
lpc288x_flash_bank_t -> struct lpc288x_flash_bank
...
Remove misleading typedef and redundant suffix from struct lpc288x_flash_bank.
2009-11-13 11:58:06 -08:00
a15d4cc75e
lpc2000_flash_bank_t -> struct lpc2000_flash_bank
...
Remove misleading typedef and redundant suffix from struct lpc2000_flash_bank.
2009-11-13 11:58:06 -08:00
632fd663a8
flash_driver_t -> struct flash_driver
...
Remove misleading typedef and redundant suffix from struct flash_driver.
2009-11-13 11:58:06 -08:00
fb59ec739a
flash_sector_t -> struct flash_sector
...
Remove misleading typedef and redundant suffix from struct flash_sector.
2009-11-13 11:58:06 -08:00
98d7ed8523
faux_flash_bank_t -> struct faux_flash_bank
...
Remove misleading typedef and redundant suffix from struct faux_flash_bank.
2009-11-13 11:58:06 -08:00
de1781b7fa
ecosflash_flash_bank_t -> struct ecosflash_flash_bank
...
Remove misleading typedef and redundant suffix from struct ecosflash_flash_bank.
2009-11-13 11:58:06 -08:00
453a103f48
cfi_fixup_t -> struct cfi_fixup
...
Remove misleading typedef and redundant suffix from struct cfi_fixup.
2009-11-13 11:58:06 -08:00
4c28cc68ed
cfi_unlock_addresses_t -> struct cfi_unlock_addresses
...
Remove misleading typedef and redundant suffix from struct cfi_unlock_addresses.
2009-11-13 11:58:06 -08:00
0139e7d51a
cfi_spansion_pri_ext_t -> struct cfi_spansion_pri_ext
...
Remove misleading typedef and redundant suffix from struct cfi_spansion_pri_ext.
2009-11-13 11:58:06 -08:00
2ded74115d
cfi_atmel_pri_ext_t -> struct cfi_atmel_pri_ext
...
Remove misleading typedef and redundant suffix from struct cfi_atmel_pri_ext.
2009-11-13 11:58:06 -08:00
1f328f2885
cfi_intel_pri_ext_t -> struct cfi_intel_pri_ext
...
Remove misleading typedef and redundant suffix from struct cfi_intel_pri_ext.
2009-11-13 11:58:06 -08:00
3be0edbc5e
cfi_flash_bank_t -> struct cfi_flash_bank
...
Remove misleading typedef and redundant suffix from struct cfi_flash_bank.
2009-11-13 11:58:06 -08:00
a7a8a1c9e2
avrf_flash_bank_t -> struct avrf_flash_bank
...
Remove misleading typedef and redundant suffix from struct avrf_flash_bank.
2009-11-13 11:58:06 -08:00
6ca63ee756
avrf_type_t -> struct avrf_type
...
Remove misleading typedef and redundant suffix from struct avrf_type.
2009-11-13 11:58:06 -08:00
3877201581
at91sam7_flash_bank_t -> struct at91sam7_flash_bank
...
Remove misleading typedef and redundant suffix from struct at91sam7_flash_bank.
2009-11-13 11:58:05 -08:00
d0809ac060
scan_field_t -> struct scan_field
...
Remove useless structure typedef.
2009-11-13 11:58:04 -08:00
42ef503d37
jtag_tap_t -> struct jtag_tap
...
Search and destroy the jtag_tap_t typedef. This also cleans up a
layering violation, removing the declaration from types.h.
2009-11-13 11:58:04 -08:00
9f212b01be
fileio_t -> struct fileio
...
Remove useless structure typedef.
2009-11-13 11:58:04 -08:00
d22270e0ed
command_handler_t: make argc unsigned
...
The number of command arguments will always be 0 or more, so use
the right type in handlers. This has a cascading effect up through
the layers, but the new COMMAND_HANDLER macros prevented total chaos.
2009-11-13 10:55:27 -08:00
a585bdf726
add CMD_NAME macro for command handlers
...
By introducing the CMD_NAME macro, this parameter may be integrated
as args[-1] in command.[ch], without touching any other call sites.
2009-11-13 10:55:00 -08:00
5b6df55a1e
use CALL_COMMAND_HANDLER instead of direct calls
...
By using CALL_COMMAND_HANDLER, parameters can be reordered, added, or
even removed in inherited signatures, without requiring revisiting
all of the various call sites.
2009-11-13 10:51:46 -08:00
670f999e7a
nand: add NAND_DEVICE_COMMAND_HANDLER macro
...
Abstracts the extended NAND command handling to allow the function
signature to be controlled by __COMMAND_HANDLER.
2009-11-13 10:51:46 -08:00
0796dfff89
use FLASH_BANK_COMMAND_HANDLER macro
...
Defines all flash_bank_command handlers using the new macro.
2009-11-13 10:51:46 -08:00
57c5c5f463
add FLASH_BANK_COMMAND_HANDLER macro
...
The FLASH_BANK_COMMAND_HANDLER provides an extended command handler
using the __COMMAND_HANDLER macro, whereby changing that macro is
sufficient to update flash handlers with the new signature. It also
enforces uniform style and scope when implementing this handler.
2009-11-13 10:51:46 -08:00
76868e0713
s3c24xx: use COMMAND_HANDLER with command helper
...
Add S3C24XX_DEVICE_COMMAND macros to abstract common command handler
conventions.
2009-11-13 10:51:46 -08:00
cfc4d5c6b7
use COMMAND_HANDLER macro to define all commands
2009-11-13 10:51:45 -08:00
e8e94ab245
nand: rename device to nand
...
To be more informative (and consistent with flash and pld trees), change
'device' parameter name to 'nand' in NAND source files. This change
eliminates confusing 'device->device->' instance from the code, and
it simplifies the forthcoming command handler patches.
2009-11-12 22:25:55 -08:00
2821115ab8
remove obsolete doxygen comments
...
Documenting command handler parameters is redundant and pointless.
2009-11-11 11:53:22 -08:00
39ab1c1a41
remove more useless declarations
...
Removes forward declarations by moving command registration after
defintion of the command handlers.
2009-11-11 11:53:22 -08:00
ca594adb5a
add const keyword to some APIs
...
Add 'const' keyword to 'char *' parameters to allow command handlers to
pass constant string arguments. These changes allow the 'args' command
handler to be changed to 'const' in a subsequent patch.
2009-11-11 11:53:22 -08:00
9741e126fd
change argv to args in command handlers
...
Subsequent patches expect all command handlers to use a uniform
parameter naming scheme. In the entire tree, these two files used
standard 'argv' instead of our non-standard 'args'. This patch opts
to reduces the noise required to unify the command handlers, using
dominant 'args' form.
A future patch may be used to convert us back to the standard argv, but
that requires coordination with all developers to minimize disruptions.
2009-11-11 11:50:36 -08:00
b7b4efcdf1
makefiles: improve build order
...
Separates various groups of files to be built in logical succession.
In each layer, the core module (target.c, nand.c, etc.) is built _after_
their helper modules (e.g. image.c, nand_ecc.c) but _before_ any of
their drivers (e.g. arm966e.c, mx3_nand.c).
This allows problems introduced at the bottom of the stack to result
in build failures as soon as possible, as the helpers and core should
wrap portions of them.
2009-11-11 05:40:48 -08:00
2351641b8f
{pic32m,stm32}x.c: remove useless declarations
...
Remove useless forward declarations.
Moves command registrations to end of files.
Moves flash structure definitions to end of files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:48 -08:00
6cd97f48d0
str{7,9}x*.c: remove useless forward declarations
...
Remove useless forward declarations.
Moves command registrations to end of files.
Moves flash structure definitions to end of files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
041c319d9d
flash/<various>.c: remove useless declarations
...
Remove useless forward declarations.
Moves flash structure definitions to end of files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
712d3fc0fb
flash/<assorted>.c: remove useless declarations
...
Remove useless forward declarations.
Moves command registrations to end of files.
Moves flash structure definitions to end of files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
4cd02c63e9
flash/at91sam[37].c: remove useless declarations
...
Remove useless forward declarations.
Moves command registration to end of file.
Moves flash structure definitions to end of files.
Changes a few references to global flash structure to local refs.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
770716e9e0
flash/lpc2???.c: remove useless declarations
...
Remove useless forward declarations.
Moves command registrations to end of files.
Moves flash structure definitions to end of files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
8b5c5c054d
flash/*nand*.c: remove useless declarations
...
Remove useless forward declarations.
Moves command registration to end of files.
Moves flash structure definition to end of files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
5c95741df7
flash/flash.c: remove forward declarations
...
Remove useless forward declarations.
Moves command registration to end of file.
Moves flash structure definition to end of file.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
2009-11-09 18:42:47 -08:00
81fbc63718
src/flash: remove 'extern' and wrap headers
...
Removes 'extern' keywords from function prototypes in the flash headers.
Wraps long lines to fit into 80 columns.
Adds multiple inclusion protection for s3c2xx_nand.h.
2009-11-09 09:44:33 -08:00
2689f58f2a
Overhaul time support API
...
This patch changes the duration_* API in several ways. First, it
updates the API to use better names. Second, string formatting has
been removed from the API (with its associated malloc). Finally, a
new function added to convert the time into seconds, which can be
used (or formatted) by the caller. This eliminates hidden calls to
malloc that require associated calls to free().
This patch also removes the useless extern keyword from prototypes,
and it eliminates the duration_t typedef (use 'struct duration').
These API also allows proper error checking, as it is possible for
gettimeofday to fail in certain circumstances.
The consumers have all been chased to use this new API as well, as
there were relatively few cases doing this type of measurement.
In most cases, the code performs additional checks for errors, but
the calling code looks much cleaner in every case.
2009-11-09 01:21:50 -08:00
ca00483a95
Simplify nand indentation.
...
Removes check covered by new nand_command_get_device_by_num helper.
Reverses logic of probe check to further reduce indentation.
2009-11-06 02:52:56 -08:00
ff61e6a37c
Improve flash indentation.
...
Removes redundant tests and reverses backwards logic to reduce the
indentation level in flash.c.
2009-11-06 02:52:51 -08:00
36b4ac90e4
Improve str9xpec command argument parsing.
2009-11-05 18:19:19 -08:00
fa9e5d1027
Improve str9x config command argument parsing.
2009-11-05 18:19:19 -08:00
111b7a6a9d
Improve str7x config command argument parsing.
2009-11-05 18:19:19 -08:00
aa9351ba46
Improve stm32x.c command argument parsing.
2009-11-05 18:19:19 -08:00
786106d725
Improve stellaris.c erase argument parsing.
2009-11-05 18:19:19 -08:00
fc116380bf
Improve pic32mx.c command argument parsing.
2009-11-05 18:19:18 -08:00
ee4723c494
Improve mflash.c command argument parsing.
2009-11-05 18:19:18 -08:00
c63671e4f7
Improve lpc3180_nand_controller.c parsing.
...
This fixes a memory leak in lpc3180_nand_device_command by
reordering the malloc to occur after all parsing has completed.
2009-11-05 18:19:18 -08:00
7b2d8d93e6
Improve lpc2900.c command argument parsing.
2009-11-05 18:19:18 -08:00
0004691e91
Improve lpc288x.c command argument parsing.
2009-11-05 18:19:18 -08:00
7f6ad49d12
Improve lpc2000.c command argument parsing.
2009-11-05 18:19:18 -08:00
680e22c4d7
Improve cfi.c command argument parsing.
2009-11-05 18:19:18 -08:00
7b3d54a127
Improve avrf.c command argument parsing.
2009-11-05 18:19:18 -08:00
266c423bbd
Improve orion_nand.c command argument parsing.
2009-11-05 18:19:18 -08:00
7b49739790
Improve davinci_nand.c command argument parsing.
2009-11-05 18:19:18 -08:00
Zachary T Welch