interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

jtag/drivers/cmsis_dap: add LOG_DEBUG_IO to cmsis_dap_metacmd_targetsel 

Make write to DP_TARGETSEL is logged the similar way as other DP register
read/writes.

While on it fix checkpatch message
'Concatenated strings should use spaces between elements'

Change-Id: I98f724c984e8c4610cc461340f4c4a7cc9627ed9
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: https://review.openocd.org/c/openocd/+/7219
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Jonathan Bell <jonathan@raspberrypi.com>
Tested-by: jenkins
This commit is contained in:
Tomas Vanek 2022-09-21 09:47:05 +02:00 committed by Antonio Borneo
parent 48507e3b10
commit 1d77fc74e1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/jtag/drivers/cmsis_dap.c
View File

@ -573,6 +573,8 @@ static int cmsis_dap_metacmd_targetsel(uint32_t instance_id)
The purpose of this operation is to select the target The purpose of this operation is to select the target
corresponding to the instance_id that is written */ corresponding to the instance_id that is written */
LOG_DEBUG_IO("DP write reg TARGETSEL %" PRIx32, instance_id);
size_t idx = 0; size_t idx = 0;
command[idx++] = CMD_DAP_SWD_SEQUENCE; command[idx++] = CMD_DAP_SWD_SEQUENCE;
command[idx++] = 3; /* sequence count */ command[idx++] = 3; /* sequence count */
@ -783,7 +785,7 @@ static void cmsis_dap_swd_write_from_queue(struct cmsis_dap *dap)
uint8_t cmd = transfer->cmd; uint8_t cmd = transfer->cmd;
uint32_t data = transfer->data; uint32_t data = transfer->data;
LOG_DEBUG_IO("%s %s reg %x %"PRIx32, LOG_DEBUG_IO("%s %s reg %x %" PRIx32,
cmd & SWD_CMD_APNDP ? "AP" : "DP", cmd & SWD_CMD_APNDP ? "AP" : "DP",
cmd & SWD_CMD_RNW ? "read" : "write", cmd & SWD_CMD_RNW ? "read" : "write",
(cmd & SWD_CMD_A32) >> 1, data); (cmd & SWD_CMD_A32) >> 1, data);
@ -889,7 +891,7 @@ static void cmsis_dap_swd_read_process(struct cmsis_dap *dap, int timeout_ms)
uint32_t tmp = data; uint32_t tmp = data;
idx += 4; idx += 4;
LOG_DEBUG_IO("Read result: %"PRIx32, data); LOG_DEBUG_IO("Read result: %" PRIx32, data);
/* Imitate posted AP reads */ /* Imitate posted AP reads */
if ((transfer->cmd & SWD_CMD_APNDP) || if ((transfer->cmd & SWD_CMD_APNDP) ||