From 1d77fc74e11d8eed87111216dd01e94d900c00c0 Mon Sep 17 00:00:00 2001 From: Tomas Vanek Date: Wed, 21 Sep 2022 09:47:05 +0200 Subject: [PATCH] jtag/drivers/cmsis_dap: add LOG_DEBUG_IO to cmsis_dap_metacmd_targetsel Make write to DP_TARGETSEL is logged the similar way as other DP register read/writes. While on it fix checkpatch message 'Concatenated strings should use spaces between elements' Change-Id: I98f724c984e8c4610cc461340f4c4a7cc9627ed9 Signed-off-by: Tomas Vanek Reviewed-on: https://review.openocd.org/c/openocd/+/7219 Reviewed-by: Antonio Borneo Reviewed-by: Jonathan Bell Tested-by: jenkins --- src/jtag/drivers/cmsis_dap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/jtag/drivers/cmsis_dap.c b/src/jtag/drivers/cmsis_dap.c index e708d5252..2f5f9c907 100644 --- a/src/jtag/drivers/cmsis_dap.c +++ b/src/jtag/drivers/cmsis_dap.c @@ -573,6 +573,8 @@ static int cmsis_dap_metacmd_targetsel(uint32_t instance_id) The purpose of this operation is to select the target corresponding to the instance_id that is written */ + LOG_DEBUG_IO("DP write reg TARGETSEL %" PRIx32, instance_id); + size_t idx = 0; command[idx++] = CMD_DAP_SWD_SEQUENCE; command[idx++] = 3; /* sequence count */ @@ -783,7 +785,7 @@ static void cmsis_dap_swd_write_from_queue(struct cmsis_dap *dap) uint8_t cmd = transfer->cmd; uint32_t data = transfer->data; - LOG_DEBUG_IO("%s %s reg %x %"PRIx32, + LOG_DEBUG_IO("%s %s reg %x %" PRIx32, cmd & SWD_CMD_APNDP ? "AP" : "DP", cmd & SWD_CMD_RNW ? "read" : "write", (cmd & SWD_CMD_A32) >> 1, data); @@ -889,7 +891,7 @@ static void cmsis_dap_swd_read_process(struct cmsis_dap *dap, int timeout_ms) uint32_t tmp = data; idx += 4; - LOG_DEBUG_IO("Read result: %"PRIx32, data); + LOG_DEBUG_IO("Read result: %" PRIx32, data); /* Imitate posted AP reads */ if ((transfer->cmd & SWD_CMD_APNDP) ||