Commit Graph

3519 Commits

Author SHA1 Message Date
Pietro Gagliardi 59d8e81b85 There, found the reason that code doesn't work (LVIF_ICON was as tall as LVIF_BOUNDS) and fixed it (use the actual icon size for vertical centering) 2018-06-12 01:54:21 -04:00
Pietro Gagliardi 0f89418a95 Fixed a typo in tableimages.cpp. Okay, so the code I had before worked purely by accident, and this code doesn't. Wonderful... 2018-06-12 01:40:26 -04:00
Pietro Gagliardi 8f0019af10 Tried to combine all the Windows table metrics stuff. This broke things, so we'll have to go back to the drawing board here. 2018-06-11 22:22:54 -04:00
Pietro Gagliardi c843f1e62d More TODOs. 2018-06-11 08:01:18 -04:00
Pietro Gagliardi 0c6e7add01 Experimented with custom-drawing the text, this time in a nicer place thatn the default. Okay, this isn't too bad, especially now that it seems everything is vertically centered... 2018-06-10 23:03:54 -04:00
Pietro Gagliardi dfb3bd39f1 Some more TODO work. I might as well try custom drawing text now. 2018-06-10 20:18:07 -04:00
Pietro Gagliardi cd2a6f7c29 Fixed the checkbox y-offset issue. There are other issues, but this is more hopeful already... 2018-06-10 19:54:44 -04:00
Pietro Gagliardi 2a2990f19c I have no clue anymore. Tempted to undo checkbox stuff entirely for now. 2018-06-10 19:07:34 -04:00
Pietro Gagliardi 94a3397894 Tried to resolve checkboxes appearing selected. It doesn't work fully yet, so the actual drawing that makes it work is disabled for now. But the handler for NM_CUSTOMDRAW now has a hook to become cleaner in the future. 2018-06-10 17:38:51 -04:00
Pietro Gagliardi 5a5f9ba9ac And added themed checkboxes. 2018-06-10 13:15:21 -04:00
Pietro Gagliardi 8dd9f08ba4 Actually one more quick test fix to cycle through all the images before continuing. Okay, NOW for themed checkboxes. 2018-06-10 10:45:50 -04:00
Pietro Gagliardi c22f643df7 More image and checkbox fixups. Next: themed checkboxes. 2018-06-10 10:43:29 -04:00
Pietro Gagliardi a3feb425a1 Started splitting image and checkbox stuff into its own file. Also started adopting HRESULT returns everywhere, because why not make the conversion to it later slightly easier by starting now. 2018-06-10 00:51:50 -04:00
Pietro Gagliardi 8d43b55ff8 Removed some now-unused stuff. 2018-06-09 23:55:43 -04:00
Pietro Gagliardi 405a6defd2 Started using normal images for checkboxes in Windows uiTables. It doesn't quite work yet. 2018-06-09 23:25:16 -04:00
Pietro Gagliardi 4c5f0961fe Started an implementation of checkboxes in table.cpp. List View simply does not seem to support state images in subitems, so we'll have to improvise. Hopefully this won't screw accessibility. 2018-06-09 23:02:37 -04:00
Pietro Gagliardi 0f59bf7399 More TODOs. 2018-06-09 20:42:13 -04:00
Pietro Gagliardi b43fb4b247 And added images to uiTable. Right now it's loading the 32x32 images into the table instead of the 16x16 ones, but hey, it works! 2018-06-09 20:35:05 -04:00
Pietro Gagliardi a858300f25 Filled in image.cpp. Also switched on WIC since we'll need it for uiArea, though uiTable will still need classic GDI. Now let's integrate this into uiTable. 2018-06-09 19:24:36 -04:00
Pietro Gagliardi 3aee505f4e Weirdness workarounds. 2018-06-09 14:32:04 -04:00
Pietro Gagliardi ff64685655 More work. List View is starting to show its dumbness again. 2018-06-09 13:57:43 -04:00
Pietro Gagliardi 1c9f9627c0 Started image support for Windows tables. 2018-06-09 12:15:50 -04:00
Pietro Gagliardi c6c4dbd580 Started handling colors in the Windows table code. 2018-06-09 10:40:42 -04:00
Pietro Gagliardi 06a8044c2c Oops, forgot to keep the string queue full. It works! Now to switch to custom draw. 2018-06-08 22:11:46 -04:00
Pietro Gagliardi 69e91a9678 Fixed build errors and some logic errors. Let's hope it works! 2018-06-08 22:05:11 -04:00
Pietro Gagliardi 71a310909d Oops 2018-06-08 21:45:30 -04:00
Pietro Gagliardi 41d63bd0cf And finished rewriting table.cpp. That wasn't too bad for just text columns. Let's hope it works. 2018-06-08 21:44:55 -04:00
Pietro Gagliardi 516eb312fc Rearranged stuff in table.cpp on Windows and started rewriting it to handle owner-data in the new API. 2018-06-08 21:16:06 -04:00
Pietro Gagliardi 3aa16e844d Adjusted uiTableModel on Windows for owner-data list views. 2018-06-08 01:35:23 -04:00
Pietro Gagliardi ca2115ca57 Removed some old files from wintable that we won't use anymore. 2018-06-08 01:23:11 -04:00
Pietro Gagliardi 0adad7743a Drop mixing of C and C++ class allocations, including placement new. This is the easiest change I can make to the Windows table code for now... 2018-06-07 22:54:01 -04:00
Pietro Gagliardi 7a40bdfb3f Amazingly, it worked the first time! Just a quick logic error here. 2018-06-07 22:30:43 -04:00
Pietro Gagliardi 66ca3315cf Fixed compile errors. Now for runtime errors, if any! 2018-06-07 22:25:17 -04:00
Pietro Gagliardi d6ac22a20a Finished rewriting table.c. Now to test. 2018-06-07 21:50:38 -04:00
Pietro Gagliardi b7151388e3 Started rewriting the column constructors. 2018-06-05 22:47:11 -04:00
Pietro Gagliardi 18d8a8fe22 Converted column functions and editable handlers on GTK+. 2018-06-05 22:00:54 -04:00
Pietro Gagliardi 75a5a050cb Split the uiTableModel GTK+ code into its own file, tablemodel.c. 2018-06-04 23:46:30 -04:00
Pietro Gagliardi 94fa10b35e Started rewriting GTK+ uiTable. Did uiTableModel first. 2018-06-04 23:39:52 -04:00
Pietro Gagliardi 7a5577db94 Deleted now-irrelevant code from OLD_table.m. 2018-06-04 23:28:46 -04:00
Pietro Gagliardi 3c063c71d5 And one more TODO before we move on. 2018-06-04 22:15:05 -04:00
Pietro Gagliardi 0a6a781be7 And implemented row background colors and button clicks. OS X implementation done for now! 2018-06-04 22:14:05 -04:00
Pietro Gagliardi 3fa15d5277 Fixed graphical glitches in the OS X Table. Finally. SOMEHOW. 2018-06-04 20:17:15 -04:00
Pietro Gagliardi 8c611cf95d And added the rest of the column types to the tester. 2018-06-04 20:13:35 -04:00
Pietro Gagliardi 71e02a5c6e And set up the constraints for the other column types. 2018-06-04 20:09:09 -04:00
Pietro Gagliardi 8a0ca54e93 Fixed constraint issues in tablecolumn.m for text-containing columns. I guess that one constraint function needs to go... 2018-06-04 20:03:05 -04:00
Pietro Gagliardi 2cfbb0144e Fixed segfaults. Now to fix logic errors. (Technically one of the two changes here is a logic error too.) 2018-06-04 18:17:05 -04:00
Pietro Gagliardi 3bb050777b Started converting the test program. First column works fine, second segfaults. 2018-06-03 23:23:48 -04:00
Pietro Gagliardi 2b428d50f6 And fixed build errors. Now I just need to rewrite the tester and try this out... 2018-06-03 23:06:44 -04:00
Pietro Gagliardi 8fc4a9aaf5 Filled in the rest of tablecolumn.m: wrote the NSTableColumn subclasses and implemented the public functions. Let's build and see what breaks! 2018-06-03 22:37:36 -04:00
Pietro Gagliardi 6457e1668f Rewrote uiTableModelRowChanged() to properly update rows. We can do this now that we have the setup for row updates and reuse, but this is better than calling reloadData anyway (and reloadData doesn't update the row view, but we (almost) do, so...)... 2018-06-03 21:39:49 -04:00