Comments related to above.

This commit is contained in:
Pietro Gagliardi 2017-06-06 16:20:58 -04:00
parent ef3ed04e2d
commit dbb17e441d
2 changed files with 1 additions and 1 deletions

View File

@ -2,7 +2,6 @@
#include "drawtext.h" #include "drawtext.h"
// TODO double-check ligatures on all platforms to make sure we can place the cursor at the right place // TODO double-check ligatures on all platforms to make sure we can place the cursor at the right place
// TODO the hiding and showing does not work properly on GTK+
// TODO using the arrow keys allows us to walk back to the end of the line on some platforms (TODO which?); IIRC arrow keys shouldn't do that // TODO using the arrow keys allows us to walk back to the end of the line on some platforms (TODO which?); IIRC arrow keys shouldn't do that
// TODO make sure to check the cursor positions of RTL on all platforms // TODO make sure to check the cursor positions of RTL on all platforms

View File

@ -89,6 +89,7 @@ _UI_EXTERN void uiUnixControlSetContainer(uiUnixControl *, GtkContainer *, gbool
{ \ { \
if (!uiUnixControl(c)->addedBefore) { \ if (!uiUnixControl(c)->addedBefore) { \
g_object_ref_sink(type(c)->widget); /* our own reference, which we release in Destroy() */ \ g_object_ref_sink(type(c)->widget); /* our own reference, which we release in Destroy() */ \
/* massive hack notes: without any of this, nothing gets shown when we show a window; without the if, all things get shown even if some were explicitly hidden (TODO why don't we just show everything except windows on create? */ \
/*TODO*/if(!uiUnixControl(c)->explicitlyHidden) gtk_widget_show(type(c)->widget); \ /*TODO*/if(!uiUnixControl(c)->explicitlyHidden) gtk_widget_show(type(c)->widget); \
uiUnixControl(c)->addedBefore = TRUE; \ uiUnixControl(c)->addedBefore = TRUE; \
} \ } \