From dbb17e441db3a8a94b669446764f65527b1c095c Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Tue, 6 Jun 2017 16:20:58 -0400 Subject: [PATCH] Comments related to above. --- examples/drawtext/hittest.c | 1 - ui_unix.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/drawtext/hittest.c b/examples/drawtext/hittest.c index ce0685d1..a8092b47 100644 --- a/examples/drawtext/hittest.c +++ b/examples/drawtext/hittest.c @@ -2,7 +2,6 @@ #include "drawtext.h" // TODO double-check ligatures on all platforms to make sure we can place the cursor at the right place -// TODO the hiding and showing does not work properly on GTK+ // TODO using the arrow keys allows us to walk back to the end of the line on some platforms (TODO which?); IIRC arrow keys shouldn't do that // TODO make sure to check the cursor positions of RTL on all platforms diff --git a/ui_unix.h b/ui_unix.h index 23269186..ed019260 100644 --- a/ui_unix.h +++ b/ui_unix.h @@ -89,6 +89,7 @@ _UI_EXTERN void uiUnixControlSetContainer(uiUnixControl *, GtkContainer *, gbool { \ if (!uiUnixControl(c)->addedBefore) { \ g_object_ref_sink(type(c)->widget); /* our own reference, which we release in Destroy() */ \ + /* massive hack notes: without any of this, nothing gets shown when we show a window; without the if, all things get shown even if some were explicitly hidden (TODO why don't we just show everything except windows on create? */ \ /*TODO*/if(!uiUnixControl(c)->explicitlyHidden) gtk_widget_show(type(c)->widget); \ uiUnixControl(c)->addedBefore = TRUE; \ } \