interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Some TODO resolution and stale TODO deletion in windows/spinbox.c. Also decided to keep defaultOnChanged() where it was.

This commit is contained in:
Pietro Gagliardi 2015-06-02 10:35:10 -04:00
parent 884bd5c862
commit a25d7b2a0c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
redo/windows/spinbox.c
View File

@ -55,7 +55,8 @@ static void spinboxCommitDestroy(uiControl *c)
struct spinbox *s = (struct spinbox *) c; struct spinbox *s = (struct spinbox *) c;
uiWindowsUnregisterWM_COMMANDHandler(s->hwnd); uiWindowsUnregisterWM_COMMANDHandler(s->hwnd);
// TODO destroy the updown if (DestroyWindow(s->updown) == 0)
logLastError("error destroying updown in spinboxCommitDestroy()");
(*(s->baseCommitDestroy))(uiControl(s)); (*(s->baseCommitDestroy))(uiControl(s));
} }
@ -81,7 +82,6 @@ static void spinboxPreferredSize(uiControl *c, uiSizing *d, intmax_t *width, int
// an up-down control will only properly position itself the first time // an up-down control will only properly position itself the first time
// stupidly, there are no messages to force a size calculation, nor can I seem to reset the buddy window to force a new position // stupidly, there are no messages to force a size calculation, nor can I seem to reset the buddy window to force a new position
// alas, we have to make a new up/down control each time :( // alas, we have to make a new up/down control each time :(
// TODO will we need to store a copy of the current position and range for this?
static void recreateUpDown(struct spinbox *s) static void recreateUpDown(struct spinbox *s)
{ {
HWND parent; HWND parent;
@ -140,7 +140,6 @@ COMMIT(Hide, uiWindowsUtilHide)
COMMIT(Enable, uiWindowsUtilEnable) COMMIT(Enable, uiWindowsUtilEnable)
COMMIT(Disable, uiWindowsUtilDisable) COMMIT(Disable, uiWindowsUtilDisable)
// TODO does it go here relative of other things?
static void defaultOnChanged(uiSpinbox *s, void *data) static void defaultOnChanged(uiSpinbox *s, void *data)
{ {
// do nothing // do nothing