From a25d7b2a0c7ef4d712b011a350685c417a0dd148 Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Tue, 2 Jun 2015 10:35:10 -0400 Subject: [PATCH] Some TODO resolution and stale TODO deletion in windows/spinbox.c. Also decided to keep defaultOnChanged() where it was. --- redo/windows/spinbox.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/redo/windows/spinbox.c b/redo/windows/spinbox.c index 70ee5d45..c6165f18 100644 --- a/redo/windows/spinbox.c +++ b/redo/windows/spinbox.c @@ -55,7 +55,8 @@ static void spinboxCommitDestroy(uiControl *c) struct spinbox *s = (struct spinbox *) c; uiWindowsUnregisterWM_COMMANDHandler(s->hwnd); - // TODO destroy the updown + if (DestroyWindow(s->updown) == 0) + logLastError("error destroying updown in spinboxCommitDestroy()"); (*(s->baseCommitDestroy))(uiControl(s)); } @@ -81,7 +82,6 @@ static void spinboxPreferredSize(uiControl *c, uiSizing *d, intmax_t *width, int // an up-down control will only properly position itself the first time // stupidly, there are no messages to force a size calculation, nor can I seem to reset the buddy window to force a new position // alas, we have to make a new up/down control each time :( -// TODO will we need to store a copy of the current position and range for this? static void recreateUpDown(struct spinbox *s) { HWND parent; @@ -140,7 +140,6 @@ COMMIT(Hide, uiWindowsUtilHide) COMMIT(Enable, uiWindowsUtilEnable) COMMIT(Disable, uiWindowsUtilDisable) -// TODO does it go here relative of other things? static void defaultOnChanged(uiSpinbox *s, void *data) { // do nothing