interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Wait I thought I did PIC already wtf

This commit is contained in:
Pietro Gagliardi 2018-09-01 20:37:05 -04:00
parent e2222e414d
commit 6891017cbe
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
CMakeLists.txt
View File

@ -205,6 +205,9 @@ if(BUILD_SHARED_LIBS)
SOVERSION "${_VERSION}") SOVERSION "${_VERSION}")
endif() endif()
endif() endif()
# TODO why is this not a default?!
set_property(TARGET libui PROPERTY
POSITION_INDEPENDENT_CODE True)
macro(_add_exec _name) macro(_add_exec _name)
# TODOTODO re-add WIN32 when merging back # TODOTODO re-add WIN32 when merging back
@ -214,11 +217,9 @@ macro(_add_exec _name)
target_link_libraries(${_name} libui) target_link_libraries(${_name} libui)
_target_link_options_private(${_name} _target_link_options_private(${_name}
_COMMON_LDFLAGS) _COMMON_LDFLAGS)
# make shared-linked executables PIC too # TODO does this propagate?
if(BUILD_SHARED_LIBS) set_property(TARGET ${_name} PROPERTY
set_property(TARGET ${_name} PROPERTY POSITION_INDEPENDENT_CODE True)
POSITION_INDEPENDENT_CODE True)
endif()
# TODO see above about INTERFACE # TODO see above about INTERFACE
if(NOT BUILD_SHARED_LIBS) if(NOT BUILD_SHARED_LIBS)
target_link_libraries(${_name} target_link_libraries(${_name}

1
README.md
View File

@ -32,6 +32,7 @@ But libui is not dead; I am working on it whenever I can, and I hope to get it t
* **1 September 2018** * **1 September 2018**
* **Alpha 4.1 is here.** This is an emergency fix to Alpha 4 to fix `uiImageAppend()` not working as documented. It now works properly, with one important difference you'll need to care about: **it now requires image data to be alpha-premultiplied**. In addition, `uiImage` also is implemented slightly more nicely now, and `ui.h` has minor documentation typo fixes. * **Alpha 4.1 is here.** This is an emergency fix to Alpha 4 to fix `uiImageAppend()` not working as documented. It now works properly, with one important difference you'll need to care about: **it now requires image data to be alpha-premultiplied**. In addition, `uiImage` also is implemented slightly more nicely now, and `ui.h` has minor documentation typo fixes.
* Alpha 4.1 also tries to make everything properly PIC-enabled.
* **10 August 2018** * **10 August 2018**
* **Alpha 4 is finally here.** Everything from Alpha 3.5 and what's listed below is in this release; the two biggest changes are still the new text drawing API and new uiTable control. In between all that is a whole bunch of bugfixes, and hopefully more stability too. Thanks to everybody who helped contribute! * **Alpha 4 is finally here.** Everything from Alpha 3.5 and what's listed below is in this release; the two biggest changes are still the new text drawing API and new uiTable control. In between all that is a whole bunch of bugfixes, and hopefully more stability too. Thanks to everybody who helped contribute!