54db54931e
p2p: add static node dialing test
2015-05-04 13:08:42 +03:00
e82ddd9198
p2p: correct a leftover trusted -> static
2015-04-30 19:34:33 +03:00
413ace37d3
eth, p2p: rename trusted nodes to static, drop inbound extra slots
2015-04-30 19:32:48 +03:00
701591b403
cmd, eth, p2p: fix review issues enumerated by Felix
2015-04-30 16:15:29 +03:00
1528dbc171
p2p: add trust check to handshake, test privileged connectivity
...
Conflicts:
p2p/server_test.go
2015-04-30 16:06:47 +03:00
14f32a0c3a
p2p: reduce the severity of a debug log
2015-04-30 16:04:09 +03:00
de0549fabb
cmd/geth, cmd/mist, cmd/utils, eth, p2p: support trusted peers
2015-04-30 16:03:10 +03:00
72ab6d3255
p2p/discover: track sha3(ID) in Node
2015-04-30 15:02:23 +02:00
b34a8ef624
p2p, p2p/discover: protocol version 4
2015-04-30 14:57:34 +02:00
fc747ef4a6
p2p/discover: new endpoint format
...
This commit changes the discovery protocol to use the new "v4" endpoint
format, which allows for separate UDP and TCP ports and makes it
possible to discover the UDP address after NAT.
2015-04-30 14:57:33 +02:00
01e3d694a6
p2p: added received at to peer message
...
p2p.Msg.ReceivedAt can be used for determining block propagation from
begining to end.
2015-04-29 22:49:58 +02:00
b569550a39
p2p/discover: fix api issues caused by leveldb update
2015-04-28 13:57:57 +03:00
4992765032
p2p/discover: fix goroutine leak due to blocking on sync.Once
2015-04-28 10:28:04 +03:00
437cf4b3ac
p2p/discover: add node expirer and related tests
2015-04-27 17:38:28 +03:00
a136e2bb22
p2p/discover: parametrize nodedb version, add persistency tests
2015-04-27 15:28:17 +03:00
75fd738dea
p2p/discover: drop a superfluous warning
2015-04-27 15:06:31 +03:00
706da56f75
p2p/discover: wrap the pinger to update the node db too
2015-04-27 14:56:42 +03:00
85b4b44235
p2p/discover: use iterator based seeding, drop old protocol test
2015-04-27 14:45:35 +03:00
8de8f61d36
p2p/discover: write the basic tests, catch RLP bug
2015-04-27 12:33:06 +03:00
0201c04b95
p2p/discovery: fix issues raised in the nodeDb PR
2015-04-27 10:19:16 +03:00
8646365b42
cmd/bootnode, eth, p2p, p2p/discover: use a fancier db design
2015-04-24 18:04:41 +03:00
6def110c37
cmd/bootnode, eth, p2p, p2p/discover: clean up the seeder and mesh into eth.
2015-04-24 11:33:55 +03:00
971702e7a1
p2p/discovery: fix broken tests due to API update
2015-04-24 11:23:20 +03:00
af923c965f
p2p/discovery: use the seed table for finding nodes, auto drop stale ones
2015-04-24 11:23:20 +03:00
5f735d6fce
cmd, eth, p2p, p2p/discover: init and clean up the seed cache
2015-04-24 11:23:20 +03:00
936c8e19ff
p2p/discover: store nodes in leveldb
2015-04-24 11:23:20 +03:00
635b66acdc
p2p: return zero node from Self if the server is not running
...
This helps with fixing the tests for cmd/geth to run without networking.
2015-04-22 12:31:19 +02:00
9c7281c17e
p2p: make DiscReason bigger than byte
...
We decode into [1]DiscReason in a few places. That doesn't work anymore
because package rlp no longer accepts RLP lists for byte arrays.
2015-04-17 14:45:10 +02:00
eedbb1ee9a
p2p/discover: use rlp.DecodeBytes
2015-04-17 14:45:09 +02:00
56a48101dc
cmd/rlpdump, cmd/utils, eth, p2p, whisper: use rlp input limit
2015-04-17 14:45:09 +02:00
5528abc795
p2p: fix the dial timer
...
The dial timer was not reset properly when the peer count reached
MaxPeers.
2015-04-17 08:17:01 +02:00
474aa924ca
p2p: added limiter function to limit package broadcasting
2015-04-14 12:47:31 +02:00
0217652d1b
p2p/discover: improve timer handling for reply timeouts
2015-04-13 18:08:11 +02:00
b8aeb04f6f
p2p/discover: remove unused field Node.activeStamp
2015-04-13 17:44:14 +02:00
b9929d289d
p2p: fix unsynchronized map access during Server shutdown
...
removePeer can be called even after listenLoop and dialLoop have returned.
2015-04-13 17:37:32 +02:00
995fab2ebc
p2p: fix yet another disconnect hang
...
Peer.readLoop will only terminate if the connection is closed. Fix the
hang by closing the connection before waiting for readLoop to terminate.
This also removes the british disconnect procedure where we're waiting
for the remote end to close the connection. I have confirmed with
@subtly that cpp-ethereum doesn't adhere to it either.
2015-04-13 17:34:08 +02:00
79a6782c1c
p2p: fix goroutine leak when handshake read fails
...
This regression was introduced in b3c058a9e4
2015-04-13 17:06:19 +02:00
c5332537f5
p2p: limit number of lingering inbound pre-handshake connections
...
This is supposed to apply some back pressure so Server is not accepting
more connections than it can actually handle. The current limit is 50.
This doesn't really need to be configurable, but we'll see how it
behaves in our test nodes and adjust accordingly.
2015-04-10 17:24:41 +02:00
56977c225e
p2p: use RLock instead of Lock for pre-dial checks
2015-04-10 17:23:09 +02:00
b3c058a9e4
p2p: improve disconnect signaling at handshake time
...
As of this commit, p2p will disconnect nodes directly after the
encryption handshake if too many peer connections are active.
Errors in the protocol handshake packet are now handled more politely
by sending a disconnect packet before closing the connection.
2015-04-10 16:57:56 +02:00
99a1db2d40
p2p: don't mess with the socket deadline in Peer.readLoop
...
netWrapper already sets a read deadline in ReadMsg.
2015-04-10 13:26:28 +02:00
145330fdf2
p2p: properly decrement peer wait group counter for setup errors
2015-04-10 13:26:27 +02:00
f1d710af00
p2p: fix Peer shutdown deadlocks
...
There were multiple synchronization issues in the disconnect handling,
all caused by the odd special-casing of Peer.readLoop errors. Remove the
special handling of read errors and make readLoop part of the Peer
WaitGroup.
Thanks to @Gustav-Simonsson for pointing at arrows in a diagram
and playing rubber-duck.
2015-04-10 13:26:27 +02:00
22d1f0faf1
p2p: improve peer selection logic
...
This commit introduces a new (temporary) peer selection
strategy based on random lookups.
While we're here, also implement the TODOs in dialLoop.
2015-04-10 13:26:27 +02:00
7be05b4b9d
p2p/discover: don't log packet content
2015-04-10 13:26:27 +02:00
9cd8c96157
p2p/discover: make packet processing less concurrent
2015-04-10 13:26:27 +02:00
688d118c7e
Updated logging
2015-04-07 14:57:04 +02:00
a77c431e37
p2p/discover: fix off by one error causing buckets to contain duplicates
2015-04-01 17:00:12 +02:00
de7af720d6
p2p/discover: implement node bonding
...
This a fix for an attack vector where the discovery protocol could be
used to amplify traffic in a DDOS attack. A malicious actor would send a
findnode request with the IP address and UDP port of the target as the
source address. The recipient of the findnode packet would then send a
neighbors packet (which is 16x the size of findnode) to the victim.
Our solution is to require a 'bond' with the sender of findnode. If no
bond exists, the findnode packet is not processed. A bond between nodes
α and β is created when α replies to a ping from β.
This (initial) version of the bonding implementation might still be
vulnerable against replay attacks during the expiration time window.
We will add stricter source address validation later.
2015-04-01 17:00:12 +02:00
92928309b2
p2p/discover: add version number to ping packet
...
The primary motivation for doing this right now is that old PoC 8
nodes and newer PoC 9 nodes keep discovering each other, causing
handshake failures.
2015-04-01 15:53:04 +02:00
9880f99ccb
fix p2p/testlog_test
2015-03-23 16:41:41 +00:00
a7ad9c309b
Merge branch 'develop' into conversion
2015-03-21 14:52:42 +01:00
4f5b362bda
%#x => %x
2015-03-20 12:52:03 +01:00
b9e0b11e7d
p2p: interrupt MsgPipe payload read/write
...
This is better because protocols might not actually read the payload for
some errors (msg too big, etc.) which can be a pain to test with the old
behaviour.
2015-03-19 15:16:06 +01:00
a7bced779a
p2p: log disconnect requests
...
This helps a lot with debugging.
2015-03-19 15:15:07 +01:00
5ba51594c7
p2p: use package rlp to encode messages
...
Message encoding functions have been renamed to catch any uses.
The switch to the new encoder can cause subtle incompatibilities.
If there are any users outside of our tree, they will at least be
alerted that there was a change.
NewMsg no longer exists. The replacements for EncodeMsg are called
Send and SendItems.
2015-03-19 15:11:02 +01:00
4811f460e7
p2p: export ExpectMsg (for eth protocol testing)
2015-03-19 15:08:04 +01:00
b3e133dd15
Merge branch 'frontier/js' into frontier/nodeadmin.js
2015-03-16 22:50:29 +07:00
b523441361
Moved ethutil => common
2015-03-16 11:27:38 +01:00
e150832734
p2p: server>discover table Self=Node exported
2015-03-15 13:38:41 +07:00
485e37e889
Move MakeName to ethutil
2015-03-11 14:29:07 -05:00
215c763d53
eth, p2p: delete p2p.Blacklist
...
It is unused and untested right now. We can
bring it back later if required.
2015-03-04 16:54:36 +01:00
429828cd92
p2p: reject messages that cannot be written as simple RLPx frames
...
Until chunked frames are implemented we cannot send messages
with a size overflowing uint24.
2015-03-04 16:42:01 +01:00
22659a7fea
p2p: restore read/write timeouts
...
They got lost in the transition to rlpxFrameRW.
2015-03-04 16:42:00 +01:00
7964f30dcb
p2p: msg.Payload contains list data
...
With RLPx frames, the message code is contained in the
frame and is no longer part of the encoded data.
EncodeMsg, Msg.Decode have been updated to match.
Code that decodes RLP directly from Msg.Payload will need
to change.
2015-03-04 12:27:24 +01:00
21649100b1
p2p: verify protocol handshake node ID
2015-03-04 12:27:24 +01:00
7d39fd6678
p2p: make encryption handshake code easier to follow
...
This mostly changes how information is passed around.
Instead of using many function parameters and return values,
put the entire state in a struct and pass that.
This also adds back derivation of ecdhe-shared-secret. I deleted
it by accident in a previous refactoring.
2015-03-04 12:27:24 +01:00
2c505efd1e
p2p/discover: add NodeID.Pubkey
2015-03-04 12:27:24 +01:00
d344054e5a
p2p: make RLPx frame MAC 16 bytes as defined in the spec
2015-03-04 12:27:24 +01:00
d084aed5e9
p2p: delete frameRW
2015-03-04 12:27:24 +01:00
736e632215
p2p: use RLPx frames for messaging
2015-03-04 12:27:23 +01:00
51e01cceca
p2p: encrypted and authenticated RLPx frame I/O
2015-03-04 12:27:23 +01:00
936dd0f3bc
p2p: add basic RLPx frame I/O
2015-03-04 12:27:23 +01:00
3719db352a
p2p: emit JSON connect/disconnect events
2015-02-19 17:09:33 +01:00
dd871e791c
p2p: initialize Server.ourHandshake before accepting connections
2015-02-19 17:08:18 +01:00
3dbd32093c
p2p: enable devp2p ping
...
This should prevent connection drops.
2015-02-19 16:54:54 +01:00
73f94f3755
p2p: disable encryption handshake
...
The diff is a bit bigger than expected because the protocol handshake
logic has moved out of Peer. This is necessary because the protocol
handshake will have custom framing in the final protocol.
2015-02-19 16:54:53 +01:00
c1d0693cb1
Merge pull request #325 from fjl/deps-cleanup
...
Cleanup imports
2015-02-17 23:19:45 +01:00
7ea131d4ff
p2p/discover: fix pending replies iteration
...
Range expressions capture the length of the slice once before the first
iteration. A range expression cannot be used here since the loop
modifies the slice variable (including length changes).
2015-02-17 15:21:39 +01:00
f965f41b6e
p2p/nat: switch to github.com/huin/goupnp
...
My temporary fix was merged upstream.
2015-02-17 13:10:11 +01:00
34d0e1b2c3
p2p: fix ecies dependency in tests
...
We forgot to update this reference when moving ecies into the
go-ethereum repo.
2015-02-17 12:04:20 +01:00
09e53367a2
Use a mutex write-lock for a write operation
2015-02-15 02:13:24 +01:00
65159d65c8
Merge branch 'develop' of github.com-obscure:ethereum/go-ethereum into develop
2015-02-14 00:27:46 +01:00
84f7c966f7
Moved ECIES to repo & added secondary title for webview
...
* ECIES moved from obscuren to ethereum
* Added html META[name=badge] to reflect menuItem.secondaryTitle
2015-02-14 00:25:47 +01:00
4bef3ce284
p2p: print Cap as name/version
2015-02-13 23:54:34 +01:00
32a9c0ca80
p2p: bump devp2p protcol version to 3
...
For compatibility with cpp-ethereum
2015-02-13 15:08:40 +01:00
fd3e1061e0
p2p: handle disconnect before protocol handshake
2015-02-13 15:06:47 +01:00
cf754b9483
p2p/discover: fix race in ListenUDP
...
udp.Table was assigned after the readLoop started, so
packets could arrive and be processed before the Table was there.
2015-02-13 15:06:47 +01:00
5cc1256fd6
p2p: ensure we don't dial ourself
...
addPeer doesn't allow self connects, but we can avoid opening
connections in the first place.
2015-02-13 15:06:47 +01:00
7101f44998
p2p: add I/O timeout for encrytion handshake
2015-02-13 15:06:47 +01:00
22ee366ed6
p2p: fix goroutine leak for invalid peers
...
The deflect logic called Disconnect on the peer, but the peer never ran
and wouldn't process the disconnect request.
2015-02-13 15:06:46 +01:00
5110f80bba
p2p: improve read deadlines
...
There are now two deadlines, frameReadTimeout and payloadReadTimeout.
The frame timeout is longer and allows for connections that are idle.
The message timeout is still short and ensures that we don't get stuck
in the middle of a message.
2015-02-13 14:44:00 +01:00
170eb3ac68
p2p/discover: map listening port using configured mechanism
2015-02-13 11:39:32 +01:00
82f0bd9009
p2p/discover: code review fixes
2015-02-13 11:39:31 +01:00
d0a2e655c9
cmd/ethereum, cmd/mist, eth, p2p: use package p2p/nat
...
This deletes the old NAT implementation.
2015-02-13 11:39:31 +01:00
1543833ca0
p2p/nat: new package for port mapping stuff
...
I have verified that UPnP and NAT-PMP work against an older version of
the MiniUPnP daemon running on pfSense. This code is kind of hard to
test automatically.
2015-02-13 11:39:31 +01:00
9915d3c3be
p2p/discover: deflake UDP tests
2015-02-09 11:02:32 +01:00
028775a086
cmd/ethereum, cmd/mist: add flag for discovery bootstrap nodes
2015-02-07 00:52:49 +01:00
2cf4fed11b
cmd/mist, eth, javascript, p2p: use Node URLs for peer suggestions
2015-02-07 00:46:56 +01:00
e34d134102
p2p: fixes for actual connections
...
The unit test hooks were turned on 'in production'.
2015-02-07 00:43:52 +01:00
Péter Szilágyi
Felix Lange
obscuren
zelig
Taylor Gerring
Jeffrey Wilcke